sminnee / silverstripe-framework

tests/model/ArrayListTest.php

Doc Comments +4 added lines

@@ -802,6 +802,10 @@
 	public $First;
 	public $Second;
 
+	/**
+	 * @param string $first
+	 * @param string $second
+	 */
 	public function __construct($first, $second) {
 		$this->First  = $first;
 		$this->Second = $second;

tests/model/DataObjectTest.php

Doc Comments +4 added lines

@@ -1117,6 +1117,10 @@
 		);
 	}
 
+	/**
+	 * @param DataObjectTest_Team $object
+	 * @param string $method
+	 */
 	protected function makeAccessible($object, $method) {
 		$reflectionMethod = new ReflectionMethod($object, $method);
 		$reflectionMethod->setAccessible(true);

tests/model/HierarchyTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -512,7 +512,7 @@
 	 * Get the HTML class attribute from a node in the sitetree
 	 *
 	 * @param $html
-	 * @param $node
+	 * @param DataObject|null $node
 	 * @return string
 	 */
 	protected function getNodeClassFromTree($html, $node) {

tests/security/GroupTest.php

Doc Comments +4 added lines

@@ -175,6 +175,10 @@
 
 class GroupTest_MemberForm extends Form {
 
+	/**
+	 * @param GroupTest $controller
+	 * @param string $name
+	 */
 	public function __construct($controller, $name) {
 		$fields = singleton('GroupTest_Member')->getCMSFields();
 		$actions = new FieldList(

tests/security/MemberTest.php

Doc Comments +3 added lines

@@ -913,6 +913,9 @@
  */
 class MemberTest_ValidatorExtension extends DataExtension implements TestOnly {
 
+	/**
+	 * @param Member_Validator $validator
+	 */
 	public function updateValidator(&$validator) {
 		$validator->addRequiredField('Surname');
 		$validator->removeRequiredField('FirstName');

tests/security/SecurityTest.php

Doc Comments +4 added lines

@@ -580,6 +580,8 @@ 
 	/**
 	 * Execute a log-in form using Director::test().
 	 * Helper method for the tests above
+	 * @param string $email
+	 * @param string $password
 	 */
 	public function doTestLoginForm($email, $password, $backURL = 'test/link') {
 		$this->get(Config::inst()->get('Security', 'logout_url'));
@@ -600,6 +602,8 @@ 
 
 	/**
 	 * Helper method to execute a change password form
+	 * @param string $oldPassword
+	 * @param string $newPassword
 	 */
 	public function doTestChangepasswordForm($oldPassword, $newPassword) {
 		return $this->submitForm(

tests/view/SSViewerCacheBlockTest.php

Doc Comments +6 added lines

@@ -28,6 +28,9 @@ 
 		"Versioned('Stage', 'Live')"
 	);
 
+	/**
+	 * @param string $entropy
+	 */
 	public function setEntropy($entropy) {
 		$this->entropy = $entropy;
 	}
@@ -53,6 +56,9 @@ 
 		SS_Cache::set_cache_lifetime('cacheblock', $cacheOn ? 600 : -1);
 	}
 
+	/**
+	 * @param string $template
+	 */
 	protected function _runtemplate($template, $data = null) {
 		if ($data === null) $data = $this->data;
 		if (is_array($data)) $data = $this->data->customise($data);

view/SSTemplateParser.php

Doc Comments +9 added lines, -5 removed lines

@@ -111,6 +111,8 @@ 
 
 	/**
 	 * Override the function that constructs the result arrays to also prepare a 'php' item in the array
+	 * @param string $matchrule
+	 * @param string $name
 	 */
 	function construct($matchrule, $name, $arguments = null) {
 		$res = parent::construct($matchrule, $name, $arguments);
@@ -172,9 +174,9 @@ 
 
 	/**
 	 * Ensures that the arguments to addOpenBlock and addClosedBlock are valid
-	 * @param $name
-	 * @param $callable
-	 * @param $type
+	 * @param string $name
+	 * @param callable $callable
+	 * @param string $type
 	 * @throws InvalidArgumentException
 	 */
 	protected function validateExtensionBlock($name, $callable, $type) {
@@ -737,6 +739,7 @@ 
 	 * The basic generated PHP of LookupStep and LastLookupStep is the same, except that LookupStep calls 'obj' to
 	 * get the next ViewableData in the sequence, and LastLookupStep calls different methods (XML_val, hasValue, obj)
 	 * depending on the context the lookup is used in.
+	 * @param string $method
 	 */
 	function Lookup_AddLookupStep(&$res, $sub, $method) {
 		$res['LookupSteps'][] = $sub;
@@ -4691,8 +4694,8 @@ 
 	 * Compiles some passed template source code into the php code that will execute as per the template source.
 	 *
 	 * @throws SSTemplateParseException
-	 * @param  $string The source of the template
-	 * @param string $templateName The name of the template, normally the filename the template source was loaded from
+	 * @param  string $string The source of the template
+	 * @param string string The name of the template, normally the filename the template source was loaded from
 	 * @param bool $includeDebuggingComments True is debugging comments should be included in the output
 	 * @param bool $topTemplate True if this is a top template, false if it's just a template
 	 * @return mixed|string The php that, when executed (via include or exec) will behave as per the template source
@@ -4732,6 +4735,7 @@ 
 
 	/**
 	 * @param string $code
+	 * @param string $templateName
 	 * @return string $code
 	 */
 	protected function includeDebuggingComments($code, $templateName) {

filesystem/Upload.php

Doc Comments +2 added lines, -2 removed lines

@@ -114,7 +114,7 @@ 
 	 * Set a different instance than {@link Upload_Validator}
 	 * for this upload session.
 	 *
-	 * @param object $validator
+	 * @param Upload_Validator $validator
 	 */
 	public function setValidator($validator) {
 		$this->validator = $validator;
@@ -363,7 +363,7 @@ 
 	/**
 	 * Determines wether previous operations caused an error.
 	 *
-	 * @return boolean
+	 * @return integer
 	 */
 	public function isError() {
 		return (count($this->errors));