sminnee / silverstripe-framework

src/Forms/MoneyField.php

Doc Comments +9 added lines, -2 removed lines

@@ -57,6 +57,10 @@ 
         return $this->fieldAmount;
     }
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, $value = "")
     {
         $this->setName($name);
@@ -210,7 +214,7 @@ 
      *
      * (see @link MoneyFieldTest_CustomSetter_Object for more information)
      *
-     * @param DataObjectInterface|Object $dataObject
+     * @param DataObjectInterface $dataObject
      */
     public function saveInto(DataObjectInterface $dataObject)
     {
@@ -236,6 +240,9 @@ 
         return $clone;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);
@@ -259,7 +266,7 @@ 
     /**
      * Set list of currencies. Currencies should be in the 3-letter ISO 4217 currency code.
      *
-     * @param array $currencies
+     * @param string[] $currencies
      * @return $this
      */
     public function setAllowedCurrencies($currencies)

src/Forms/NumericField.php

Doc Comments +1 added lines, -1 removed lines

@@ -287,7 +287,7 @@
      * Get number of digits to show to the right of the decimal point.
      * 0 for integer, any number for floating point, or null to flexible
      *
-     * @return int|null
+     * @return string
      */
     public function getScale()
     {

src/Forms/SelectionGroup_Item.php

Doc Comments +6 added lines

@@ -37,6 +37,9 @@ 
         return $this->title;
     }
 
+    /**
+     * @param string $title
+     */
     function setTitle($title)
     {
         $this->title = $title;
@@ -48,6 +51,9 @@ 
         return $this->value;
     }
 
+    /**
+     * @param string $Value
+     */
     function setValue($Value, $data = null)
     {
         $this->value = $Value;

src/ORM/FieldType/DBDate.php

Doc Comments +2 added lines, -2 removed lines

@@ -245,7 +245,7 @@ 
      * Return a date formatted as per a CMS user's settings.
      *
      * @param Member $member
-     * @return boolean | string A date formatted as per user-defined settings.
+     * @return null|string | string A date formatted as per user-defined settings.
      */
     public function FormatFromSettings($member = null)
     {
@@ -553,7 +553,7 @@ 
      * Attempt to split date string into year, month, day, and timestamp components.
      *
      * @param string $value
-     * @return array
+     * @return string[]
      */
     protected function explodeDateString($value)
     {

src/ORM/FieldType/DBTime.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
      */
     const ISO_TIME = 'HH:mm:ss';
 
+    /**
+     * @param string $value
+     */
     public function setValue($value, $record = null, $markChanged = true)
     {
         $value = $this->parseTime($value);

tests/php/Forms/NumericFieldTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Forms\NumericField;
 use SilverStripe\Forms\RequiredFields;
-use SilverStripe\i18n\i18n;
 
 class NumericFieldTest extends SapphireTest
 {

tests/php/View/SSViewerCacheBlockTest.php

Doc Comments +3 added lines

@@ -41,6 +41,9 @@
         Injector::inst()->get(CacheInterface::class . '.cacheblock')->clear();
     }
 
+    /**
+     * @param string $template
+     */
     protected function _runtemplate($template, $data = null)
     {
         if ($data === null) {

src/Core/Manifest/Module.php

Doc Comments +4 added lines

@@ -28,6 +28,10 @@
      */
     protected $composerData = null;
 
+    /**
+     * @param string $path
+     * @param string $base
+     */
     public function __construct($path, $base)
     {
         $this->path = rtrim($path, '/\\');

src/Dev/FunctionalTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -226,7 +226,7 @@ 
      * Find an attribute in a SimpleXMLElement object by name.
      * @param SimpleXMLElement $object
      * @param string $attribute Name of attribute to find
-     * @return SimpleXMLElement object of the attribute
+     * @return boolean object of the attribute
      */
     public function findAttribute($object, $attribute)
     {
@@ -260,7 +260,7 @@ 
      * Note:   characters are stripped from the content; make sure that your assertions take this into account.
      *
      * @param string $selector A basic CSS selector, e.g. 'li.jobs h3'
-     * @param array|string $expectedMatches The content of at least one of the matched tags
+     * @param string[] $expectedMatches The content of at least one of the matched tags
      * @param string $message
      * @throws PHPUnit_Framework_AssertionFailedError
      */