sminnee / silverstripe-framework

tests/php/Forms/CurrencyFieldTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\Forms\Tests;
 
-use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Forms\CurrencyField;
 use SilverStripe\Forms\RequiredFields;

tests/php/Forms/GridField/GridFieldTest/Component.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     /**
      * @skipUpgrade
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getColumnsHandled($gridField)
     {

src/Core/Core.php

Doc Comments +4 added lines, -7 removed lines

@@ -144,6 +144,9 @@ 
     return Injector::inst()->get($className);
 }
 
+/**
+ * @return string
+ */
 function project()
 {
     global $project;
@@ -160,12 +163,6 @@ 
      * @param string $entity Entity that identifies the string. It must be in the form
      * "Namespace.Entity" where Namespace will be usually the class name where this
      * string is used and Entity identifies the string inside the namespace.
-     * @param mixed $arg,... Additional arguments are parsed as such:
-     *  - Next string argument is a default. Pass in a `|` pipe-delimeted value with `{count}`
-     *    to do pluralisation.
-     *  - Any other string argument after default is context for i18nTextCollector
-     *  - Any array argument in any order is an injection parameter list. Pass in a `count`
-     *    injection parameter to pluralise.
      * @return string
      */
 function _t($entity, $arg = null)
@@ -179,7 +176,7 @@ 
  * Only increases up to the maximum defined in {@link set_increase_memory_limit_max()},
  * and defaults to the 'memory_limit' setting in the PHP configuration.
  *
- * @param string|int $memoryLimit A memory limit string, such as "64M".  If omitted, unlimited memory will be set.
+ * @param integer $memoryLimit A memory limit string, such as "64M".  If omitted, unlimited memory will be set.
  * @return Boolean TRUE indicates a successful change, FALSE a denied change.
  */
 function increase_memory_limit_to($memoryLimit = -1)

src/Dev/Deprecation.php

Doc Comments +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
      * greater than or equal to this version, a message will be raised
      *
      * @static
-     * @param $ver string -
+     * @param string $ver string -
      *     A php standard version string, see http://php.net/manual/en/function.version-compare.php for details.
      * @param null $forModule string -
      *    The name of a module. The passed version will be used as the check value for
@@ -141,7 +141,7 @@ 
     /**
      * Determine if deprecation notices should be displayed
      *
-     * @return bool
+     * @return boolean|string
      */
     public static function get_enabled()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Dev;
 
 use SilverStripe\Control\Director;
-use SilverStripe\Core\Manifest\ClassLoader;
 use SilverStripe\Core\Manifest\Module;
 use SilverStripe\Core\Manifest\ModuleLoader;
 

src/Forms/GridField/GridFieldAddExistingAutocompleter.php

Doc Comments +3 added lines, -3 removed lines

@@ -155,7 +155,7 @@ 
     /**
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {
@@ -219,7 +219,7 @@ 
      *
      * @param GridField $gridField
      * @param HTTPRequest $request
-     * @return string
+     * @return HTTPResponse
      */
     public function doSearch($gridField, $request)
     {
@@ -299,7 +299,7 @@ 
     }
 
     /**
-     * @param array $fields
+     * @param string[] $fields
      * @return $this
      */
     public function setSearchFields($fields)

src/i18n/Messages/Symfony/ModuleYamlLoader.php

Unused Use Statements -3 removed lines

@@ -2,12 +2,9 @@
 
 namespace SilverStripe\i18n\Messages\Symfony;
 
-use SilverStripe\Core\Config\Configurable;
-use SilverStripe\Dev\Debug;
 use SilverStripe\i18n\i18n;
 use SilverStripe\i18n\Messages\Reader;
 use Symfony\Component\Translation\Loader\ArrayLoader;
-use Symfony\Component\Translation\PluralizationRules;
 
 /**
  * Loads yaml localisations across all modules simultaneously.

src/ORM/ListDecorator.php

Doc Comments +1 added lines

@@ -41,6 +41,7 @@
      * Useful for keeping a decorator/paginated list configuration intact while modifying
      * the underlying list.
      *
+     * @param SS_List $list
      * @return SS_List
      */
     public function setList($list)

src/View/SSViewer_DataPresenter.php

Doc Comments +7 added lines

@@ -33,6 +33,10 @@ 
      */
     protected $underlay;
 
+    /**
+     * @param ViewableData $item
+     * @param ViewableData $inheritedScope
+     */
     public function __construct($item, $overlay = null, $underlay = null, $inheritedScope = null)
     {
         parent::__construct($item, $inheritedScope);
@@ -65,6 +69,9 @@ 
         $this->underlay = $underlay ? $underlay : array();
     }
 
+    /**
+     * @param string $variableMethod
+     */
     protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false)
     {
         $implementers = ClassInfo::implementorsOf($interfaceToQuery);

src/Forms/FormField.php

Doc Comments +2 added lines, -2 removed lines

@@ -1222,7 +1222,7 @@ 
     /**
      * @param FormTransformation $transformation
      *
-     * @return mixed
+     * @return FormField
      */
     public function transform(FormTransformation $transformation)
     {
@@ -1333,7 +1333,7 @@ 
      * This function is used by the template processor. If you refer to a field as a $ variable, it
      * will return the $Field value.
      *
-     * @return string
+     * @return DBHTMLText
      */
     public function forTemplate()
     {

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Control\RequestHandler;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Convert;
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DataObjectInterface;
 use SilverStripe\ORM\FieldType\DBField;