sminnee / silverstripe-framework

src/Security/BasicAuth.php

Unused Use Statements -1 removed lines

@@ -9,7 +9,6 @@
 use SilverStripe\Core\Config\Configurable;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Core\Injector\Injector;
-
 use SilverStripe\Security\MemberAuthenticator\Authenticator;
 
 /**

tests/php/Security/MemberTest.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use SilverStripe\ORM\DB;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\Security\Member;
-use SilverStripe\Security\MemberAuthenticator;
 use SilverStripe\Security\Security;
 use SilverStripe\Security\MemberPassword;
 use SilverStripe\Security\Group;

src/Forms/DateField.php

Doc Comments +2 added lines, -2 removed lines

@@ -312,7 +312,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -337,7 +337,7 @@ 
      *
      * When $html5=true, assign value from ISO 8601 string.
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

src/Forms/TimeField.php

Doc Comments +2 added lines, -2 removed lines

@@ -250,7 +250,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -267,7 +267,7 @@ 
     /**
      * Set time assigned from database value
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

tests/php/Forms/DatetimeFieldTest.php

Unused Use Statements -2 removed lines

@@ -6,9 +6,7 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Forms\DatetimeField;
 use SilverStripe\Forms\RequiredFields;
-use SilverStripe\Forms\DateField;
 use SilverStripe\Forms\Tests\DatetimeFieldTest\Model;
-use SilverStripe\Forms\TimeField;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\FormAction;
 use SilverStripe\Forms\Form;

src/Security/CMSSecurity.php

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\ORM\FieldType\DBField;
-use SilverStripe\Security\MemberAuthenticator\CMSAuthenticator;
 use SilverStripe\View\Requirements;
 
 /**

Doc Comments +6 added lines

@@ -49,6 +49,9 @@ 
         return parent::login($request, Authenticator::CMS_LOGIN);
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         /** @skipUpgrade */
@@ -79,6 +82,9 @@ 
         return null;
     }
 
+    /**
+     * @param string $title
+     */
     public function getResponseController($title)
     {
         // Use $this to prevent use of Page to render underlying templates

src/Security/MemberAuthenticator/Authenticator.php

Doc Comments +1 added lines

@@ -53,6 +53,7 @@
      * @param $message
      * @param bool &$success Success flag
      * @param null|Member $member If the parent method already identified the member, it can be passed in
+     * @param null|boolean $success
      * @return Member Found member, regardless of successful login
      */
     protected function authenticateMember($data, &$message, &$success, $member = null)

src/Security/MemberAuthenticator/LoginForm.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\Control\Director;
 use SilverStripe\Control\RequestHandler;
 use SilverStripe\Control\Session;
-use SilverStripe\Control\Controller;
 use SilverStripe\Forms\HiddenField;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\FormAction;

tests/php/Security/MemberAuthenticatorTest.php

Unused Use Statements -5 removed lines

@@ -3,12 +3,8 @@ 
 namespace SilverStripe\Security\Tests;
 
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\FieldType\DBDatetime;
-use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\MemberAuthenticator\CMSAuthenticator;
-use SilverStripe\Security\PasswordEncryptor;
-use SilverStripe\Security\PasswordEncryptor_PHPHash;
 use SilverStripe\Security\Security;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\MemberAuthenticator\Authenticator;
@@ -17,7 +13,6 @@ 
 use SilverStripe\Security\IdentityStore;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;
 use SilverStripe\Control\HTTPRequest;