sminnee / silverstripe-framework

src/Core/Startup/ErrorControlChain.php

Doc Comments +2 added lines, -2 removed lines

@@ -106,7 +106,7 @@ 
     /**
      * Get value of display_errors ini value
      *
-     * @return mixed
+     * @return string
      */
     protected function getDisplayErrors()
     {
@@ -117,7 +117,7 @@ 
      * Add this callback to the chain of callbacks to call along with the state
      * that $error must be in this point in the chain for the callback to be called
      *
-     * @param $callback - The callback to call
+     * @param callable $callback - The callback to call
      * @param $onErrorState - false if only call if no errors yet, true if only call if already errors, null for either
      * @return $this
      */

src/Core/Startup/ParameterConfirmationToken.php

Doc Comments +4 added lines, -1 removed lines

@@ -38,6 +38,9 @@ 
      */
     protected $token = null;
 
+    /**
+     * @param string $token
+     */
     protected function pathForToken($token)
     {
         return TEMP_FOLDER.'/token_'.preg_replace('/[^a-z0-9]+/', '', $token);
@@ -247,7 +250,7 @@ 
      * Given a list of token names, suppress all tokens that have not been validated, and
      * return the non-validated token with the highest priority
      *
-     * @param array $keys List of token keys in ascending priority (low to high)
+     * @param string[] $keys List of token keys in ascending priority (low to high)
      * @return ParameterConfirmationToken The token container for the unvalidated $key given with the highest priority
      */
     public static function prepare_tokens($keys)

src/Dev/BulkLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -217,7 +217,7 @@
      *
      * @todo Mix in custom column mappings
      *
-     * @return array
+     * @return string
      **/
     public function getImportSpec()
     {

src/Dev/BulkLoader_Result.php

Doc Comments +6 added lines, -6 removed lines

@@ -132,8 +132,8 @@ 
     }
 
     /**
-     * @param $obj DataObject
-     * @param $message string
+     * @param DataObject $obj DataObject
+     * @param string $message string
      */
     public function addCreated($obj, $message = null)
     {
@@ -146,8 +146,8 @@ 
     }
 
     /**
-     * @param $obj DataObject
-     * @param $message string
+     * @param DataObject $obj DataObject
+     * @param string $message string
      */
     public function addUpdated($obj, $message = null)
     {
@@ -160,8 +160,8 @@ 
     }
 
     /**
-     * @param $obj DataObject
-     * @param $message string
+     * @param DataObject|null $obj DataObject
+     * @param string $message string
      */
     public function addDeleted($obj, $message = null)
     {

src/Dev/CsvBulkLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
      * @param string $path Path to large file to split
      * @param int $lines Number of lines per file
      *
-     * @return array List of file paths
+     * @return string[] List of file paths
      */
     protected function splitFile($path, $lines = null)
     {

src/Dev/Deprecation.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
      * greater than or equal to this version, a message will be raised
      *
      * @static
-     * @param $ver string -
+     * @param string $ver string -
      *     A php standard version string, see http://php.net/manual/en/function.version-compare.php for details.
      * @param null $forModule string -
      *    The name of a module. The passed version will be used as the check value for

src/Dev/FixtureBlueprint.php

Doc Comments +6 added lines

@@ -304,6 +304,9 @@ 
         return $this;
     }
 
+    /**
+     * @param string $type
+     */
     protected function invokeCallbacks($type, $args = array())
     {
         foreach ($this->callbacks[$type] as $callback) {
@@ -346,6 +349,9 @@ 
         $obj->$name = $this->parseValue($value, $fixtures);
     }
 
+    /**
+     * @param string $fieldName
+     */
     protected function overrideField($obj, $fieldName, $value, $fixtures = null)
     {
         $class = get_class($obj);

src/Dev/SapphireTest.php

Doc Comments +4 added lines, -4 removed lines

@@ -632,10 +632,10 @@ 
     /**
      * Assert that the matching email was sent since the last call to clearEmails()
      * All of the parameters can either be a string, or, if they start with "/", a PREG-compatible regular expression.
-     * @param $to
+     * @param string $to
      * @param $from
-     * @param $subject
-     * @param $content
+     * @param string $subject
+     * @param string $content
      * @return array Contains the keys: 'type', 'to', 'from', 'subject', 'content', 'plainContent', 'attachedFiles',
      *               'customHeaders', 'htmlContent', inlineImages'
      */
@@ -868,7 +868,7 @@ 
      * @param string $expectedSQL
      * @param string $actualSQL
      * @param string $message
-     * @param float|int $delta
+     * @param integer $delta
      * @param integer $maxDepth
      * @param boolean $canonicalize
      * @param boolean $ignoreCase

src/Dev/SapphireTestReporter.php

Doc Comments +4 added lines, -1 removed lines

@@ -368,7 +368,7 @@ 
      *
      * @param PHPUnit_Framework_Test $test current test that is being run
      * @param Exception $e PHPUnit error
-     * @return array
+     * @return string
      */
     private function getTestException(PHPUnit_Framework_Test $test, Exception $e)
     {
@@ -487,6 +487,9 @@ 
         echo "</div>";
     }
 
+    /**
+     * @param string $name
+     */
     protected function testNameToPhrase($name)
     {
         return ucfirst(preg_replace("/([a-z])([A-Z])/", "$1 $2", $name));