sminnee / silverstripe-framework

src/Forms/ListboxField.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {

src/Forms/LookupField.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {

src/Forms/TextField.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {

src/View/Requirements.php

Doc Comments +1 added lines

@@ -321,6 +321,7 @@
      * Forces the JavaScript requirements to the end of the body, right before the closing tag
      *
      * @param bool
+     * @param boolean $var
      * @return $this
      */
     public function setForceJSToBottom($var)

src/View/SSTemplateParser.php

Doc Comments +7 added lines, -3 removed lines

@@ -116,6 +116,8 @@ 
 
     /**
      * Override the function that constructs the result arrays to also prepare a 'php' item in the array
+     * @param string $matchrule
+     * @param string $name
      */
     public function construct($matchrule, $name, $arguments = null)
     {
@@ -184,9 +186,9 @@ 
 
     /**
      * Ensures that the arguments to addOpenBlock and addClosedBlock are valid
-     * @param $name
-     * @param $callable
-     * @param $type
+     * @param string $name
+     * @param callable $callable
+     * @param string $type
      * @throws InvalidArgumentException
      */
     protected function validateExtensionBlock($name, $callable, $type)
@@ -277,6 +279,7 @@ 
      * The basic generated PHP of LookupStep and LastLookupStep is the same, except that LookupStep calls 'obj' to
      * get the next ViewableData in the sequence, and LastLookupStep calls different methods (XML_val, hasValue, obj)
      * depending on the context the lookup is used in.
+     * @param string $method
      */
     public function Lookup_AddLookupStep(&$res, $sub, $method)
     {
@@ -1279,6 +1282,7 @@ 
 
     /**
      * @param string $code
+     * @param string $templateName
      * @return string $code
      */
     protected function includeDebuggingComments($code, $templateName)

admin/code/CMSMenu.php

Doc Comments +3 added lines, -3 removed lines

@@ -117,7 +117,7 @@ 
      * @param array $attributes an array of attributes to include on the link.
      * @param string $iconClass
      *
-     * @return boolean The result of the operation.
+     * @return boolean|null The result of the operation.
      */
     public static function add_link($code, $menuTitle, $url, $priority = -1, $attributes = null, $iconClass = null)
     {
@@ -140,7 +140,7 @@ 
      * @param array $attributes an array of attributes to include on the link.
      * @param string $iconClass
      *
-     * @return bool Success
+     * @return boolean|null Success
      */
     public static function add_menu_item(
         $code,
@@ -322,7 +322,7 @@ 
      * @param array $attributes an array of attributes to include on the link.
      * @param string $iconClass
      *
-     * @return bool Success
+     * @return boolean|null Success
      */
     public static function replace_menu_item(
         $code,

admin/code/GroupImportForm.php

Doc Comments +4 added lines

@@ -24,6 +24,10 @@
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {

admin/code/MemberImportForm.php

Doc Comments +5 added lines, -1 removed lines

@@ -25,6 +25,10 @@ 
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {
@@ -127,7 +131,7 @@ 
     }
 
     /**
-     * @param $group Group
+     * @param Group $group Group
      */
     public function setGroup($group)
     {

admin/code/ModelAdmin.php

Doc Comments +4 added lines, -1 removed lines

@@ -153,6 +153,9 @@ 
         }
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         if (!$action) {
@@ -404,7 +407,7 @@ 
     /**
      * Generate a CSV import form for a single {@link DataObject} subclass.
      *
-     * @return Form|false
+     * @return Form
      */
     public function ImportForm()
     {

Unused Use Statements -2 removed lines

@@ -23,7 +23,6 @@ 
 use SilverStripe\Forms\GridField\GridFieldConfig_RecordEditor;
 use SilverStripe\Forms\GridField\GridFieldPrintButton;
 use SilverStripe\Forms\GridField\GridField;
-use SilverStripe\Forms\CompositeField;
 use SilverStripe\Forms\GridField\GridFieldImportButton;
 use SilverStripe\ORM\ArrayLib;
 use SilverStripe\ORM\ArrayList;
@@ -33,7 +32,6 @@ 
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Member;
 use SilverStripe\View\ArrayData;
-use SilverStripe\View\SSViewer;
 
 /**
  * Generates a three-pane UI for editing model classes, with an