sminnee / silverstripe-framework

src/View/SSViewer.php

Doc Comments +4 added lines, -1 removed lines

@@ -648,7 +648,7 @@ 
      * @param mixed $data Data context
      * @param array $arguments Additional arguments
      * @param Object $scope
-     * @return string Evaluated result
+     * @return DBHTMLText Evaluated result
      */
     public static function execute_template($template, $data, $arguments = null, $scope = null)
     {
@@ -676,6 +676,9 @@ 
         return $v->process($data, $arguments);
     }
 
+    /**
+     * @param string $content
+     */
     public function parseTemplateContent($content, $template = "")
     {
         return $this->getParser()->compileString(

src/View/SSViewer_DataPresenter.php

Doc Comments +8 added lines

@@ -33,6 +33,10 @@ 
      */
     protected $underlay;
 
+    /**
+     * @param ViewableData $item
+     * @param ViewableData $inheritedScope
+     */
     public function __construct($item, $overlay = null, $underlay = null, $inheritedScope = null)
     {
         parent::__construct($item, $inheritedScope);
@@ -65,6 +69,10 @@ 
         $this->underlay = $underlay ? $underlay : array();
     }
 
+    /**
+     * @param string $interfaceToQuery
+     * @param string $variableMethod
+     */
     protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false)
     {
         $implementers = ClassInfo::implementorsOf($interfaceToQuery);

src/View/SSViewer_FromString.php

Doc Comments +3 added lines

@@ -30,6 +30,9 @@
      */
     protected $cacheTemplate;
 
+    /**
+     * @param string $content
+     */
     public function __construct($content, TemplateParser $parser = null)
     {
         if ($parser) {

tests/php/Forms/CurrencyFieldTest.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use SilverStripe\Core\Convert;
-use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\View\Parsers\URLSegmentFilter;
 

tests/php/i18n/i18nTextCollectorTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use SilverStripe\Dev\Debug;
 use SilverStripe\ORM\DataObjectSchema;
 use SilverStripe\ORM\DB;
 use SilverStripe\ORM\HasManyList;

tests/php/ORM/DBFieldTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\ORM\Tests;
 
-use SilverStripe\ORM\DB;
 use SilverStripe\ORM\FieldType\DBVarchar;
 use SilverStripe\ORM\FieldType\DBText;
 use SilverStripe\ORM\FieldType\DBField;

tests/php/ORM/ManyManyListExtensionTest.php

Unused Use Statements -3 removed lines

@@ -2,11 +2,8 @@
 
 namespace SilverStripe\ORM\Tests;
 
-use SilverStripe\ORM\DataObject;
-use SilverStripe\ORM\DataExtension;
 use SilverStripe\Core\Object;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Dev\TestOnly;
 
 class ManyManyListExtensionTest extends SapphireTest {
 

tests/php/Security/SecurityTest.php

Unused Use Statements -2 removed lines

@@ -11,11 +11,9 @@
 use SilverStripe\Security\Member;
 use SilverStripe\Security\MemberAuthenticator;
 use SilverStripe\Security\Security;
-use SilverStripe\Security\Permission;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
 use SilverStripe\Dev\FunctionalTest;
-use SilverStripe\Dev\TestOnly;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Control\Session;
 use SilverStripe\Control\Director;

Doc Comments +4 added lines

@@ -676,6 +676,8 @@ 
     /**
      * Execute a log-in form using Director::test().
      * Helper method for the tests above
+     * @param string $email
+     * @param string $password
      */
     public function doTestLoginForm($email, $password, $backURL = 'test/link')
     {
@@ -697,6 +699,8 @@ 
 
     /**
      * Helper method to execute a change password form
+     * @param string $oldPassword
+     * @param string $newPassword
      */
     public function doTestChangepasswordForm($oldPassword, $newPassword)
     {

tests/php/View/SSViewerTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use SilverStripe\Dev\Debug;
 use SilverStripe\ORM\DataObjectSchema;
 use SilverStripe\ORM\DB;
 use SilverStripe\ORM\HasManyList;

Doc Comments +13 added lines

@@ -173,6 +173,10 @@ 
         );
     }
 
+    /**
+     * @param \SilverStripe\ORM\FieldType\DBHTMLText $result
+     * @param string[] $expected
+     */
     private function assertExpectedStrings($result, $expected)
     {
         foreach ($expected as $expectedStr) {
@@ -1088,6 +1092,10 @@ 
         $this->assertEquals('A A1 A1 i A1 ii A2 A3', $rationalisedResult);
     }
 
+    /**
+     * @param string $a
+     * @param string $b
+     */
     public function assertEqualIgnoringWhitespace($a, $b, $message = '')
     {
         $this->assertEquals(preg_replace('/\s+/', '', $a), preg_replace('/\s+/', '', $b), $message);
@@ -1816,6 +1824,11 @@ 
             $this->_renderWithSourceFileComments('SSViewerTestComments/'.$template['name'], $template['expected']);
         }
     }
+
+    /**
+     * @param string $name
+     * @param string $expected
+     */
     private function _renderWithSourceFileComments($name, $expected)
     {
         $viewer = new SSViewer(array($name));