sminnee / silverstripe-framework

src/Security/MemberAuthenticator/LogoutHandler.php

Doc Comments +2 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
 
     /**
      * @param Member $member
-     * @return HTTPResponse
+     * @return \SilverStripe\Control\HTTPResponse
      */
     public function doLogOut($member)
     {
@@ -99,7 +99,7 @@ 
     }
 
     /**
-     * @return HTTPResponse
+     * @return \SilverStripe\Control\HTTPResponse
      */
     protected function redirectAfterLogout()
     {

src/Security/MemberAuthenticator/MemberAuthenticator.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use InvalidArgumentException;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Core\Extensible;
-use SilverStripe\Dev\Debug;
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Authenticator;
 use SilverStripe\Security\DefaultAdminService;

src/Security/RememberLoginHash.php

Doc Comments +6 added lines

@@ -84,11 +84,17 @@
      */
     private $token = null;
 
+    /**
+     * @return string
+     */
     public function getToken()
     {
         return $this->token;
     }
 
+    /**
+     * @param string $token
+     */
     public function setToken($token)
     {
         $this->token = $token;

src/Security/Security.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Control\HTTPResponse_Exception;
 use SilverStripe\Control\RequestHandler;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Convert;
 use SilverStripe\Core\Injector\Injector;

tests/php/Core/ObjectTest.php

Unused Use Statements -2 removed lines

@@ -4,10 +4,8 @@
 
 use SilverStripe\Control\Controller;
 use SilverStripe\Core\ClassInfo;
-use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Extension;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Core\Manifest\ClassLoader;
 use SilverStripe\Core\Tests\ObjectTest\BaseObject;
 use SilverStripe\Core\Tests\ObjectTest\ExtendTest1;
 use SilverStripe\Core\Tests\ObjectTest\ExtendTest2;

tests/php/Forms/DropdownFieldTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -400,7 +400,7 @@
      * string of HTML.
      *
      * @param  string $html HTML to scan for elements
-     * @return SimpleXMLElement
+     * @return \SimpleXMLElement[]
      */
     public function findOptionElements($html)
     {

tests/php/Forms/GridField/GridField_URLHandlerTest/TestComponent_ItemRequest.php

Doc Comments +5 added lines

@@ -20,6 +20,11 @@
 
     protected $id;
 
+    /**
+     * @param \SilverStripe\Forms\GridField\GridField $gridField
+     * @param string $id
+     * @param string $link
+     */
     public function __construct($gridField, $id, $link)
     {
         $this->gridField = $gridField;

tests/php/Forms/GridField/GridFieldDetailFormTest.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Forms\Tests\GridField;
 
 use SilverStripe\Dev\CSSContentParser;
-use SilverStripe\Dev\Debug;
 use SilverStripe\Dev\FunctionalTest;
 use SilverStripe\Control\Controller;
 use SilverStripe\Forms\HiddenField;

src/Control/TrustedProxyMiddleware.php

Doc Comments +1 added lines

@@ -102,6 +102,7 @@
     /**
      * Determine if the current request is coming from a trusted proxy
      *
+     * @param HTTPRequest $request
      * @return boolean True if the request's source IP is a trusted proxy
      */
     protected function isTrustedProxy($request)