sminnee / silverstripe-framework

tests/forms/uploadfield/AssetFieldTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -356,7 +356,7 @@
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {

tests/forms/uploadfield/UploadFieldTest.php

Doc Comments +4 added lines, -1 removed lines

@@ -946,7 +946,7 @@ 
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -958,6 +958,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $fileField
+	 */
 	protected function mockFileExists($fileField, $fileName) {
 		return $this->get(
 			"UploadFieldTest_Controller/Form/field/{$fileField}/fileexists?filename=".urlencode($fileName)

tests/model/ImageTest.php

Unused Use Statements -4 removed lines

@@ -1,9 +1,5 @@
 <?php
 
-use League\Flysystem\Filesystem;
-use SilverStripe\Assets\Flysystem\AssetAdapter;
-use SilverStripe\Assets\Flysystem\FlysystemAssetStore;
-use SilverStripe\Assets\Flysystem\FlysystemUrlPlugin;
 use SilverStripe\Assets\File;
 use SilverStripe\Assets\Filesystem as SSFilesystem;
 use SilverStripe\Assets\Image;

View/Parsers/Diff.php

Doc Comments +1 added lines, -1 removed lines

@@ -160,7 +160,7 @@
 	}
 
 	/**
-	 * @param string|array $content If passed as an array, values will be concatenated with a comma.
+	 * @param string $content If passed as an array, values will be concatenated with a comma.
 	 * @return array
 	 */
 	public static function getHTMLChunks($content) {

View/Parsers/HTMLValue.php

Doc Comments +1 added lines

@@ -139,6 +139,7 @@
 	/**
 	 * Get the body element, or false if there isn't one (we haven't loaded any content
 	 * or this instance is in an invalid state)
+	 * @return \DOMElement
 	 */
 	public function getBody() {
 		$doc = $this->getDocument();

View/Parsers/ShortcodeParser.php

Doc Comments +3 added lines

@@ -168,6 +168,9 @@
 
 	// --------------------------------------------------------------------------------------------------------------
 
+	/**
+	 * @param DOMElement $node
+	 */
 	protected function removeNode($node) {
 		$node->parentNode->removeChild($node);
 	}

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\View\Parsers;
 
 use DOMNodeList;
-use SilverStripe\Core\Object;
 use SilverStripe\Core\Injector\Injector;
 use InvalidArgumentException;
 use DOMElement;

View/Parsers/URLSegmentFilter.php

Doc Comments +1 added lines

@@ -89,6 +89,7 @@
 	 * Determines if the field should render open or closed by default.
 	 *
 	 * @param boolean
+	 * @param boolean $bool
 	 */
 	public function startClosed($bool) {
 		($bool) ? $this->addExtraClass('startClosed') : $this->removeExtraClass('startClosed');

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace SilverStripe\View\Parsers;
 
-use SilverStripe\Core\Object;
-
 /**
  * Filter certain characters from "URL segments" (also called "slugs"), for nicer (more SEO-friendly) URLs.
  * Uses {@link Transliterator} to convert non-ASCII characters to meaningful ASCII representations.

View/Requirements_Backend.php

Doc Comments +1 added lines

@@ -321,6 +321,7 @@
 	 * Forces the JavaScript requirements to the end of the body, right before the closing tag
 	 *
 	 * @param bool
+	 * @param boolean $var
 	 * @return $this
 	 */
 	public function setForceJSToBottom($var)

View/SSTemplateParser.php.inc

Doc Comments +7 added lines, -3 removed lines

@@ -114,6 +114,8 @@ 
 
 	/**
 	 * Override the function that constructs the result arrays to also prepare a 'php' item in the array
+	 * @param string $matchrule
+	 * @param string $name
 	 */
 	function construct($matchrule, $name, $arguments = null) {
 		$res = parent::construct($matchrule, $name, $arguments);
@@ -175,9 +177,9 @@ 
 
 	/**
 	 * Ensures that the arguments to addOpenBlock and addClosedBlock are valid
-	 * @param $name
-	 * @param $callable
-	 * @param $type
+	 * @param string $name
+	 * @param callable $callable
+	 * @param string $type
 	 * @throws InvalidArgumentException
 	 */
 	protected function validateExtensionBlock($name, $callable, $type) {
@@ -262,6 +264,7 @@ 
 	 * The basic generated PHP of LookupStep and LastLookupStep is the same, except that LookupStep calls 'obj' to
 	 * get the next ViewableData in the sequence, and LastLookupStep calls different methods (XML_val, hasValue, obj)
 	 * depending on the context the lookup is used in.
+	 * @param string $method
 	 */
 	function Lookup_AddLookupStep(&$res, $sub, $method) {
 		$res['LookupSteps'][] = $sub;
@@ -1174,6 +1177,7 @@ 
 
 	/**
 	 * @param string $code
+	 * @param string $templateName
 	 * @return string $code
 	 */
 	protected function includeDebuggingComments($code, $templateName) {