Completed
Push — fix-34-builds ( 135a64 )
by Sam
05:53
created
model/connect/DBSchemaManager.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -38,7 +38,6 @@  discard block
 block discarded – undo
38 38
 	/**
39 39
 	 * Injector injection point for database controller
40 40
 	 *
41
-	 * @param SS_Database $connector
42 41
 	 */
43 42
 	public function setDatabase(SS_Database $database) {
44 43
 		$this->database = $database;
@@ -104,6 +103,7 @@  discard block
 block discarded – undo
104 103
 	 *
105 104
 	 * @var callable $callback
106 105
 	 * @throws Exception
106
+	 * @param Closure $callback
107 107
 	 */
108 108
 	public function schemaUpdate($callback) {
109 109
 		// Begin schema update
@@ -476,7 +476,7 @@  discard block
 block discarded – undo
476 476
 	/**
477 477
 	 * Given an index spec determines the index type
478 478
 	 *
479
-	 * @param array|string $spec
479
+	 * @param string $spec
480 480
 	 * @return string
481 481
 	 */
482 482
 	protected function determineIndexType($spec) {
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
 	/**
545 545
 	 * Returns true if the given table is exists in the current database
546 546
 	 *
547
-	 * @param string $table Name of table to check
547
+	 * @param string $tableName Name of table to check
548 548
 	 * @return boolean Flag indicating existence of table
549 549
 	 */
550 550
 	abstract public function hasTable($tableName);
Please login to merge, or discard this patch.
model/connect/MySQLSchemaManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -115,6 +115,9 @@
 block discarded – undo
115 115
 		$this->query("ALTER TABLE \"$tableName\" $alterations");
116 116
 	}
117 117
 
118
+	/**
119
+	 * @param string $tableName
120
+	 */
118 121
 	public function isView($tableName) {
119 122
 		$info = $this->query("SHOW /*!50002 FULL*/ TABLES LIKE '$tableName'")->record();
120 123
 		return $info && strtoupper($info['Table_type']) == 'VIEW';
Please login to merge, or discard this patch.
model/DataDifferencer.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -50,6 +50,7 @@
 block discarded – undo
50 50
 	 *
51 51
 	 * @param DataObject (Optional)
52 52
 	 * @param DataObject
53
+	 * @param DataObject|null $fromRecord
53 54
 	 */
54 55
 	public function __construct($fromRecord, DataObject $toRecord) {
55 56
 		if(!$toRecord) user_error("DataDifferencer constructed without a toRecord", E_USER_WARNING);
Please login to merge, or discard this patch.
model/fieldtypes/Currency.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -28,6 +28,9 @@  discard block
 block discarded – undo
28 28
 	 */
29 29
 	private static $currency_symbol = '$';
30 30
 
31
+	/**
32
+	 * @param string $name
33
+	 */
31 34
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
32 35
 		parent::__construct($name, $wholeSize, $decimalSize, $defaultValue);
33 36
 	}
@@ -51,6 +54,9 @@  discard block
 block discarded – undo
51 54
 		else return $val;
52 55
 	}
53 56
 
57
+	/**
58
+	 * @param string $value
59
+	 */
54 60
 	public function setValue($value, $record = null, $markChanged = true) {
55 61
 		$matches = null;
56 62
 		if(is_numeric($value)) {
Please login to merge, or discard this patch.
model/fieldtypes/Date.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,6 +31,9 @@  discard block
 block discarded – undo
31 31
  */
32 32
 class DBDate extends DBField {
33 33
 
34
+	/**
35
+	 * @param string $value
36
+	 */
34 37
 	public function setValue($value, $record = null, $markChanged = true) {
35 38
 		if($value === false || $value === null || (is_string($value) && !strlen($value))) {
36 39
 			// don't try to evaluate empty values with strtotime() below, as it returns "1970-01-01" when it should be
@@ -113,7 +116,7 @@  discard block
 block discarded – undo
113 116
 
114 117
 	/**
115 118
 	 * Returns the day of the month.
116
-	 * @param boolean $includeOrdinals Include ordinal suffix to day, e.g. "th" or "rd"
119
+	 * @param boolean $includeOrdinal Include ordinal suffix to day, e.g. "th" or "rd"
117 120
 	 * @return string
118 121
 	 */
119 122
 	public function DayOfMonth($includeOrdinal = false) {
Please login to merge, or discard this patch.
model/fieldtypes/Decimal.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 	 * @param string $name
22 22
 	 * @param int $wholeSize
23 23
 	 * @param int $decimalSize
24
-	 * @param float $defaultValue
24
+	 * @param integer $defaultValue
25 25
 	 */
26 26
 	public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0) {
27 27
 		$this->wholeSize = is_int($wholeSize) ? $wholeSize : 9;
@@ -33,14 +33,14 @@  discard block
 block discarded – undo
33 33
 	}
34 34
 
35 35
 	/**
36
-	 * @return float
36
+	 * @return string
37 37
 	 */
38 38
 	public function Nice() {
39 39
 		return number_format($this->value, $this->decimalSize);
40 40
 	}
41 41
 
42 42
 	/**
43
-	 * @return int
43
+	 * @return double
44 44
 	 */
45 45
 	public function Int() {
46 46
 		return floor($this->value);
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 	}
87 87
 
88 88
 	/**
89
-	 * @return float
89
+	 * @return integer
90 90
 	 */
91 91
 	public function nullValue() {
92 92
 		return 0;
Please login to merge, or discard this patch.
model/fieldtypes/HTMLText.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -47,6 +47,9 @@
 block discarded – undo
47 47
 
48 48
 	protected $whitelist = false;
49 49
 
50
+	/**
51
+	 * @param string $name
52
+	 */
50 53
 	public function __construct($name = null, $options = array()) {
51 54
 		if(is_string($options)) {
52 55
 			$options = array('whitelist' => $options);
Please login to merge, or discard this patch.
model/fieldtypes/Time.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -64,6 +64,9 @@
 block discarded – undo
64 64
 		if($this->value) return date($format, strtotime($this->value));
65 65
 	}
66 66
 
67
+	/**
68
+	 * @param string[] $parts
69
+	 */
67 70
 	public function TwelveHour( $parts ) {
68 71
 		$hour = $parts[1];
69 72
 		$min = $parts[2];
Please login to merge, or discard this patch.
model/fieldtypes/Year.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -24,6 +24,9 @@
 block discarded – undo
24 24
 		DB::require_field($this->tableName, $this->name, $values);
25 25
 	}
26 26
 
27
+	/**
28
+	 * @param string $title
29
+	 */
27 30
 	public function scaffoldFormField($title = null, $params = null) {
28 31
 		$selectBox = new DropdownField($this->name, $title);
29 32
 		$selectBox->setSource($this->getDefaultOptions());
Please login to merge, or discard this patch.