sminnee / silverstripe-framework

tests/php/Forms/EmailFieldTest.php

Doc Comments +5 added lines

@@ -40,6 +40,11 @@
         $this->internalCheck("domain.but.no.user", "Invalid, no user part", false);
     }
 
+    /**
+     * @param string $email
+     * @param string $checkText
+     * @param boolean $expectSuccess
+     */
     public function internalCheck($email, $checkText, $expectSuccess)
     {
         $field = new EmailField("MyEmail");

tests/php/Forms/GridField/GridFieldAddExistingAutocompleterTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\Forms\Tests\GridField;
 
-use SilverStripe\Dev\Debug;
 use SilverStripe\Forms\Tests\GridField\GridFieldAddExistingAutocompleterTest\TestController;
 use SilverStripe\Forms\Tests\GridField\GridFieldTest\Cheerleader;
 use SilverStripe\Forms\Tests\GridField\GridFieldTest\Permissions;

tests/php/Forms/HTMLEditor/HTMLEditorSanitiserTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Dev\FunctionalTest;
 use SilverStripe\Forms\HTMLEditor\HTMLEditorConfig;
-use SilverStripe\Forms\HTMLEditor\HTMLEditorSanitiser;
 
 class HTMLEditorSanitiserTest extends FunctionalTest
 {

tests/php/Forms/TimeFieldTest.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Forms\Tests;
 
 use IntlDateFormatter;
-use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Forms\TimeField;
 use SilverStripe\Forms\RequiredFields;

tests/php/ORM/DBDatetimeTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\i18n\i18n;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Security\Member;
 
 /**
  * Tests for {@link Datetime} class.

tests/php/ORM/DBTimeTest.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use SilverStripe\ORM\FieldType\DBField;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\ORM\FieldType\DBTime;
-use SilverStripe\Security\Member;
 
 class DBTimeTest extends SapphireTest
 {

tests/php/View/ContentNegotiatorTest.php

Doc Comments +1 added lines

@@ -14,6 +14,7 @@
     /**
      * Small helper to render templates from strings
      * Cloned from SSViewerTest
+     * @param string $templateString
      */
     private function render($templateString, $data = null)
     {

tests/php/View/Parsers/ShortcodeParserTest.php

Doc Comments +4 added lines

@@ -208,6 +208,10 @@
         $this->assertEquals('', $this->parser->parse('[test_shortcode][test_shortcode]'));
     }
 
+    /**
+     * @param string $a
+     * @param string $b
+     */
     protected function assertEqualsIgnoringWhitespace($a, $b, $message = null)
     {
         $this->assertEquals(preg_replace('/\s+/', '', $a), preg_replace('/\s+/', '', $b), $message);

src/Forms/DateField.php

Doc Comments +2 added lines, -2 removed lines

@@ -312,7 +312,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -337,7 +337,7 @@ 
      *
      * When $html5=true, assign value from ISO 8601 string.
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */