PDOQuery::fetchAllPgsql() - Code Metrics - Inspection of "NEW: Allow for user-created objects to have values..." - sminnee/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — fix-6460 ( 379c3e...254990 )

by Sam

created 2019-05-27 02:31 UTC

PDOQuery::fetchAllPgsql() A

↳ Parent: Project

Complexity

Conditions	5
Paths	2

Size

Total Lines	23
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	13
nc	2
nop	1
dl	0
loc	23
rs	9.5222
c	0
b	0
f	0

<?php

namespace SilverStripe\ORM\Connect;

/**
 * A result-set from a PDO database.
 */
class PDOQuery extends Query
{
    /**
     * @var array
     */
    protected $results = null;

    /**
     * Hook the result-set given into a Query class, suitable for use by SilverStripe.
     * @param PDOStatement $statement The internal PDOStatement containing the results
     */
    public function __construct(PDOStatementHandle $statement)
    {
        // Since no more than one PDOStatement for any one connection can be safely
        // traversed, each statement simply requests all rows at once for safety.
        // This could be re-engineered to call fetchAll on an as-needed basis

        $this->results = $statement->typeCorrectedFetchAll();
        $statement->closeCursor();
    }

    public function seek($row)
    {
        $this->rowNum = $row - 1;
        return $this->nextRecord();

    }

    public function numRecords()
    {
        return count($this->results);
    }

    public function nextRecord()
    {
        $index = $this->rowNum + 1;

        if (isset($this->results[$index])) {
            return $this->results[$index];
        } else {
            return false;
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
        }
    }
}


1			<?php
2
3			namespace SilverStripe\ORM\Connect;
4
5			/**
6			* A result-set from a PDO database.
7			*/
8			class PDOQuery extends Query
9			{
10			/**
11			* @var array
12			*/
13			protected $results = null;
14
15			/**
16			* Hook the result-set given into a Query class, suitable for use by SilverStripe.
17			* @param PDOStatement $statement The internal PDOStatement containing the results
18			*/
19			public function __construct(PDOStatementHandle $statement)
20			{
21			// Since no more than one PDOStatement for any one connection can be safely
22			// traversed, each statement simply requests all rows at once for safety.
23			// This could be re-engineered to call fetchAll on an as-needed basis
24
25			$this->results = $statement->typeCorrectedFetchAll();
26			$statement->closeCursor();
27			}
28
29			public function seek($row)
30			{
31			$this->rowNum = $row - 1;
32			return $this->nextRecord();
			0 ignored issues – show Bug Best Practice introduced 2018-09-18 01:26 UTC by Report Bug Copy Issue Report The expression `return $this->nextRecord()` also could return the type `false` which is incompatible with the return type mandated by `SilverStripe\ORM\Connect\Query::seek()` of `array`. Loading history...
33			}
34
35			public function numRecords()
36			{
37			return count($this->results);
38			}
39
40			public function nextRecord()
41			{
42			$index = $this->rowNum + 1;
43
44			if (isset($this->results[$index])) {
45			return $this->results[$index];
46			} else {
47			return false;
			0 ignored issues – show Bug Best Practice introduced 2018-09-18 01:26 UTC by Report Bug Copy Issue Report The expression `return false` returns the type `false` which is incompatible with the return type mandated by `SilverStripe\ORM\Connect\Query::nextRecord()` of `array`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
48			}
49			}
50			}
51

sminnee / silverstripe-framework

Push — fix-6460 ( 379c3e...254990 )

PDOQuery::fetchAllPgsql() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like