sminnee / silverstripe-framework

src/Forms/HTMLEditor/HTMLEditorField_Embed.php

Doc Comments +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
     }
 
     /**
-     * @return AdapterInterface
+     * @return Adapter
      */
     public function getEmbed()
     {

src/Forms/TreeDropdownField.php

Doc Comments +2 added lines, -2 removed lines

@@ -313,7 +313,7 @@ 
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {
@@ -479,7 +479,7 @@ 
 
     /**
      * Marking a specific node in the tree as disabled
-     * @param $node
+     * @param DataObject $node
      * @return boolean
      */
     public function nodeIsDisabled($node)

src/ORM/Hierarchy/MarkedSet.php

Doc Comments +3 added lines, -3 removed lines

@@ -387,7 +387,7 @@ 
      *
      * @param DataObject $node
      * @param int $depth
-     * @return array|string
+     * @return callable
      */
     protected function getSubtree($node, $depth = 0)
     {
@@ -620,7 +620,7 @@ 
     /**
      * Expose the given object in the tree, by marking this page and all it ancestors.
      *
-     * @param DataObject|Hierarchy $childObj
+     * @param DataObject $childObj
      * @return $this
      */
     public function markToExpose(DataObject $childObj)
@@ -765,7 +765,7 @@ 
     /**
      * Check if this node has too many children
      *
-     * @param DataObject|Hierarchy $node
+     * @param DataObject $node
      * @param int $count Children count (if already calculated)
      * @return bool
      */

src/Security/MemberAuthenticator/Authenticator.php

Doc Comments +1 added lines, -1 removed lines

@@ -47,8 +47,8 @@
      * Attempt to find and authenticate member if possible from the given data
      *
      * @param array $data
-     * @param Form $form
      * @param bool &$success Success flag
+     * @param string $message
      * @return Member Found member, regardless of successful login
      */
     protected function authenticateMember($data, &$message, &$success)

src/Security/MemberAuthenticator/LoginForm.php

Unused Use Statements -1 removed lines

@@ -15,7 +15,6 @@
 use SilverStripe\Forms\RequiredFields;
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\View\Requirements;
-
 use SilverStripe\Security\Member;
 use SilverStripe\Security\Security;
 use SilverStripe\Security\RememberLoginHash;

src/Security/MemberAuthenticator/LostPasswordHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * Factory method for the lost password form
      *
      * @skipUpgrade
-     * @return Form Returns the lost password form
+     * @return LoginForm Returns the lost password form
      */
     public function lostPasswordForm()
     {

Unused Use Statements -2 removed lines

@@ -5,9 +5,7 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\Email\Email;
 use SilverStripe\Control\HTTPResponse;
-use SilverStripe\Control\Session;
 use SilverStripe\Control\RequestHandler;
-use SilverStripe\ORM\ValidationResult;
 
 /**
  * Handle login requests from MemberLoginForm

src/Security/Security.php

Doc Comments +3 added lines, -3 removed lines

@@ -583,7 +583,7 @@ 
      * Combine the given forms into a formset with a tabbed interface
      *
      * @param array $forms List of LoginForm instances
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     protected function generateLoginFormSet($forms)
     {
@@ -893,7 +893,7 @@ 
      * Factory method for the lost password form
      *
      * @skipUpgrade
-     * @return ChangePasswordForm Returns the lost password form
+     * @return MemberAuthenticator\ChangePasswordForm Returns the lost password form
      */
     public function ChangePasswordForm()
     {
@@ -1204,7 +1204,7 @@ 
     /**
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
-     * @param $flag True or false
+     * @param boolean $flag True or false
      */
     public static function set_ignore_disallowed_actions($flag)
     {

Unused Use Statements -5 removed lines

@@ -12,14 +12,10 @@ 
 use SilverStripe\Control\Session;
 use SilverStripe\Control\RequestHandler;
 use SilverStripe\Core\ClassInfo;
-use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
 use SilverStripe\Dev\Deprecation;
 use SilverStripe\Dev\TestOnly;
-use SilverStripe\Forms\EmailField;
-use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;
-use SilverStripe\Forms\FormAction;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DB;
 use SilverStripe\ORM\DataObject;
@@ -29,7 +25,6 @@ 
 use SilverStripe\View\SSViewer;
 use SilverStripe\View\TemplateGlobalProvider;
 use Exception;
-use SilverStripe\View\ViewableData_Customised;
 use Subsite;
 use SilverStripe\Core\Injector\Injector;
 

tests/php/ORM/DBDateTest.php

Unused Use Statements -2 removed lines

@@ -7,9 +7,7 @@
 use SilverStripe\ORM\FieldType\DBDate;
 use SilverStripe\ORM\FieldType\DBField;
 use SilverStripe\ORM\FieldType\DBDatetime;
-use SilverStripe\ORM\DataObject;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Security\Member;
 
 class DBDateTest extends SapphireTest
 {

tests/php/ORM/MarkedSetTest.php

Doc Comments +5 added lines

@@ -418,6 +418,7 @@ 
      *
      * @param string$html
      * @param DataObject $node
+     * @param string $html
      * @return string
      */
     protected function getNodeClassFromTree($html, $node)
@@ -434,6 +435,10 @@ 
         return '';
     }
 
+    /**
+     * @param string $expected
+     * @param string $actual
+     */
     protected function assertHTMLSame($expected, $actual, $message = '')
     {
         // Trim each line, strip empty lines

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\ORM\Tests;
 
-use DOMDocument;
 use SilverStripe\Dev\CSSContentParser;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\ORM\DataObject;