sminnee / silverstripe-framework

tests/php/Forms/GridField/GridFieldDeleteActionTest.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use SilverStripe\Security\SecurityToken;
 use SilverStripe\Dev\CSSContentParser;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Control\Controller;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Control\Session;
 use SilverStripe\Forms\FieldList;

tests/php/Forms/GridField/GridFieldEditButtonTest.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use SilverStripe\Security\Member;
 use SilverStripe\Dev\CSSContentParser;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Control\Controller;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;
 use SilverStripe\Forms\GridField\GridFieldConfig;

tests/php/Forms/GridField/GridFieldPaginatorTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\Forms\Tests\GridField;
 
-use SilverStripe\Control\Controller;
 use SilverStripe\Dev\CSSContentParser;
 use SilverStripe\Dev\FunctionalTest;
 use SilverStripe\Forms\FieldList;

tests/php/ORM/DataExtensionTest.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace SilverStripe\ORM\Tests;
 
-use SilverStripe\Assets\Tests\FileMigrationHelperTest\Extension;
-use SilverStripe\Core\Config\Middleware\ExtensionMiddleware;
-use SilverStripe\Dev\Debug;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\SapphireTest;

src/Control/Director.php

Doc Comments +3 added lines, -3 removed lines

@@ -249,7 +249,7 @@ 
      *
      * @param string $url The URL to visit.
      * @param array $postVars The $_POST & $_FILES variables.
-     * @param array|Session $session The {@link Session} object representing the current session.
+     * @param Session|null $session The {@link Session} object representing the current session.
      * By passing the same object to multiple  calls of Director::test(), you can simulate a persisted
      * session.
      * @param string $httpMethod The HTTP method, such as GET or POST.  It will default to POST if
@@ -928,7 +928,7 @@ 
     /**
      * Returns true if the given file exists. Filename should be relative to the site root.
      *
-     * @param $file
+     * @param string $file
      *
      * @return bool
      */
@@ -1156,7 +1156,7 @@ 
      * Can also be checked with {@link Director::isDev()}, {@link Director::isTest()}, and
      * {@link Director::isLive()}.
      *
-     * @return bool
+     * @return string
      */
     public static function get_environment_type()
     {

src/Control/HTTPRequest.php

Doc Comments +3 added lines, -3 removed lines

@@ -349,7 +349,7 @@ 
      * Remove an existing HTTP header
      *
      * @param string $header
-     * @return mixed
+     * @return string
      */
     public function getHeader($header)
     {
@@ -458,9 +458,9 @@ 
      * it's only advisable to send small files through this method.
      *
      * @static
-     * @param $fileData
+     * @param string $fileData
      * @param $fileName
-     * @param null $mimeType
+     * @param string $mimeType
      * @return HTTPResponse
      */
     public static function send_file($fileData, $fileName, $mimeType = null)

src/Core/Cache/DefaultCacheFactory.php

Doc Comments +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
     /**
      * Determine if apcu is supported
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function isAPCUSupported()
     {
@@ -92,7 +92,7 @@ 
     /**
      * Determine if PHP files is supported
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function isPHPFilesSupported()
     {

src/Core/Convert.php

Doc Comments +3 added lines, -2 removed lines

@@ -203,7 +203,7 @@ 
      * table, or column name. Supports encoding of multi identfiers separated by
      * a delimiter (e.g. ".")
      *
-     * @param string|array $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
+     * @param string $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
      * to be joined via the separator.
      * @param string $separator The string that delimits subsequent identifiers
      * @return string The escaped identifier. E.g. '"SiteTree"."Title"'
@@ -304,6 +304,7 @@ 
      * call this function directly, Please use {@link Convert::xml2array()}
      *
      * @param SimpleXMLElement
+     * @param SimpleXMLElement $xml
      *
      * @return mixed
      */
@@ -517,7 +518,7 @@ 
      * - IDField => idField
      * - iDField => iDField
      *
-     * @param $str
+     * @param string $str
      * @return string
      */
     public static function upperCamelToLowerCamel($str)

src/Dev/BulkLoader.php

Doc Comments +4 added lines

@@ -140,6 +140,10 @@
 	 *
 	 * @return BulkLoader_Result See {@link self::processAll()}
 	 */
+
+    /**
+     * @param string $filepath
+     */
     public function load($filepath)
     {
         increase_time_limit_to(3600);