sminnee / silverstripe-framework

src/Control/RequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -296,7 +296,7 @@
      *
      * Must not raise HTTPResponse_Exceptions - instead it should return
      *
-     * @param $request
+     * @param HTTPRequest $request
      * @param $action
      * @return HTTPResponse
      */

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\Control;
 
 use InvalidArgumentException;
-use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Object;
 use SilverStripe\Dev\Debug;

src/Control/RSS/RSSFeed.php

Doc Comments +1 added lines

@@ -248,6 +248,7 @@
      * via the standard template inclusion process.
      *
      * @param string
+     * @param string|null $template
      */
     public function setTemplate($template)
     {

src/Control/Session.php

Doc Comments +6 added lines

@@ -330,6 +330,9 @@ 
         }
     }
 
+    /**
+     * @param string $name
+     */
     public function inst_set($name, $val)
     {
         // Quicker execution path for "."-free names
@@ -379,6 +382,9 @@ 
         $diffVar[sizeof($var)-1] = $val;
     }
 
+    /**
+     * @param string $name
+     */
     public function inst_get($name)
     {
         // Quicker execution path for "."-free names

src/Core/ClassInfo.php

Doc Comments +5 added lines

@@ -297,6 +297,9 @@ 
 
     private static $method_from_cache = array();
 
+    /**
+     * @param string $method
+     */
     public static function has_method_from($class, $method, $compclass)
     {
         $lClass = strtolower($class);
@@ -322,6 +325,8 @@ 
 
     /**
      * @deprecated 4.0..5.0
+     * @param string $candidateClass
+     * @param string $fieldName
      */
     public static function table_for_object_field($candidateClass, $fieldName)
     {

src/Core/Convert.php

Doc Comments +5 added lines, -4 removed lines

@@ -57,9 +57,9 @@ 
      *
      * @see http://www.w3.org/TR/REC-html40/types.html#type-cdata
      *
-     * @param array|string $val String to escape, or array of strings
+     * @param string $val String to escape, or array of strings
      *
-     * @return array|string
+     * @return string
      */
     public static function raw2htmlname($val)
     {
@@ -200,7 +200,7 @@ 
      * table, or column name. Supports encoding of multi identfiers separated by
      * a delimiter (e.g. ".")
      *
-     * @param string|array $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
+     * @param string $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
      * to be joined via the separator.
      * @param string $separator The string that delimits subsequent identifiers
      * @return string The escaped identifier. E.g. '"SiteTree"."Title"'
@@ -301,6 +301,7 @@ 
      * call this function directly, Please use {@link Convert::xml2array()}
      *
      * @param SimpleXMLElement
+     * @param SimpleXMLElement $xml
      *
      * @return mixed
      */
@@ -514,7 +515,7 @@ 
      * - IDField => idField
      * - iDField => iDField
      *
-     * @param $str
+     * @param string $str
      * @return string
      */
     public static function upperCamelToLowerCamel($str)

src/Core/CustomMethods.php

Doc Comments +1 added lines, -1 removed lines

@@ -152,7 +152,7 @@
     /**
      * Get meta-data details on a named method
      *
-     * @param array $method
+     * @param string $method
      * @return array List of custom method details, if defined for this method
      */
     protected function getExtraMethodConfig($method)

src/Core/Injector/Injector.php

Doc Comments +2 added lines, -2 removed lines

@@ -368,7 +368,7 @@ 
      *
      * @param string $property
      *                the name of the property
-     * @param object $object
+     * @param string $object
      *                the object to be set
      * @return $this
      */
@@ -463,7 +463,7 @@ 
      *              The name of the service to update the definition for
      * @param string $property
      *              The name of the property to update.
-     * @param mixed $value
+     * @param string $value
      *              The value to set
      * @param boolean $append
      *              Whether to append (the default) when the property is an array

src/Core/Manifest/ClassManifest.php

Doc Comments +1 added lines, -1 removed lines

@@ -259,7 +259,7 @@
      * Returns an array containing all the descendants (direct and indirect)
      * of a class.
      *
-     * @param  string|object $class
+     * @param  string $class
      * @return array
      */
     public function getDescendantsOf($class)

src/Core/Startup/ErrorControlChain.php

Doc Comments +2 added lines, -2 removed lines

@@ -106,7 +106,7 @@ 
     /**
      * Get value of display_errors ini value
      *
-     * @return mixed
+     * @return string
      */
     protected function getDisplayErrors()
     {
@@ -117,7 +117,7 @@ 
      * Add this callback to the chain of callbacks to call along with the state
      * that $error must be in this point in the chain for the callback to be called
      *
-     * @param $callback - The callback to call
+     * @param callable $callback - The callback to call
      * @param $onErrorState - false if only call if no errors yet, true if only call if already errors, null for either
      * @return $this
      */