Completed
Push — add-versioned-test ( 5ea238 )
by Sam
13:40
created
src/Control/RequestHandler.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -296,7 +296,7 @@
 block discarded – undo
296 296
      *
297 297
      * Must not raise HTTPResponse_Exceptions - instead it should return
298 298
      *
299
-     * @param $request
299
+     * @param HTTPRequest $request
300 300
      * @param $action
301 301
      * @return HTTPResponse
302 302
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SilverStripe\Control;
4 4
 
5 5
 use InvalidArgumentException;
6
-use SilverStripe\Core\ClassInfo;
7 6
 use SilverStripe\Core\Config\Config;
8 7
 use SilverStripe\Core\Object;
9 8
 use SilverStripe\Dev\Debug;
Please login to merge, or discard this patch.
src/Control/RSS/RSSFeed.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -248,6 +248,7 @@
 block discarded – undo
248 248
      * via the standard template inclusion process.
249 249
      *
250 250
      * @param string
251
+     * @param string|null $template
251 252
      */
252 253
     public function setTemplate($template)
253 254
     {
Please login to merge, or discard this patch.
src/Control/Session.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -330,6 +330,9 @@  discard block
 block discarded – undo
330 330
         }
331 331
     }
332 332
 
333
+    /**
334
+     * @param string $name
335
+     */
333 336
     public function inst_set($name, $val)
334 337
     {
335 338
         // Quicker execution path for "."-free names
@@ -379,6 +382,9 @@  discard block
 block discarded – undo
379 382
         $diffVar[sizeof($var)-1] = $val;
380 383
     }
381 384
 
385
+    /**
386
+     * @param string $name
387
+     */
382 388
     public function inst_get($name)
383 389
     {
384 390
         // Quicker execution path for "."-free names
Please login to merge, or discard this patch.
src/Core/ClassInfo.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -297,6 +297,9 @@  discard block
 block discarded – undo
297 297
 
298 298
     private static $method_from_cache = array();
299 299
 
300
+    /**
301
+     * @param string $method
302
+     */
300 303
     public static function has_method_from($class, $method, $compclass)
301 304
     {
302 305
         $lClass = strtolower($class);
@@ -322,6 +325,8 @@  discard block
 block discarded – undo
322 325
 
323 326
     /**
324 327
      * @deprecated 4.0..5.0
328
+     * @param string $candidateClass
329
+     * @param string $fieldName
325 330
      */
326 331
     public static function table_for_object_field($candidateClass, $fieldName)
327 332
     {
Please login to merge, or discard this patch.
src/Core/Convert.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -57,9 +57,9 @@  discard block
 block discarded – undo
57 57
      *
58 58
      * @see http://www.w3.org/TR/REC-html40/types.html#type-cdata
59 59
      *
60
-     * @param array|string $val String to escape, or array of strings
60
+     * @param string $val String to escape, or array of strings
61 61
      *
62
-     * @return array|string
62
+     * @return string
63 63
      */
64 64
     public static function raw2htmlname($val)
65 65
     {
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
      * table, or column name. Supports encoding of multi identfiers separated by
201 201
      * a delimiter (e.g. ".")
202 202
      *
203
-     * @param string|array $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
203
+     * @param string $identifier The identifier to escape. E.g. 'SiteTree.Title' or list of identifiers
204 204
      * to be joined via the separator.
205 205
      * @param string $separator The string that delimits subsequent identifiers
206 206
      * @return string The escaped identifier. E.g. '"SiteTree"."Title"'
@@ -301,6 +301,7 @@  discard block
 block discarded – undo
301 301
      * call this function directly, Please use {@link Convert::xml2array()}
302 302
      *
303 303
      * @param SimpleXMLElement
304
+     * @param SimpleXMLElement $xml
304 305
      *
305 306
      * @return mixed
306 307
      */
@@ -514,7 +515,7 @@  discard block
 block discarded – undo
514 515
      * - IDField => idField
515 516
      * - iDField => iDField
516 517
      *
517
-     * @param $str
518
+     * @param string $str
518 519
      * @return string
519 520
      */
520 521
     public static function upperCamelToLowerCamel($str)
Please login to merge, or discard this patch.
src/Core/CustomMethods.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -152,7 +152,7 @@
 block discarded – undo
152 152
     /**
153 153
      * Get meta-data details on a named method
154 154
      *
155
-     * @param array $method
155
+     * @param string $method
156 156
      * @return array List of custom method details, if defined for this method
157 157
      */
158 158
     protected function getExtraMethodConfig($method)
Please login to merge, or discard this patch.
src/Core/Injector/Injector.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
      *
369 369
      * @param string $property
370 370
      *                the name of the property
371
-     * @param object $object
371
+     * @param string $object
372 372
      *                the object to be set
373 373
      * @return $this
374 374
      */
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
      *              The name of the service to update the definition for
464 464
      * @param string $property
465 465
      *              The name of the property to update.
466
-     * @param mixed $value
466
+     * @param string $value
467 467
      *              The value to set
468 468
      * @param boolean $append
469 469
      *              Whether to append (the default) when the property is an array
Please login to merge, or discard this patch.
src/Core/Manifest/ClassManifest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@
 block discarded – undo
259 259
      * Returns an array containing all the descendants (direct and indirect)
260 260
      * of a class.
261 261
      *
262
-     * @param  string|object $class
262
+     * @param  string $class
263 263
      * @return array
264 264
      */
265 265
     public function getDescendantsOf($class)
Please login to merge, or discard this patch.
src/Core/Startup/ErrorControlChain.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
     /**
107 107
      * Get value of display_errors ini value
108 108
      *
109
-     * @return mixed
109
+     * @return string
110 110
      */
111 111
     protected function getDisplayErrors()
112 112
     {
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
      * Add this callback to the chain of callbacks to call along with the state
118 118
      * that $error must be in this point in the chain for the callback to be called
119 119
      *
120
-     * @param $callback - The callback to call
120
+     * @param callable $callback - The callback to call
121 121
      * @param $onErrorState - false if only call if no errors yet, true if only call if already errors, null for either
122 122
      * @return $this
123 123
      */
Please login to merge, or discard this patch.