sminnee / silverstripe-framework

src/Core/Cache/ApcuCacheFactory.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\Core\Injector\Injector;
 use Symfony\Component\Cache\Simple\ApcuCache;
-use Memcached;
 
 class ApcuCacheFactory implements CacheFactory
 {

src/Core/Cache/CacheFactory.php

Doc Comments -2 removed lines

@@ -12,8 +12,6 @@
      * Note: While the returned object is used as a singleton (by the originating Injector->get() call),
      * this cache object shouldn't be a singleton itself - it has varying constructor args for the same service name.
      *
-     * @param string $class
-     * @param array $args
      * @return CacheInterface
      */
     public function create($service, array $params = array());

src/Forms/DatetimeField.php

Doc Comments +17 added lines, -1 removed lines

@@ -54,6 +54,10 @@ 
      */
     protected $dateTimeOrder = '{date} {time}';
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, $value = "")
     {
         $this->timeField = TimeField::create($name . '[time]', false);
@@ -61,6 +65,9 @@ 
         parent::__construct($name, $title, $value);
     }
 
+    /**
+     * @param Form $form
+     */
     public function setForm($form)
     {
         parent::setForm($form);
@@ -69,6 +76,9 @@ 
         return $this;
     }
 
+    /**
+     * @param string $name
+     */
     public function setName($name)
     {
         parent::setName($name);
@@ -152,7 +162,7 @@ 
     /**
      * Assign value from iso8601 string
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -260,6 +270,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);
@@ -345,6 +358,9 @@ 
         return $this->dateField->getLocale();
     }
 
+    /**
+     * @param RequiredFields $validator
+     */
     public function validate($validator)
     {
         $dateValid = $this->dateField->validate($validator);

src/Forms/FormField.php

Doc Comments +2 added lines, -2 removed lines

@@ -1222,7 +1222,7 @@ 
     /**
      * @param FormTransformation $transformation
      *
-     * @return mixed
+     * @return FormField
      */
     public function transform(FormTransformation $transformation)
     {
@@ -1333,7 +1333,7 @@ 
      * This function is used by the template processor. If you refer to a field as a $ variable, it
      * will return the $Field value.
      *
-     * @return string
+     * @return DBHTMLText
      */
     public function forTemplate()
     {

src/Forms/HTMLEditor/HTMLEditorField.php

Doc Comments +5 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
     /**
      * Assign a new configuration instance or identifier
      *
-     * @param string|HTMLEditorConfig $config
+     * @param string $config
      * @return $this
      */
     public function setEditorConfig($config)
@@ -94,7 +94,7 @@ 
      *
      * @param string $name The internal field name, passed to forms.
      * @param string $title The human-readable field label.
-     * @param mixed $value The value of the field.
+     * @param integer $value The value of the field.
      * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
      */
     public function __construct($name, $title = null, $value = '', $config = null)
@@ -142,6 +142,9 @@ 
         $record->{$this->name} = $htmlValue->getContent();
     }
 
+    /**
+     * @param string|null $value
+     */
     public function setValue($value, $data = null)
     {
         // Regenerate links prior to preview, so that the editor can see them.

src/Forms/MemberDatetimeOptionsetField.php

Doc Comments +3 added lines

@@ -156,6 +156,9 @@
         return parent::setSubmittedValue($value);
     }
 
+    /**
+     * @param string $value
+     */
     public function setValue($value, $data = null)
     {
         if (is_array($value)) {

src/Forms/MoneyField.php

Doc Comments +9 added lines, -2 removed lines

@@ -57,6 +57,10 @@ 
         return $this->fieldAmount;
     }
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, $value = "")
     {
         $this->setName($name);
@@ -210,7 +214,7 @@ 
      *
      * (see @link MoneyFieldTest_CustomSetter_Object for more information)
      *
-     * @param DataObjectInterface|Object $dataObject
+     * @param DataObjectInterface $dataObject
      */
     public function saveInto(DataObjectInterface $dataObject)
     {
@@ -236,6 +240,9 @@ 
         return $clone;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);
@@ -259,7 +266,7 @@ 
     /**
      * Set list of currencies. Currencies should be in the 3-letter ISO 4217 currency code.
      *
-     * @param array $currencies
+     * @param string[] $currencies
      * @return $this
      */
     public function setAllowedCurrencies($currencies)

src/Forms/NumericField.php

Doc Comments +1 added lines, -1 removed lines

@@ -287,7 +287,7 @@
      * Get number of digits to show to the right of the decimal point.
      * 0 for integer, any number for floating point, or null to flexible
      *
-     * @return int|null
+     * @return string
      */
     public function getScale()
     {

src/Forms/SelectionGroup_Item.php

Doc Comments +6 added lines

@@ -37,6 +37,9 @@ 
         return $this->title;
     }
 
+    /**
+     * @param string $title
+     */
     function setTitle($title)
     {
         $this->title = $title;
@@ -48,6 +51,9 @@ 
         return $this->value;
     }
 
+    /**
+     * @param string $Value
+     */
     function setValue($Value, $data = null)
     {
         $this->value = $Value;