sminnee / silverstripe-framework

tests/php/Forms/GridField/GridFieldTest/Component.php

Doc Comments +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
     /**
      * @skipUpgrade
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getColumnsHandled($gridField)
     {

tests/php/ORM/ManyManyListExtensionTest.php

Unused Use Statements -3 removed lines

@@ -2,11 +2,8 @@
 
 namespace SilverStripe\ORM\Tests;
 
-use SilverStripe\ORM\DataObject;
-use SilverStripe\ORM\DataExtension;
 use SilverStripe\Core\Object;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Dev\TestOnly;
 
 class ManyManyListExtensionTest extends SapphireTest
 {

admin/code/ModelAdmin.php

Doc Comments +2 added lines, -1 removed lines

@@ -162,6 +162,7 @@ 
      * currently viewing) is included in the URL.
      *
      * @inheritdoc
+     * @param string $action
      */
     public function Link($action = null)
     {
@@ -441,7 +442,7 @@ 
     /**
      * Generate a CSV import form for a single {@link DataObject} subclass.
      *
-     * @return Form|false
+     * @return Form
      */
     public function ImportForm()
     {

Unused Use Statements -3 removed lines

@@ -23,17 +23,14 @@
 use SilverStripe\Forms\GridField\GridFieldConfig_RecordEditor;
 use SilverStripe\Forms\GridField\GridFieldPrintButton;
 use SilverStripe\Forms\GridField\GridField;
-use SilverStripe\Forms\CompositeField;
 use SilverStripe\Forms\GridField\GridFieldImportButton;
 use SilverStripe\ORM\ArrayLib;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\Search\SearchContext;
-use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ValidationResult;
 use SilverStripe\Security\Member;
 use SilverStripe\View\ArrayData;
-use SilverStripe\View\SSViewer;
 
 /**
  * Generates a three-pane UI for editing model classes, with an

src/Assets/Flysystem/AssetAdapter.php

Doc Comments +3 added lines

@@ -42,6 +42,9 @@
         ]
     );
 
+    /**
+     * @param string $root
+     */
     public function __construct($root = null, $writeFlags = LOCK_EX, $linkHandling = self::DISALLOW_LINKS)
     {
         // Get root path, and ensure that this exists and is safe

src/Core/Core.php

Doc Comments +4 added lines, -7 removed lines

@@ -144,6 +144,9 @@ 
     return Injector::inst()->get($className);
 }
 
+/**
+ * @return string
+ */
 function project()
 {
     global $project;
@@ -160,12 +163,6 @@ 
      * @param string $entity Entity that identifies the string. It must be in the form
      * "Namespace.Entity" where Namespace will be usually the class name where this
      * string is used and Entity identifies the string inside the namespace.
-     * @param mixed $arg,... Additional arguments are parsed as such:
-     *  - Next string argument is a default. Pass in a `|` pipe-delimeted value with `{count}`
-     *    to do pluralisation.
-     *  - Any other string argument after default is context for i18nTextCollector
-     *  - Any array argument in any order is an injection parameter list. Pass in a `count`
-     *    injection parameter to pluralise.
      * @return string
      */
 function _t($entity, $arg = null)
@@ -179,7 +176,7 @@ 
  * Only increases up to the maximum defined in {@link set_increase_memory_limit_max()},
  * and defaults to the 'memory_limit' setting in the PHP configuration.
  *
- * @param string|int $memoryLimit A memory limit string, such as "64M".  If omitted, unlimited memory will be set.
+ * @param integer $memoryLimit A memory limit string, such as "64M".  If omitted, unlimited memory will be set.
  * @return Boolean TRUE indicates a successful change, FALSE a denied change.
  */
 function increase_memory_limit_to($memoryLimit = -1)

src/Dev/Deprecation.php

Doc Comments +2 added lines, -2 removed lines

@@ -75,7 +75,7 @@ 
      * greater than or equal to this version, a message will be raised
      *
      * @static
-     * @param $ver string -
+     * @param string $ver string -
      *     A php standard version string, see http://php.net/manual/en/function.version-compare.php for details.
      * @param null $forModule string -
      *    The name of a module. The passed version will be used as the check value for
@@ -141,7 +141,7 @@ 
     /**
      * Determine if deprecation notices should be displayed
      *
-     * @return bool
+     * @return boolean|string
      */
     public static function get_enabled()
     {

src/Forms/GridField/GridFieldAddExistingAutocompleter.php

Doc Comments +3 added lines, -3 removed lines

@@ -155,7 +155,7 @@ 
     /**
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {
@@ -219,7 +219,7 @@ 
      *
      * @param GridField $gridField
      * @param HTTPRequest $request
-     * @return string
+     * @return HTTPResponse
      */
     public function doSearch($gridField, $request)
     {
@@ -299,7 +299,7 @@ 
     }
 
     /**
-     * @param array $fields
+     * @param string[] $fields
      * @return $this
      */
     public function setSearchFields($fields)

src/i18n/Messages/Symfony/ModuleYamlLoader.php

Unused Use Statements -3 removed lines

@@ -2,12 +2,9 @@
 
 namespace SilverStripe\i18n\Messages\Symfony;
 
-use SilverStripe\Core\Config\Configurable;
-use SilverStripe\Dev\Debug;
 use SilverStripe\i18n\i18n;
 use SilverStripe\i18n\Messages\Reader;
 use Symfony\Component\Translation\Loader\ArrayLoader;
-use Symfony\Component\Translation\PluralizationRules;
 
 /**
  * Loads yaml localisations across all modules simultaneously.

src/ORM/ListDecorator.php

Doc Comments +1 added lines

@@ -41,6 +41,7 @@
      * Useful for keeping a decorator/paginated list configuration intact while modifying
      * the underlying list.
      *
+     * @param SS_List $list
      * @return SS_List
      */
     public function setList($list)