sminnee / silverstripe-framework

src/Forms/ConfirmedPasswordField.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DataObjectInterface;
 use SilverStripe\Security\Member;
-use SilverStripe\View\Requirements;
 
 /**
  * Two masked input fields, checks for matching passwords.

src/Forms/FieldList.php

Doc Comments +6 added lines, -2 removed lines

@@ -89,6 +89,9 @@ 
         $this->sequentialSaveableSet = null;
     }
 
+    /**
+     * @param FormField[] $list
+     */
     protected function collateDataFields(&$list, $saveableOnly = false)
     {
         if (!isset($list)) {
@@ -198,7 +201,7 @@ 
      * Removes a number of fields from a Tab/TabSet within this FieldList.
      *
      * @param string $tabName The name of the Tab or TabSet field
-     * @param array $fields A list of fields, e.g. array('Name', 'Email')
+     * @param string[] $fields A list of fields, e.g. array('Name', 'Email')
      */
     public function removeFieldsFromTab($tabName, $fields)
     {
@@ -625,7 +628,7 @@ 
     }
 
     /**
-     * @param $field
+     * @param CompositeField $field
      * @return $this
      */
     public function setContainerField($field)
@@ -707,6 +710,7 @@ 
      * the children collection. Doesn't work recursively.
      *
      * @param string|FormField
+     * @param string $field
      * @return int Position in children collection (first position starts with 0).
      * Returns FALSE if the field can't be found.
      */

src/Forms/GridField/GridFieldPrintButton.php

Doc Comments +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
      *
      * @param GridField
      *
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {

src/Forms/HiddenField.php

Doc Comments +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function FieldHolder($properties = array())
     {

src/Forms/TabSet.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\Core\Convert;
 use SilverStripe\ORM\FieldType\DBHTMLText;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

src/Forms/TreeMultiselectField.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DataObjectInterface;
 use SilverStripe\ORM\FieldType\DBHTMLText;
-use SilverStripe\View\Requirements;
 use SilverStripe\View\ViewableData;
 use stdClass;
 

src/ORM/DataObjectSchema.php

Doc Comments +1 added lines, -1 removed lines

@@ -701,7 +701,7 @@
      * @param string $parentClass Parent class name
      * @param string $component ManyMany name
      * @param string|array $specification Declaration of many_many relation type
-     * @return array
+     * @return string[]
      */
     protected function parseManyManyComponent($parentClass, $component, $specification)
     {

src/ORM/ValidationResult.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use InvalidArgumentException;
 use Serializable;
-use SilverStripe\Core\Convert;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\Dev\Deprecation;
 

src/Security/CMSSecurity.php

Doc Comments +6 added lines

@@ -41,6 +41,9 @@ 
         Requirements::javascript(FRAMEWORK_ADMIN_DIR . '/client/dist/js/vendor.js');
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         /** @skipUpgrade */
@@ -60,6 +63,9 @@ 
         return null;
     }
 
+    /**
+     * @param string $title
+     */
     public function getResponseController($title)
     {
         // Use $this to prevent use of Page to render underlying templates