sminnee / silverstripe-framework

src/View/Parsers/URLSegmentFilter.php

Doc Comments +1 added lines

@@ -139,6 +139,7 @@
 
     /**
      * @param boolean
+     * @param boolean $bool
      */
     public function setAllowMultibyte($bool)
     {

src/View/Requirements.php

Doc Comments +1 added lines

@@ -74,6 +74,7 @@
      * while automatically busting this cache every time the file is changed.
      *
      * @param bool
+     * @param boolean $var
      */
     public static function set_suffix_requirements($var)
     {

src/View/Requirements_Backend.php

Doc Comments +1 added lines

@@ -321,6 +321,7 @@
      * Forces the JavaScript requirements to the end of the body, right before the closing tag
      *
      * @param bool
+     * @param boolean $var
      * @return $this
      */
     public function setForceJSToBottom($var)

src/View/SSTemplateParser.php

Doc Comments +7 added lines, -3 removed lines

@@ -95,6 +95,8 @@ 
 
     /**
      * Override the function that constructs the result arrays to also prepare a 'php' item in the array
+     * @param string $matchrule
+     * @param string $name
      */
     function construct($matchrule, $name, $arguments = null)
     {
@@ -163,9 +165,9 @@ 
 
     /**
      * Ensures that the arguments to addOpenBlock and addClosedBlock are valid
-     * @param $name
-     * @param $callable
-     * @param $type
+     * @param string $name
+     * @param callable $callable
+     * @param string $type
      * @throws InvalidArgumentException
      */
     protected function validateExtensionBlock($name, $callable, $type)
@@ -924,6 +926,7 @@ 
      * The basic generated PHP of LookupStep and LastLookupStep is the same, except that LookupStep calls 'obj' to
      * get the next ViewableData in the sequence, and LastLookupStep calls different methods (XML_val, hasValue, obj)
      * depending on the context the lookup is used in.
+     * @param string $method
      */
     function Lookup_AddLookupStep(&$res, $sub, $method)
     {
@@ -6477,6 +6480,7 @@ 
 
     /**
      * @param string $code
+     * @param string $templateName
      * @return string $code
      */
     protected function includeDebuggingComments($code, $templateName)

src/View/SSViewer.php

Doc Comments +4 added lines, -1 removed lines

@@ -648,7 +648,7 @@ 
      * @param mixed $data Data context
      * @param array $arguments Additional arguments
      * @param Object $scope
-     * @return string Evaluated result
+     * @return DBHTMLText Evaluated result
      */
     public static function execute_template($template, $data, $arguments = null, $scope = null)
     {
@@ -676,6 +676,9 @@ 
         return $v->process($data, $arguments);
     }
 
+    /**
+     * @param string $content
+     */
     public function parseTemplateContent($content, $template = "")
     {
         return $this->getParser()->compileString(

src/View/SSViewer_FromString.php

Doc Comments +3 added lines

@@ -30,6 +30,9 @@
      */
     protected $cacheTemplate;
 
+    /**
+     * @param string $content
+     */
     public function __construct($content, TemplateParser $parser = null)
     {
         if ($parser) {

tests/php/Security/SecurityTest.php

Unused Use Statements -2 removed lines

@@ -11,11 +11,9 @@
 use SilverStripe\Security\Member;
 use SilverStripe\Security\MemberAuthenticator;
 use SilverStripe\Security\Security;
-use SilverStripe\Security\Permission;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
 use SilverStripe\Dev\FunctionalTest;
-use SilverStripe\Dev\TestOnly;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Control\Session;
 use SilverStripe\Control\Director;

Doc Comments +4 added lines

@@ -676,6 +676,8 @@ 
     /**
      * Execute a log-in form using Director::test().
      * Helper method for the tests above
+     * @param string $email
+     * @param string $password
      */
     public function doTestLoginForm($email, $password, $backURL = 'test/link')
     {
@@ -697,6 +699,8 @@ 
 
     /**
      * Helper method to execute a change password form
+     * @param string $oldPassword
+     * @param string $newPassword
      */
     public function doTestChangepasswordForm($oldPassword, $newPassword)
     {

admin/code/CMSMenu.php

Doc Comments +3 added lines, -3 removed lines

@@ -117,7 +117,7 @@ 
      * @param array $attributes an array of attributes to include on the link.
      * @param string $iconClass
      *
-     * @return boolean The result of the operation.
+     * @return boolean|null The result of the operation.
      */
     public static function add_link($code, $menuTitle, $url, $priority = -1, $attributes = null, $iconClass = null)
     {
@@ -140,7 +140,7 @@ 
      * @param array $attributes an array of attributes to include on the link.
      * @param string $iconClass
      *
-     * @return bool Success
+     * @return boolean|null Success
      */
     public static function add_menu_item(
         $code,
@@ -322,7 +322,7 @@ 
      * @param array $attributes an array of attributes to include on the link.
      * @param string $iconClass
      *
-     * @return bool Success
+     * @return boolean|null Success
      */
     public static function replace_menu_item(
         $code,

admin/code/GroupImportForm.php

Doc Comments +4 added lines

@@ -24,6 +24,10 @@
      */
     protected $group;
 
+    /**
+     * @param SecurityAdmin $controller
+     * @param string $name
+     */
     public function __construct($controller, $name, $fields = null, $actions = null, $validator = null)
     {
         if (!$fields) {