Completed
Push — mssql-community-support ( 94e0ba...da2db2 )
by Sam
15:37 queued 10:00
created
src/ORM/Connect/MySQLSchemaManager.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -129,6 +129,9 @@
 block discarded – undo
129 129
         $this->query("ALTER TABLE \"$tableName\" $alterations");
130 130
     }
131 131
 
132
+    /**
133
+     * @param string $tableName
134
+     */
132 135
     public function isView($tableName)
133 136
     {
134 137
         $info = $this->query("SHOW /*!50002 FULL*/ TABLES LIKE '$tableName'")->record();
Please login to merge, or discard this patch.
src/ORM/DatabaseAdmin.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
     /**
144 144
      * Gets the url to return to after build
145 145
      *
146
-     * @return string|null
146
+     * @return string
147 147
      */
148 148
     protected function getReturnURL()
149 149
     {
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
     /**
176 176
      * Returns the timestamp of the time that the database was last built
177 177
      *
178
-     * @return string Returns the timestamp of the time that the database was
178
+     * @return integer|null Returns the timestamp of the time that the database was
179 179
      *                last built
180 180
      */
181 181
     public static function lastBuilt()
Please login to merge, or discard this patch.
src/ORM/DataObject.php 1 patch
Doc Comments   +7 added lines, -6 removed lines patch added patch discarded remove patch
@@ -2469,6 +2469,7 @@  discard block
 block discarded – undo
2469 2469
 
2470 2470
     /**
2471 2471
      * {@inheritdoc}
2472
+     * @param string $field
2472 2473
      */
2473 2474
     public function castingHelper($field)
2474 2475
     {
@@ -2637,7 +2638,7 @@  discard block
 block discarded – undo
2637 2638
 
2638 2639
     /**
2639 2640
      * @param Member $member
2640
-     * @return boolean
2641
+     * @return boolean|string
2641 2642
      */
2642 2643
     public function canView($member = null)
2643 2644
     {
@@ -2650,7 +2651,7 @@  discard block
 block discarded – undo
2650 2651
 
2651 2652
     /**
2652 2653
      * @param Member $member
2653
-     * @return boolean
2654
+     * @return boolean|string
2654 2655
      */
2655 2656
     public function canEdit($member = null)
2656 2657
     {
@@ -2663,7 +2664,7 @@  discard block
 block discarded – undo
2663 2664
 
2664 2665
     /**
2665 2666
      * @param Member $member
2666
-     * @return boolean
2667
+     * @return boolean|string
2667 2668
      */
2668 2669
     public function canDelete($member = null)
2669 2670
     {
@@ -2678,7 +2679,7 @@  discard block
 block discarded – undo
2678 2679
      * @param Member $member
2679 2680
      * @param array $context Additional context-specific data which might
2680 2681
      * affect whether (or where) this object could be created.
2681
-     * @return boolean
2682
+     * @return boolean|string
2682 2683
      */
2683 2684
     public function canCreate($member = null, $context = array())
2684 2685
     {
@@ -2788,7 +2789,7 @@  discard block
 block discarded – undo
2788 2789
      * Traverses to a field referenced by relationships between data objects, returning the value
2789 2790
      * The path to the related field is specified with dot separated syntax (eg: Parent.Child.Child.FieldName)
2790 2791
      *
2791
-     * @param $fieldName string
2792
+     * @param string $fieldName string
2792 2793
      * @return string | null - will return null on a missing value
2793 2794
      */
2794 2795
     public function relField($fieldName)
@@ -2866,7 +2867,7 @@  discard block
 block discarded – undo
2866 2867
      * @param string $callerClass The class of objects to be returned
2867 2868
      * @param string|array $filter A filter to be inserted into the WHERE clause.
2868 2869
      * Supports parameterised queries. See SQLSelect::addWhere() for syntax examples.
2869
-     * @param string|array $sort A sort expression to be inserted into the ORDER
2870
+     * @param string $sort A sort expression to be inserted into the ORDER
2870 2871
      * BY clause.  If omitted, self::$default_sort will be used.
2871 2872
      * @param string $join Deprecated 3.0 Join clause. Use leftJoin($table, $joinClause) instead.
2872 2873
      * @param string|array $limit A limit expression to be inserted into the LIMIT clause.
Please login to merge, or discard this patch.
src/ORM/DataQuery.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     /**
111 111
      * Remove a filter from the query
112 112
      *
113
-     * @param string|array $fieldExpression The predicate of the condition to remove
113
+     * @param string|null $fieldExpression The predicate of the condition to remove
114 114
      * (ignoring parameters). The expression will be considered a match if it's
115 115
      * contained within any other predicate.
116 116
      * @return DataQuery Self reference
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
     /**
192 192
      * Ensure that the query is ready to execute.
193 193
      *
194
-     * @param array|null $queriedColumns Any columns to filter the query by
194
+     * @param string[] $queriedColumns Any columns to filter the query by
195 195
      * @return SQLSelect The finalised sql query
196 196
      */
197 197
     public function getFinalisedQuery($queriedColumns = null)
Please login to merge, or discard this patch.
src/ORM/FieldType/DBClassName.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -171,6 +171,9 @@
 block discarded – undo
171 171
         return $classNames;
172 172
     }
173 173
 
174
+    /**
175
+     * @param \SilverStripe\ORM\Tests\DBClassNameTest\ObjectSubClass $record
176
+     */
174 177
     public function setValue($value, $record = null, $markChanged = true)
175 178
     {
176 179
         parent::setValue($value, $record, $markChanged);
Please login to merge, or discard this patch.
src/ORM/FieldType/DBComposite.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -220,6 +220,9 @@
 block discarded – undo
220 220
         return null;
221 221
     }
222 222
 
223
+    /**
224
+     * @param string $field
225
+     */
223 226
     public function hasField($field)
224 227
     {
225 228
         $fields = $this->compositeDatabaseFields();
Please login to merge, or discard this patch.
src/ORM/FieldType/DBCurrency.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -24,6 +24,9 @@  discard block
 block discarded – undo
24 24
      */
25 25
     private static $currency_symbol = '$';
26 26
 
27
+    /**
28
+     * @param string $name
29
+     */
27 30
     public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0)
28 31
     {
29 32
         parent::__construct($name, $wholeSize, $decimalSize, $defaultValue);
@@ -56,6 +59,9 @@  discard block
 block discarded – undo
56 59
         }
57 60
     }
58 61
 
62
+    /**
63
+     * @param string $value
64
+     */
59 65
     public function setValue($value, $record = null, $markChanged = true)
60 66
     {
61 67
         $matches = null;
Please login to merge, or discard this patch.
src/ORM/FieldType/DBDecimal.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
      * @param string $name
20 20
      * @param int $wholeSize
21 21
      * @param int $decimalSize
22
-     * @param float|int $defaultValue
22
+     * @param integer $defaultValue
23 23
      */
24 24
     public function __construct($name = null, $wholeSize = 9, $decimalSize = 2, $defaultValue = 0)
25 25
     {
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     }
34 34
 
35 35
     /**
36
-     * @return float
36
+     * @return string
37 37
      */
38 38
     public function Nice()
39 39
     {
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
     }
42 42
 
43 43
     /**
44
-     * @return int
44
+     * @return double
45 45
      */
46 46
     public function Int()
47 47
     {
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     }
89 89
 
90 90
     /**
91
-     * @return float
91
+     * @return integer
92 92
      */
93 93
     public function nullValue()
94 94
     {
Please login to merge, or discard this patch.
src/ORM/FieldType/DBField.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -529,7 +529,7 @@
 block discarded – undo
529 529
     }
530 530
 
531 531
     /**
532
-     * @param array $value
532
+     * @param string $value
533 533
      * @return $this
534 534
      */
535 535
     public function setArrayValue($value)
Please login to merge, or discard this patch.