sminnee / silverstripe-framework

src/Forms/HTMLEditor/HTMLEditorField.php

Doc Comments +5 added lines, -2 removed lines

@@ -73,7 +73,7 @@ 
     /**
      * Assign a new configuration instance or identifier
      *
-     * @param string|HTMLEditorConfig $config
+     * @param string $config
      * @return $this
      */
     public function setEditorConfig($config)
@@ -88,7 +88,7 @@ 
      *
      * @param string $name The internal field name, passed to forms.
      * @param string $title The human-readable field label.
-     * @param mixed $value The value of the field.
+     * @param integer $value The value of the field.
      * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
      */
     public function __construct($name, $title = null, $value = '', $config = null)
@@ -136,6 +136,9 @@ 
         $record->{$this->name} = $htmlValue->getContent();
     }
 
+    /**
+     * @param string|null $value
+     */
     public function setValue($value)
     {
         // Regenerate links prior to preview, so that the editor can see them.

src/Forms/HTMLEditor/HTMLEditorField_Embed.php

Doc Comments +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
     }
 
     /**
-     * @return AdapterInterface
+     * @return Embed
      */
     public function getEmbed()
     {

src/Forms/HTMLEditor/HTMLEditorField_Toolbar.php

Doc Comments +5 added lines, -1 removed lines

@@ -67,6 +67,10 @@ 
      */
     protected $name;
 
+    /**
+     * @param Controller|null $controller
+     * @param string $name
+     */
     public function __construct($controller, $name)
     {
         parent::__construct();
@@ -508,7 +512,7 @@ 
     /**
      * Find all anchors available on the given page.
      *
-     * @return array
+     * @return string
      * @throws HTTPResponse_Exception
      */
     public function getanchors()

src/Forms/MoneyField.php

Doc Comments +11 added lines, -1 removed lines

@@ -61,6 +61,10 @@ 
         return $this->fieldAmount;
     }
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, $value = "")
     {
         $this->setName($name);
@@ -136,7 +140,7 @@ 
      *
      * (see @link MoneyFieldTest_CustomSetter_Object for more information)
      *
-     * @param DataObjectInterface|Object $dataObject
+     * @param DataObjectInterface $dataObject
      */
     public function saveInto(DataObjectInterface $dataObject)
     {
@@ -167,6 +171,9 @@ 
         return $clone;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);
@@ -211,6 +218,9 @@ 
         return $this->allowedCurrencies;
     }
 
+    /**
+     * @param string $locale
+     */
     public function setLocale($locale)
     {
         $this->_locale = $locale;

src/Forms/NullableField.php

Doc Comments +2 added lines, -2 removed lines

@@ -82,7 +82,7 @@ 
     /**
      * Set the label used for the Is Null checkbox.
      *
-     * @param $isNulLabel string
+     * @param string $isNulLabel string
      *
      * @return $this
      */
@@ -129,7 +129,7 @@ 
     /**
      * Value is sometimes an array, and sometimes a single value, so we need to handle both cases
      *
-     * @param mixed $value
+     * @param string|null $value
      * @param null|array $data
      *
      * @return $this

src/Forms/PrintableTransformation_TabSet.php

Doc Comments +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 class PrintableTransformation_TabSet extends TabSet
 {
     /**
-     * @param array $tabs
+     * @param FieldList $tabs
      */
     public function __construct($tabs)
     {

src/Forms/ReadonlyField.php

Doc Comments +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
      * If $dontEscape is false the returned value will be safely encoded,
      * but should not be escaped by the frontend.
      *
-     * @return mixed|string
+     * @return string
      */
     public function Value()
     {

src/Forms/TimeField.php

Doc Comments +8 added lines, -1 removed lines

@@ -57,6 +57,10 @@ 
 
     protected $schemaDataType = FormField::SCHEMA_DATA_TYPE_TIME;
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, $value = "")
     {
         if (!$this->locale) {
@@ -231,7 +235,7 @@ 
 
     /**
      * @param String $name Optional, returns the whole configuration array if empty
-     * @return mixed|array
+     * @return string
      */
     public function getConfig($name = null)
     {
@@ -250,6 +254,9 @@ 
         return $this->castedCopy('SilverStripe\\Forms\\TimeField_Readonly');
     }
 
+    /**
+     * @param string $class
+     */
     public function castedCopy($class)
     {
         $copy = parent::castedCopy($class);

src/Forms/UploadField.php

Doc Comments +4 added lines, -4 removed lines

@@ -304,7 +304,7 @@ 
     /**
      * Determine if the target folder for new uploads in is visible the field UI.
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canPreviewFolder()
     {
@@ -581,7 +581,7 @@ 
      * Customises a file with additional details suitable for rendering in the
      * UploadField.ss template
      *
-     * @param ViewableData|AssetContainer $file
+     * @param AssetContainer $file
      * @return ViewableData_Customised
      */
     protected function customiseFile(AssetContainer $file)
@@ -690,7 +690,7 @@ 
     /**
      * Determine if the user has permission to upload.
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canUpload()
     {
@@ -718,7 +718,7 @@ 
      * Determine if the user has permission to attach existing files
      * By default returns true if the user has the CMS_ACCESS_AssetAdmin permission
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canAttachExisting()
     {

Unused Use Statements -2 removed lines

@@ -13,13 +13,11 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\ArrayList;
-use SilverStripe\ORM\ValidationException;
 use SilverStripe\Security\Permission;
 use SilverStripe\View\ArrayData;
 use SilverStripe\View\ViewableData;
 use SilverStripe\View\ViewableData_Customised;
 use InvalidArgumentException;
-use Exception;
 
 /**
  * Field for uploading single or multiple files of all types, including images.