sminnee / silverstripe-framework

src/Control/Director.php

Doc Comments +2 added lines, -2 removed lines

@@ -925,7 +925,7 @@ 
     /**
      * Returns true if the given file exists. Filename should be relative to the site root.
      *
-     * @param $file
+     * @param string $file
      *
      * @return bool
      */
@@ -1153,7 +1153,7 @@ 
      * Can also be checked with {@link Director::isDev()}, {@link Director::isTest()}, and
      * {@link Director::isLive()}.
      *
-     * @return bool
+     * @return string
      */
     public static function get_environment_type()
     {

src/Core/Manifest/Module.php

Doc Comments +4 added lines

@@ -28,6 +28,10 @@
      */
     protected $composerData = null;
 
+    /**
+     * @param string $path
+     * @param string $base
+     */
     public function __construct($path, $base)
     {
         $this->path = rtrim($path, '/\\');

src/Dev/FunctionalTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -226,7 +226,7 @@ 
      * Find an attribute in a SimpleXMLElement object by name.
      * @param SimpleXMLElement $object
      * @param string $attribute Name of attribute to find
-     * @return SimpleXMLElement object of the attribute
+     * @return boolean object of the attribute
      */
     public function findAttribute($object, $attribute)
     {
@@ -260,7 +260,7 @@ 
      * Note:   characters are stripped from the content; make sure that your assertions take this into account.
      *
      * @param string $selector A basic CSS selector, e.g. 'li.jobs h3'
-     * @param array|string $expectedMatches The content of at least one of the matched tags
+     * @param string[] $expectedMatches The content of at least one of the matched tags
      * @param string $message
      * @throws PHPUnit_Framework_AssertionFailedError
      */

Unused Use Statements -4 removed lines

@@ -2,14 +2,10 @@
 
 namespace SilverStripe\Dev;
 
-use SilverStripe\Control\Controller;
 use SilverStripe\Control\Session;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Core\Config\Config;
-use SilverStripe\ORM\DataObject;
 use SilverStripe\Security\BasicAuth;
-use SilverStripe\Security\Member;
-use SilverStripe\Security\Security;
 use SilverStripe\Security\SecurityToken;
 use SilverStripe\View\SSViewer;
 use PHPUnit_Framework_AssertionFailedError;

src/Forms/FormRequestHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -388,7 +388,7 @@
     /**
      * Fields can have action to, let's check if anyone of the responds to $funcname them
      *
-     * @param SS_List|array $fields
+     * @param FieldList $fields
      * @param callable $funcName
      * @return FormField
      */

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use BadMethodCallException;
 use SilverStripe\Control\Controller;
-use SilverStripe\Control\Director;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Control\HTTPResponse_Exception;

src/Security/PasswordEncryptor_Blowfish.php

Doc Comments +5 added lines

@@ -165,6 +165,11 @@
         return sprintf('%02d', self::$cost) . '$' . substr($generator->randomToken('sha1'), 0, 22);
     }
 
+    /**
+     * @param string|false $hash
+     * @param string $password
+     * @param string $salt
+     */
     public function check($hash, $password, $salt = null, $member = null)
     {
         if (strpos($hash, '$2y$') === 0) {

tests/php/Forms/FormScaffolderTest.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\Forms\HTMLEditor\HTMLEditorField;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Control\Controller;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;
 use SilverStripe\Forms\Tests\FormScaffolderTest\Article;

tests/php/Forms/GridField/GridFieldPaginatorTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\Forms\Tests\GridField;
 
-use SilverStripe\Control\Controller;
 use SilverStripe\Dev\CSSContentParser;
 use SilverStripe\Dev\FunctionalTest;
 use SilverStripe\Forms\FieldList;

tests/php/ORM/DataExtensionTest.php

Unused Use Statements -3 removed lines

@@ -2,9 +2,6 @@
 
 namespace SilverStripe\ORM\Tests;
 
-use SilverStripe\Assets\Tests\FileMigrationHelperTest\Extension;
-use SilverStripe\Core\Config\Middleware\ExtensionMiddleware;
-use SilverStripe\Dev\Debug;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\SapphireTest;

src/Core/Cache/DefaultCacheFactory.php

Doc Comments +2 added lines, -2 removed lines

@@ -78,7 +78,7 @@ 
     /**
      * Determine if apcu is supported
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function isAPCUSupported()
     {
@@ -92,7 +92,7 @@ 
     /**
      * Determine if PHP files is supported
      *
-     * @return bool
+     * @return boolean|null
      */
     protected function isPHPFilesSupported()
     {