Completed
Push — fix-1666 ( 09164e )
by Sam
15:14 queued 07:38
created
src/Forms/TreeMultiselectField.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,6 @@
 block discarded – undo
8 8
 use SilverStripe\ORM\DataObject;
9 9
 use SilverStripe\ORM\DataObjectInterface;
10 10
 use SilverStripe\ORM\FieldType\DBHTMLText;
11
-use SilverStripe\View\Requirements;
12 11
 use SilverStripe\View\ViewableData;
13 12
 use stdClass;
14 13
 
Please login to merge, or discard this patch.
src/ORM/DataObjectSchema.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -701,7 +701,7 @@
 block discarded – undo
701 701
      * @param string $parentClass Parent class name
702 702
      * @param string $component ManyMany name
703 703
      * @param string|array $specification Declaration of many_many relation type
704
-     * @return array
704
+     * @return string[]
705 705
      */
706 706
     protected function parseManyManyComponent($parentClass, $component, $specification)
707 707
     {
Please login to merge, or discard this patch.
src/ORM/ValidationResult.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use InvalidArgumentException;
6 6
 use Serializable;
7
-use SilverStripe\Core\Convert;
8 7
 use SilverStripe\Core\Injector\Injectable;
9 8
 use SilverStripe\Dev\Deprecation;
10 9
 
Please login to merge, or discard this patch.
src/Security/CMSSecurity.php 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -41,6 +41,9 @@  discard block
 block discarded – undo
41 41
         Requirements::javascript(FRAMEWORK_ADMIN_DIR . '/client/dist/js/vendor.js');
42 42
     }
43 43
 
44
+    /**
45
+     * @param string $action
46
+     */
44 47
     public function Link($action = null)
45 48
     {
46 49
         /** @skipUpgrade */
@@ -60,6 +63,9 @@  discard block
 block discarded – undo
60 63
         return null;
61 64
     }
62 65
 
66
+    /**
67
+     * @param string $title
68
+     */
63 69
     public function getResponseController($title)
64 70
     {
65 71
         // Use $this to prevent use of Page to render underlying templates
Please login to merge, or discard this patch.
tests/php/Forms/CurrencyFieldTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace SilverStripe\Forms\Tests;
4 4
 
5
-use SilverStripe\Core\Config\Config;
6 5
 use SilverStripe\Dev\SapphireTest;
7 6
 use SilverStripe\Forms\CurrencyField;
8 7
 use SilverStripe\Forms\RequiredFields;
Please login to merge, or discard this patch.
tests/php/Forms/GridField/GridFieldTest/Component.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
     /**
40 40
      * @skipUpgrade
41 41
      * @param GridField $gridField
42
-     * @return array
42
+     * @return string[]
43 43
      */
44 44
     public function getColumnsHandled($gridField)
45 45
     {
Please login to merge, or discard this patch.
tests/php/ORM/ManyManyListExtensionTest.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,11 +2,8 @@
 block discarded – undo
2 2
 
3 3
 namespace SilverStripe\ORM\Tests;
4 4
 
5
-use SilverStripe\ORM\DataObject;
6
-use SilverStripe\ORM\DataExtension;
7 5
 use SilverStripe\Core\Object;
8 6
 use SilverStripe\Dev\SapphireTest;
9
-use SilverStripe\Dev\TestOnly;
10 7
 
11 8
 class ManyManyListExtensionTest extends SapphireTest
12 9
 {
Please login to merge, or discard this patch.
src/Core/Core.php 1 patch
Doc Comments   +4 added lines, -7 removed lines patch added patch discarded remove patch
@@ -144,6 +144,9 @@  discard block
 block discarded – undo
144 144
     return Injector::inst()->get($className);
145 145
 }
146 146
 
147
+/**
148
+ * @return string
149
+ */
147 150
 function project()
148 151
 {
149 152
     global $project;
@@ -160,12 +163,6 @@  discard block
 block discarded – undo
160 163
      * @param string $entity Entity that identifies the string. It must be in the form
161 164
      * "Namespace.Entity" where Namespace will be usually the class name where this
162 165
      * string is used and Entity identifies the string inside the namespace.
163
-     * @param mixed $arg,... Additional arguments are parsed as such:
164
-     *  - Next string argument is a default. Pass in a `|` pipe-delimeted value with `{count}`
165
-     *    to do pluralisation.
166
-     *  - Any other string argument after default is context for i18nTextCollector
167
-     *  - Any array argument in any order is an injection parameter list. Pass in a `count`
168
-     *    injection parameter to pluralise.
169 166
      * @return string
170 167
      */
171 168
 function _t($entity, $arg = null)
@@ -179,7 +176,7 @@  discard block
 block discarded – undo
179 176
  * Only increases up to the maximum defined in {@link set_increase_memory_limit_max()},
180 177
  * and defaults to the 'memory_limit' setting in the PHP configuration.
181 178
  *
182
- * @param string|int $memoryLimit A memory limit string, such as "64M".  If omitted, unlimited memory will be set.
179
+ * @param integer $memoryLimit A memory limit string, such as "64M".  If omitted, unlimited memory will be set.
183 180
  * @return Boolean TRUE indicates a successful change, FALSE a denied change.
184 181
  */
185 182
 function increase_memory_limit_to($memoryLimit = -1)
Please login to merge, or discard this patch.
src/Dev/Deprecation.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
      * greater than or equal to this version, a message will be raised
76 76
      *
77 77
      * @static
78
-     * @param $ver string -
78
+     * @param string $ver string -
79 79
      *     A php standard version string, see http://php.net/manual/en/function.version-compare.php for details.
80 80
      * @param null $forModule string -
81 81
      *    The name of a module. The passed version will be used as the check value for
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
     /**
142 142
      * Determine if deprecation notices should be displayed
143 143
      *
144
-     * @return bool
144
+     * @return boolean|string
145 145
      */
146 146
     public static function get_enabled()
147 147
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace SilverStripe\Dev;
4 4
 
5 5
 use SilverStripe\Control\Director;
6
-use SilverStripe\Core\Manifest\ClassLoader;
7 6
 use SilverStripe\Core\Manifest\Module;
8 7
 use SilverStripe\Core\Manifest\ModuleLoader;
9 8
 
Please login to merge, or discard this patch.