sminnee / silverstripe-framework

src/Forms/TreeDropdownField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {

src/Forms/TreeMultiselectField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

src/Forms/UploadField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

Doc Comments +4 added lines, -4 removed lines

@@ -304,7 +304,7 @@ 
     /**
      * Determine if the target folder for new uploads in is visible the field UI.
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canPreviewFolder()
     {
@@ -581,7 +581,7 @@ 
      * Customises a file with additional details suitable for rendering in the
      * UploadField.ss template
      *
-     * @param ViewableData|AssetContainer $file
+     * @param AssetContainer $file
      * @return ViewableData_Customised
      */
     protected function customiseFile(AssetContainer $file)
@@ -690,7 +690,7 @@ 
     /**
      * Determine if the user has permission to upload.
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canUpload()
     {
@@ -718,7 +718,7 @@ 
      * Determine if the user has permission to attach existing files
      * By default returns true if the user has the CMS_ACCESS_AssetAdmin permission
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canAttachExisting()
     {

src/ORM/FieldType/DBText.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Convert;
-use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Forms\TextareaField;
 use SilverStripe\Forms\NullableField;
 use SilverStripe\Forms\TextField;

src/ORM/Filters/PartialMatchFilter.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\ORM\DataQuery;
 use SilverStripe\ORM\DB;
-use InvalidArgumentException;
 
 /**
  * Matches textual content with a LIKE '%keyword%' construct.

src/ORM/Queries/SQLSelect.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace SilverStripe\ORM\Queries;
 
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\ORM\DB;
 use InvalidArgumentException;
 

Doc Comments +2 added lines, -4 removed lines

@@ -66,7 +66,7 @@ 
     /**
      * Construct a new SQLSelect.
      *
-     * @param array|string $select An array of SELECT fields.
+     * @param string $select An array of SELECT fields.
      * @param array|string $from An array of FROM clauses. The first one should be just the table name.
      * Each should be ANSI quoted.
      * @param array $where An array of WHERE clauses.
@@ -378,7 +378,7 @@ 
      *
      * @param string $value
      * @param string $defaultDirection
-     * @return array A two element array: array($column, $direction)
+     * @return string[] A two element array: array($column, $direction)
      */
     private function getDirectionFromString($value, $defaultDirection = null)
     {
@@ -480,7 +480,6 @@ 
      * @see SQLSelect::addWhere() for syntax examples
      *
      * @param mixed $having Predicate(s) to set, as escaped SQL statements or paramaterised queries
-     * @param mixed $having,... Unlimited additional predicates
      * @return $this Self reference
      */
     public function setHaving($having)
@@ -496,7 +495,6 @@ 
      * @see SQLSelect::addWhere() for syntax examples
      *
      * @param mixed $having Predicate(s) to set, as escaped SQL statements or paramaterised queries
-     * @param mixed $having,... Unlimited additional predicates
      * @return $this Self reference
      */
     public function addHaving($having)

src/Security/Group.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

Doc Comments +1 added lines

@@ -409,6 +409,7 @@
      * Overloaded to ensure the code is always descent.
      *
      * @param string
+     * @param string $val
      */
     public function setCode($val)
     {

src/Security/PermissionCheckboxSetField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

src/Assets/File.php

Doc Comments +5 added lines, -5 removed lines

@@ -423,7 +423,7 @@ 
      * Check if this file can be modified
      *
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canEdit($member = null)
     {
@@ -444,7 +444,7 @@ 
      *
      * @param Member $member
      * @param array $context
-     * @return boolean
+     * @return boolean|string
      */
     public function canCreate($member = null, $context = array())
     {
@@ -464,7 +464,7 @@ 
      * Check if this file can be deleted
      *
      * @param Member $member
-     * @return boolean
+     * @return boolean|string
      */
     public function canDelete($member = null)
     {
@@ -697,7 +697,7 @@ 
      *
      * @param string $condition The PHP condition to be evaluated.  The page will be called $item
      * @param array $collator An array, passed by reference, to collect all of the matching descendants.
-     * @return true|null
+     * @return boolean|null
      */
     public function collateDescendants($condition, &$collator)
     {
@@ -1089,6 +1089,7 @@ 
      *
      * @param String File extension, without dot prefix. Use an asterisk ('*')
      * to specify a generic fallback if no mapping is found for an extension.
+     * @param string $ext
      * @return String Classname for a subclass of {@link File}
      */
     public static function get_class_for_file_extension($ext)
@@ -1248,7 +1249,6 @@ 
      * Note that the result will not have a leading slash, and should not be used
      * with local file paths.
      *
-     * @param string $part,... Parts
      * @return string
      */
     public static function join_paths($part = null)