sminnee / silverstripe-framework

src/Forms/AssetField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

Doc Comments +6 added lines, -2 removed lines

@@ -204,7 +204,7 @@ 
     /**
      * Determine if the target folder for new uploads in is visible the field UI.
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canPreviewFolder()
     {
@@ -279,6 +279,10 @@ 
         return $this->record;
     }
 
+    /**
+     * @param null|DataObject $value
+     * @param DataObject $record
+     */
     public function setValue($value, $record = null)
     {
         // Extract value from underlying record
@@ -392,7 +396,7 @@ 
     /**
      * Determine if the user has permission to upload.
      *
-     * @return boolean
+     * @return boolean|string
      */
     public function canUpload()
     {

src/Forms/ConfirmedPasswordField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

src/Forms/DatetimeField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

Doc Comments +20 added lines, -4 removed lines

@@ -70,6 +70,10 @@ 
      */
     protected $config;
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, $value = "")
     {
         $this->config = $this->config()->default_config;
@@ -81,6 +85,9 @@ 
         parent::__construct($name, $title, $value);
     }
 
+    /**
+     * @param Form $form
+     */
     public function setForm($form)
     {
         parent::setForm($form);
@@ -92,6 +99,9 @@ 
         return $this;
     }
 
+    /**
+     * @param string $name
+     */
     public function setName($name)
     {
         parent::setName($name);
@@ -105,7 +115,7 @@ 
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function FieldHolder($properties = array())
     {
@@ -120,7 +130,7 @@ 
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {
@@ -254,6 +264,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);
@@ -354,7 +367,7 @@ 
      * to set field-specific config options.
      *
      * @param string $name
-     * @param mixed $val
+     * @param string $val
      * @return $this
      */
     public function setConfig($name, $val)
@@ -374,7 +387,7 @@ 
      * to get field-specific config options.
      *
      * @param String $name Optional, returns the whole configuration array if empty
-     * @return mixed
+     * @return string
      */
     public function getConfig($name = null)
     {
@@ -385,6 +398,9 @@ 
         }
     }
 
+    /**
+     * @param RequiredFields $validator
+     */
     public function validate($validator)
     {
         $dateValid = $this->dateField->validate($validator);

src/Forms/Form.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\ORM\DataQuery;
 use SilverStripe\ORM\DB;
-use InvalidArgumentException;
 
 /**
  * Matches textual content with a LIKE '%keyword%' construct.

Doc Comments +4 added lines, -3 removed lines

@@ -541,7 +541,7 @@ 
      * The callback can opt out of handling specific responses by returning NULL,
      * in which case the default form behaviour will kick in.
      *
-     * @param $callback
+     * @param \Closure $callback
      * @return self
      */
     public function setValidationResponseCallback($callback)
@@ -603,7 +603,7 @@ 
     /**
      * Fields can have action to, let's check if anyone of the responds to $funcname them
      *
-     * @param SS_List|array $fields
+     * @param FieldList $fields
      * @param callable $funcName
      * @return FormField
      */
@@ -755,6 +755,7 @@ 
      * Set actions that are exempt from validation
      *
      * @param array
+     * @param string[] $actions
      * @return $this
      */
     public function setValidationExemptActions($actions)
@@ -1198,7 +1199,7 @@ 
      * If set to false (the default), then the form method is only used to construct the default
      * form.
      *
-     * @param $bool boolean
+     * @param boolean $bool boolean
      * @return $this
      */
     public function setStrictFormMethodCheck($bool)

src/Forms/FormField.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\ORM\DataQuery;
 use SilverStripe\ORM\DB;
-use InvalidArgumentException;
 
 /**
  * Matches textual content with a LIKE '%keyword%' construct.

Doc Comments +2 added lines, -3 removed lines

@@ -807,7 +807,6 @@ 
      * Set the field value.
      *
      * @param mixed $value
-     * @param null|array|DataObject $data {@see Form::loadDataFrom}
      * @return $this
      */
     public function setValue($value)
@@ -1251,7 +1250,7 @@ 
     /**
      * @param FormTransformation $transformation
      *
-     * @return mixed
+     * @return FormField
      */
     public function transform(FormTransformation $transformation)
     {
@@ -1362,7 +1361,7 @@ 
      * This function is used by the template processor. If you refer to a field as a $ variable, it
      * will return the $Field value.
      *
-     * @return string
+     * @return DBHTMLText
      */
     public function forTemplate()
     {

src/Forms/GridField/GridField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

Doc Comments +1 added lines, -1 removed lines

@@ -228,7 +228,7 @@
      *
      * @todo refactor this into GridFieldComponent
      *
-     * @param mixed $value
+     * @param string $value
      * @param string|array $castingDefinition
      *
      * @return mixed

src/Forms/HTMLEditor/HTMLEditorSanitiser.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use DOMAttr;
 use DOMElement;
-use DOMNode;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\View\Parsers\HTMLValue;
 use stdClass;

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
     /**
      * Given a TinyMCE pattern (close to unix glob style), create a regex that does the match
      *
-     * @param $str - The TinyMCE pattern
+     * @param string|null $str - The TinyMCE pattern
      * @return string - The equivalent regex
      */
     protected function patternToRegex($str)

src/Forms/InlineFormAction.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace SilverStripe\Forms;
 
-use SilverStripe\View\Requirements;
-
 /**
  * Render a button that will submit the form its contained in through ajax.
  *

src/Forms/MemberDatetimeOptionsetField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**