sminnee / silverstripe-framework

tests/php/Forms/AssetFieldTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -356,7 +356,7 @@
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {

tests/php/Forms/AssetFieldTest/TestForm.php

Doc Comments +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
 	/**
 	 * @skipUpgrade
-	 * @param null $controller
+	 * @param TestController $controller
 	 * @param string $name
 	 */
 	public function __construct($controller = null, $name = 'Form')

tests/php/Forms/CurrencyFieldTest.php

Unused Use Statements -1 removed lines

@@ -1,7 +1,6 @@
 <?php
 
 use SilverStripe\Core\Convert;
-use SilverStripe\Core\Config\Config;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\View\Parsers\URLSegmentFilter;
 

tests/php/Forms/DropdownFieldTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -343,7 +343,7 @@
 	 * string of HTML.
 	 *
 	 * @param string $html HTML to scan for elements
-	 * @return SimpleXMLElement
+	 * @return \SimpleXMLElement
 	 */
 	public function findOptionElements($html) {
 		$parser = new CSSContentParser($html);

tests/php/Forms/GridField/GridField_URLHandlerTest/TestComponent_ItemRequest.php

Doc Comments +3 added lines

@@ -111,6 +111,9 @@
 
 	protected $id;
 
+	/**
+	 * @param string $link
+	 */
 	public function __construct($gridField, $id, $link) {
 		$this->gridField = $gridField;
 		$this->id = $id;

tests/php/Forms/GridField/GridFieldTest/Component.php

Doc Comments +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
 	/**
 	 *
 	 * @param GridField $gridField
-	 * @return array
+	 * @return string[]
 	 */
 	public function getActions($gridField) {
 		return array('addto');

tests/php/Forms/NumericFieldTest.php

Doc Comments +3 added lines

@@ -21,6 +21,9 @@
 		return str_replace(' ', $nbsp, trim($input));
 	}
 
+	/**
+	 * @param string $locale
+	 */
 	protected function checkInputValidation($locale, $tests) {
 		i18n::set_locale($locale);
 		$field = new NumericField('Number');

tests/php/Forms/UploadFieldTest.php

Doc Comments +4 added lines, -1 removed lines

@@ -946,7 +946,7 @@ 
 	 * Simulates a file upload
 	 *
 	 * @param string $fileField Name of the field to mock upload for
-	 * @param array $tmpFileName Name of temporary file to upload
+	 * @param string $tmpFileName Name of temporary file to upload
 	 * @return HTTPResponse form response
 	 */
 	protected function mockFileUpload($fileField, $tmpFileName) {
@@ -958,6 +958,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $fileField
+	 */
 	protected function mockFileExists($fileField, $fileName) {
 		return $this->get(
 			"UploadFieldTest_Controller/Form/field/{$fileField}/fileexists?filename=".urlencode($fileName)

tests/php/i18n/i18nTextCollectorTest.php

Unused Use Statements -1 removed lines

@@ -1,6 +1,5 @@
 <?php
 
-use SilverStripe\Dev\Debug;
 use SilverStripe\ORM\DataObjectSchema;
 use SilverStripe\ORM\DB;
 use SilverStripe\ORM\HasManyList;