sminnee /
silverstripe-framework
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like UploadFieldTest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use UploadFieldTest, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 7 | class UploadFieldTest extends FunctionalTest { |
||
| 8 | |||
| 9 | protected static $fixture_file = 'UploadFieldTest.yml'; |
||
| 10 | |||
| 11 | protected $extraDataObjects = array('UploadFieldTest_Record'); |
||
| 12 | |||
| 13 | protected $requiredExtensions = array( |
||
| 14 | 'File' => array('UploadFieldTest_FileExtension') |
||
| 15 | ); |
||
| 16 | |||
| 17 | /** |
||
| 18 | * Test that files can be uploaded against an object with no relation |
||
| 19 | */ |
||
| 20 | public function testUploadNoRelation() { |
||
| 21 | $this->loginWithPermission('ADMIN'); |
||
| 22 | |||
| 23 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
|
|
|||
| 24 | |||
| 25 | $tmpFileName = 'testUploadBasic.txt'; |
||
| 26 | $response = $this->mockFileUpload('NoRelationField', $tmpFileName); |
||
| 27 | $this->assertFalse($response->isError()); |
||
| 28 | $this->assertFileExists(ASSETS_PATH . "/UploadFieldTest/$tmpFileName"); |
||
| 29 | $uploadedFile = DataObject::get_one('File', array( |
||
| 30 | '"File"."Name"' => $tmpFileName |
||
| 31 | )); |
||
| 32 | $this->assertTrue(is_object($uploadedFile), 'The file object is created'); |
||
| 33 | } |
||
| 34 | |||
| 35 | /** |
||
| 36 | * Test that an object can be uploaded against an object with a has_one relation |
||
| 37 | */ |
||
| 38 | View Code Duplication | public function testUploadHasOneRelation() { |
|
| 39 | $this->loginWithPermission('ADMIN'); |
||
| 40 | |||
| 41 | // Unset existing has_one relation before re-uploading |
||
| 42 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 43 | $record->HasOneFileID = null; |
||
| 44 | $record->write(); |
||
| 45 | |||
| 46 | // Firstly, ensure the file can be uploaded |
||
| 47 | $tmpFileName = 'testUploadHasOneRelation.txt'; |
||
| 48 | $response = $this->mockFileUpload('HasOneFile', $tmpFileName); |
||
| 49 | $this->assertFalse($response->isError()); |
||
| 50 | $this->assertFileExists(ASSETS_PATH . "/UploadFieldTest/$tmpFileName"); |
||
| 51 | $uploadedFile = DataObject::get_one('File', array( |
||
| 52 | '"File"."Name"' => $tmpFileName |
||
| 53 | )); |
||
| 54 | $this->assertTrue(is_object($uploadedFile), 'The file object is created'); |
||
| 55 | |||
| 56 | // Secondly, ensure that simply uploading an object does not save the file against the relation |
||
| 57 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 58 | $this->assertFalse($record->HasOneFile()->exists()); |
||
| 59 | |||
| 60 | // Thirdly, test submitting the form with the encoded data |
||
| 61 | $response = $this->mockUploadFileIDs('HasOneFile', array($uploadedFile->ID)); |
||
| 62 | $this->assertEmpty($response['errors']); |
||
| 63 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 64 | $this->assertTrue($record->HasOneFile()->exists()); |
||
| 65 | $this->assertEquals($record->HasOneFile()->Name, $tmpFileName); |
||
| 66 | } |
||
| 67 | |||
| 68 | /** |
||
| 69 | * Tests that has_one relations work with subclasses of File |
||
| 70 | */ |
||
| 71 | View Code Duplication | public function testUploadHasOneRelationWithExtendedFile() { |
|
| 72 | $this->loginWithPermission('ADMIN'); |
||
| 73 | |||
| 74 | // Unset existing has_one relation before re-uploading |
||
| 75 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 76 | $record->HasOneExtendedFileID = null; |
||
| 77 | $record->write(); |
||
| 78 | |||
| 79 | // Test that the file can be safely uploaded |
||
| 80 | $tmpFileName = 'testUploadHasOneRelationWithExtendedFile.txt'; |
||
| 81 | $response = $this->mockFileUpload('HasOneExtendedFile', $tmpFileName); |
||
| 82 | $this->assertFalse($response->isError()); |
||
| 83 | $this->assertFileExists(ASSETS_PATH . "/UploadFieldTest/$tmpFileName"); |
||
| 84 | $uploadedFile = DataObject::get_one('UploadFieldTest_ExtendedFile', array( |
||
| 85 | '"File"."Name"' => $tmpFileName |
||
| 86 | )); |
||
| 87 | $this->assertTrue(is_object($uploadedFile), 'The file object is created'); |
||
| 88 | |||
| 89 | // Test that the record isn't written to automatically |
||
| 90 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 91 | $this->assertFalse($record->HasOneExtendedFile()->exists()); |
||
| 92 | |||
| 93 | // Test that saving the form writes the record |
||
| 94 | $response = $this->mockUploadFileIDs('HasOneExtendedFile', array($uploadedFile->ID)); |
||
| 95 | $this->assertEmpty($response['errors']); |
||
| 96 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 97 | $this->assertTrue($record->HasOneExtendedFile()->exists()); |
||
| 98 | $this->assertEquals($record->HasOneExtendedFile()->Name, $tmpFileName); |
||
| 99 | } |
||
| 100 | |||
| 101 | |||
| 102 | /** |
||
| 103 | * Test that has_many relations work with files |
||
| 104 | */ |
||
| 105 | public function testUploadHasManyRelation() { |
||
| 106 | $this->loginWithPermission('ADMIN'); |
||
| 107 | |||
| 108 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 109 | |||
| 110 | // Test that uploaded files can be posted to a has_many relation |
||
| 111 | $tmpFileName = 'testUploadHasManyRelation.txt'; |
||
| 112 | $response = $this->mockFileUpload('HasManyFiles', $tmpFileName); |
||
| 113 | $this->assertFalse($response->isError()); |
||
| 114 | $this->assertFileExists(ASSETS_PATH . "/UploadFieldTest/$tmpFileName"); |
||
| 115 | $uploadedFile = DataObject::get_one('File', array( |
||
| 116 | '"File"."Name"' => $tmpFileName |
||
| 117 | )); |
||
| 118 | $this->assertTrue(is_object($uploadedFile), 'The file object is created'); |
||
| 119 | |||
| 120 | // Test that the record isn't written to automatically |
||
| 121 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 122 | $this->assertEquals(2, $record->HasManyFiles()->Count()); // Existing two files should be retained |
||
| 123 | |||
| 124 | // Test that saving the form writes the record |
||
| 125 | $ids = array_merge($record->HasManyFiles()->getIDList(), array($uploadedFile->ID)); |
||
| 126 | $response = $this->mockUploadFileIDs('HasManyFiles', $ids); |
||
| 127 | $this->assertEmpty($response['errors']); |
||
| 128 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 129 | $this->assertEquals(3, $record->HasManyFiles()->Count()); // New record should appear here now |
||
| 130 | } |
||
| 131 | |||
| 132 | /** |
||
| 133 | * Test that many_many relationships work with files |
||
| 134 | */ |
||
| 135 | public function testUploadManyManyRelation() { |
||
| 136 | $this->loginWithPermission('ADMIN'); |
||
| 137 | |||
| 138 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 139 | $relationCount = $record->ManyManyFiles()->Count(); |
||
| 140 | |||
| 141 | // Test that uploaded files can be posted to a many_many relation |
||
| 142 | $tmpFileName = 'testUploadManyManyRelation.txt'; |
||
| 143 | $response = $this->mockFileUpload('ManyManyFiles', $tmpFileName); |
||
| 144 | $this->assertFalse($response->isError()); |
||
| 145 | $this->assertFileExists(ASSETS_PATH . "/UploadFieldTest/$tmpFileName"); |
||
| 146 | $uploadedFile = DataObject::get_one('File', array( |
||
| 147 | '"File"."Name"' => $tmpFileName |
||
| 148 | )); |
||
| 149 | $this->assertTrue(is_object($uploadedFile), 'The file object is created'); |
||
| 150 | |||
| 151 | // Test that the record isn't written to automatically |
||
| 152 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 153 | // Existing file count should be retained |
||
| 154 | $this->assertEquals($relationCount, $record->ManyManyFiles()->Count()); |
||
| 155 | |||
| 156 | // Test that saving the form writes the record |
||
| 157 | $ids = array_merge($record->ManyManyFiles()->getIDList(), array($uploadedFile->ID)); |
||
| 158 | $response = $this->mockUploadFileIDs('ManyManyFiles', $ids); |
||
| 159 | $this->assertEmpty($response['errors']); |
||
| 160 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 161 | $record->flushCache(); |
||
| 162 | // New record should appear here now |
||
| 163 | $this->assertEquals($relationCount + 1, $record->ManyManyFiles()->Count()); |
||
| 164 | } |
||
| 165 | |||
| 166 | /** |
||
| 167 | * Partially covered by {@link UploadTest->testUploadAcceptsAllowedExtension()}, |
||
| 168 | * but this test additionally verifies that those constraints are actually enforced |
||
| 169 | * in this controller method. |
||
| 170 | */ |
||
| 171 | public function testAllowedExtensions() { |
||
| 172 | $this->loginWithPermission('ADMIN'); |
||
| 173 | |||
| 174 | // Test invalid file |
||
| 175 | // Relies on Upload_Validator failing to allow this extension |
||
| 176 | $invalidFile = 'invalid.php'; |
||
| 177 | $_FILES = array('AllowedExtensionsField' => $this->getUploadFile($invalidFile)); |
||
| 178 | $response = $this->post( |
||
| 179 | 'UploadFieldTest_Controller/Form/field/AllowedExtensionsField/upload', |
||
| 180 | array('AllowedExtensionsField' => $this->getUploadFile($invalidFile)) |
||
| 181 | ); |
||
| 182 | $response = json_decode($response->getBody(), true); |
||
| 183 | $this->assertTrue(array_key_exists('error', $response[0])); |
||
| 184 | $this->assertContains('Extension is not allowed', $response[0]['error']); |
||
| 185 | |||
| 186 | // Test valid file |
||
| 187 | $validFile = 'valid.txt'; |
||
| 188 | $_FILES = array('AllowedExtensionsField' => $this->getUploadFile($validFile)); |
||
| 189 | $response = $this->post( |
||
| 190 | 'UploadFieldTest_Controller/Form/field/AllowedExtensionsField/upload', |
||
| 191 | array('AllowedExtensionsField' => $this->getUploadFile($validFile)) |
||
| 192 | ); |
||
| 193 | $response = json_decode($response->getBody(), true); |
||
| 194 | $this->assertFalse(array_key_exists('error', $response[0])); |
||
| 195 | |||
| 196 | // Test that setAllowedExtensions rejects extensions explicitly denied by File.allowed_extensions |
||
| 197 | // Relies on File::validate failing to allow this extension |
||
| 198 | $invalidFile = 'invalid.php'; |
||
| 199 | $_FILES = array('AllowedExtensionsField' => $this->getUploadFile($invalidFile)); |
||
| 200 | $response = $this->post( |
||
| 201 | 'UploadFieldTest_Controller/Form/field/InvalidAllowedExtensionsField/upload', |
||
| 202 | array('InvalidAllowedExtensionsField' => $this->getUploadFile($invalidFile)) |
||
| 203 | ); |
||
| 204 | $response = json_decode($response->getBody(), true); |
||
| 205 | $this->assertTrue(array_key_exists('error', $response[0])); |
||
| 206 | $this->assertContains('Extension is not allowed', $response[0]['error']); |
||
| 207 | |||
| 208 | } |
||
| 209 | |||
| 210 | /** |
||
| 211 | * Test that has_one relations do not support multiple files |
||
| 212 | */ |
||
| 213 | public function testAllowedMaxFileNumberWithHasOne() { |
||
| 214 | $this->loginWithPermission('ADMIN'); |
||
| 215 | |||
| 216 | // Get references for each file to upload |
||
| 217 | $file1 = $this->objFromFixture('File', 'file1'); |
||
| 218 | $file2 = $this->objFromFixture('File', 'file2'); |
||
| 219 | $fileIDs = array($file1->ID, $file2->ID); |
||
| 220 | |||
| 221 | // Test each of the three cases - has one with no max filel limit, has one with a limit of |
||
| 222 | // one, has one with a limit of more than one (makes no sense, but should test it anyway). |
||
| 223 | // Each of them should public function in the same way - attaching the first file should work, the |
||
| 224 | // second should cause an error. |
||
| 225 | foreach (array('HasOneFile', 'HasOneFileMaxOne', 'HasOneFileMaxTwo') as $recordName) { |
||
| 226 | |||
| 227 | // Unset existing has_one relation before re-uploading |
||
| 228 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 229 | $record->{"{$recordName}ID"} = null; |
||
| 230 | $record->write(); |
||
| 231 | |||
| 232 | // Post form with two files for this field, should result in an error |
||
| 233 | $response = $this->mockUploadFileIDs($recordName, $fileIDs); |
||
| 234 | $isError = !empty($response['errors']); |
||
| 235 | |||
| 236 | // Strictly, a has_one should not allow two files, but this is overridden |
||
| 237 | // by the setAllowedMaxFileNumber(2) call |
||
| 238 | $maxFiles = ($recordName === 'HasOneFileMaxTwo') ? 2 : 1; |
||
| 239 | |||
| 240 | // Assert that the form fails if the maximum number of files is exceeded |
||
| 241 | $this->assertTrue((count($fileIDs) > $maxFiles) == $isError); |
||
| 242 | } |
||
| 243 | } |
||
| 244 | |||
| 245 | /** |
||
| 246 | * Test that max number of items on has_many is validated |
||
| 247 | */ |
||
| 248 | public function testAllowedMaxFileNumberWithHasMany() { |
||
| 249 | $this->loginWithPermission('ADMIN'); |
||
| 250 | |||
| 251 | // The 'HasManyFilesMaxTwo' field has a maximum of two files able to be attached to it. |
||
| 252 | // We want to add files to it until we attempt to add the third. We expect that the first |
||
| 253 | // two should work and the third will fail. |
||
| 254 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 255 | $record->HasManyFilesMaxTwo()->removeAll(); |
||
| 256 | $this->assertCount(0, $record->HasManyFilesMaxTwo()); |
||
| 257 | |||
| 258 | // Get references for each file to upload |
||
| 259 | $file1 = $this->objFromFixture('File', 'file1'); |
||
| 260 | $file2 = $this->objFromFixture('File', 'file2'); |
||
| 261 | $file3 = $this->objFromFixture('File', 'file3'); |
||
| 262 | $this->assertTrue($file1->exists()); |
||
| 263 | $this->assertTrue($file2->exists()); |
||
| 264 | $this->assertTrue($file3->exists()); |
||
| 265 | |||
| 266 | // Write the first element, should be okay. |
||
| 267 | $response = $this->mockUploadFileIDs('HasManyFilesMaxTwo', array($file1->ID)); |
||
| 268 | $this->assertEmpty($response['errors']); |
||
| 269 | $this->assertCount(1, $record->HasManyFilesMaxTwo()); |
||
| 270 | $this->assertContains($file1->ID, $record->HasManyFilesMaxTwo()->getIDList()); |
||
| 271 | |||
| 272 | |||
| 273 | $record->HasManyFilesMaxTwo()->removeAll(); |
||
| 274 | $this->assertCount(0, $record->HasManyFilesMaxTwo()); |
||
| 275 | $this->assertTrue($file1->exists()); |
||
| 276 | $this->assertTrue($file2->exists()); |
||
| 277 | $this->assertTrue($file3->exists()); |
||
| 278 | |||
| 279 | |||
| 280 | |||
| 281 | // Write the second element, should be okay. |
||
| 282 | $response = $this->mockUploadFileIDs('HasManyFilesMaxTwo', array($file1->ID, $file2->ID)); |
||
| 283 | $this->assertEmpty($response['errors']); |
||
| 284 | $this->assertCount(2, $record->HasManyFilesMaxTwo()); |
||
| 285 | $this->assertContains($file1->ID, $record->HasManyFilesMaxTwo()->getIDList()); |
||
| 286 | $this->assertContains($file2->ID, $record->HasManyFilesMaxTwo()->getIDList()); |
||
| 287 | |||
| 288 | $record->HasManyFilesMaxTwo()->removeAll(); |
||
| 289 | $this->assertCount(0, $record->HasManyFilesMaxTwo()); |
||
| 290 | $this->assertTrue($file1->exists()); |
||
| 291 | $this->assertTrue($file2->exists()); |
||
| 292 | $this->assertTrue($file3->exists()); |
||
| 293 | |||
| 294 | |||
| 295 | // Write the third element, should result in error. |
||
| 296 | $response = $this->mockUploadFileIDs('HasManyFilesMaxTwo', array($file1->ID, $file2->ID, $file3->ID)); |
||
| 297 | $this->assertNotEmpty($response['errors']); |
||
| 298 | $this->assertCount(0, $record->HasManyFilesMaxTwo()); |
||
| 299 | } |
||
| 300 | |||
| 301 | /** |
||
| 302 | * Test that files can be removed from has_one relations |
||
| 303 | */ |
||
| 304 | public function testRemoveFromHasOne() { |
||
| 305 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 306 | $file1 = $this->objFromFixture('File', 'file1'); |
||
| 307 | |||
| 308 | // Check record exists |
||
| 309 | $this->assertTrue($record->HasOneFile()->exists()); |
||
| 310 | |||
| 311 | // Remove from record |
||
| 312 | $response = $this->mockUploadFileIDs('HasOneFile', array()); |
||
| 313 | $this->assertEmpty($response['errors']); |
||
| 314 | |||
| 315 | // Check file is removed |
||
| 316 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 317 | $this->assertFalse($record->HasOneFile()->exists()); |
||
| 318 | |||
| 319 | // Check file object itself exists |
||
| 320 | $this->assertFileExists($file1->FullPath, 'File is only detached, not deleted from filesystem'); |
||
| 321 | } |
||
| 322 | |||
| 323 | /** |
||
| 324 | * Test that items can be removed from has_many |
||
| 325 | */ |
||
| 326 | public function testRemoveFromHasMany() { |
||
| 327 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 328 | $file2 = $this->objFromFixture('File', 'file2'); |
||
| 329 | $file3 = $this->objFromFixture('File', 'file3'); |
||
| 330 | |||
| 331 | // Check record has two files attached |
||
| 332 | $this->assertEquals(array('File2', 'File3'), $record->HasManyFiles()->column('Title')); |
||
| 333 | |||
| 334 | // Remove file 2 |
||
| 335 | $response = $this->mockUploadFileIDs('HasManyFiles', array($file3->ID)); |
||
| 336 | $this->assertEmpty($response['errors']); |
||
| 337 | |||
| 338 | // check only file 3 is left |
||
| 339 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 340 | $this->assertEquals(array('File3'), $record->HasManyFiles()->column('Title')); |
||
| 341 | |||
| 342 | // Check file 2 object itself exists |
||
| 343 | $this->assertFileExists($file3->FullPath, 'File is only detached, not deleted from filesystem'); |
||
| 344 | } |
||
| 345 | |||
| 346 | /** |
||
| 347 | * Test that items can be removed from many_many |
||
| 348 | */ |
||
| 349 | public function testRemoveFromManyMany() { |
||
| 350 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 351 | $file4 = $this->objFromFixture('File', 'file4'); |
||
| 352 | $file5 = $this->objFromFixture('File', 'file5'); |
||
| 353 | |||
| 354 | // Check that both files are currently set |
||
| 355 | $this->assertContains('File4', $record->ManyManyFiles()->column('Title')); |
||
| 356 | $this->assertContains('File5', $record->ManyManyFiles()->column('Title')); |
||
| 357 | |||
| 358 | // Remove file 4 |
||
| 359 | $response = $this->mockUploadFileIDs('ManyManyFiles', array($file5->ID)); |
||
| 360 | $this->assertEmpty($response['errors']); |
||
| 361 | |||
| 362 | // check only file 5 is left |
||
| 363 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 364 | $this->assertNotContains('File4', $record->ManyManyFiles()->column('Title')); |
||
| 365 | $this->assertContains('File5', $record->ManyManyFiles()->column('Title')); |
||
| 366 | |||
| 367 | // check file 4 object exists |
||
| 368 | $this->assertFileExists($file4->FullPath, 'File is only detached, not deleted from filesystem'); |
||
| 369 | } |
||
| 370 | |||
| 371 | /** |
||
| 372 | * Test that files can be deleted from has_one and the filesystem |
||
| 373 | */ |
||
| 374 | public function testDeleteFromHasOne() { |
||
| 375 | $this->loginWithPermission('ADMIN'); |
||
| 376 | |||
| 377 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 378 | $file1 = $this->objFromFixture('File', 'file1'); |
||
| 379 | |||
| 380 | // Check that file initially exists |
||
| 381 | $this->assertTrue($record->HasOneFile()->exists()); |
||
| 382 | $this->assertFileExists($file1->FullPath); |
||
| 383 | |||
| 384 | // Delete physical file and update record |
||
| 385 | $response = $this->mockFileDelete('HasOneFile', $file1->ID); |
||
| 386 | $this->assertFalse($response->isError()); |
||
| 387 | $response = $this->mockUploadFileIDs('HasOneFile', array()); |
||
| 388 | $this->assertEmpty($response['errors']); |
||
| 389 | |||
| 390 | // Check that file is not set against record |
||
| 391 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 392 | $this->assertFalse($record->HasOneFile()->exists()); |
||
| 393 | |||
| 394 | // Check that the physical file is deleted |
||
| 395 | $this->assertFileNotExists($file1->FullPath, 'File is also removed from filesystem'); |
||
| 396 | } |
||
| 397 | |||
| 398 | /** |
||
| 399 | * Test that files can be deleted from has_many and the filesystem |
||
| 400 | */ |
||
| 401 | public function testDeleteFromHasMany() { |
||
| 402 | $this->loginWithPermission('ADMIN'); |
||
| 403 | |||
| 404 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 405 | $file2 = $this->objFromFixture('File', 'file2'); |
||
| 406 | $file3 = $this->objFromFixture('File', 'file3'); |
||
| 407 | |||
| 408 | // Check that files initially exists |
||
| 409 | $this->assertEquals(array('File2', 'File3'), $record->HasManyFiles()->column('Title')); |
||
| 410 | $this->assertFileExists($file2->FullPath); |
||
| 411 | $this->assertFileExists($file3->FullPath); |
||
| 412 | |||
| 413 | // Delete physical file and update record without file 2 |
||
| 414 | $response = $this->mockFileDelete('HasManyFiles', $file2->ID); |
||
| 415 | $this->assertFalse($response->isError()); |
||
| 416 | $response = $this->mockUploadFileIDs('HasManyFiles', array($file3->ID)); |
||
| 417 | $this->assertEmpty($response['errors']); |
||
| 418 | |||
| 419 | // Test that file is removed from record |
||
| 420 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 421 | $this->assertEquals(array('File3'), $record->HasManyFiles()->column('Title')); |
||
| 422 | |||
| 423 | // Test that physical file is removed |
||
| 424 | $this->assertFileNotExists($file2->FullPath, 'File is also removed from filesystem'); |
||
| 425 | } |
||
| 426 | |||
| 427 | /** |
||
| 428 | * Test that files can be deleted from many_many and the filesystem |
||
| 429 | */ |
||
| 430 | public function testDeleteFromManyMany() { |
||
| 431 | $this->loginWithPermission('ADMIN'); |
||
| 432 | |||
| 433 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 434 | $file4 = $this->objFromFixture('File', 'file4'); |
||
| 435 | $file5 = $this->objFromFixture('File', 'file5'); |
||
| 436 | $fileNoDelete = $this->objFromFixture('File', 'file-nodelete'); |
||
| 437 | |||
| 438 | // Test that files initially exist |
||
| 439 | $setFiles = $record->ManyManyFiles()->column('Title'); |
||
| 440 | $this->assertContains('File4', $setFiles); |
||
| 441 | $this->assertContains('File5', $setFiles); |
||
| 442 | $this->assertContains('nodelete.txt', $setFiles); |
||
| 443 | $this->assertFileExists($file4->FullPath); |
||
| 444 | $this->assertFileExists($file5->FullPath); |
||
| 445 | $this->assertFileExists($fileNoDelete->FullPath); |
||
| 446 | |||
| 447 | // Delete physical file and update record without file 4 |
||
| 448 | $response = $this->mockFileDelete('ManyManyFiles', $file4->ID); |
||
| 449 | $this->assertFalse($response->isError()); |
||
| 450 | |||
| 451 | // Check file is removed from record |
||
| 452 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 453 | $this->assertNotContains('File4', $record->ManyManyFiles()->column('Title')); |
||
| 454 | $this->assertContains('File5', $record->ManyManyFiles()->column('Title')); |
||
| 455 | |||
| 456 | // Check physical file is removed from filesystem |
||
| 457 | $this->assertFileNotExists($file4->FullPath, 'File is also removed from filesystem'); |
||
| 458 | |||
| 459 | // Test record-based permissions |
||
| 460 | $response = $this->mockFileDelete('ManyManyFiles', $fileNoDelete->ID); |
||
| 461 | $this->assertEquals(403, $response->getStatusCode()); |
||
| 462 | |||
| 463 | // Test that folders can't be deleted |
||
| 464 | $folder = $this->objFromFixture('Folder', 'folder1-subfolder1'); |
||
| 465 | $response = $this->mockFileDelete('ManyManyFiles', $folder->ID); |
||
| 466 | $this->assertEquals(403, $response->getStatusCode()); |
||
| 467 | } |
||
| 468 | |||
| 469 | /** |
||
| 470 | * Test control output html |
||
| 471 | */ |
||
| 472 | public function testView() { |
||
| 473 | $this->loginWithPermission('ADMIN'); |
||
| 474 | |||
| 475 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 476 | $file4 = $this->objFromFixture('File', 'file4'); |
||
| 477 | $file5 = $this->objFromFixture('File', 'file5'); |
||
| 478 | $fileNoView = $this->objFromFixture('File', 'file-noview'); |
||
| 479 | $fileNoEdit = $this->objFromFixture('File', 'file-noedit'); |
||
| 480 | $fileNoDelete = $this->objFromFixture('File', 'file-nodelete'); |
||
| 481 | |||
| 482 | $response = $this->get('UploadFieldTest_Controller'); |
||
| 483 | $this->assertFalse($response->isError()); |
||
| 484 | |||
| 485 | $parser = new CSSContentParser($response->getBody()); |
||
| 486 | $items = $parser->getBySelector( |
||
| 487 | '#UploadFieldTestForm_Form_HasManyNoViewFiles_Holder .ss-uploadfield-files .ss-uploadfield-item' |
||
| 488 | ); |
||
| 489 | $ids = array(); |
||
| 490 | foreach($items as $item) $ids[] = (int)$item['data-fileid']; |
||
| 491 | |||
| 492 | $this->assertContains($file4->ID, $ids, 'Views related file'); |
||
| 493 | $this->assertContains($file5->ID, $ids, 'Views related file'); |
||
| 494 | $this->assertNotContains($fileNoView->ID, $ids, "Doesn't view files without view permissions"); |
||
| 495 | $this->assertContains($fileNoEdit->ID, $ids, "Views files without edit permissions"); |
||
| 496 | $this->assertContains($fileNoDelete->ID, $ids, "Views files without delete permissions"); |
||
| 497 | } |
||
| 498 | |||
| 499 | public function testEdit() { |
||
| 500 | $memberID = $this->loginWithPermission('ADMIN'); |
||
| 501 | |||
| 502 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 503 | $file4 = $this->objFromFixture('File', 'file4'); |
||
| 504 | $fileNoEdit = $this->objFromFixture('File', 'file-noedit'); |
||
| 505 | $folder = $this->objFromFixture('Folder', 'folder1-subfolder1'); |
||
| 506 | |||
| 507 | $response = $this->mockFileEditForm('ManyManyFiles', $file4->ID); |
||
| 508 | $this->assertFalse($response->isError()); |
||
| 509 | |||
| 510 | $response = $this->mockFileEdit('ManyManyFiles', $file4->ID, array('Title' => 'File 4 modified')); |
||
| 511 | $this->assertFalse($response->isError()); |
||
| 512 | |||
| 513 | $record = DataObject::get_by_id($record->class, $record->ID, false); |
||
| 514 | $file4 = DataObject::get_by_id($file4->class, $file4->ID, false); |
||
| 515 | $this->assertEquals('File 4 modified', $file4->Title); |
||
| 516 | |||
| 517 | // Test record-based permissions |
||
| 518 | $response = $this->mockFileEditForm('ManyManyFiles', $fileNoEdit->ID); |
||
| 519 | $this->assertEquals(403, $response->getStatusCode()); |
||
| 520 | |||
| 521 | $response = $this->mockFileEdit('ManyManyFiles', $fileNoEdit->ID, array()); |
||
| 522 | $this->assertEquals(403, $response->getStatusCode()); |
||
| 523 | |||
| 524 | // Test folder permissions |
||
| 525 | $response = $this->mockFileEditForm('ManyManyFiles', $folder->ID); |
||
| 526 | $this->assertEquals(403, $response->getStatusCode()); |
||
| 527 | |||
| 528 | $response = $this->mockFileEdit('ManyManyFiles', $folder->ID, array()); |
||
| 529 | $this->assertEquals(403, $response->getStatusCode()); |
||
| 530 | } |
||
| 531 | |||
| 532 | public function testGetRecord() { |
||
| 533 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 534 | $form = $this->getMockForm(); |
||
| 535 | |||
| 536 | $field = UploadField::create('MyField'); |
||
| 537 | $field->setForm($form); |
||
| 538 | $this->assertNull($field->getRecord(), 'Returns no record by default'); |
||
| 539 | |||
| 540 | $field = UploadField::create('MyField'); |
||
| 541 | $field->setForm($form); |
||
| 542 | $form->loadDataFrom($record); |
||
| 543 | $this->assertEquals($record, $field->getRecord(), 'Returns record from form if available'); |
||
| 544 | |||
| 545 | $field = UploadField::create('MyField'); |
||
| 546 | $field->setForm($form); |
||
| 547 | $field->setRecord($record); |
||
| 548 | $this->assertEquals($record, $field->getRecord(), 'Returns record when set explicitly'); |
||
| 549 | } |
||
| 550 | |||
| 551 | public function testSetItems() { |
||
| 552 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 553 | $items = new ArrayList(array( |
||
| 554 | $this->objFromFixture('File', 'file1'), |
||
| 555 | $this->objFromFixture('File', 'file2') |
||
| 556 | )); |
||
| 557 | |||
| 558 | // Field with no record attached |
||
| 559 | $field = UploadField::create('DummyField'); |
||
| 560 | $field->setItems($items); |
||
| 561 | $this->assertEquals(array('File1', 'File2'), $field->getItems()->column('Title')); |
||
| 562 | |||
| 563 | // Anonymous field |
||
| 564 | $field = UploadField::create('MyField'); |
||
| 565 | $field->setRecord($record); |
||
| 566 | $field->setItems($items); |
||
| 567 | $this->assertEquals(array('File1', 'File2'), $field->getItems()->column('Title')); |
||
| 568 | |||
| 569 | // Field with has_one auto-detected |
||
| 570 | $field = UploadField::create('HasOneFile'); |
||
| 571 | $field->setRecord($record); |
||
| 572 | $field->setItems($items); |
||
| 573 | $this->assertEquals(array('File1', 'File2'), $field->getItems()->column('Title'), |
||
| 574 | 'Allows overwriting of items even when relationship is detected' |
||
| 575 | ); |
||
| 576 | } |
||
| 577 | |||
| 578 | public function testGetItems() { |
||
| 579 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 580 | |||
| 581 | // Anonymous field |
||
| 582 | $field = UploadField::create('MyField'); |
||
| 583 | $field->setValue(null, $record); |
||
| 584 | $this->assertEquals(array(), $field->getItems()->column('Title')); |
||
| 585 | |||
| 586 | // Field with has_one auto-detected |
||
| 587 | $field = UploadField::create('HasOneFile'); |
||
| 588 | $field->setValue(null, $record); |
||
| 589 | $this->assertEquals(array('File1'), $field->getItems()->column('Title')); |
||
| 590 | |||
| 591 | // Field with has_many auto-detected |
||
| 592 | $field = UploadField::create('HasManyFiles'); |
||
| 593 | $field->setValue(null, $record); |
||
| 594 | $this->assertEquals(array('File2', 'File3'), $field->getItems()->column('Title')); |
||
| 595 | |||
| 596 | // Field with many_many auto-detected |
||
| 597 | $field = UploadField::create('ManyManyFiles'); |
||
| 598 | $field->setValue(null, $record); |
||
| 599 | $this->assertNotContains('File1',$field->getItems()->column('Title')); |
||
| 600 | $this->assertNotContains('File2',$field->getItems()->column('Title')); |
||
| 601 | $this->assertNotContains('File3',$field->getItems()->column('Title')); |
||
| 602 | $this->assertContains('File4',$field->getItems()->column('Title')); |
||
| 603 | $this->assertContains('File5',$field->getItems()->column('Title')); |
||
| 604 | } |
||
| 605 | |||
| 606 | View Code Duplication | public function testReadonly() { |
|
| 607 | $this->loginWithPermission('ADMIN'); |
||
| 608 | |||
| 609 | $response = $this->get('UploadFieldTest_Controller'); |
||
| 610 | $this->assertFalse($response->isError()); |
||
| 611 | |||
| 612 | $parser = new CSSContentParser($response->getBody()); |
||
| 613 | |||
| 614 | $this->assertFalse( |
||
| 615 | (bool)$parser->getBySelector( |
||
| 616 | '#UploadFieldTestForm_Form_ReadonlyField .ss-uploadfield-files .ss-uploadfield-item .ss-ui-button' |
||
| 617 | ), |
||
| 618 | 'Removes all buttons on items'); |
||
| 619 | $this->assertFalse( |
||
| 620 | (bool)$parser->getBySelector('#UploadFieldTestForm_Form_ReadonlyField .ss-uploadfield-dropzone'), |
||
| 621 | 'Removes dropzone' |
||
| 622 | ); |
||
| 623 | $this->assertFalse( |
||
| 624 | (bool)$parser->getBySelector( |
||
| 625 | '#UploadFieldTestForm_Form_ReadonlyField .ss-uploadfield-addfile' |
||
| 626 | ), |
||
| 627 | 'Entire "add" area' |
||
| 628 | ); |
||
| 629 | } |
||
| 630 | |||
| 631 | View Code Duplication | public function testDisabled() { |
|
| 632 | $this->loginWithPermission('ADMIN'); |
||
| 633 | |||
| 634 | $response = $this->get('UploadFieldTest_Controller'); |
||
| 635 | $this->assertFalse($response->isError()); |
||
| 636 | |||
| 637 | $parser = new CSSContentParser($response->getBody()); |
||
| 638 | $this->assertFalse( |
||
| 639 | (bool)$parser->getBySelector( |
||
| 640 | '#UploadFieldTestForm_Form_DisabledField .ss-uploadfield-files .ss-uploadfield-item .ss-ui-button' |
||
| 641 | ), |
||
| 642 | 'Removes all buttons on items'); |
||
| 643 | $this->assertFalse((bool)$parser->getBySelector( |
||
| 644 | '#UploadFieldTestForm_Form_DisabledField .ss-uploadfield-dropzone' |
||
| 645 | ), |
||
| 646 | 'Removes dropzone'); |
||
| 647 | $this->assertFalse( |
||
| 648 | (bool)$parser->getBySelector('#UploadFieldTestForm_Form_DisabledField .ss-uploadfield-addfile'), |
||
| 649 | 'Entire "add" area' |
||
| 650 | ); |
||
| 651 | } |
||
| 652 | |||
| 653 | public function testCanUpload() { |
||
| 654 | $this->loginWithPermission('ADMIN'); |
||
| 655 | $response = $this->get('UploadFieldTest_Controller'); |
||
| 656 | $this->assertFalse($response->isError()); |
||
| 657 | |||
| 658 | $parser = new CSSContentParser($response->getBody()); |
||
| 659 | $this->assertFalse( |
||
| 660 | (bool)$parser->getBySelector( |
||
| 661 | '#UploadFieldTestForm_Form_CanUploadFalseField_Holder .ss-uploadfield-dropzone' |
||
| 662 | ), |
||
| 663 | 'Removes dropzone'); |
||
| 664 | $this->assertTrue( |
||
| 665 | (bool)$parser->getBySelector( |
||
| 666 | '#UploadFieldTestForm_Form_CanUploadFalseField_Holder .ss-uploadfield-fromfiles' |
||
| 667 | ), |
||
| 668 | 'Keeps "From files" button' |
||
| 669 | ); |
||
| 670 | } |
||
| 671 | |||
| 672 | public function testCanUploadWithPermissionCode() { |
||
| 673 | $field = UploadField::create('MyField'); |
||
| 674 | |||
| 675 | $field->setCanUpload(true); |
||
| 676 | $this->assertTrue($field->canUpload()); |
||
| 677 | |||
| 678 | $field->setCanUpload(false); |
||
| 679 | $this->assertFalse($field->canUpload()); |
||
| 680 | |||
| 681 | $this->loginWithPermission('ADMIN'); |
||
| 682 | |||
| 683 | $field->setCanUpload(false); |
||
| 684 | $this->assertFalse($field->canUpload()); |
||
| 685 | |||
| 686 | $field->setCanUpload('ADMIN'); |
||
| 687 | $this->assertTrue($field->canUpload()); |
||
| 688 | } |
||
| 689 | |||
| 690 | public function testCanAttachExisting() { |
||
| 691 | $this->loginWithPermission('ADMIN'); |
||
| 692 | $response = $this->get('UploadFieldTest_Controller'); |
||
| 693 | $this->assertFalse($response->isError()); |
||
| 694 | |||
| 695 | $parser = new CSSContentParser($response->getBody()); |
||
| 696 | $this->assertTrue( |
||
| 697 | (bool)$parser->getBySelector( |
||
| 698 | '#UploadFieldTestForm_Form_CanAttachExistingFalseField_Holder .ss-uploadfield-fromcomputer-fileinput' |
||
| 699 | ), |
||
| 700 | 'Keeps input file control' |
||
| 701 | ); |
||
| 702 | $this->assertFalse( |
||
| 703 | (bool)$parser->getBySelector( |
||
| 704 | '#UploadFieldTestForm_Form_CanAttachExistingFalseField_Holder .ss-uploadfield-fromfiles' |
||
| 705 | ), |
||
| 706 | 'Removes "From files" button' |
||
| 707 | ); |
||
| 708 | |||
| 709 | // Test requests to select files have the correct given permission |
||
| 710 | $response2 = $this->get('UploadFieldTest_Controller/Form/field/CanAttachExistingFalseField/select'); |
||
| 711 | $this->assertEquals(403, $response2->getStatusCode()); |
||
| 712 | $response3 = $this->get('UploadFieldTest_Controller/Form/field/HasOneFile/select'); |
||
| 713 | $this->assertEquals(200, $response3->getStatusCode()); |
||
| 714 | } |
||
| 715 | |||
| 716 | View Code Duplication | public function testSelect() { |
|
| 717 | $this->loginWithPermission('ADMIN'); |
||
| 718 | |||
| 719 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 720 | $file4 = $this->objFromFixture('File', 'file4'); |
||
| 721 | $fileSubfolder = $this->objFromFixture('File', 'file-subfolder'); |
||
| 722 | |||
| 723 | $response = $this->get('UploadFieldTest_Controller/Form/field/ManyManyFiles/select/'); |
||
| 724 | $this->assertFalse($response->isError()); |
||
| 725 | |||
| 726 | // A bit too much coupling with GridField, but a full template overload would make things too complex |
||
| 727 | $parser = new CSSContentParser($response->getBody()); |
||
| 728 | $items = $parser->getBySelector('.ss-gridfield-item'); |
||
| 729 | $itemIDs = array_map(create_function('$el', 'return (int)$el["data-id"];'), $items); |
||
| 730 | $this->assertContains($file4->ID, $itemIDs, 'Contains file in assigned folder'); |
||
| 731 | $this->assertContains($fileSubfolder->ID, $itemIDs, 'Contains file in subfolder'); |
||
| 732 | } |
||
| 733 | |||
| 734 | View Code Duplication | public function testSelectWithDisplayFolderName() { |
|
| 735 | $this->loginWithPermission('ADMIN'); |
||
| 736 | |||
| 737 | $record = $this->objFromFixture('UploadFieldTest_Record', 'record1'); |
||
| 738 | $file4 = $this->objFromFixture('File', 'file4'); |
||
| 739 | $fileSubfolder = $this->objFromFixture('File', 'file-subfolder'); |
||
| 740 | |||
| 741 | $response = $this->get('UploadFieldTest_Controller/Form/field/HasManyDisplayFolder/select/'); |
||
| 742 | $this->assertFalse($response->isError()); |
||
| 743 | |||
| 744 | // A bit too much coupling with GridField, but a full template overload would make things too complex |
||
| 745 | $parser = new CSSContentParser($response->getBody()); |
||
| 746 | $items = $parser->getBySelector('.ss-gridfield-item'); |
||
| 747 | $itemIDs = array_map(create_function('$el', 'return (int)$el["data-id"];'), $items); |
||
| 748 | $this->assertContains($file4->ID, $itemIDs, 'Contains file in assigned folder'); |
||
| 749 | $this->assertNotContains($fileSubfolder->ID, $itemIDs, 'Does not contain file in subfolder'); |
||
| 750 | } |
||
| 751 | |||
| 752 | /** |
||
| 753 | * Test that UploadField:overwriteWarning cannot overwrite Upload:replaceFile |
||
| 754 | */ |
||
| 755 | public function testConfigOverwriteWarningCannotRelaceFiles() { |
||
| 756 | $this->loginWithPermission('ADMIN'); |
||
| 757 | |||
| 758 | Upload::config()->replaceFile = false; |
||
| 759 | UploadField::config()->defaultConfig = array_merge( |
||
| 760 | UploadField::config()->defaultConfig, array('overwriteWarning' => true) |
||
| 761 | ); |
||
| 762 | |||
| 763 | $tmpFileName = 'testUploadBasic.txt'; |
||
| 764 | $response = $this->mockFileUpload('NoRelationField', $tmpFileName); |
||
| 765 | $this->assertFalse($response->isError()); |
||
| 766 | $responseData = Convert::json2array($response->getBody()); |
||
| 767 | $this->assertFileExists(ASSETS_PATH . '/UploadFieldTest/' . $responseData[0]['name']); |
||
| 768 | $uploadedFile = DataObject::get_by_id('File', (int) $responseData[0]['id']); |
||
| 769 | $this->assertTrue(is_object($uploadedFile), 'The file object is created'); |
||
| 770 | |||
| 771 | $tmpFileName = 'testUploadBasic.txt'; |
||
| 772 | $response = $this->mockFileUpload('NoRelationField', $tmpFileName); |
||
| 773 | $this->assertFalse($response->isError()); |
||
| 774 | $responseData = Convert::json2array($response->getBody()); |
||
| 775 | $this->assertFileExists(ASSETS_PATH . '/UploadFieldTest/' . $responseData[0]['name']); |
||
| 776 | $uploadedFile2 = DataObject::get_by_id('File', (int) $responseData[0]['id']); |
||
| 777 | $this->assertTrue(is_object($uploadedFile2), 'The file object is created'); |
||
| 778 | $this->assertTrue( |
||
| 779 | $uploadedFile->Filename !== $uploadedFile2->Filename, |
||
| 780 | 'Filename is not the same' |
||
| 781 | ); |
||
| 782 | $this->assertTrue( |
||
| 783 | $uploadedFile->ID !== $uploadedFile2->ID, |
||
| 784 | 'File database record is not the same' |
||
| 785 | ); |
||
| 786 | |||
| 787 | $uploadedFile->delete(); |
||
| 788 | $uploadedFile2->delete(); |
||
| 789 | } |
||
| 790 | |||
| 791 | /** |
||
| 792 | * Tests that UploadField::fileexist works |
||
| 793 | */ |
||
| 794 | public function testFileExists() { |
||
| 795 | $this->loginWithPermission('ADMIN'); |
||
| 796 | |||
| 797 | // Check that fileexist works on subfolders |
||
| 798 | $nonFile = uniqid().'.txt'; |
||
| 799 | $responseEmpty = $this->mockFileExists('NoRelationField', $nonFile); |
||
| 800 | $responseEmptyData = json_decode($responseEmpty->getBody()); |
||
| 801 | $this->assertFalse($responseEmpty->isError()); |
||
| 802 | $this->assertFalse($responseEmptyData->exists); |
||
| 803 | |||
| 804 | // Check that filexists works on root folder |
||
| 805 | $responseRoot = $this->mockFileExists('RootFolderTest', $nonFile); |
||
| 806 | $responseRootData = json_decode($responseRoot->getBody()); |
||
| 807 | $this->assertFalse($responseRoot->isError()); |
||
| 808 | $this->assertFalse($responseRootData->exists); |
||
| 809 | |||
| 810 | // Check that uploaded files can be detected in the root |
||
| 811 | $tmpFileName = 'testUploadBasic.txt'; |
||
| 812 | $response = $this->mockFileUpload('RootFolderTest', $tmpFileName); |
||
| 813 | $this->assertFalse($response->isError()); |
||
| 814 | $this->assertFileExists(ASSETS_PATH . "/$tmpFileName"); |
||
| 815 | $responseExists = $this->mockFileExists('RootFolderTest', $tmpFileName); |
||
| 816 | $responseExistsData = json_decode($responseExists->getBody()); |
||
| 817 | $this->assertFalse($responseExists->isError()); |
||
| 818 | $this->assertTrue($responseExistsData->exists); |
||
| 819 | |||
| 820 | // Check that uploaded files can be detected |
||
| 821 | $response = $this->mockFileUpload('NoRelationField', $tmpFileName); |
||
| 822 | $this->assertFalse($response->isError()); |
||
| 823 | $this->assertFileExists(ASSETS_PATH . "/UploadFieldTest/$tmpFileName"); |
||
| 824 | $responseExists = $this->mockFileExists('NoRelationField', $tmpFileName); |
||
| 825 | $responseExistsData = json_decode($responseExists->getBody()); |
||
| 826 | $this->assertFalse($responseExists->isError()); |
||
| 827 | $this->assertTrue($responseExistsData->exists); |
||
| 828 | |||
| 829 | // Test that files with invalid characters are rewritten safely and both report exists |
||
| 830 | // Check that uploaded files can be detected in the root |
||
| 831 | $tmpFileName = '_test___Upload___Bad.txt'; |
||
| 832 | $tmpFileNameExpected = 'test-Upload-Bad.txt'; |
||
| 833 | $response = $this->mockFileUpload('NoRelationField', $tmpFileName); |
||
| 834 | $this->assertFalse($response->isError()); |
||
| 835 | $this->assertFileExists(ASSETS_PATH . "/UploadFieldTest/$tmpFileNameExpected"); |
||
| 836 | // With original file |
||
| 837 | $responseExists = $this->mockFileExists('NoRelationField', $tmpFileName); |
||
| 838 | $responseExistsData = json_decode($responseExists->getBody()); |
||
| 839 | $this->assertFalse($responseExists->isError()); |
||
| 840 | $this->assertTrue($responseExistsData->exists); |
||
| 841 | // With rewritten file |
||
| 842 | $responseExists = $this->mockFileExists('NoRelationField', $tmpFileNameExpected); |
||
| 843 | $responseExistsData = json_decode($responseExists->getBody()); |
||
| 844 | $this->assertFalse($responseExists->isError()); |
||
| 845 | $this->assertTrue($responseExistsData->exists); |
||
| 846 | |||
| 847 | // Test that attempts to navigate outside of the directory return false |
||
| 848 | $responseExists = $this->mockFileExists('NoRelationField', "../../../../var/private/$tmpFileName"); |
||
| 849 | $responseExistsData = json_decode($responseExists->getBody()); |
||
| 850 | $this->assertTrue($responseExists->isError()); |
||
| 851 | $this->assertContains('File is not a valid upload', $responseExists->getBody()); |
||
| 852 | } |
||
| 853 | |||
| 854 | protected function getMockForm() { |
||
| 857 | |||
| 858 | /** |
||
| 859 | * @return Array Emulating an entry in the $_FILES superglobal |
||
| 860 | */ |
||
| 861 | protected function getUploadFile($tmpFileName = 'UploadFieldTest-testUpload.txt') { |
||
| 862 | $tmpFilePath = TEMP_FOLDER . '/' . $tmpFileName; |
||
| 863 | $tmpFileContent = ''; |
||
| 864 | for($i=0; $i<10000; $i++) $tmpFileContent .= '0'; |
||
| 865 | file_put_contents($tmpFilePath, $tmpFileContent); |
||
| 866 | |||
| 867 | // emulates the $_FILES array |
||
| 868 | return array( |
||
| 869 | 'name' => array('Uploads' => array($tmpFileName)), |
||
| 870 | 'type' => array('Uploads' => array('text/plaintext')), |
||
| 871 | 'size' => array('Uploads' => array(filesize($tmpFilePath))), |
||
| 872 | 'tmp_name' => array('Uploads' => array($tmpFilePath)), |
||
| 873 | 'error' => array('Uploads' => array(UPLOAD_ERR_OK)), |
||
| 874 | ); |
||
| 875 | } |
||
| 876 | |||
| 877 | /** |
||
| 878 | * Simulates a form post to the test controller with the specified file IDs |
||
| 879 | * |
||
| 880 | * @param string $fileField Name of field to assign ids to |
||
| 881 | * @param array $ids list of file IDs |
||
| 882 | * @return boolean Array with key 'errors' |
||
| 883 | */ |
||
| 884 | protected function mockUploadFileIDs($fileField, $ids) { |
||
| 885 | |||
| 886 | // collate file ids |
||
| 911 | |||
| 912 | /** |
||
| 913 | * Simulates a file upload |
||
| 914 | * |
||
| 915 | * @param string $fileField Name of the field to mock upload for |
||
| 916 | * @param array $tmpFileName Name of temporary file to upload |
||
| 917 | * @return SS_HTTPResponse form response |
||
| 918 | */ |
||
| 919 | protected function mockFileUpload($fileField, $tmpFileName) { |
||
| 927 | |||
| 928 | protected function mockFileExists($fileField, $fileName) { |
||
| 933 | |||
| 934 | /** |
||
| 935 | * Gets the edit form for the given file |
||
| 936 | * |
||
| 937 | * @param string $fileField Name of the field |
||
| 938 | * @param integer $fileID ID of the file to delete |
||
| 939 | * @return SS_HTTPResponse form response |
||
| 940 | */ |
||
| 941 | protected function mockFileEditForm($fileField, $fileID) { |
||
| 946 | |||
| 947 | /** |
||
| 948 | * Mocks edit submissions to a file |
||
| 949 | * |
||
| 950 | * @param string $fileField Name of the field |
||
| 951 | * @param integer $fileID ID of the file to delete |
||
| 952 | * @param array $fields Fields to update |
||
| 953 | * @return SS_HTTPResponse form response |
||
| 954 | */ |
||
| 955 | protected function mockFileEdit($fileField, $fileID, $fields = array()) { |
||
| 961 | |||
| 962 | /** |
||
| 963 | * Simulates a physical file deletion |
||
| 964 | * |
||
| 965 | * @param string $fileField Name of the field |
||
| 966 | * @param integer $fileID ID of the file to delete |
||
| 967 | * @return SS_HTTPResponse form response |
||
| 968 | */ |
||
| 969 | protected function mockFileDelete($fileField, $fileID) { |
||
| 975 | |||
| 976 | public function setUp() { |
||
| 996 | |||
| 997 | public function tearDown() { |
||
| 1026 | |||
| 1027 | } |
||
| 1028 | |||
| 1220 |
Loading history...
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.