GDBackend

Complexity

Total Complexity

102

Size/Duplication

Total Lines	575
Duplicated Lines	2.09 %

Coupling/Cohesion

Components	1
Dependencies	7

29 Methods

Rating	Name	Duplication	Size	Complexity
A	set_default_quality()	3	6	4
A	setGD()	0	4	1
A	getImageResource()	0	3	1
A	getGD()	0	4	1
A	imageAvailable()	0	3	2
A	checkAvailableMemory()	0	20	4
A	failedResample()	0	4	2
A	setQuality()	0	3	1
A	hasImageResource()	0	3	2
A	getWidth()	0	3	1
A	getHeight()	0	3	1
A	resizeByWidth()	0	4	1
A	resizeByHeight()	0	4	1
A	makeDir()	0	4	3
C	__construct()	0	44	11
A	setImageResource()	0	5	1
C	croppedResize()	0	46	7
A	fittedResize()	0	5	2
A	hasGD()	0	5	1
D	resize()	0	30	10
A	rotate()	0	13	3
C	rotatePixelByPixel()	0	31	7
A	crop()	0	13	1
A	resizeRatio()	5	10	4
A	color_web2gd()	3	9	2
C	paddedResize()	0	50	7
B	greyscale()	0	27	6
F	writeTo()	0	38	13
A	onBeforeDelete()	0	8	2

<?php
/**
 * A wrapper class for GD-based images, with lots of manipulation functions.
 * @package framework
 * @subpackage filesystem
 */
class GDBackend extends Object implements Image_Backend {
	protected $gd, $width, $height;
	protected $quality;
	protected $interlace;
	protected $cache, $cacheKey, $manipulation;

	/**
	 * @config
	 * @var integer
	 */
	private static $default_quality = 75;

	/**
	 * @config
	 * @var integer
	 */
	private static $image_interlace = 0;

	/**
	 * Set the default image quality.
	 *
	 * @deprecated 4.0 Use the "GDBackend.default_quality" config setting instead
	 * @param quality int A number from 0 to 100, 100 being the best quality.
	 */
	public static function set_default_quality($quality) {
		Deprecation::notice('4.0', 'Use the "GDBackend.default_quality" config setting instead');
		if(is_numeric($quality) && (int) $quality >= 0 && (int) $quality <= 100) {

This code seems to be duplicated across your project.

			config::inst()->update('GDBackend', 'default_quality', (int) $quality);
		}
	}

	public function __construct($filename = null, $args = array()) {
		// If we're working with image resampling, things could take a while.  Bump up the time-limit
		increase_time_limit_to(300);

		$this->cache = SS_Cache::factory('GDBackend_Manipulations');

		if($filename && is_readable($filename)) {

The expression $filename of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

			$this->cacheKey = md5(implode('_', array($filename, filemtime($filename))));
			$this->manipulation = implode('|', $args);

			$cacheData = unserialize($this->cache->load($this->cacheKey));
			$cacheData = ($cacheData !== false) ? $cacheData : array();

			if ($this->imageAvailable($filename, $this->manipulation)) {
				$cacheData[$this->manipulation] = true;
				$this->cache->save(serialize($cacheData), $this->cacheKey);

				// We use getimagesize instead of extension checking, because sometimes extensions are wrong.
				list($width, $height, $type, $attr) = getimagesize($filename);

The assignment to $width is unused. Consider omitting it like so list($first,,$third).

The assignment to $height is unused. Consider omitting it like so list($first,,$third).

The assignment to $attr is unused. Consider omitting it like so list($first,,$third).

				switch($type) {
					case 1:
						if(function_exists('imagecreatefromgif'))
							$this->setImageResource(imagecreatefromgif($filename));
						break;
					case 2:
						if(function_exists('imagecreatefromjpeg'))
							$this->setImageResource(imagecreatefromjpeg($filename));
						break;
					case 3:
						if(function_exists('imagecreatefrompng')) {
							$img = imagecreatefrompng($filename);
							imagesavealpha($img, true); // save alphablending setting (important)
							$this->setImageResource($img);
						}
						break;
				}
			}
		}

		parent::__construct();

		$this->quality = $this->config()->default_quality;

The property default_quality does not exist on object<Config_ForClass>. Since you implemented __set, maybe consider adding a @property annotation.

		$this->interlace = $this->config()->image_interlace;

The property image_interlace does not exist on object<Config_ForClass>. Since you implemented __set, maybe consider adding a @property annotation.

	}

	public function setImageResource($resource) {
		$this->gd = $resource;
		$this->width = imagesx($resource);
		$this->height = imagesy($resource);
	}

	/**
	 * @deprecated
	 */
	public function setGD($gd) {
		Deprecation::notice('4.0', 'Use GD::setImageResource instead');
		return $this->setImageResource($gd);
	}

	public function getImageResource() {
		return $this->gd;
	}

	/**
	 * @deprecated
	 */
	public function getGD() {
		Deprecation::notice('4.0', 'GD::getImageResource instead');
		return $this->getImageResource();
	}

	/**
	 * @param string $filename
	 * @param string $manipulation
	 * @return boolean
	 */
	public function imageAvailable($filename, $manipulation) {
		return ($this->checkAvailableMemory($filename) && ! $this->failedResample($filename, $manipulation));
	}

	/**
	 * Check if we've got enough memory available for resampling this image. This check is rough,
	 * so it will not catch all images that are too large - it also won't work accurately on large,
	 * animated GIFs as bits per pixel can't be calculated for an animated GIF with a global color
	 * table.
	 *
	 * @param string $filename
	 * @return boolean
	 */
	public function checkAvailableMemory($filename) {
		$limit = translate_memstring(ini_get('memory_limit'));

		if ($limit < 0) return true; // memory_limit == -1

		$imageInfo = getimagesize($filename);

		// bits per channel (rounded up, default to 1)
		$bits = isset($imageInfo['bits']) ? ($imageInfo['bits'] + 7) / 8 : 1;

		// channels (default 4 rgba)
		$channels = isset($imageInfo['channels']) ? $imageInfo['channels'] : 4;

		$bytesPerPixel = $bits * $channels;

		// width * height * bytes per pixel
		$memoryRequired = $imageInfo[0] * $imageInfo[1] * $bytesPerPixel;

		return $memoryRequired + memory_get_usage() < $limit;
	}

	/**
	 * Check if this image has previously crashed GD when attempting to open it - if it's opened
	 * successfully, the manipulation's cache key is removed.
	 *
	 * @param string $filename
	 * @return boolean
	 */
	public function failedResample($filename, $manipulation) {

The parameter $filename is not used and could be removed.

		$cacheData = unserialize($this->cache->load($this->cacheKey));
		return ($cacheData && array_key_exists($manipulation, $cacheData));
	}

	/**
	 * Set the image quality, used when saving JPEGs.
	 */
	public function setQuality($quality) {
		$this->quality = $quality;
	}

	/**
	 * Resize an image to cover the given width/height completely, and crop off any overhanging edges.
	 */
	public function croppedResize($width, $height) {
		if(!$this->gd) return;

		$width = round($width);
		$height = round($height);

		// Check that a resize is actually necessary.
		if ($width == $this->width && $height == $this->height) {
			return $this;
		}

		$newGD = imagecreatetruecolor($width, $height);

		// Preserves transparency between images
		imagealphablending($newGD, false);
		imagesavealpha($newGD, true);

		$destAR = $width / $height;
		if ($this->width > 0 && $this->height > 0 ){
			// We can't divide by zero theres something wrong.

			$srcAR = $this->width / $this->height;

			// Destination narrower than the source
			if($destAR < $srcAR) {
				$srcY = 0;
				$srcHeight = $this->height;

				$srcWidth = round( $this->height * $destAR );
				$srcX = round( ($this->width - $srcWidth) / 2 );

			// Destination shorter than the source
			} else {
				$srcX = 0;
				$srcWidth = $this->width;

				$srcHeight = round( $this->width / $destAR );
				$srcY = round( ($this->height - $srcHeight) / 2 );
			}

			imagecopyresampled($newGD, $this->gd, 0,0, $srcX, $srcY, $width, $height, $srcWidth, $srcHeight);
		}
		$output = clone $this;
		$output->setImageResource($newGD);
		return $output;
	}

	/**
	 * Resizes the image to fit within the given region.
	 * Behaves similarly to paddedResize but without the padding.
	 * @todo This method isn't very efficent
	 */
	public function fittedResize($width, $height) {
		$gd = $this->resizeByHeight($height);
		if($gd->width > $width) $gd = $gd->resizeByWidth($width);
		return $gd;
	}

	/**
	 * hasImageResource
	 *
	 * @return boolean
	 */
	public function hasImageResource() {
		return $this->gd ? true : false;
	}

	/**
	 * @deprecated
	 */
	public function hasGD() {
		Deprecation::notice('4.0', 'GD::hasImageResource instead',
			Deprecation::SCOPE_CLASS);
		return $this->hasImageResource();
	}


	/**
	 * Resize an image, skewing it as necessary.
	 */
	public function resize($width, $height) {
		if(!$this->gd) return;

		if($width < 0 || $height < 0) throw new InvalidArgumentException("Image resizing dimensions cannot be negative");
		if(!$width && !$height) throw new InvalidArgumentException("No dimensions given when resizing image");
		if(!$width) throw new InvalidArgumentException("Width not given when resizing image");
		if(!$height) throw new InvalidArgumentException("Height not given when resizing image");

		//use whole numbers, ensuring that size is at least 1x1
		$width = max(1, round($width));
		$height = max(1, round($height));

		// Check that a resize is actually necessary.
		if ($width == $this->width && $height == $this->height) {
			return $this;
		}


		$newGD = imagecreatetruecolor($width, $height);

		// Preserves transparency between images
		imagealphablending($newGD, false);
		imagesavealpha($newGD, true);

		imagecopyresampled($newGD, $this->gd, 0,0, 0, 0, $width, $height, $this->width, $this->height);

		$output = clone $this;
		$output->setImageResource($newGD);
		return $output;
	}

	/**
	 * Rotates image by given angle.
	 *
	 * @param angle
	 *
	 * @return GD
	*/

	public function rotate($angle) {
		if(!$this->gd) return;

		if(function_exists("imagerotate")) {
			$newGD = imagerotate($this->gd, $angle,0);
		} else {
			//imagerotate is not included in PHP included in Ubuntu
			$newGD = $this->rotatePixelByPixel($angle);
		}
		$output = clone $this;
		$output->setImageResource($newGD);
		return $output;
	}

	/**
	 * Rotates image by given angle. It's slow because makes it pixel by pixel rather than
	 * using built-in function. Used when imagerotate function is not available(i.e. Ubuntu)
	 *
	 * @param angle
	 *
	 * @return GD
	*/

	public function rotatePixelByPixel($angle) {
		$sourceWidth = imagesx($this->gd);
		$sourceHeight = imagesy($this->gd);
		if ($angle == 180) {
			$destWidth = $sourceWidth;
			$destHeight = $sourceHeight;
		} else {
			$destWidth = $sourceHeight;
			$destHeight = $sourceWidth;
		}
		$rotate=imagecreatetruecolor($destWidth,$destHeight);
		imagealphablending($rotate, false);
		for ($x = 0; $x < ($sourceWidth); $x++) {
			for ($y = 0; $y < ($sourceHeight); $y++) {
				$color = imagecolorat($this->gd, $x, $y);
				switch ($angle) {
					case 90:
						imagesetpixel($rotate, $y, $destHeight - $x - 1, $color);
					break;
					case 180:
						imagesetpixel($rotate, $destWidth - $x - 1, $destHeight - $y - 1, $color);
					break;
					case 270:
						imagesetpixel($rotate, $destWidth - $y - 1, $x, $color);
					break;
					default: $rotate = $this->gd;
				};
			}
		}
		return $rotate;
	}


	/**
	 * Crop's part of image.
	 *
	 * @param top y position of left upper corner of crop rectangle
	 * @param left x position of left upper corner of crop rectangle
	 * @param width rectangle width
	 * @param height rectangle height
	 *
	 * @return GD
	*/

	public function crop($top, $left, $width, $height) {
		$newGD = imagecreatetruecolor($width, $height);

		// Preserve alpha channel between images
		imagealphablending($newGD, false);
		imagesavealpha($newGD, true);

		imagecopyresampled($newGD, $this->gd, 0, 0, $left, $top, $width, $height, $width, $height);

		$output = clone $this;
		$output->setImageResource($newGD);
		return $output;
	}

	/**
	 * Method return width of image.
	 *
	 * @return integer width.
	*/
	public function getWidth() {
		return $this->width;
	}

	/**
	 * Method return height of image.
	 *
	 * @return integer height
	*/

	public function getHeight() {
		return $this->height;
	}

	/**
	 * Resize an image by width. Preserves aspect ratio.
	 */
	public function resizeByWidth( $width ) {
		$heightScale = $width / $this->width;
		return $this->resize( $width, $heightScale * $this->height );
	}

	/**
	 * Resize an image by height. Preserves aspect ratio
	 */
	public function resizeByHeight( $height ) {
		$scale = $height / $this->height;
		return $this->resize( $scale * $this->width, $height );
	}

	/**
	 * Resize the image by preserving aspect ratio. By default, it will keep the image inside the maxWidth
	 * and maxHeight. Passing useAsMinimum will make the smaller dimension equal to the maximum corresponding dimension
	 */
	public function resizeRatio( $maxWidth, $maxHeight, $useAsMinimum = false ) {

		$widthRatio = $maxWidth / $this->width;
		$heightRatio = $maxHeight / $this->height;

		if( $widthRatio < $heightRatio )

This code seems to be duplicated across your project.

			return $useAsMinimum ? $this->resizeByHeight( $maxHeight ) : $this->resizeByWidth( $maxWidth );
		else
			return $useAsMinimum ? $this->resizeByWidth( $maxWidth ) : $this->resizeByHeight( $maxHeight );
	}

	public static function color_web2gd($image, $webColor) {
		if(substr($webColor,0,1) == "#") $webColor = substr($webColor,1);
		$r = hexdec(substr($webColor,0,2));
		$g = hexdec(substr($webColor,2,2));
		$b = hexdec(substr($webColor,4,2));

		return imagecolorallocate($image, $r, $g, $b);

	}

	/**
	 * Resize to fit fully within the given box, without resizing.  Extra space left around
	 * the image will be padded with the background color.
	 * @param width
	 * @param height
	 * @param backgroundColour
	 */
	public function paddedResize($width, $height, $backgroundColor = "FFFFFF") {
		if(!$this->gd) return;
		$width = round($width);
		$height = round($height);

		// Check that a resize is actually necessary.
		if ($width == $this->width && $height == $this->height) {
			return $this;
		}

		$newGD = imagecreatetruecolor($width, $height);

		// Preserves transparency between images
		imagealphablending($newGD, false);
		imagesavealpha($newGD, true);

		$bg = GD::color_web2gd($newGD, $backgroundColor);
		imagefilledrectangle($newGD, 0, 0, $width, $height, $bg);

		$destAR = $width / $height;
		if ($this->width > 0 && $this->height > 0) {
			// We can't divide by zero theres something wrong.

			$srcAR = $this->width / $this->height;

			// Destination narrower than the source
			if($destAR > $srcAR) {
				$destY = 0;
				$destHeight = $height;

				$destWidth = round( $height * $srcAR );
				$destX = round( ($width - $destWidth) / 2 );

			// Destination shorter than the source
			} else {
				$destX = 0;
				$destWidth = $width;

				$destHeight = round( $width / $srcAR );
				$destY = round( ($height - $destHeight) / 2 );
			}

			imagecopyresampled($newGD, $this->gd,
				$destX, $destY, 0, 0,
				$destWidth, $destHeight, $this->width, $this->height);
		}
		$output = clone $this;
		$output->setImageResource($newGD);
		return $output;
	}

	/**
	 * Make the image greyscale
	 * $rv = red value, defaults to 38
	 * $gv = green value, defaults to 36
	 * $bv = blue value, defaults to 26
	 * Based (more or less entirely, with changes for readability) on code from
	 * http://www.teckis.com/scriptix/thumbnails/teck.html
	 */
	public function greyscale($rv=38, $gv=36, $bv=26) {
		$width = $this->width;
		$height = $this->height;
		$newGD = imagecreatetruecolor($this->width, $this->height);

		// Preserves transparency between images
		imagealphablending($newGD, false);
		imagesavealpha($newGD, true);

		$rt = $rv + $bv + $gv;
		$rr = ($rv == 0) ? 0 : 1/($rt/$rv);
		$br = ($bv == 0) ? 0 : 1/($rt/$bv);
		$gr = ($gv == 0) ? 0 : 1/($rt/$gv);
		for($dy = 0; $dy < $height; $dy++) {
			for($dx = 0; $dx < $width; $dx++) {
				$pxrgb = imagecolorat($this->gd, $dx, $dy);
				$heightgb = ImageColorsforIndex($this->gd, $pxrgb);
				$newcol = ($rr*$heightgb['red']) + ($br*$heightgb['blue']) + ($gr*$heightgb['green']);
				$setcol = ImageColorAllocateAlpha($newGD, $newcol, $newcol, $newcol, $heightgb['alpha']);
				imagesetpixel($newGD, $dx, $dy, $setcol);
			}
		}

		$output = clone $this;
		$output->setImageResource($newGD);
		return $output;
	}

	public function makeDir($dirname) {
		if(!file_exists(dirname($dirname))) $this->makeDir(dirname($dirname));
		if(!file_exists($dirname)) mkdir($dirname, Config::inst()->get('Filesystem', 'folder_create_mask'));
	}

	public function writeTo($filename) {
		$this->makeDir(dirname($filename));

		if($filename) {
			if(file_exists($filename)) list($width, $height, $type, $attr) = getimagesize($filename);

The assignment to $width is unused. Consider omitting it like so list($first,,$third).

The assignment to $height is unused. Consider omitting it like so list($first,,$third).

The assignment to $attr is unused. Consider omitting it like so list($first,,$third).

			if(file_exists($filename)) unlink($filename);

			$ext = strtolower(substr($filename, strrpos($filename,'.')+1));
			if(!isset($type)) switch($ext) {
				case "gif": $type = IMAGETYPE_GIF; break;
				case "jpeg": case "jpg": case "jpe": $type = IMAGETYPE_JPEG; break;
				default: $type = IMAGETYPE_PNG; break;
			}

			// if $this->interlace != 0, the output image will be interlaced
			imageinterlace ($this->gd, $this->interlace);

			// if the extension does not exist, the file will not be created!

			switch($type) {
				case IMAGETYPE_GIF: imagegif($this->gd, $filename); break;
				case IMAGETYPE_JPEG: imagejpeg($this->gd, $filename, $this->quality); break;

				// case 3, and everything else
				default:
					// Save them as 8-bit images
					// imagetruecolortopalette($this->gd, false, 256);
					imagepng($this->gd, $filename); break;
			}
			if(file_exists($filename)) @chmod($filename,0664);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

			// Remove image manipulation from cache now that it's complete
			$cacheData = unserialize($this->cache->load($this->cacheKey));
			if(isset($cacheData[$this->manipulation])) unset($cacheData[$this->manipulation]);
			$this->cache->save(serialize($cacheData), $this->cacheKey);
		}
	}

	/**
	 * @param Image $frontend
	 * @return void
	 */
	public function onBeforeDelete($frontend) {
		$file = Director::baseFolder() . "/" . $frontend->Filename;

		if (file_exists($file)) {
			$key = md5(implode('_', array($file, filemtime($file))));
			$this->cache->remove($key);
		}
	}

}

/**
 * This class is maintained for backwards-compatibility only. Please use the {@link GDBackend} class instead.
 *
 * @package framework
 * @subpackage filesystem
 */
class GD extends GDBackend {

	/**
	 * @deprecated 4.0 Use the "GDBackend.default_quality" config setting instead
	 */
	public static function set_default_quality($quality) {
		Deprecation::notice('4.0', 'Use the "GDBackend.default_quality" config setting instead');
		GDBackend::set_default_quality($quality);

The method GDBackend::set_default_quality() has been deprecated with message: 4.0 Use the "GDBackend.default_quality" config setting instead

	}
}