RequestProcessor::preRequest() - Code Metrics - Inspection of "FIX: Rename Controller.ss default template." - sminnee/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — namespace-model ( 32fe71...476d0e )

by Sam

created 2016-05-03 10:00 UTC

RequestProcessor::preRequest() A

↳ Parent: RequestProcessor

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Metric	Value
cc	3
eloc	5
nc	3
nop	3
dl	8
loc	8
rs	9.4285

<?php

namespace SilverStripe\Control;

use SilverStripe\Model\DataModel;


use SilverStripe\Control\HTTPRequest;
use SilverStripe\Control\HTTPResponse;



/**
 * Represents a request processer that delegates pre and post request handling to nested request filters
 *
 * @package framework
 * @subpackage control
 */
class RequestProcessor implements RequestFilter {

	/**
	 * List of currently assigned request filters
	 *
	 * @var array
	 */
	private $filters = array();

	public function __construct($filters = array()) {
		$this->filters = $filters;
	}

	/**
	 * Assign a list of request filters
	 *
	 * @param array $filters
	 */
	public function setFilters($filters) {
		$this->filters = $filters;
	}

	public function preRequest(HTTPRequest $request, Session $session, DataModel $model) {

		foreach ($this->filters as $filter) {
			$res = $filter->preRequest($request, $session, $model);
			if ($res === false) {
				return false;
			}
		}
	}

	public function postRequest(HTTPRequest $request, HTTPResponse $response, DataModel $model) {

		foreach ($this->filters as $filter) {
			$res = $filter->postRequest($request, $response, $model);
			if ($res === false) {
				return false;
			}
		}
	}
}


1		<?php
2
3		namespace SilverStripe\Control;
4
5		use SilverStripe\Model\DataModel;
6
7
8		use SilverStripe\Control\HTTPRequest;
9		use SilverStripe\Control\HTTPResponse;
10
11
12
13		/**
14		* Represents a request processer that delegates pre and post request handling to nested request filters
15		*
16		* @package framework
17		* @subpackage control
18		*/
19		class RequestProcessor implements RequestFilter {
20
21		/**
22		* List of currently assigned request filters
23		*
24		* @var array
25		*/
26		private $filters = array();
27
28		public function __construct($filters = array()) {
29		$this->filters = $filters;
30		}
31
32		/**
33		* Assign a list of request filters
34		*
35		* @param array $filters
36		*/
37		public function setFilters($filters) {
38		$this->filters = $filters;
39		}
40
41	View Code Duplication	public function preRequest(HTTPRequest $request, Session $session, DataModel $model) {
		0 ignored issues – show Duplication introduced 2016-05-03 10:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		foreach ($this->filters as $filter) {
43		$res = $filter->preRequest($request, $session, $model);
44		if ($res === false) {
45		return false;
46		}
47		}
48		}
49
50	View Code Duplication	public function postRequest(HTTPRequest $request, HTTPResponse $response, DataModel $model) {
		0 ignored issues – show Duplication introduced 2016-05-03 10:08 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
51		foreach ($this->filters as $filter) {
52		$res = $filter->postRequest($request, $response, $model);
53		if ($res === false) {
54		return false;
55		}
56		}
57		}
58		}
59

sminnee / silverstripe-framework

Push — namespace-model ( 32fe71...476d0e )

RequestProcessor::preRequest() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like