sminnee / silverstripe-framework

tests/php/Core/Manifest/fixtures/namespaced_classmanifest/module/classes/ClassI.php

Unused Use Statements +1 added lines, -3 removed lines

@@ -6,11 +6,9 @@
 /** @skipUpgrade */
 use SilverStripe\Admin\ModelAdmin;
 /** @skipUpgrade */
-use SilverStripe\Control\Controller  as  Cont ;
 /** @skipUpgrade */
-use SilverStripe\Control\HTTPRequest as Request, SilverStripe\Control\HTTPResponse as Response, SilverStripe\Security\PermissionProvider as P;
+use SilverStripe\Security\PermissionProvider as P;
 /** @skipUpgrade */
-use silverstripe\test\ClassA;
 /** @skipUpgrade */
 use \SilverStripe\Core\ClassInfo;
 

tests/php/Forms/GridField/GridFieldEditButtonTest.php

Unused Use Statements -2 removed lines

@@ -8,10 +8,8 @@
 use SilverStripe\Forms\Tests\GridField\GridFieldTest\Team;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataList;
-use SilverStripe\Security\Member;
 use SilverStripe\Dev\CSSContentParser;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Control\Controller;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\Form;
 use SilverStripe\Forms\GridField\GridFieldConfig;

src/Core/Injector/Injector.php

Doc Comments +3 added lines, -3 removed lines

@@ -372,7 +372,7 @@ 
      *
      * @param string $property
      *                the name of the property
-     * @param object $object
+     * @param string $object
      *                the object to be set
      * @return $this
      */
@@ -467,7 +467,7 @@ 
      *              The name of the service to update the definition for
      * @param string $property
      *              The name of the property to update.
-     * @param mixed $value
+     * @param string $value
      *              The value to set
      * @param boolean $append
      *              Whether to append (the default) when the property is an array
@@ -789,7 +789,7 @@ 
     /**
      * @deprecated 4.0.0:5.0.0 Use Injector::has() instead
      * @param $name
-     * @return string
+     * @return boolean
      */
     public function hasService($name)
     {

src/ORM/Connect/DBSchemaManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -331,7 +331,7 @@ 
      *   - array('fields' => array('A','B','C'), 'type' => 'index/unique/fulltext'): This gives you full
      *     control over the index.
      * @param boolean $hasAutoIncPK A flag indicating that the primary key on this table is an autoincrement type
-     * @param array $options Create table options (ENGINE, etc.)
+     * @param string|null $options Create table options (ENGINE, etc.)
      * @param array|bool $extensions List of extensions
      */
     public function requireTable(
@@ -595,7 +595,7 @@ 
      *
      * @param string $table The table name.
      * @param string $field The field name.
-     * @param array|string $spec The field specification. If passed in array syntax, the specific database
+     * @param string $spec The field specification. If passed in array syntax, the specific database
      *  driver takes care of the ALTER TABLE syntax. If passed as a string, its assumed to
      *  be prepared as a direct SQL framgment ready for insertion into ALTER TABLE. In this case you'll
      *  need to take care of database abstraction in your DBField subclass.

src/ORM/DataObjectSchema.php

Doc Comments +1 added lines, -1 removed lines

@@ -488,7 +488,7 @@
      * Cache all indexes for the given class.
      * Will do nothing if already cached
      *
-     * @param $class
+     * @param string $class
      */
     protected function cacheDatabaseIndexes($class)
     {

src/ORM/Search/FulltextSearchable.php

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use SilverStripe\Assets\File;
 use SilverStripe\CMS\Model\SiteTree;
-use SilverStripe\Core\Config\Config;
 use SilverStripe\CMS\Controllers\ContentController;
-use SilverStripe\ORM\Connect\MySQLSchemaManager;
 use SilverStripe\ORM\DataExtension;
 use Exception;
 

src/Security/MemberAuthenticator/LogoutHandler.php

Unused Use Statements -3 removed lines

@@ -2,13 +2,10 @@
 
 namespace SilverStripe\Security\MemberAuthenticator;
 
-use SilverStripe\Control\Cookie;
 use SilverStripe\Control\RequestHandler;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\Security\IdentityStore;
 use SilverStripe\Security\Member;
-use SilverStripe\Security\RememberLoginHash;
 use SilverStripe\Security\Security;
 
 /**

src/Dev/FunctionalTest.php

Doc Comments +5 added lines, -2 removed lines

@@ -230,7 +230,7 @@ 
      * Find an attribute in a SimpleXMLElement object by name.
      * @param SimpleXMLElement $object
      * @param string $attribute Name of attribute to find
-     * @return SimpleXMLElement object of the attribute
+     * @return boolean object of the attribute
      */
     public function findAttribute($object, $attribute)
     {
@@ -264,7 +264,7 @@ 
      * Note:   characters are stripped from the content; make sure that your assertions take this into account.
      *
      * @param string $selector A basic CSS selector, e.g. 'li.jobs h3'
-     * @param array|string $expectedMatches The content of at least one of the matched tags
+     * @param string[] $expectedMatches The content of at least one of the matched tags
      * @param string $message
      * @throws PHPUnit_Framework_AssertionFailedError
      */
@@ -424,6 +424,9 @@ 
         Security::setCurrentUser(null);
     }
 
+    /**
+     * @param DataObject|null $member
+     */
     public function logIn($member)
     {
         Security::setCurrentUser($member);

src/Security/BasicAuth.php

Unused Use Statements -2 removed lines

@@ -10,8 +10,6 @@
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Config\Configurable;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Core\Injector\Injector;
-
 use SilverStripe\Security\MemberAuthenticator\MemberAuthenticator;
 
 /**