sminnee / silverstripe-framework

src/View/SSViewer_DataPresenter.php

Doc Comments +7 added lines

@@ -33,6 +33,10 @@ 
      */
     protected $underlay;
 
+    /**
+     * @param ViewableData $item
+     * @param ViewableData $inheritedScope
+     */
     public function __construct($item, $overlay = null, $underlay = null, $inheritedScope = null)
     {
         parent::__construct($item, $inheritedScope);
@@ -65,6 +69,9 @@ 
         $this->underlay = $underlay ? $underlay : array();
     }
 
+    /**
+     * @param string $variableMethod
+     */
     protected function createCallableArray(&$extraArray, $interfaceToQuery, $variableMethod, $createObject = false)
     {
         $implementers = ClassInfo::implementorsOf($interfaceToQuery);

src/Forms/FormField.php

Doc Comments +2 added lines, -2 removed lines

@@ -1222,7 +1222,7 @@ 
     /**
      * @param FormTransformation $transformation
      *
-     * @return mixed
+     * @return FormField
      */
     public function transform(FormTransformation $transformation)
     {
@@ -1333,7 +1333,7 @@ 
      * This function is used by the template processor. If you refer to a field as a $ variable, it
      * will return the $Field value.
      *
-     * @return string
+     * @return DBHTMLText
      */
     public function forTemplate()
     {

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Control\RequestHandler;
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Convert;
-use SilverStripe\Dev\Deprecation;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DataObjectInterface;
 use SilverStripe\ORM\FieldType\DBField;

src/Forms/HTMLEditor/HTMLEditorField.php

Doc Comments +5 added lines, -2 removed lines

@@ -79,7 +79,7 @@ 
     /**
      * Assign a new configuration instance or identifier
      *
-     * @param string|HTMLEditorConfig $config
+     * @param string $config
      * @return $this
      */
     public function setEditorConfig($config)
@@ -94,7 +94,7 @@ 
      *
      * @param string $name The internal field name, passed to forms.
      * @param string $title The human-readable field label.
-     * @param mixed $value The value of the field.
+     * @param integer $value The value of the field.
      * @param string $config HTMLEditorConfig identifier to be used. Default to the active one.
      */
     public function __construct($name, $title = null, $value = '', $config = null)
@@ -142,6 +142,9 @@ 
         $record->{$this->name} = $htmlValue->getContent();
     }
 
+    /**
+     * @param string|null $value
+     */
     public function setValue($value, $data = null)
     {
         // Regenerate links prior to preview, so that the editor can see them.

src/Forms/MoneyField.php

Doc Comments +9 added lines, -2 removed lines

@@ -57,6 +57,10 @@ 
         return $this->fieldAmount;
     }
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title = null, $value = "")
     {
         $this->setName($name);
@@ -210,7 +214,7 @@ 
      *
      * (see @link MoneyFieldTest_CustomSetter_Object for more information)
      *
-     * @param DataObjectInterface|Object $dataObject
+     * @param DataObjectInterface $dataObject
      */
     public function saveInto(DataObjectInterface $dataObject)
     {
@@ -236,6 +240,9 @@ 
         return $clone;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);
@@ -259,7 +266,7 @@ 
     /**
      * Set list of currencies. Currencies should be in the 3-letter ISO 4217 currency code.
      *
-     * @param array $currencies
+     * @param string[] $currencies
      * @return $this
      */
     public function setAllowedCurrencies($currencies)

src/Forms/NumericField.php

Doc Comments +1 added lines, -1 removed lines

@@ -287,7 +287,7 @@
      * Get number of digits to show to the right of the decimal point.
      * 0 for integer, any number for floating point, or null to flexible
      *
-     * @return int|null
+     * @return string
      */
     public function getScale()
     {

src/Forms/SelectionGroup_Item.php

Doc Comments +6 added lines

@@ -37,6 +37,9 @@ 
         return $this->title;
     }
 
+    /**
+     * @param string $title
+     */
     function setTitle($title)
     {
         $this->title = $title;
@@ -48,6 +51,9 @@ 
         return $this->value;
     }
 
+    /**
+     * @param string $Value
+     */
     function setValue($Value, $data = null)
     {
         $this->value = $Value;

src/ORM/FieldType/DBDate.php

Doc Comments +2 added lines, -2 removed lines

@@ -245,7 +245,7 @@ 
      * Return a date formatted as per a CMS user's settings.
      *
      * @param Member $member
-     * @return boolean | string A date formatted as per user-defined settings.
+     * @return null|string | string A date formatted as per user-defined settings.
      */
     public function FormatFromSettings($member = null)
     {
@@ -553,7 +553,7 @@ 
      * Attempt to split date string into year, month, day, and timestamp components.
      *
      * @param string $value
-     * @return array
+     * @return string[]
      */
     protected function explodeDateString($value)
     {

src/ORM/FieldType/DBTime.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
      */
     const ISO_TIME = 'HH:mm:ss';
 
+    /**
+     * @param string $value
+     */
     public function setValue($value, $record = null, $markChanged = true)
     {
         $value = $this->parseTime($value);

tests/php/Forms/NumericFieldTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\Forms\NumericField;
 use SilverStripe\Forms\RequiredFields;
-use SilverStripe\i18n\i18n;
 
 class NumericFieldTest extends SapphireTest
 {