sminnee / silverstripe-framework

src/Forms/InlineFormAction.php

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace SilverStripe\Forms;
 
-use SilverStripe\View\Requirements;
-
 /**
  * Render a button that will submit the form its contained in through ajax.
  *

src/Forms/ListboxField.php

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
 	}
 
 	/**
-	 * @return string
+	 * @return \SilverStripe\ORM\FieldType\DBHTMLText
 	 */
 	public function InternallyLabelledField() {
 		Deprecation::notice('4.0', 'Please use ->setValue() instead');

src/Forms/LookupField.php

Doc Comments +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
 	}
 
 	/**
-	 * @return string
+	 * @return \SilverStripe\ORM\FieldType\DBHTMLText
 	 */
 	public function InternallyLabelledField() {
 		Deprecation::notice('4.0', 'Please use ->setValue() instead');

src/Forms/MemberDatetimeOptionsetField.php

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataObjectInterface;
-use SilverStripe\View\Requirements;
 use InvalidArgumentException;
 
 /**

src/Forms/MoneyField.php

Doc Comments +11 added lines, -1 removed lines

@@ -57,6 +57,10 @@ 
 		return $this->fieldAmount;
 	}
 
+	/**
+	 * @param string $name
+	 * @param string $title
+	 */
 	public function __construct($name, $title = null, $value = "") {
 		$this->setName($name);
 
@@ -129,7 +133,7 @@ 
 	 *
 	 * (see @link MoneyFieldTest_CustomSetter_Object for more information)
 	 *
-	 * @param DataObjectInterface|Object $dataObject
+	 * @param DataObjectInterface $dataObject
 	 */
 	public function saveInto(DataObjectInterface $dataObject) {
 		$fieldName = $this->getName();
@@ -158,6 +162,9 @@ 
 		return $clone;
 	}
 
+	/**
+	 * @param boolean $bool
+	 */
 	public function setReadonly($bool) {
 		parent::setReadonly($bool);
 
@@ -198,6 +205,9 @@ 
 		return $this->allowedCurrencies;
 	}
 
+	/**
+	 * @param string $locale
+	 */
 	public function setLocale($locale) {
 		$this->_locale = $locale;
 		return $this;

src/Forms/NullableField.php

Doc Comments +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
 	/**
 	 * Set the label used for the Is Null checkbox.
 	 *
-	 * @param $isNulLabel string
+	 * @param string $isNulLabel string
 	 *
 	 * @return $this
 	 */
@@ -128,7 +128,7 @@ 
 	/**
 	 * Value is sometimes an array, and sometimes a single value, so we need to handle both cases
 	 *
-	 * @param mixed $value
+	 * @param string|null $value
 	 * @param null|array $data
 	 *
 	 * @return $this

src/Forms/PrintableTransformation_TabSet.php

Doc Comments +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 class PrintableTransformation_TabSet extends TabSet
 {
 	/**
-	 * @param array $tabs
+	 * @param FieldList $tabs
 	 */
 	public function __construct($tabs)
 	{

src/Forms/ReadonlyField.php

Doc Comments +1 added lines, -1 removed lines

@@ -95,7 +95,7 @@
 	 * If $dontEscape is false the returned value will be safely encoded,
 	 * but should not be escaped by the frontend.
 	 *
-	 * @return mixed|string
+	 * @return string
 	 */
 	public function Value() {
 		// Get raw value

src/Forms/SelectionGroup_Item.php

Doc Comments +6 added lines

@@ -154,6 +154,9 @@ 
 		return $this->title;
 	}
 
+	/**
+	 * @param string $title
+	 */
 	function setTitle($title) {
 		$this->title = $title;
 		return $this;
@@ -163,6 +166,9 @@ 
 		return $this->value;
 	}
 
+	/**
+	 * @param string $Value
+	 */
 	function setValue($Value) {
 		$this->value = $Value;
 		return $this;