sminnee / silverstripe-framework

tests/php/Security/MemberTest.php

Unused Use Statements -1 removed lines

@@ -20,7 +20,6 @@
 use SilverStripe\Security\RememberLoginHash;
 use SilverStripe\Security\Member_Validator;
 use SilverStripe\Security\Tests\MemberTest\FieldsExtension;
-use SilverStripe\Control\HTTPRequest;
 
 class MemberTest extends FunctionalTest
 {

src/Security/MemberAuthenticator/ChangePasswordHandler.php

Doc Comments +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
     /**
      * Return a link to this request handler.
      * The link returned is supplied in the constructor
-     * @param null $action
+     * @param string $action
      * @return string
      */
     public function link($action = null)

src/Security/Security.php

Doc Comments +5 added lines, -4 removed lines

@@ -226,7 +226,7 @@ 
     protected static $currentUser;
 
     /**
-     * @return array
+     * @return Authenticator[]
      */
     public static function getAuthenticators()
     {
@@ -291,7 +291,7 @@ 
      * Get all registered authenticators
      *
      * @param int $service The type of service that is requested
-     * @return array Return an array of Authenticator objects
+     * @return Authenticator[] Return an array of Authenticator objects
      */
     public function getApplicableAuthenticators($service = Authenticator::LOGIN)
     {
@@ -622,7 +622,7 @@ 
      * Combine the given forms into a formset with a tabbed interface
      *
      * @param $forms
-     * @return string
+     * @return DBHTMLText
      */
     protected function generateLoginFormSet($forms)
     {
@@ -1206,6 +1206,7 @@ 
 
     /**
      * For the database_is_ready call to return a certain value - used for testing
+     * @param boolean $isReady
      */
     public static function force_database_is_ready($isReady)
     {
@@ -1226,7 +1227,7 @@ 
     /**
      * Set to true to ignore access to disallowed actions, rather than returning permission failure
      * Note that this is just a flag that other code needs to check with Security::ignore_disallowed_actions()
-     * @param $flag True or false
+     * @param boolean $flag True or false
      */
     public static function set_ignore_disallowed_actions($flag)
     {

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 use SilverStripe\View\ArrayData;
 use SilverStripe\View\SSViewer;
 use SilverStripe\View\TemplateGlobalProvider;
-use Subsite;
 
 /**
  * Implements a basic security model

src/Security/MemberAuthenticator/MemberAuthenticator.php

Doc Comments +1 added lines

@@ -53,6 +53,7 @@
      * @param array $data Form submitted data
      * @param ValidationResult $result
      * @param Member|null This third parameter is used in the CMSAuthenticator(s)
+     * @param Member $member
      * @return Member Found member, regardless of successful login
      */
     protected function authenticateMember($data, &$result = null, $member = null)