TempPath.php ➔ getTempParentFolder() - Code Metrics - Inspection of "Changes not picked up by the auto-converter." - sminnee/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — namespace-model ( c67c40...018a87 )

by Sam

created 2016-05-02 23:54 UTC

TempPath.php ➔ getTempParentFolder() C

↳ Parent: Project

Complexity

Conditions	10
Paths	40

Size

Total Lines	51
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	10
eloc	31
nc	40
nop	1
dl	0
loc	51
rs	6

How to fix Long Method Complexity

<?php
/**
 * Returns the temporary folder path that silverstripe should use for its cache files.
 *
 * @package framework
 * @subpackage core
 *
 * @param $base The base path to use for determining the temporary path
 * @return string Path to temp
 */
function getTempFolder($base = null) {
	$parent = getTempParentFolder($base);

	// The actual temp folder is a subfolder of getTempParentFolder(), named by username
	$subfolder = $parent . DIRECTORY_SEPARATOR . getTempFolderUsername();

	if(!@file_exists($subfolder)) {
		mkdir($subfolder);
	}

	return $subfolder;
}

/**
 * Returns as best a representation of the current username as we can glean.
 *
 * @package framework
 * @subpackage core
 */
function getTempFolderUsername() {
	$user = getenv('APACHE_RUN_USER');
	if(!$user) $user = getenv('USER');
	if(!$user) $user = getenv('USERNAME');
	if(!$user && function_exists('posix_getuid')) {
		$userDetails = posix_getpwuid(posix_getuid());
		$user = $userDetails['name'];
	}
	if(!$user) $user = 'unknown';
	$user = preg_replace('/[^A-Za-z0-9_\-]/', '', $user);
	return $user;
}

/**
 * Return the parent folder of the temp folder.
 * The temp folder will be a subfolder of this, named by username.
 * This structure prevents permission problems.
 *
 * @package framework
 * @subpackage core
 */
function getTempParentFolder($base = null) {
	if(!$base && defined('BASE_PATH')) $base = BASE_PATH;

	$worked = true;

	// first, try finding a silverstripe-cache dir built off the base path
	$tempPath = $base . DIRECTORY_SEPARATOR . 'silverstripe-cache';
	if(@file_exists($tempPath)) {
		if((fileperms($tempPath) & 0777) != 0777) {
			@chmod($tempPath, 0777);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		}
		return $tempPath;
	}

	// failing the above, try finding a namespaced silverstripe-cache dir in the system temp
	$tempPath = sys_get_temp_dir() . DIRECTORY_SEPARATOR .
		'silverstripe-cache-php' . preg_replace('/[^\w-\.+]+/', '-', PHP_VERSION) .
		str_replace(array(' ', '/', ':', '\\'), '-', $base);
	if(!@file_exists($tempPath)) {
		$oldUMask = umask(0);
		$worked = @mkdir($tempPath, 0777);
		umask($oldUMask);

	// if the folder already exists, correct perms
	} else {
		if((fileperms($tempPath) & 0777) != 0777) {
			@chmod($tempPath, 0777);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		}
	}

	// failing to use the system path, attempt to create a local silverstripe-cache dir
	if(!$worked) {
		$worked = true;
		$tempPath = $base . DIRECTORY_SEPARATOR . 'silverstripe-cache';
		if(!@file_exists($tempPath)) {
			$oldUMask = umask(0);
			$worked = @mkdir($tempPath, 0777);
			umask($oldUMask);
		}
	}

	if(!$worked) {
		throw new Exception(
			'Permission problem gaining access to a temp folder. ' .
			'Please create a folder named silverstripe-cache in the base folder ' .
			'of the installation and ensure it has the correct permissions'
		);
	}

	return $tempPath;
}


1			<?php
2			/**
3			* Returns the temporary folder path that silverstripe should use for its cache files.
4			*
5			* @package framework
6			* @subpackage core
7			*
8			* @param $base The base path to use for determining the temporary path
9			* @return string Path to temp
10			*/
11			function getTempFolder($base = null) {
12			$parent = getTempParentFolder($base);
13
14			// The actual temp folder is a subfolder of getTempParentFolder(), named by username
15			$subfolder = $parent . DIRECTORY_SEPARATOR . getTempFolderUsername();
16
17			if(!@file_exists($subfolder)) {
18			mkdir($subfolder);
19			}
20
21			return $subfolder;
22			}
23
24			/**
25			* Returns as best a representation of the current username as we can glean.
26			*
27			* @package framework
28			* @subpackage core
29			*/
30			function getTempFolderUsername() {
31			$user = getenv('APACHE_RUN_USER');
32			if(!$user) $user = getenv('USER');
33			if(!$user) $user = getenv('USERNAME');
34			if(!$user && function_exists('posix_getuid')) {
35			$userDetails = posix_getpwuid(posix_getuid());
36			$user = $userDetails['name'];
37			}
38			if(!$user) $user = 'unknown';
39			$user = preg_replace('/[^A-Za-z0-9_\-]/', '', $user);
40			return $user;
41			}
42
43			/**
44			* Return the parent folder of the temp folder.
45			* The temp folder will be a subfolder of this, named by username.
46			* This structure prevents permission problems.
47			*
48			* @package framework
49			* @subpackage core
50			*/
51			function getTempParentFolder($base = null) {
52			if(!$base && defined('BASE_PATH')) $base = BASE_PATH;
53
54			$worked = true;
55
56			// first, try finding a silverstripe-cache dir built off the base path
57			$tempPath = $base . DIRECTORY_SEPARATOR . 'silverstripe-cache';
58			if(@file_exists($tempPath)) {
59			if((fileperms($tempPath) & 0777) != 0777) {
60			@chmod($tempPath, 0777);
			0 ignored issues – show Security Best Practice introduced 2015-12-18 04:35 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
61			}
62			return $tempPath;
63			}
64
65			// failing the above, try finding a namespaced silverstripe-cache dir in the system temp
66			$tempPath = sys_get_temp_dir() . DIRECTORY_SEPARATOR .
67			'silverstripe-cache-php' . preg_replace('/[^\w-\.+]+/', '-', PHP_VERSION) .
68			str_replace(array(' ', '/', ':', '\\'), '-', $base);
69			if(!@file_exists($tempPath)) {
70			$oldUMask = umask(0);
71			$worked = @mkdir($tempPath, 0777);
72			umask($oldUMask);
73
74			// if the folder already exists, correct perms
75			} else {
76			if((fileperms($tempPath) & 0777) != 0777) {
77			@chmod($tempPath, 0777);
			0 ignored issues – show Security Best Practice introduced 2015-12-18 04:35 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
78			}
79			}
80
81			// failing to use the system path, attempt to create a local silverstripe-cache dir
82			if(!$worked) {
83			$worked = true;
84			$tempPath = $base . DIRECTORY_SEPARATOR . 'silverstripe-cache';
85			if(!@file_exists($tempPath)) {
86			$oldUMask = umask(0);
87			$worked = @mkdir($tempPath, 0777);
88			umask($oldUMask);
89			}
90			}
91
92			if(!$worked) {
93			throw new Exception(
94			'Permission problem gaining access to a temp folder. ' .
95			'Please create a folder named silverstripe-cache in the base folder ' .
96			'of the installation and ensure it has the correct permissions'
97			);
98			}
99
100			return $tempPath;
101			}
102

sminnee / silverstripe-framework

Push — namespace-model ( c67c40...018a87 )

TempPath.php ➔ getTempParentFolder() C

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like