DatetimeFieldTest::testConstructorWithLocalizedDateSetsNullValue() - Code Metrics - Inspection of "Some method re-ordering. Initial grouping of metho..." - sminnee/silverstripe-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — authenticator-refactor ( fcc98b...4aec3f )

by Sam

created 2017-04-29 23:21 UTC

testConstructorWithLocalizedDateSetsNullValue() A

↳ Parent: DatetimeFieldTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	0
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0

<?php

namespace SilverStripe\Forms\Tests;

use SilverStripe\Dev\SapphireTest;
use SilverStripe\Control\Controller;
use SilverStripe\Forms\DatetimeField;
use SilverStripe\Forms\RequiredFields;
use SilverStripe\Forms\DateField;
use SilverStripe\Forms\Tests\DatetimeFieldTest\Model;
use SilverStripe\Forms\TimeField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\Form;
use SilverStripe\i18n\i18n;
use SilverStripe\ORM\FieldType\DBDatetime;

class DatetimeFieldTest extends SapphireTest
{
    protected $timezone = null;

    protected function setUp()
    {
        parent::setUp();
        i18n::set_locale('en_NZ');
        $this->timezone = date_default_timezone_get();
    }

    protected function tearDown()
    {
        date_default_timezone_set($this->timezone);
        parent::tearDown(); // TODO: Change the autogenerated stub
    }

    public function testFormSaveInto()

    {
        $dateTimeField = new DatetimeField('MyDatetime');
        $form = $this->getMockForm();
        $form->Fields()->push($dateTimeField);

        $dateTimeField->setSubmittedValue('2003-03-29T23:59:38');
        $validator = new RequiredFields();
        $this->assertTrue($dateTimeField->validate($validator));
        $m = new Model();
        $form->saveInto($m);
        $this->assertEquals('2003-03-29 23:59:38', $m->MyDatetime);
    }

    public function testFormSaveIntoLocalised()

    {
        $dateTimeField = new DatetimeField('MyDatetime');
        $dateTimeField
            ->setHTML5(false)
            ->setLocale('en_NZ');

        $form = $this->getMockForm();
        $form->Fields()->push($dateTimeField);

        // en_NZ standard format
        $dateTimeField->setSubmittedValue('29/03/2003 11:59:38 pm');
        $validator = new RequiredFields();
        $this->assertTrue($dateTimeField->validate($validator));
        $m = new Model();
        $form->saveInto($m);
        $this->assertEquals('2003-03-29 23:59:38', $m->MyDatetime);
    }

    public function testDataValue()

    {
        $f = new DatetimeField('Datetime');
        $this->assertEquals(null, $f->dataValue(), 'Empty field');

        $f = new DatetimeField('Datetime', null, '2003-03-29 23:59:38');
        $this->assertEquals('2003-03-29 23:59:38', $f->dataValue(), 'From date/time string');
    }

    public function testDataValueWithTimezone()
    {
        // Berlin and Auckland have 12h time difference in northern hemisphere winter
        date_default_timezone_set('Europe/Berlin');

        $f = new DatetimeField('Datetime');
        $f->setTimezone('Pacific/Auckland');
        $f->setSubmittedValue('2003-01-30T23:59:38'); // frontend timezone (Auckland)
        $this->assertEquals('2003-01-30 11:59:38', $f->dataValue()); // server timezone (Berlin)
    }

    public function testConstructorWithoutArgs()
    {
        $f = new DatetimeField('Datetime');
        $this->assertEquals($f->dataValue(), null);
    }

    public function testConstructorWithLocalizedDateSetsNullValue()
    {
        $f = new DatetimeField('Datetime', 'Datetime', '29/03/2003 23:59:38');
        $this->assertNull($f->Value());
    }

    public function testConstructorWithIsoDate()
    {
        // used by Form->loadDataFrom()
        $f = new DatetimeField('Datetime', 'Datetime', '2003-03-29 23:59:38');
        $this->assertEquals($f->dataValue(), '2003-03-29 23:59:38');
    }

    public function testSetValueWithDateTimeString()
    {
        $f = new DatetimeField('Datetime', 'Datetime');
        $f->setValue('2003-03-29 23:59:38');
        $this->assertEquals($f->dataValue(), '2003-03-29 23:59:38', 'Accepts ISO');

        $f = new DatetimeField('Datetime', 'Datetime');
        $f->setValue('2003-03-29T23:59:38');
        $this->assertNull($f->dataValue(), 'Rejects normalised ISO');
    }

    public function testSubmittedValue()
    {
        $datetimeField = new DatetimeField('Datetime', 'Datetime');
        $datetimeField->setSubmittedValue('2003-03-29 23:00:00');
        $this->assertEquals($datetimeField->dataValue(), '2003-03-29 23:00:00');

        $datetimeField = new DatetimeField('Datetime', 'Datetime');
        $datetimeField->setSubmittedValue('2003-03-29T23:00:00');
        $this->assertEquals($datetimeField->dataValue(), '2003-03-29 23:00:00', 'Normalised ISO');
    }

    public function testSetValueWithLocalised()
    {
        $datetimeField = new DatetimeField('Datetime', 'Datetime');

        $datetimeField
            ->setHTML5(false)
            ->setLocale('en_NZ');

        $datetimeField->setSubmittedValue('29/03/2003 11:00:00 pm');
        $this->assertEquals($datetimeField->dataValue(), '2003-03-29 23:00:00');

        // Some localisation packages exclude the ',' in default medium format
        $this->assertRegExp(
            '#29/03/2003(,)? 11:00:00 (PM|pm)#',
            $datetimeField->Value(),
            'User value is formatted, and in user timezone'
        );
    }

    public function testValidate()
    {
        $f = new DatetimeField('Datetime', 'Datetime', '2003-03-29 23:59:38');
        $this->assertTrue($f->validate(new RequiredFields()));

        $f = new DatetimeField('Datetime', 'Datetime', '2003-03-29T23:59:38');
        $this->assertFalse($f->validate(new RequiredFields()), 'Normalised ISO');

        $f = new DatetimeField('Datetime', 'Datetime', '2003-03-29');
        $this->assertFalse($f->validate(new RequiredFields()), 'Leaving out time');

        $f = (new DatetimeField('Datetime', 'Datetime'))
            ->setSubmittedValue('2003-03-29T00:00');
        $this->assertTrue($f->validate(new RequiredFields()), 'Leaving out seconds (like many browsers)');

        $f = new DatetimeField('Datetime', 'Datetime', 'wrong');
        $this->assertFalse($f->validate(new RequiredFields()));
    }

    public function testSetMinDate()

    {
        $f = (new DatetimeField('Datetime'))->setMinDatetime('2009-03-31T23:00:00');
        $this->assertEquals($f->getMinDatetime(), '2009-03-31 23:00:00', 'Retains ISO');

        $f = (new DatetimeField('Datetime'))->setMinDatetime('2009-03-31 23:00:00');
        $this->assertEquals($f->getMinDatetime(), '2009-03-31 23:00:00', 'Converts normalised ISO to ISO');

        $f = (new DatetimeField('Datetime'))->setMinDatetime('invalid');
        $this->assertNull($f->getMinDatetime(), 'Ignores invalid values');
    }

    public function testSetMaxDate()

    {
        $f = (new DatetimeField('Datetime'))->setMaxDatetime('2009-03-31T23:00:00');
        $this->assertEquals($f->getMaxDatetime(), '2009-03-31 23:00:00', 'Retains ISO');

        $f = (new DatetimeField('Datetime'))->setMaxDatetime('2009-03-31 23:00:00');
        $this->assertEquals($f->getMaxDatetime(), '2009-03-31 23:00:00', 'Converts normalised ISO to ISO');

        $f = (new DatetimeField('Datetime'))->setMaxDatetime('invalid');
        $this->assertNull($f->getMaxDatetime(), 'Ignores invalid values');
    }

    public function testValidateMinDate()

    {
        $dateField = new DatetimeField('Datetime');
        $dateField->setMinDatetime('2009-03-31 23:00:00');
        $dateField->setValue('2009-03-31 23:00:01');
        $this->assertTrue($dateField->validate(new RequiredFields()), 'Time above min datetime');

        $dateField = new DatetimeField('Datetime');
        $dateField->setMinDatetime('2009-03-31 23:00:00');
        $dateField->setValue('2009-03-31 22:00:00');
        $this->assertFalse($dateField->validate(new RequiredFields()), 'Time below min datetime');

        $dateField = new DatetimeField('Datetime');
        $dateField->setMinDatetime('2009-03-31 23:00:00');
        $dateField->setValue('2009-03-31 23:00:00');
        $this->assertTrue($dateField->validate(new RequiredFields()), 'Date and time matching min datetime');

        $dateField = new DatetimeField('Datetime');
        $dateField->setMinDatetime('2009-03-31 23:00:00');
        $dateField->setValue('2008-03-31 23:00:00');
        $this->assertFalse($dateField->validate(new RequiredFields()), 'Date below min datetime');
    }

    public function testValidateMinDateWithSubmittedValueAndTimezone()

    {
        // Berlin and Auckland have 12h time difference in northern hemisphere winter
        date_default_timezone_set('Europe/Berlin');

        $dateField = new DatetimeField('Datetime');
        $dateField->setTimezone('Pacific/Auckland');
        $dateField->setMinDatetime('2009-01-30 23:00:00'); // server timezone (Berlin)
        $dateField->setSubmittedValue('2009-01-31T11:00:01'); // frontend timezone (Auckland)
        $this->assertTrue($dateField->validate(new RequiredFields()), 'Time above min datetime');

        $dateField = new DatetimeField('Datetime');
        $dateField->setTimezone('Pacific/Auckland');
        $dateField->setMinDatetime('2009-01-30 23:00:00');
        $dateField->setSubmittedValue('2009-01-31T10:00:00');
        $this->assertFalse($dateField->validate(new RequiredFields()), 'Time below min datetime');

        $dateField = new DatetimeField('Datetime');
        $dateField->setTimezone('Pacific/Auckland');
        $dateField->setMinDatetime('2009-01-30 23:00:00');
        $dateField->setSubmittedValue('2009-01-31T11:00:00');
        $this->assertTrue($dateField->validate(new RequiredFields()), 'Date and time matching min datetime');

        $dateField = new DatetimeField('Datetime');
        $dateField->setTimezone('Pacific/Auckland');
        $dateField->setMinDatetime('2009-01-30 23:00:00');
        $dateField->setSubmittedValue('2008-01-31T11:00:00');
        $this->assertFalse($dateField->validate(new RequiredFields()), 'Date below min datetime');
    }

    public function testValidateMinDateStrtotime()

    {
        $f = new DatetimeField('Datetime');
        $f->setMinDatetime('-7 days');
        $f->setValue(strftime('%Y-%m-%d %T', strtotime('-8 days', DBDatetime::now()->getTimestamp())));
        $this->assertFalse($f->validate(new RequiredFields()), 'Date below min datetime, with strtotime');

        $f = new DatetimeField('Datetime');
        $f->setMinDatetime('-7 days');
        $f->setValue(strftime('%Y-%m-%d %T', strtotime('-7 days', DBDatetime::now()->getTimestamp())));
        $this->assertTrue($f->validate(new RequiredFields()), 'Date matching min datetime, with strtotime');
    }

    public function testValidateMaxDateStrtotime()

    {
        $f = new DatetimeField('Datetime');
        $f->setMaxDatetime('7 days');
        $f->setValue(strftime('%Y-%m-%d %T', strtotime('8 days', DBDatetime::now()->getTimestamp())));
        $this->assertFalse($f->validate(new RequiredFields()), 'Date above max date, with strtotime');

        $f = new DatetimeField('Datetime');
        $f->setMaxDatetime('7 days');
        $f->setValue(strftime('%Y-%m-%d %T', strtotime('7 days', DBDatetime::now()->getTimestamp())));
        $this->assertTrue($f->validate(new RequiredFields()), 'Date matching max date, with strtotime');
    }

    public function testValidateMaxDate()

    {
        $f = new DatetimeField('Datetime');
        $f->setMaxDatetime('2009-03-31 23:00:00');
        $f->setValue('2009-03-31 22:00:00');
        $this->assertTrue($f->validate(new RequiredFields()), 'Time below max datetime');

        $f = new DatetimeField('Datetime');
        $f->setMaxDatetime('2009-03-31 23:00:00');
        $f->setValue('2010-03-31 23:00:01');
        $this->assertFalse($f->validate(new RequiredFields()), 'Time above max datetime');

        $f = new DatetimeField('Datetime');
        $f->setMaxDatetime('2009-03-31 23:00:00');
        $f->setValue('2009-03-31 23:00:00');
        $this->assertTrue($f->validate(new RequiredFields()), 'Date and time matching max datetime');

        $f = new DatetimeField('Datetime');
        $f->setMaxDatetime('2009-03-31 23:00:00');
        $f->setValue('2010-03-31 23:00:00');
        $this->assertFalse($f->validate(new RequiredFields()), 'Date above max datetime');
    }

    public function testValidateMaxDateWithSubmittedValueAndTimezone()

    {
        // Berlin and Auckland have 12h time difference in northern hemisphere winter
        date_default_timezone_set('Europe/Berlin');

        $f = new DatetimeField('Datetime');
        $f->setTimezone('Pacific/Auckland');
        $f->setMaxDatetime('2009-01-31 23:00:00'); // server timezone (Berlin)
        $f->setSubmittedValue('2009-01-31T10:00:00'); // frontend timezone (Auckland)
        $this->assertTrue($f->validate(new RequiredFields()), 'Time below max datetime');

        $f = new DatetimeField('Datetime');
        $f->setTimezone('Pacific/Auckland');
        $f->setMaxDatetime('2009-01-31 23:00:00');
        $f->setSubmittedValue('2010-01-31T11:00:01');
        $this->assertFalse($f->validate(new RequiredFields()), 'Time above max datetime');

        $f = new DatetimeField('Datetime');
        $f->setTimezone('Pacific/Auckland');
        $f->setMaxDatetime('2009-01-31 23:00:00');
        $f->setSubmittedValue('2009-01-31T11:00:00');
        $this->assertTrue($f->validate(new RequiredFields()), 'Date and time matching max datetime');

        $f = new DatetimeField('Datetime');
        $f->setTimezone('Pacific/Auckland');
        $f->setMaxDatetime('2009-01-31 23:00:00');
        $f->setSubmittedValue('2010-01-31T11:00:00');
        $this->assertFalse($f->validate(new RequiredFields()), 'Date above max datetime');
    }

    public function testTimezoneSetValueLocalised()

    {
        date_default_timezone_set('Europe/Berlin');
        // Berlin and Auckland have 12h time difference in northern hemisphere winter
        $datetimeField = new DatetimeField('Datetime', 'Datetime');

        $datetimeField
            ->setHTML5(false)
            ->setDatetimeFormat('dd/MM/y HH:mm:ss');

        $datetimeField->setTimezone('Pacific/Auckland');
        $datetimeField->setValue('2003-12-24 23:59:59');
        $this->assertEquals(
            '25/12/2003 11:59:59',
            $datetimeField->Value(),
            'User value is formatted, and in user timezone'
        );

        $this->assertEquals(
            '2003-12-24 23:59:59',
            $datetimeField->dataValue(),
            'Data value is in ISO format, and in server timezone'
        );
    }

    public function testTimezoneSetValueWithHtml5()
    {
        date_default_timezone_set('Europe/Berlin');
        // Berlin and Auckland have 12h time difference in northern hemisphere winter
        $datetimeField = new DatetimeField('Datetime', 'Datetime');

        $datetimeField->setTimezone('Pacific/Auckland');
        $datetimeField->setValue('2003-12-24 23:59:59');
        $this->assertEquals(
            '2003-12-25T11:59:59',
            $datetimeField->Value(),
            'User value is in normalised ISO format and in user timezone'
        );

        $this->assertEquals(
            '2003-12-24 23:59:59',
            $datetimeField->dataValue(),
            'Data value is in ISO format, and in server timezone'
        );
    }

    public function testTimezoneSetSubmittedValueLocalised()

    {
        date_default_timezone_set('Europe/Berlin');
        // Berlin and Auckland have 12h time difference in northern hemisphere summer, but Berlin and Moscow only 2h.
        $datetimeField = new DatetimeField('Datetime', 'Datetime');

        $datetimeField
            ->setHTML5(false)
            ->setLocale('en_NZ');

        $datetimeField->setTimezone('Europe/Moscow');
        // pass in default format, at user time (Moscow)
        $datetimeField->setSubmittedValue('24/06/2003 11:59:59 pm');
        $this->assertTrue($datetimeField->validate(new RequiredFields()));
        $this->assertEquals('2003-06-24 21:59:59', $datetimeField->dataValue(), 'Data value matches server timezone');
    }

    public function testGetName()
    {
        $field = new DatetimeField('Datetime');

        $this->assertEquals('Datetime', $field->getName());
    }

    public function testSetName()
    {
        $field = new DatetimeField('Datetime', 'Datetime');
        $field->setName('CustomDatetime');
        $this->assertEquals('CustomDatetime', $field->getName());
    }

    public function testSchemaDataDefaultsIncludesMinMax()

    {
        $field = new DatetimeField('Datetime');
        $field->setMinDatetime('2009-03-31 23:00:00');
        $field->setMaxDatetime('2010-03-31 23:00:00');
        $defaults = $field->getSchemaDataDefaults();
        $this->assertEquals($defaults['data']['min'], '2009-03-31T23:00:00');
        $this->assertEquals($defaults['data']['max'], '2010-03-31T23:00:00');
    }

    public function testSchemaDataDefaultsAdjustsMinMaxToTimezone()

    {
        date_default_timezone_set('Europe/Berlin');
        // Berlin and Auckland have 12h time difference in northern hemisphere summer, but Berlin and Moscow only 2h.

        $field = new DatetimeField('Datetime');
        $field->setTimezone('Pacific/Auckland');
        $field->setMinDatetime('2009-01-31 11:00:00'); // server timezone
        $field->setMaxDatetime('2010-01-31 11:00:00'); // server timezone
        $defaults = $field->getSchemaDataDefaults();
        $this->assertEquals($defaults['data']['min'], '2009-01-31T23:00:00'); // frontend timezone
        $this->assertEquals($defaults['data']['max'], '2010-01-31T23:00:00'); // frontend timezone
    }

    public function testAttributesIncludesMinMax()
    {
        $field = new DatetimeField('Datetime');
        $field->setMinDatetime('2009-03-31 23:00:00');
        $field->setMaxDatetime('2010-03-31 23:00:00');
        $attrs = $field->getAttributes();
        $this->assertEquals($attrs['min'], '2009-03-31T23:00:00');
        $this->assertEquals($attrs['max'], '2010-03-31T23:00:00');
    }

    public function testAttributesAdjustsMinMaxToTimezone()

    {
        date_default_timezone_set('Europe/Berlin');
        // Berlin and Auckland have 12h time difference in northern hemisphere summer, but Berlin and Moscow only 2h.

        $field = new DatetimeField('Datetime');
        $field->setTimezone('Pacific/Auckland');
        $field->setMinDatetime('2009-01-31 11:00:00'); // server timezone
        $field->setMaxDatetime('2010-01-31 11:00:00'); // server timezone
        $attrs = $field->getAttributes();
        $this->assertEquals($attrs['min'], '2009-01-31T23:00:00'); // frontend timezone
        $this->assertEquals($attrs['max'], '2010-01-31T23:00:00'); // frontend timezone
    }

    protected function getMockForm()
    {
        /** @skipUpgrade */
        return new Form(
            new Controller(),
            'Form',
            new FieldList(),
            new FieldList(
                new FormAction('doSubmit')
            )
        );
    }
}


1		<?php
2
3		namespace SilverStripe\Forms\Tests;
4
5		use SilverStripe\Dev\SapphireTest;
6		use SilverStripe\Control\Controller;
7		use SilverStripe\Forms\DatetimeField;
8		use SilverStripe\Forms\RequiredFields;
9		use SilverStripe\Forms\DateField;
10		use SilverStripe\Forms\Tests\DatetimeFieldTest\Model;
11		use SilverStripe\Forms\TimeField;
12		use SilverStripe\Forms\FieldList;
13		use SilverStripe\Forms\FormAction;
14		use SilverStripe\Forms\Form;
15		use SilverStripe\i18n\i18n;
16		use SilverStripe\ORM\FieldType\DBDatetime;
17
18		class DatetimeFieldTest extends SapphireTest
19		{
20		protected $timezone = null;
21
22		protected function setUp()
23		{
24		parent::setUp();
25		i18n::set_locale('en_NZ');
26		$this->timezone = date_default_timezone_get();
27		}
28
29		protected function tearDown()
30		{
31		date_default_timezone_set($this->timezone);
32		parent::tearDown(); // TODO: Change the autogenerated stub
33		}
34
35	View Code Duplication	public function testFormSaveInto()
		0 ignored issues – show Duplication introduced 2017-04-29 23:26 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$dateTimeField = new DatetimeField('MyDatetime');
38		$form = $this->getMockForm();
39		$form->Fields()->push($dateTimeField);

sminnee / silverstripe-framework

Push — authenticator-refactor ( fcc98b...4aec3f )

testConstructorWithLocalizedDateSetsNullValue() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like