sminnee / silverstripe-framework

src/ORM/Queries/SQLConditionalExpression.php

Doc Comments -4 removed lines

@@ -398,7 +398,6 @@ 
      * @see SQLConditionalExpression::addWhere() for syntax examples
      *
      * @param mixed $where Predicate(s) to set, as escaped SQL statements or paramaterised queries
-     * @param mixed $where,... Unlimited additional predicates
      * @return $this Self reference
      */
     public function setWhere($where)
@@ -485,7 +484,6 @@ 
      * </code>
      *
      * @param mixed $where Predicate(s) to set, as escaped SQL statements or paramaterised queries
-     * @param mixed $where,... Unlimited additional predicates
      * @return $this Self reference
      */
     public function addWhere($where)
@@ -502,7 +500,6 @@ 
      * @see SQLConditionalExpression::addWhere()
      *
      * @param mixed $filters Predicate(s) to set, as escaped SQL statements or paramaterised queries
-     * @param mixed $filters,... Unlimited additional predicates
      * @return $this Self reference
      */
     public function setWhereAny($filters)
@@ -517,7 +514,6 @@ 
      * @see SQLConditionalExpression::addWhere()
      *
      * @param mixed $filters Predicate(s) to set, as escaped SQL statements or paramaterised queries
-     * @param mixed $filters,... Unlimited additional predicates
      * @return $this Self reference
      */
     public function addWhereAny($filters)

src/Security/Group.php

Doc Comments +1 added lines

@@ -409,6 +409,7 @@
      * Overloaded to ensure the code is always descent.
      *
      * @param string
+     * @param string $val
      */
     public function setCode($val)
     {

Unused Use Statements -1 removed lines

@@ -30,7 +30,6 @@
 use SilverStripe\ORM\Hierarchy\Hierarchy;
 use SilverStripe\ORM\ManyManyList;
 use SilverStripe\ORM\UnsavedRelationList;
-use SilverStripe\View\Requirements;
 
 /**
  * A security group.

src/Security/PasswordValidator.php

Doc Comments +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
      * Eg: $this->characterStrength(3, array("lowercase", "uppercase", "digits", "punctuation"))
      *
      * @param int $minScore The minimum number of character tests that must pass
-     * @param array $testNames The names of the tests to perform
+     * @param string[] $testNames The names of the tests to perform
      * @return $this
      */
     public function characterStrength($minScore, $testNames)

src/Security/Permission.php

Doc Comments +2 added lines, -2 removed lines

@@ -122,7 +122,7 @@ 
      *  will be checked for the current user
      * @param bool $strict Use "strict" checking (which means a permission
      *  will be granted if the key does not exist at all)?
-     * @return int|bool The ID of the permission record if the permission
+     * @return boolean|string The ID of the permission record if the permission
      *  exists; FALSE otherwise. If "strict" checking is
      *  disabled, TRUE will be returned if the permission does not exist at all.
      */
@@ -162,7 +162,7 @@ 
      * @param string $arg Optional argument (e.g. a permissions for a specific page)
      * @param bool $strict Use "strict" checking (which means a permission
      *  will be granted if the key does not exist at all)?
-     * @return int|bool The ID of the permission record if the permission
+     * @return boolean|string The ID of the permission record if the permission
      *  exists; FALSE otherwise. If "strict" checking is
      *  disabled, TRUE will be returned if the permission does not exist at all.
      */

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use SilverStripe\Core\ClassInfo;
 use SilverStripe\Core\Resettable;
-use SilverStripe\Dev\Debug;
 use SilverStripe\Dev\TestOnly;
 use SilverStripe\i18n\i18nEntityProvider;
 use SilverStripe\ORM\DB;

src/Security/Permission_Group.php

Doc Comments +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
     /**
      * Get permissions
      *
-     * @return array Associative array of permissions in this permission
+     * @return string Associative array of permissions in this permission
      *               group. The array indicies are the permission codes as
      *               used in {@link Permission::check()}. The value is
      *               suitable for using in an interface.

src/Security/RememberLoginHash.php

Doc Comments +3 added lines

@@ -85,6 +85,9 @@
         return $this->token;
     }
 
+    /**
+     * @param string $token
+     */
     public function setToken($token)
     {
         $this->token = $token;

src/View/Parsers/HTMLValue.php

Doc Comments +1 added lines

@@ -150,6 +150,7 @@
     /**
      * Get the body element, or false if there isn't one (we haven't loaded any content
      * or this instance is in an invalid state)
+     * @return \DOMElement
      */
     public function getBody()
     {

src/View/Parsers/ShortcodeParser.php

Doc Comments +3 added lines

@@ -197,6 +197,9 @@
 
     // --------------------------------------------------------------------------------------------------------------
 
+    /**
+     * @param DOMElement $node
+     */
     protected function removeNode($node)
     {
         $node->parentNode->removeChild($node);

src/View/Parsers/URLSegmentFilter.php

Doc Comments +1 added lines

@@ -139,6 +139,7 @@
 
     /**
      * @param boolean
+     * @param boolean $bool
      */
     public function setAllowMultibyte($bool)
     {