sminnee / silverstripe-framework

src/ORM/DataList.php

Doc Comments +9 added lines, -9 removed lines

@@ -556,7 +556,7 @@ 
      * Check if the given field specification could be interpreted as an unquoted relation name
      *
      * @param string $field
-     * @return bool
+     * @return integer
      */
     protected function isValidRelationName($field)
     {
@@ -669,7 +669,7 @@ 
      * @param int $order A numerical index to control the order that joins are added to the query; lower order values
      * will cause the query to appear first. The default is 20, and joins created automatically by the
      * ORM have a value of 10.
-     * @param array $parameters Any additional parameters if the join is a parameterised subquery
+     * @param string[] $parameters Any additional parameters if the join is a parameterised subquery
      * @return static
      */
     public function innerJoin($table, $onClause, $alias = null, $order = 20, $parameters = array())
@@ -688,7 +688,7 @@ 
      * @param int $order A numerical index to control the order that joins are added to the query; lower order values
      * will cause the query to appear first. The default is 20, and joins created automatically by the
      * ORM have a value of 10.
-     * @param array $parameters Any additional parameters if the join is a parameterised subquery
+     * @param string[] $parameters Any additional parameters if the join is a parameterised subquery
      * @return static
      */
     public function leftJoin($table, $onClause, $alias = null, $order = 20, $parameters = array())
@@ -836,7 +836,7 @@ 
      * Return the maximum value of the given field in this DataList
      *
      * @param string $fieldName
-     * @return mixed
+     * @return string
      */
     public function max($fieldName)
     {
@@ -847,7 +847,7 @@ 
      * Return the minimum value of the given field in this DataList
      *
      * @param string $fieldName
-     * @return mixed
+     * @return string
      */
     public function min($fieldName)
     {
@@ -858,7 +858,7 @@ 
      * Return the average value of the given field in this DataList
      *
      * @param string $fieldName
-     * @return mixed
+     * @return string
      */
     public function avg($fieldName)
     {
@@ -869,7 +869,7 @@ 
      * Return the sum of the values of the given field in this DataList
      *
      * @param string $fieldName
-     * @return mixed
+     * @return string
      */
     public function sum($fieldName)
     {
@@ -928,7 +928,7 @@ 
     /**
      * Restrict the columns to fetch into this DataList
      *
-     * @param array $queriedColumns
+     * @param string[] $queriedColumns
      * @return static
      */
     public function setQueriedColumns($queriedColumns)
@@ -1174,7 +1174,7 @@ 
     /**
      * Returns item stored in list with index $key
      *
-     * @param mixed $key
+     * @param integer $key
      * @return DataObject
      */
     public function offsetGet($key)

src/ORM/FieldType/DBDatetime.php

Doc Comments +2 added lines, -2 removed lines

@@ -85,7 +85,7 @@ 
      * Return a date and time formatted as per a CMS user's settings.
      *
      * @param Member $member
-     * @return boolean | string A time and date pair formatted as per user-defined settings.
+     * @return null|string | string A time and date pair formatted as per user-defined settings.
      */
     public function FormatFromSettings($member = null)
     {
@@ -190,7 +190,7 @@ 
      * Use {@link clear_mock_now()} to revert to the current system date.
      * Caution: This sets a fixed date that doesn't increment with time.
      *
-     * @param DBDatetime|string $datetime Either in object format, or as a DBDatetime compatible string.
+     * @param string $datetime Either in object format, or as a DBDatetime compatible string.
      * @throws Exception
      */
     public static function set_mock_now($datetime)

src/ORM/Filters/SearchFilter.php

Doc Comments +3 added lines, -3 removed lines

@@ -74,7 +74,7 @@ 
      *  column. Can contain a relation name in dot notation, which will automatically join
      *  the necessary tables (e.g. "Comments.Name" to join the "Comments" has-many relationship and
      *  search the "Name" column when applying this filter to a SiteTree class).
-     * @param mixed $value
+     * @param string $value
      * @param array $modifiers
      */
     public function __construct($fullName = null, $value = false, array $modifiers = array())
@@ -188,7 +188,7 @@ 
     /**
      * Gets supported modifiers for this filter
      *
-     * @return array
+     * @return string[]
      */
     public function getSupportedModifiers()
     {
@@ -428,7 +428,7 @@ 
     /**
      * Determines case sensitivity based on {@link getModifiers()}.
      *
-     * @return Mixed TRUE or FALSE to enforce sensitivity, NULL to use field collation.
+     * @return boolean|null TRUE or FALSE to enforce sensitivity, NULL to use field collation.
      */
     protected function getCaseSensitive()
     {

src/ORM/ManyManyThroughList.php

Doc Comments +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
     }
 
     /**
-     * @param mixed $item
+     * @param Tests\ManyManyThroughListTest\Item $item
      * @param array $extraFields
      */
     public function add($item, $extraFields = [])

src/Security/Member.php

Doc Comments +5 added lines, -5 removed lines

@@ -883,9 +883,9 @@ 
      * });
      * </code>
      *
-     * @param Member|null|int $member Member or member ID to log in as.
+     * @param Member|null $member Member or member ID to log in as.
      * Set to null or 0 to act as a logged out user.
-     * @param $callback
+     * @param \Closure $callback
      */
     public static function actAs($member, $callback)
     {
@@ -1732,7 +1732,7 @@ 
      * This is likely to be customized for social sites etc. with a looser permission model.
      *
      * @param Member $member
-     * @return bool
+     * @return boolean|string
      */
     public function canView($member = null)
     {
@@ -1763,7 +1763,7 @@ 
      * Otherwise they'll need ADMIN or CMS_ACCESS_SecurityAdmin permissions
      *
      * @param Member $member
-     * @return bool
+     * @return boolean|string
      */
     public function canEdit($member = null)
     {
@@ -1798,7 +1798,7 @@ 
      * Otherwise they'll need ADMIN or CMS_ACCESS_SecurityAdmin permissions
      *
      * @param Member $member
-     * @return bool
+     * @return boolean|string
      */
     public function canDelete($member = null)
     {

Unused Use Statements -1 removed lines

@@ -31,7 +31,6 @@
 use SilverStripe\ORM\Map;
 use SilverStripe\ORM\ValidationException;
 use SilverStripe\ORM\ValidationResult;
-use SilverStripe\View\SSViewer;
 use SilverStripe\View\TemplateGlobalProvider;
 use DateTime;
 

tests/php/Core/Manifest/fixtures/namespaced_classmanifest/module/classes/ClassI.php

Unused Use Statements +1 added lines, -3 removed lines

@@ -6,11 +6,9 @@
 /** @skipUpgrade */
 use SilverStripe\Admin\ModelAdmin;
 /** @skipUpgrade */
-use SilverStripe\Control\Controller  as  Cont ;
 /** @skipUpgrade */
-use SilverStripe\Control\HTTPRequest as Request, SilverStripe\Control\HTTPResponse as Response, SilverStripe\Security\PermissionProvider as P;
+use SilverStripe\Security\PermissionProvider as P;
 /** @skipUpgrade */
-use silverstripe\test\ClassA;
 /** @skipUpgrade */
 use \SilverStripe\Core\Object;
 

tests/php/View/RequirementsTest.php

Doc Comments +4 added lines

@@ -1048,6 +1048,10 @@
         }
     }
 
+    /**
+     * @param Requirements_Backend $backend
+     * @param string $type
+     */
     public function assertFileNotIncluded($backend, $type, $files)
     {
         $includedFiles = $this->getBackendFiles($backend, $type);

src/Forms/HTMLEditor/HTMLEditorField_Embed.php

Doc Comments +1 added lines, -1 removed lines

@@ -143,7 +143,7 @@
     }
 
     /**
-     * @return AdapterInterface
+     * @return Adapter
      */
     public function getEmbed()
     {

src/Forms/TreeDropdownField.php

Doc Comments +2 added lines, -2 removed lines

@@ -313,7 +313,7 @@ 
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {
@@ -479,7 +479,7 @@ 
 
     /**
      * Marking a specific node in the tree as disabled
-     * @param $node
+     * @param DataObject $node
      * @return boolean
      */
     public function nodeIsDisabled($node)