sminnee / silverstripe-framework

forms/gridfield/GridFieldDetailForm.php

Doc Comments +12 added lines

@@ -307,6 +307,9 @@ 
 		parent::__construct();
 	}
 
+	/**
+	 * @param string $action
+	 */
 	public function Link($action = null) {
 		return Controller::join_links($this->gridField->Link('item'),
 			$this->record->ID ? $this->record->ID : 'new', $action);
@@ -335,6 +338,9 @@ 
 		}
 	}
 
+	/**
+	 * @param SS_HTTPRequest $request
+	 */
 	public function edit($request) {
 		$controller = $this->getToplevelController();
 		$form = $this->ItemEditForm($this->gridField, $request);
@@ -536,6 +542,9 @@ 
 		return $c;
 	}
 
+	/**
+	 * @return string
+	 */
 	protected function getBackLink(){
 		// TODO Coupling with CMS
 		$backlink = '';
@@ -637,6 +646,9 @@ 
 		}
 	}
 
+	/**
+	 * @param integer $errorCode
+	 */
 	public function httpError($errorCode, $errorMessage = null) {
 		$controller = $this->getToplevelController();
 		return $controller->httpError($errorCode, $errorMessage);

ORM/Connect/Database.php

Doc Comments +1 added lines, -1 removed lines

@@ -718,7 +718,7 @@
 	 * @param boolean $create Flag indicating whether the database should be created
 	 * if it doesn't exist. If $create is false and the database doesn't exist
 	 * then an error will be raised
-	 * @param int|boolean $errorLevel The level of error reporting to enable for the query, or false if no error
+	 * @param boolean $errorLevel The level of error reporting to enable for the query, or false if no error
 	 * should be raised
 	 * @return boolean Flag indicating success
 	 */

ORM/DataQuery.php

Doc Comments +8 added lines, -2 removed lines

@@ -101,7 +101,7 @@ 
 	/**
 	 * Remove a filter from the query
 	 *
-	 * @param string|array $fieldExpression The predicate of the condition to remove
+	 * @param string|null $fieldExpression The predicate of the condition to remove
 	 * (ignoring parameters). The expression will be considered a match if it's
 	 * contained within any other predicate.
 	 * @return DataQuery Self reference
@@ -180,7 +180,7 @@ 
 	/**
 	 * Ensure that the query is ready to execute.
 	 *
-	 * @param array|null $queriedColumns Any columns to filter the query by
+	 * @param string[] $queriedColumns Any columns to filter the query by
 	 * @return SQLSelect The finalised sql query
 	 */
 	public function getFinalisedQuery($queriedColumns = null) {
@@ -1040,6 +1040,9 @@ 
 	 */
 	protected $whereQuery;
 
+	/**
+	 * @param string $connective
+	 */
 	public function __construct(DataQuery $base, $connective) {
 		parent::__construct($base->dataClass);
 		$this->query = $base->query;
@@ -1049,6 +1052,9 @@ 
 		$base->where($this);
 	}
 
+	/**
+	 * @param string $filter
+	 */
 	public function where($filter) {
 		if($filter) {
 			$this->whereQuery->addWhere($filter);

ORM/Hierarchy/Hierarchy.php

Doc Comments +2 added lines, -2 removed lines

@@ -379,7 +379,7 @@ 
 	/**
 	 * Return the IDs of all the marked nodes.
 	 *
-	 * @return array
+	 * @return integer[]
 	 */
 	public function markedNodeIDs() {
 		return array_keys($this->markedNodes);
@@ -756,7 +756,7 @@ 
 	 * Get the next node in the tree of the type. If there is no instance of the className descended from this node,
 	 * then search the parents.
 	 * @param string     $className Class name of the node to find.
-	 * @param string|int $root      ID/ClassName of the node to limit the search to
+	 * @param integer $root      ID/ClassName of the node to limit the search to
 	 * @param DataObject $afterNode Used for recursive calls to this function
 	 * @return DataObject
 	 */

Security/CMSSecurity.php

Doc Comments +6 added lines

@@ -52,6 +52,9 @@ 
 		);
 	}
 
+	/**
+	 * @param string $action
+	 */
 	public function Link($action = null) {
 		/** @skipUpgrade */
 		return Controller::join_links(Director::baseURL(), "CMSSecurity", $action);
@@ -68,6 +71,9 @@ 
 		}
 	}
 
+	/**
+	 * @param string $title
+	 */
 	public function getResponseController($title) {
 		// Use $this to prevent use of Page to render underlying templates
 		return $this;

Security/PermissionCheckboxSetField.php

Unused Use Statements -3 removed lines

@@ -4,14 +4,11 @@
 
 
 
-use SilverStripe\ORM\FieldType\DBHTMLText;
 use SilverStripe\ORM\SS_List;
 use SilverStripe\ORM\ArrayList;
-use SilverStripe\ORM\FieldType\DBField;
 use SilverStripe\ORM\DataObjectInterface;
 use FormField;
 use InvalidArgumentException;
-use Requirements;
 use Config;
 
 

view/Requirements.php

Doc Comments +2 added lines

@@ -66,6 +66,7 @@ 
 	 * while automatically busting this cache every time the file is changed.
 	 *
 	 * @param bool
+	 * @param boolean $var
 	 */
 	public static function set_suffix_requirements($var) {
 		self::backend()->setSuffixRequirements($var);
@@ -784,6 +785,7 @@ 
 	 * Forces the JavaScript requirements to the end of the body, right before the closing tag
 	 *
 	 * @param bool
+	 * @param boolean $var
 	 * @return $this
 	 */
 	public function setForceJSToBottom($var) {

admin/code/AddToCampaignHandler.php

Doc Comments -1 removed lines

@@ -72,7 +72,6 @@
 	/**
 	 * AddToCampaignHandler constructor.
 	 *
-	 * @param Controller $parentController Controller for this form
 	 * @param array|DataObject $data The data submitted as part of that form
 	 * @param string $name Form name
 	 */

Unused Use Statements -4 removed lines

@@ -14,13 +14,9 @@
 use FieldList;
 use HiddenField;
 use Form;
-use CompositeField;
-use LiteralField;
 use Director;
 use SS_HTTPResponse;
-use FormAction;
 use SS_HTTPResponse_Exception;
-use HeaderField;
 
 /**
  * Class AddToCampaignHandler - handle the AddToCampaign action.

forms/FormSchema.php

Doc Comments +3 added lines

@@ -77,6 +77,9 @@
 		return $state;
 	}
 
+	/**
+	 * @param \FieldList|null $fields
+	 */
 	protected function getFieldStates($fields) {
 		$states = [];
 		foreach ($fields as $field) {