sminnee / silverstripe-framework

tests/php/ORM/DBDateTest.php

Unused Use Statements -2 removed lines

@@ -7,9 +7,7 @@
 use SilverStripe\ORM\FieldType\DBDate;
 use SilverStripe\ORM\FieldType\DBField;
 use SilverStripe\ORM\FieldType\DBDatetime;
-use SilverStripe\ORM\DataObject;
 use SilverStripe\Dev\SapphireTest;
-use SilverStripe\Security\Member;
 
 class DBDateTest extends SapphireTest
 {

tests/php/ORM/MarkedSetTest.php

Doc Comments +5 added lines

@@ -418,6 +418,7 @@ 
      *
      * @param string$html
      * @param DataObject $node
+     * @param string $html
      * @return string
      */
     protected function getNodeClassFromTree($html, $node)
@@ -434,6 +435,10 @@ 
         return '';
     }
 
+    /**
+     * @param string $expected
+     * @param string $actual
+     */
     protected function assertHTMLSame($expected, $actual, $message = '')
     {
         // Trim each line, strip empty lines

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\ORM\Tests;
 
-use DOMDocument;
 use SilverStripe\Dev\CSSContentParser;
 use SilverStripe\Dev\SapphireTest;
 use SilverStripe\ORM\DataObject;

src/Forms/DateField.php

Doc Comments +2 added lines, -2 removed lines

@@ -312,7 +312,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -337,7 +337,7 @@ 
      *
      * When $html5=true, assign value from ISO 8601 string.
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

src/Forms/TimeField.php

Doc Comments +2 added lines, -2 removed lines

@@ -250,7 +250,7 @@ 
     /**
      * Assign value posted from form submission
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -267,7 +267,7 @@ 
     /**
      * Set time assigned from database value
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */

src/Forms/CompositeField.php

Doc Comments +11 added lines

@@ -270,6 +270,9 @@ 
 
 
 
+    /**
+     * @param boolean $disabled
+     */
     public function setDisabled($disabled)
     {
         parent::setDisabled($disabled);
@@ -279,6 +282,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $readonly
+     */
     public function setReadonly($readonly)
     {
         parent::setReadonly($readonly);
@@ -371,6 +377,10 @@ 
         $this->children->removeByName($fieldName, $dataFieldOnly);
     }
 
+    /**
+     * @param string $fieldName
+     * @param FormField $newField
+     */
     public function replaceField($fieldName, $newField)
     {
         return $this->children->replaceField($fieldName, $newField);
@@ -456,6 +466,7 @@ 
      * the children collection. Doesn't work recursively.
      *
      * @param string|FormField
+     * @param string $field
      * @return int Position in children collection (first position starts with 0). Returns FALSE if the field can't
      *             be found.
      */

src/Forms/DatetimeField.php

Doc Comments +6 added lines, -3 removed lines

@@ -138,7 +138,7 @@ 
     }
 
     /**
-     * @param $bool
+     * @param boolean $bool
      * @return $this
      */
     public function setHTML5($bool)
@@ -151,7 +151,7 @@ 
      * Assign value posted from form submission, based on {@link $datetimeFormat}.
      * When $html5=true, this needs to be normalised ISO format (with "T" separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -317,7 +317,7 @@ 
      * When $html5=true, assign value from ISO 8601 normalised string (with a "T" separator).
      * Falls back to an ISO 8601 string (with a whitespace separator).
      *
-     * @param mixed $value
+     * @param string $value
      * @param mixed $data
      * @return $this
      */
@@ -492,6 +492,9 @@ 
         return $this;
     }
 
+    /**
+     * @param boolean $bool
+     */
     public function setReadonly($bool)
     {
         parent::setReadonly($bool);

src/Security/CMSSecurity.php

Doc Comments +6 added lines

@@ -49,6 +49,9 @@ 
         return parent::login($request, Authenticator::CMS_LOGIN);
     }
 
+    /**
+     * @param string $action
+     */
     public function Link($action = null)
     {
         /** @skipUpgrade */
@@ -79,6 +82,9 @@ 
         return null;
     }
 
+    /**
+     * @param string $title
+     */
     public function getResponseController($title)
     {
         // Use $this to prevent use of Page to render underlying templates

Unused Use Statements -1 removed lines

@@ -7,7 +7,6 @@
 use SilverStripe\Control\Director;
 use SilverStripe\Admin\LeftAndMain;
 use SilverStripe\Control\HTTPResponse;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Convert;
 use SilverStripe\Core\Manifest\ModuleLoader;
 use SilverStripe\ORM\FieldType\DBField;

src/Security/InheritedPermissions.php

Doc Comments +1 added lines, -1 removed lines

@@ -111,7 +111,7 @@
     /**
      * Global permissions required to edit
      *
-     * @param array $permissions
+     * @param string[] $permissions
      * @return $this
      */
     public function setGlobalEditPermissions($permissions)

src/View/Parsers/Diff.php

Doc Comments +1 added lines, -1 removed lines

@@ -161,7 +161,7 @@
     }
 
     /**
-     * @param string|bool|array $content If passed as an array, values will be concatenated with a comma.
+     * @param string $content If passed as an array, values will be concatenated with a comma.
      * @return array
      */
     public static function getHTMLChunks($content)