Completed
Push — ss3-php74 ( f30a6a )
by Sam
05:37
created
model/connect/Database.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -385,6 +385,7 @@  discard block
 block discarded – undo
385 385
 	 * - minutes
386 386
 	 * - seconds
387 387
 	 * This includes the singular forms as well
388
+	 * @param string $date
388 389
 	 * @return string SQL datetime expression to query for a datetime (YYYY-MM-DD hh:mm:ss) which is the result of
389 390
 	 *                the addition
390 391
 	 */
@@ -398,6 +399,7 @@  discard block
 block discarded – undo
398 399
 	 *                       e.g. '"SiteTree"."Created"'
399 400
 	 * @param string $date2 to be substracted of $date1, can be either 'now', literal datetime
400 401
 	 *                      like '1973-10-14 10:30:00' or field name, e.g. '"SiteTree"."Created"'
402
+	 * @param string $date1
401 403
 	 * @return string SQL datetime expression to query for the interval between $date1 and $date2 in seconds which
402 404
 	 *                is the result of the substraction
403 405
 	 */
@@ -625,7 +627,7 @@  discard block
 block discarded – undo
625 627
 	 * @param boolean $create Flag indicating whether the database should be created
626 628
 	 * if it doesn't exist. If $create is false and the database doesn't exist
627 629
 	 * then an error will be raised
628
-	 * @param int|boolean $errorLevel The level of error reporting to enable for the query, or false if no error
630
+	 * @param boolean $errorLevel The level of error reporting to enable for the query, or false if no error
629 631
 	 * should be raised
630 632
 	 * @return boolean Flag indicating success
631 633
 	 */
@@ -785,6 +787,7 @@  discard block
 block discarded – undo
785 787
 
786 788
 	/**
787 789
 	 * @deprecated since version 4.0 Use DB::field_list instead
790
+	 * @param string $table
788 791
 	 */
789 792
 	public function fieldList($table) {
790 793
 		Deprecation::notice('4.0', 'Use DB::field_list instead');
Please login to merge, or discard this patch.
control/ContentNegotiator.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -97,6 +97,7 @@
 block discarded – undo
97 97
 	/**
98 98
 	 * Returns true if negotation is enabled for the given response.
99 99
 	 * By default, negotiation is only enabled for pages that have the xml header.
100
+	 * @param SS_HTTPResponse $response
100 101
 	 */
101 102
 	public static function enabled_for($response) {
102 103
 		$contentType = $response->getHeader("Content-Type");
Please login to merge, or discard this patch.
core/Convert.php 1 patch
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
 	 *
51 51
 	 * @param array|string $val String to escape, or array of strings
52 52
 	 *
53
-	 * @return array|string
53
+	 * @return string
54 54
 	 */
55 55
 	public static function raw2htmlname($val) {
56 56
 		if(is_array($val)) {
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
 	 *
182 182
 	 * @param string|array $identifier The identifier to escape. E.g. 'SiteTree.Title'
183 183
 	 * @param string $separator The string that delimits subsequent identifiers
184
-	 * @return string|array The escaped identifier. E.g. '"SiteTree"."Title"'
184
+	 * @return string The escaped identifier. E.g. '"SiteTree"."Title"'
185 185
 	 */
186 186
 	public static function symbol2sql($identifier, $separator = '.') {
187 187
 		if(is_array($identifier)) {
@@ -266,6 +266,7 @@  discard block
 block discarded – undo
266 266
 	 * call this function directly, Please use {@link Convert::xml2array()}
267 267
 	 *
268 268
 	 * @param SimpleXMLElement
269
+	 * @param SimpleXMLElement $xml
269 270
 	 *
270 271
 	 * @return mixed
271 272
 	 */
Please login to merge, or discard this patch.
core/manifest/ConfigStaticManifest.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -323,6 +323,7 @@
 block discarded – undo
323 323
 	 *
324 324
 	 * Seperated out from parse partially so that we can recurse if there are multiple statics
325 325
 	 * being declared in a comma seperated list
326
+	 * @param string $class
326 327
 	 */
327 328
 	function parseStatic($access, $class) {
328 329
 		$variable = null;
Please login to merge, or discard this patch.
dev/Debug.php 1 patch
Doc Comments   +14 added lines, -7 removed lines patch added patch discarded remove patch
@@ -226,6 +226,12 @@  discard block
 block discarded – undo
226 226
 		set_exception_handler('exceptionHandler');
227 227
 	}
228 228
 
229
+	/**
230
+	 * @param integer $errno
231
+	 * @param string $errstr
232
+	 * @param string $errfile
233
+	 * @param integer $errline
234
+	 */
229 235
 	public static function noticeHandler($errno, $errstr, $errfile, $errline, $errcontext) {
230 236
 		if(error_reporting() == 0) return;
231 237
 		ini_set('display_errors', 0);
@@ -252,10 +258,10 @@  discard block
 block discarded – undo
252 258
 	/**
253 259
 	 * Handle a non-fatal warning error thrown by PHP interpreter.
254 260
 	 *
255
-	 * @param unknown_type $errno
256
-	 * @param unknown_type $errstr
257
-	 * @param unknown_type $errfile
258
-	 * @param unknown_type $errline
261
+	 * @param integer $errno
262
+	 * @param string $errstr
263
+	 * @param string $errfile
264
+	 * @param integer $errline
259 265
 	 * @param unknown_type $errcontext
260 266
 	 */
261 267
 	public static function warningHandler($errno, $errstr, $errfile, $errline, $errcontext) {
@@ -286,8 +292,8 @@  discard block
 block discarded – undo
286 292
 	 *
287 293
 	 * Runtime execution dies immediately once the error is generated.
288 294
 	 *
289
-	 * @param unknown_type $errno
290
-	 * @param unknown_type $errstr
295
+	 * @param integer $errno
296
+	 * @param string $errstr
291 297
 	 * @param unknown_type $errfile
292 298
 	 * @param unknown_type $errline
293 299
 	 * @param unknown_type $errcontext
@@ -327,7 +333,7 @@  discard block
 block discarded – undo
327 333
 	 *                                     or "tech-speak". Used in the HTTP Header and ajax responses.
328 334
 	 * @param string $friendlyErrorDetail Detailed user-focused message. Is just used if no {@link ErrorPage} is found
329 335
 	 *                                    for this specific status code.
330
-	 * @return string HTML error message for non-ajax requests, plaintext for ajax-request.
336
+	 * @return boolean HTML error message for non-ajax requests, plaintext for ajax-request.
331 337
 	 */
332 338
 	public static function friendlyError($statusCode=500, $friendlyErrorMessage=null, $friendlyErrorDetail=null) {
333 339
 		// Ensure the error message complies with the HTTP 1.1 spec
@@ -399,6 +405,7 @@  discard block
 block discarded – undo
399 405
 	 * @param unknown_type $errfile
400 406
 	 * @param unknown_type $errline
401 407
 	 * @param unknown_type $errcontext
408
+	 * @param string $errtype
402 409
 	 */
403 410
 	public static function showError($errno, $errstr, $errfile, $errline, $errcontext, $errtype) {
404 411
 		if(!headers_sent()) {
Please login to merge, or discard this patch.
dev/FixtureFactory.php 1 patch
Doc Comments   +5 added lines, -4 removed lines patch added patch discarded remove patch
@@ -117,6 +117,7 @@  discard block
 block discarded – undo
117 117
 	/**
118 118
 	 * Return all of the IDs in the fixture of a particular class name.
119 119
 	 *
120
+	 * @param string $class
120 121
 	 * @return A map of fixture-identifier => object-id
121 122
 	 */
122 123
 	public function getIds($class) {
@@ -131,6 +132,7 @@  discard block
 block discarded – undo
131 132
 	 * @param String
132 133
 	 * @param String $identifier
133 134
 	 * @param Int $databaseId
135
+	 * @param string $class
134 136
 	 */
135 137
 	public function setId($class, $identifier, $databaseId) {
136 138
 		$this->fixtures[$class][$identifier] = $databaseId;
@@ -140,8 +142,8 @@  discard block
 block discarded – undo
140 142
 	/**
141 143
 	 * Get an object from the fixture.
142 144
 	 *
143
-	 * @param $class The data class, as specified in your fixture file.  Parent classes won't work
144
-	 * @param $identifier The identifier string, as provided in your fixture file
145
+	 * @param string $class The data class, as specified in your fixture file.  Parent classes won't work
146
+	 * @param string $identifier The identifier string, as provided in your fixture file
145 147
 	 */
146 148
 	public function get($class, $identifier) {
147 149
 		$id = $this->getId($class, $identifier);
@@ -161,7 +163,7 @@  discard block
 block discarded – undo
161 163
 	 * or {@link createRaw()}, both from the internal fixture mapping and the database.
162 164
 	 * If the $class argument is set, limit clearing to items of this class.
163 165
 	 *
164
-	 * @param String $class
166
+	 * @param string $limitToClass
165 167
 	 */
166 168
 	public function clear($limitToClass = null) {
167 169
 		$classes = ($limitToClass) ? array($limitToClass) : array_keys($this->fixtures);
@@ -202,7 +204,6 @@  discard block
 block discarded – undo
202 204
 	 * Parse a value from a fixture file.  If it starts with =>
203 205
 	 * it will get an ID from the fixture dictionary
204 206
 	 *
205
-	 * @param String $fieldVal
206 207
 	 * @return String Fixture database ID, or the original value
207 208
 	 */
208 209
 	protected function parseValue($value) {
Please login to merge, or discard this patch.
filesystem/File.php 1 patch
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
 	 * Find a File object by the given filename.
235 235
 	 *
236 236
 	 * @param String $filename Matched against the "Name" property.
237
-	 * @return mixed null if not found, File object of found file
237
+	 * @return null|DataObject null if not found, File object of found file
238 238
 	 */
239 239
 	public static function find($filename) {
240 240
 		// Get the base file if $filename points to a resampled file
@@ -449,6 +449,7 @@  discard block
 block discarded – undo
449 449
 	 * showing icons on filelinks, etc.
450 450
 	 * Possible group values are: "audio", "mov", "zip", "image".
451 451
 	 *
452
+	 * @param string $ext
452 453
 	 * @return String
453 454
 	 */
454 455
 	public static function get_app_category($ext) {
Please login to merge, or discard this patch.
filesystem/Folder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
 	 *
43 43
 	 * @param $folderPath string Absolute or relative path to the file.
44 44
 	 *  If path is relative, its interpreted relative to the "assets/" directory.
45
-	 * @return Folder|null
45
+	 * @return null|DataObject
46 46
 	 */
47 47
 	public static function find_or_make($folderPath) {
48 48
 		// Create assets directory, if it is missing
Please login to merge, or discard this patch.
filesystem/GD.php 1 patch
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -150,6 +150,7 @@  discard block
 block discarded – undo
150 150
 	 * successfully, the manipulation's cache key is removed.
151 151
 	 *
152 152
 	 * @param string $filename
153
+	 * @param string $manipulation
153 154
 	 * @return boolean
154 155
 	 */
155 156
 	public function failedResample($filename, $manipulation) {
@@ -428,6 +429,10 @@  discard block
 block discarded – undo
428 429
 			return $useAsMinimum ? $this->resizeByWidth( $maxWidth ) : $this->resizeByHeight( $maxHeight );
429 430
 	}
430 431
 
432
+	/**
433
+	 * @param resource $image
434
+	 * @param string $webColor
435
+	 */
431 436
 	public static function color_web2gd($image, $webColor, $transparencyPercent = 0) {
432 437
 		if(substr($webColor,0,1) == "#") $webColor = substr($webColor,1);
433 438
 		$r = hexdec(substr($webColor,0,2));
@@ -546,6 +551,9 @@  discard block
 block discarded – undo
546 551
 		return $output;
547 552
 	}
548 553
 
554
+	/**
555
+	 * @param string $dirname
556
+	 */
549 557
 	public function makeDir($dirname) {
550 558
 		if(!file_exists(dirname($dirname))) $this->makeDir(dirname($dirname));
551 559
 		if(!file_exists($dirname)) mkdir($dirname, Config::inst()->get('Filesystem', 'folder_create_mask'));
Please login to merge, or discard this patch.