sminnee / silverstripe-framework

src/View/Requirements_Backend.php

Doc Comments +1 added lines

@@ -321,6 +321,7 @@
      * Forces the JavaScript requirements to the end of the body, right before the closing tag
      *
      * @param bool
+     * @param boolean $var
      * @return $this
      */
     public function setForceJSToBottom($var)

src/View/SSTemplateParser.php

Doc Comments +7 added lines, -3 removed lines

@@ -95,6 +95,8 @@ 
 
     /**
      * Override the function that constructs the result arrays to also prepare a 'php' item in the array
+     * @param string $matchrule
+     * @param string $name
      */
     function construct($matchrule, $name, $arguments = null)
     {
@@ -163,9 +165,9 @@ 
 
     /**
      * Ensures that the arguments to addOpenBlock and addClosedBlock are valid
-     * @param $name
-     * @param $callable
-     * @param $type
+     * @param string $name
+     * @param callable $callable
+     * @param string $type
      * @throws InvalidArgumentException
      */
     protected function validateExtensionBlock($name, $callable, $type)
@@ -924,6 +926,7 @@ 
      * The basic generated PHP of LookupStep and LastLookupStep is the same, except that LookupStep calls 'obj' to
      * get the next ViewableData in the sequence, and LastLookupStep calls different methods (XML_val, hasValue, obj)
      * depending on the context the lookup is used in.
+     * @param string $method
      */
     function Lookup_AddLookupStep(&$res, $sub, $method)
     {
@@ -6477,6 +6480,7 @@ 
 
     /**
      * @param string $code
+     * @param string $templateName
      * @return string $code
      */
     protected function includeDebuggingComments($code, $templateName)

src/View/SSViewer.php

Doc Comments +4 added lines, -1 removed lines

@@ -648,7 +648,7 @@ 
      * @param mixed $data Data context
      * @param array $arguments Additional arguments
      * @param Object $scope
-     * @return string Evaluated result
+     * @return DBHTMLText Evaluated result
      */
     public static function execute_template($template, $data, $arguments = null, $scope = null)
     {
@@ -676,6 +676,9 @@ 
         return $v->process($data, $arguments);
     }
 
+    /**
+     * @param string $content
+     */
     public function parseTemplateContent($content, $template = "")
     {
         return $this->getParser()->compileString(

src/View/SSViewer_FromString.php

Doc Comments +3 added lines

@@ -30,6 +30,9 @@
      */
     protected $cacheTemplate;
 
+    /**
+     * @param string $content
+     */
     public function __construct($content, TemplateParser $parser = null)
     {
         if ($parser) {

src/Forms/FileField.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
 
     /**
      * @param array $properties
-     * @return string
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText
      */
     public function Field($properties = array())
     {

src/Forms/GridField/GridFieldImportButton.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace SilverStripe\Forms\GridField;
 
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\Forms\Form;
 use SilverStripe\View\ArrayData;

src/Forms/UploadReceiver.php

Doc Comments -1 removed lines

@@ -97,7 +97,6 @@
      * for each of these categories
      *
      * @param string $category Category name
-     * @param string,... $categories Additional category names
      * @return $this
      */
     public function setAllowedFileCategories($category)

tests/php/Core/ObjectTest/Extending.php

Doc Comments +17 added lines

@@ -12,11 +12,22 @@ 
         Extending_Extension::class,
     );
 
+    /**
+     * @param integer $first
+     * @param integer $second
+     * @param integer $third
+     */
     public function getResults(&$first, &$second, &$third)
     {
         // Before extending should be invoked second
         $this->beforeExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 1 && $second === 2 && $third === 3) {
                     $first = 11;
@@ -31,6 +42,12 @@ 
         // After extending should be invoked fourth
         $this->afterExtending(
             'updateResult',
+
+            /**
+             * @param integer $first
+             * @param integer $second
+             * @param integer $third
+             */
             function (&$first, &$second, &$third) {
                 if ($first === 21 && $second === 22 && $third = 23) {
                     $first = 31;

tests/php/Core/Startup/ErrorControlChainTest/ErrorControlChainTest_Chain.php

Doc Comments +5 added lines, -1 removed lines

@@ -31,7 +31,7 @@ 
     /**
      * Modify method visibility to public for testing
      *
-     * @param mixed $errors
+     * @param string $errors
      */
     public function setDisplayErrors($errors)
     {
@@ -40,6 +40,10 @@ 
     }
 
     // Change function visibility to be testable directly
+
+    /**
+     * @param string $memstring
+     */
     public function translateMemstring($memstring)
     {
         return parent::translateMemstring($memstring);