sminnee / silverstripe-framework

security/Group.php

Doc Comments +1 added lines

@@ -331,6 +331,7 @@
 	 * Overloaded to ensure the code is always descent.
 	 *
 	 * @param string
+	 * @param string $val
 	 */
 	public function setCode($val){
 		$this->setField("Code", Convert::raw2url($val));

security/Member.php

Doc Comments +3 added lines, -1 removed lines

@@ -588,6 +588,8 @@ 
 
 	/**
 	 * Utility for generating secure password hashes for this member.
+	 * @param string $string
+	 * @return string
 	 */
 	public function encryptWithUserSettings($string) {
 		if (!$string) return null;
@@ -738,7 +740,7 @@ 
 	/**
 	 * Returns the current logged in user
 	 *
-	 * @return Member|null
+	 * @return DataObject|null
 	 */
 	public static function currentUser() {
 		$id = Member::currentUserID();

security/MemberPassword.php

Doc Comments +1 added lines

@@ -32,6 +32,7 @@
 	/**
 	 * Log a password change from the given member.
 	 * Call MemberPassword::log($this) from within Member whenever the password is changed.
+	 * @param Member $member
 	 */
 	public static function log($member) {
 		$record = new MemberPassword();

security/PasswordValidator.php

Doc Comments +4 added lines, -2 removed lines

@@ -28,6 +28,7 @@ 
 
 	/**
 	 * Minimum password length
+	 * @param integer $minLength
 	 */
 	public function minLength($minLength) {
 		$this->minLength = $minLength;
@@ -39,8 +40,8 @@ 
 	 *
 	 * Eg: $this->characterStrength(3, array("lowercase", "uppercase", "digits", "punctuation"))
 	 *
-	 * @param $minScore The minimum number of character tests that must pass
-	 * @param $testNames The names of the tests to perform
+	 * @param integer $minScore The minimum number of character tests that must pass
+	 * @param string[] $testNames The names of the tests to perform
 	 */
 	public function characterStrength($minScore, $testNames) {
 		$this->minScore = $minScore;
@@ -50,6 +51,7 @@ 
 
 	/**
 	 * Check a number of previous passwords that the user has used, and don't let them change to that.
+	 * @param integer $count
 	 */
 	public function checkHistoricalPasswords($count) {
 		$this->historicalPasswordCount = $count;

security/Permission.php

Doc Comments +2 added lines, -2 removed lines

@@ -652,7 +652,7 @@ 
 	 * Recursively traverse the nested list of declared permissions and create
 	 * a linear list.
 	 *
-	 * @param aeeay $declared Nested structure of permissions.
+	 * @param boolean $declared Nested structure of permissions.
 	 * @param $list List of permissions in the structure. The result will be
 	 *              written to this array.
 	 */
@@ -740,7 +740,7 @@ 
 	/**
 	 * Get permissions
 	 *
-	 * @return array Associative array of permissions in this permission
+	 * @return string Associative array of permissions in this permission
 	 *               group. The array indicies are the permission codes as
 	 *               used in {@link Permission::check()}. The value is
 	 *               suitable for using in an interface.

tasks/EncryptAllPasswordsTask.php

Doc Comments +1 added lines

@@ -66,6 +66,7 @@
 
 	/**
 	 * @todo This should really be taken care of by TestRunner
+	 * @param string $msg
 	 */
 	protected function debugMessage($msg) {
 		if(class_exists('SapphireTest', false) && !SapphireTest::is_running_test()) {

tests/api/RestfulServiceTest.php

Doc Comments +2 added lines

@@ -208,6 +208,8 @@
 	 * Simulate cached response file for testing error requests that are supposed to have cache files
 	 *
 	 * @todo Generate the cachepath without hardcoding the cache data
+	 * @param RestfulServiceTest_MockErrorService $connection
+	 * @param string $subUrl
 	 */
 	private function createFakeCachedResponse($connection, $subUrl) {
 		$fullUrl = $connection->getAbsoluteRequestURL($subUrl);

tests/behat/features/bootstrap/FeatureContext.php

Unused Use Statements +7 added lines, -7 removed lines

@@ -2,13 +2,13 @@
 
 namespace SilverStripe\Framework\Test\Behaviour;
 
-use SilverStripe\BehatExtension\Context\SilverStripeContext,
-	SilverStripe\BehatExtension\Context\BasicContext,
-	SilverStripe\BehatExtension\Context\LoginContext,
-	SilverStripe\BehatExtension\Context\FixtureContext,
-	SilverStripe\BehatExtension\Context\EmailContext,
-	SilverStripe\Framework\Test\Behaviour\CmsFormsContext,
-	SilverStripe\Framework\Test\Behaviour\CmsUiContext;
+use SilverStripe\BehatExtension\Context\SilverStripeContext;
+use SilverStripe\BehatExtension\Context\BasicContext;
+use SilverStripe\BehatExtension\Context\LoginContext;
+use SilverStripe\BehatExtension\Context\FixtureContext;
+use SilverStripe\BehatExtension\Context\EmailContext;
+use SilverStripe\Framework\Test\Behaviour\CmsFormsContext;
+use SilverStripe\Framework\Test\Behaviour\CmsUiContext;
 
 // PHPUnit
 require_once 'PHPUnit/Autoload.php';

tests/core/manifest/ConfigManifestTest.php

Doc Comments +3 added lines, -2 removed lines

@@ -10,7 +10,7 @@ 
 
 	/**
 	 * This is a helper method for getting a new manifest
-	 * @param $name
+	 * @param string $name
 	 * @return any
 	 */
 	protected function getConfigFixtureValue($name) {
@@ -20,6 +20,7 @@ 
 
 	/**
 	 * This is a helper method for displaying a relevant message about a parsing failure
+	 * @param string $path
 	 */
 	protected function getParsedAsMessage($path) {
 		return sprintf('Reference path "%s" failed to parse correctly', $path);
@@ -41,7 +42,7 @@ 
 
 	/**
 	 * A helper method to return a mock of the manifest in order to test expectations and reduce dependency
-	 * @param $methods
+	 * @param string[] $methods
 	 * @return SS_ConfigManifest
 	 */
 	protected function getManifestMock($methods) {