smi2 / phpClickHouse

src/Query/Degeneration/Conditions.php

<?php

Missing declare(strict_types=1).

namespace ClickHouseDB\Query\Degeneration;

use ClickHouseDB\Exception\QueryException;
use ClickHouseDB\Query\Degeneration;

class Conditions implements Degeneration
{
    /**

Found multi-line comment for property \ClickHouseDB\Query\Degeneration\Conditions::$bindings with single line content, use one-line comment instead.

     * @var array

@var annotation of property \ClickHouseDB\Query\Degeneration\Conditions::$bindings does not specify type hint for its items.

     */
    protected $bindings = [];

    /**
     * @param array $bindings

@param annotation of method \ClickHouseDB\Query\Degeneration\Conditions::bindParams() does not specify type hint for items of its traversable parameter $bindings.

     */
    public function bindParams(array $bindings)

Method \ClickHouseDB\Query\Degeneration\Conditions::bindParams() does not have void return type hint.

    {
        foreach ($bindings as $column => $value) {
            $this->bindings[$column] = $value;
        }
    }

    public function getBind(): array

Method \ClickHouseDB\Query\Degeneration\Conditions::getBind() does not have @return annotation for its traversable return value.

    {
        return $this->bindings;
    }

    static function __ifsets($matches, $markers)

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for __ifsets.

Method \ClickHouseDB\Query\Degeneration\Conditions::__ifsets() does not have parameter type hint nor @param annotation for its parameter $matches.

Method \ClickHouseDB\Query\Degeneration\Conditions::__ifsets() does not have parameter type hint nor @param annotation for its parameter $markers.

Method \ClickHouseDB\Query\Degeneration\Conditions::__ifsets() does not have return type hint nor @return annotation for its return value.

    {
        $content_false = '';

The variable $content_false should be in camel caps format.

        $condition = '';

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

        $flag_else = '';

The assignment to $flag_else is dead and can be removed.

The variable $flag_else should be in camel caps format.

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

//print_r($matches);
        if (sizeof($matches) == 4) {

Expected 1 lines after "if", found 0.

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

The use of function sizeof() is forbidden; use count() instead

Operator == is disallowed, use === instead.

            list($condition, $preset, $variable, $content_true) = $matches;

list(...) is forbidden, use [...] instead.

The variable $content_true should be in camel caps format.

        } elseif (sizeof($matches) == 6) {

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

The use of function sizeof() is forbidden; use count() instead

Operator == is disallowed, use === instead.

            list($condition, $preset, $variable, $content_true, $flag_else, $content_false) = $matches;

list(...) is forbidden, use [...] instead.

The variable $content_true should be in camel caps format.

The variable $flag_else should be in camel caps format.

The variable $content_false should be in camel caps format.

        } else {
            throw new QueryException('Error in parse Conditions' . json_encode($matches));

Function json_encode() should not be referenced via a fallback global name, but via a use statement.

        }
        $variable = trim($variable);

Function trim() should not be referenced via a fallback global name, but via a use statement.

        $preset = strtolower(trim($preset));

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

Function strtolower() should not be referenced via a fallback global name, but via a use statement.

Function trim() should not be referenced via a fallback global name, but via a use statement.

        if ($preset == '') {

Expected 1 lines after "if", found 0.

Operator == is disallowed, use === instead.

            return (isset($markers[$variable]) && ($markers[$variable] || is_numeric($markers[$variable])))

Useless parentheses.

Function is_numeric() should not be referenced via a fallback global name, but via a use statement.

                ? $content_true

The variable $content_true should be in camel caps format.

                : $content_false;

The variable $content_false should be in camel caps format.

        }
        if ($preset == 'set') {

Operator == is disallowed, use === instead.

Expected 1 lines after "if", found 0.

            return (isset($markers[$variable]) && !empty($markers[$variable])) ? $content_true : $content_false;

The variable $content_true should be in camel caps format.

Useless parentheses.

The variable $content_false should be in camel caps format.

Expected 1 space after NOT operator; 0 found

        }
        if ($preset == 'bool') {

Expected 1 lines after "if", found 0.

Operator == is disallowed, use === instead.

            return (isset($markers[$variable]) && is_bool($markers[$variable]) && $markers[$variable] == true)

Operator == is disallowed, use === instead.

Useless parentheses.

Function is_bool() should not be referenced via a fallback global name, but via a use statement.

                ? $content_true

The variable $content_true should be in camel caps format.

                : $content_false;

The variable $content_false should be in camel caps format.

        }
        if ($preset == 'string') {

Expected 1 lines after "if", found 0.

Operator == is disallowed, use === instead.

            return (isset($markers[$variable]) && is_string($markers[$variable]) && strlen($markers[$variable]))

Useless parentheses.

Function is_string() should not be referenced via a fallback global name, but via a use statement.

Function strlen() should not be referenced via a fallback global name, but via a use statement.

                ? $content_true

The variable $content_true should be in camel caps format.

                : $content_false;

The variable $content_false should be in camel caps format.

        }
        if ($preset == 'int') {

Operator == is disallowed, use === instead.

            return (isset($markers[$variable]) && intval($markers[$variable]) <> 0)

Useless parentheses.

Function intval() should not be referenced via a fallback global name, but via a use statement.

Operator <> is disallowed, use !== instead.

                ? $content_true

The variable $content_true should be in camel caps format.

                : $content_false;

The variable $content_false should be in camel caps format.

        }

        return '';
    }

    /**
     * @param string $sql

Incorrect annotations group.

     * @return mixed
     */
    public function process($sql)

Method \ClickHouseDB\Query\Degeneration\Conditions::process() does not have native type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

    {
        $markers = $this->bindings;

        // ------ if/else conditions & if[set|int]/else conditions -----
        $sql = preg_replace_callback('#\{if(.{0,}?)\s+([^\}]+?)\}(.+?)(\{else\}([^\{]+?)?)?\s*\{\/if}#sui', function ($matches) use ($markers) {

Function preg_replace_callback() should not be referenced via a fallback global name, but via a use statement.

Closure not using "$this" should be declared static.

            return self::__ifsets($matches, $markers);
        }
            , $sql);

Space found before comma in argument list

        return $sql;

        /*
         * $ifint var ELSE  {ENDIF}
         *
         */

        // stackoverflow
        // if(whatever) {  } else { adsffdsa } else if() { }
        // /^if\s*\((.*?)\)\s*{(.*?)}(\s*(else|else\s+if\s*\((.*?)\))\s*{(.*?)})*/
        // if (condition_function(params)) {
        //     statements;
        //}
        // if\s*\(((?:(?:(?:"(?:(?:\\")|[^"])*")|(?:'(?:(?:\\')|[^'])*'))|[^\(\)]|\((?1)\))*+)\)\s*{((?:(?:(?:"(?:(?:\\")|[^"])*")|(?:'(?:(?:\\')|[^'])*'))|[^{}]|{(?2)})*+)}\s*(?:(?:else\s*{((?:(?:(?:"(?:(?:\\")|[^"])*")|(?:'(?:(?:\\')|[^'])*'))|[^{}]|{(?3)})*+)}\s*)|(?:else\s*if\s*\(((?:(?:(?:"(?:(?:\\")|[^"])*")|(?:'(?:(?:\\')|[^'])*'))|[^\(\)]|\((?4)\))*+)\)\s*{((?:(?:(?:"(?:(?:\\")|[^"])*")|(?:'(?:(?:\\')|[^'])*'))|[^{}]|{(?5)})*+)}\s*))*;
        // @if\s*\(\s*([^)]*)\s*\)\s*(((?!@if|@endif).)*)\s*(?:@else\s*(((?!@if|@endif).)*))?\s*@endif
        // @if \s* \( \s* ([^)]*)\s*\)\s*(((?!@if|@endif).)*)\s*(?:@else\s*(((?!@if|@endif).)*))?\s*@endif
        // [^}]

        //        // 3. process if conditions
        //        $sql = preg_replace_callback('#\{if\s(.+?)}(.+?)\{/if}#sui', function($matches) use ($markers) {
        //            list($condition, $variable, $content) = $matches;
        //            if (isset($markers[$variable]) && ($markers[$variable] || is_numeric($markers[$variable]))) {
        //                return $content;
        //            }
        //        }, $sql);

        // 1. process if[set|int]/else conditions
        //        $sql = preg_replace_callback('#\{if(.{1,}?)\s(.+?)}(.+?)\{else}(.+?)\{/if}#sui', function($matches) use ($markers) {return  self::__ifsets($matches, $markers, true); }, $sql);
        //        $sql = preg_replace_callback('#\{if(.{1,}?)\s(.+?)}(.+?)\{/if}#sui', function($matches) use ($markers) { return self::__ifsets($matches, $markers, false); }, $sql);
    }

Expected 0 blank lines after function; 1 found

}

There must be exactly 0 empty lines before class closing brace.