Settings::set() - Code Metrics - Inspection of "Merge pull request #64 from smi2/scrutinizer-patch..." - smi2/phpClickHouse - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5a27f9...28edde )

by Igor

created 2018-06-22 11:31 UTC

Settings::set() A

↳ Parent: Settings

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	4
rs	10
ccs	3
cts	3
cp	1
cc	1
eloc	2
nc	1
nop	2
crap	1

<?php

namespace ClickHouseDB;

use ClickHouseDB\Transport\Http;

class Settings
{
    /**
     * @var Http
     */
    private $client = null;

    /**
     * @var array
     */
    private $settings = [];

    private $_ReadOnlyUser = false;

    /**
     * @var bool
     */
    private $_isHttps = false;


    /**
     * Settings constructor.
     * @param Http $client
     */
    public function __construct(Http $client)
    {
        $default = [
            'extremes'                => false,
            'readonly'                => true,
            'max_execution_time'      => 20,
            'enable_http_compression' => 0,
            'https'                   => false
        ];

        $this->settings = $default;
        $this->client = $client;
    }

    /**
     * @param string|int $key
     * @return mixed
     */
    public function get($key)
    {
        if (!$this->is($key)) {
            return null;
        }
        return $this->settings[$key];
    }

    /**
     * @param string|int $key
     * @return bool
     */
    public function is($key)
    {
        return isset($this->settings[$key]);
    }


    /**
     * @param string|int $key
     * @param mixed $value
     * @return $this
     */
    public function set($key, $value)
    {
        $this->settings[$key] = $value;
        return $this;
    }

    /**
     * @return mixed
     */
    public function getDatabase()
    {
        return $this->get('database');
    }

    /**
     * @param string $db
     * @return $this
     */
    public function database($db)
    {
        $this->set('database', $db);
        return $this;
    }

    /**
     * @return mixed
     */
    public function getTimeOut()
    {
        return $this->get('max_execution_time');
    }

    /**
     * @return mixed|null
     */
    public function isEnableHttpCompression()
    {
        return $this->getSetting('enable_http_compression');
    }

    /**
     * @param bool|int $flag
     * @return $this
     */
    public function enableHttpCompression($flag)
    {
        $this->set('enable_http_compression', intval($flag));
        return $this;
    }


    public function https($flag = true)
    {
        $this->set('https', $flag);
        return $this;
    }

    public function isHttps()
    {
        return $this->get('https');
    }


    /**
     * @param int|bool $flag
     * @return $this
     */
    public function readonly($flag)
    {
        $this->set('readonly', $flag);
        return $this;
    }

    /**
     * @param string $session_id
     * @return $this
     */
    public function session_id($session_id)
    {
        $this->set('session_id', $session_id);
        return $this;
    }
    /**
     * @return mixed
     */
    public function getSessionId()
    {
        if (empty($this->settings['session_id'])) {
            return false;
        }
        return $this->get('session_id');
    }

    /**
     * @return string
     */
    public function makeSessionId()
    {
        $this->session_id(sha1(uniqid('', true)));
        return $this->getSessionId();

    }

    /**
     * @param int $time
     * @return $this
     */
    public function max_execution_time($time)
    {
        $this->set('max_execution_time', $time);
        return $this;
    }

    /**
     * @return array
     */
    public function getSettings()
    {
        return $this->settings;
    }

    /**
     * @param array $settings_array
     * @return $this
     */
    public function apply($settings_array)
    {
        foreach ($settings_array as $key => $value) {
            $this->set($key, $value);
        }

        return $this;
    }

    /**
     * @param int|bool $flag
     */
    public function setReadOnlyUser($flag)
    {
        $this->_ReadOnlyUser = $flag;
    }

    /**
     * @return bool
     */
    public function isReadOnlyUser()
    {
        return $this->_ReadOnlyUser;
    }

    /**
     * @param string $name
     * @return mixed|null
     */
    public function getSetting($name)
    {
        if (!isset($this->settings[$name])) {
            return null;
        }

        return $this->get($name);
    }
}


1		<?php
2
3		namespace ClickHouseDB;
4
5		use ClickHouseDB\Transport\Http;
6
7		class Settings
8		{
9		/**
10		* @var Http
11		*/
12		private $client = null;
13
14		/**
15		* @var array
16		*/
17		private $settings = [];
18
19		private $_ReadOnlyUser = false;
20
21		/**
22		* @var bool
23		*/
24		private $_isHttps = false;
		0 ignored issues – show introduced 2018-05-14 13:41 UTC by Report Bug Copy Issue Report The private property `$_isHttps` is not used, and could be removed. Loading history...
25
26		/**
27		* Settings constructor.
28		* @param Http $client
29		*/
30	44	public function __construct(Http $client)
31		{
32		$default = [
33	44	'extremes' => false,
34		'readonly' => true,
35		'max_execution_time' => 20,
36		'enable_http_compression' => 0,
37		'https' => false
38		];
39
40	44	$this->settings = $default;
41	44	$this->client = $client;
42	44	}
43
44		/**
45		* @param string\|int $key
46		* @return mixed
47		*/
48	36	public function get($key)
49		{
50	36	if (!$this->is($key)) {
51		return null;
52		}
53	36	return $this->settings[$key];
54		}
55
56		/**
57		* @param string\|int $key
58		* @return bool
59		*/
60	36	public function is($key)
61		{
62	36	return isset($this->settings[$key]);
63		}
64
65
66		/**
67		* @param string\|int $key
68		* @param mixed $value
69		* @return $this
70		*/
71	44	public function set($key, $value)
72		{
73	44	$this->settings[$key] = $value;
74	44	return $this;
75		}
76
77		/**
78		* @return mixed
79		*/
80	1	public function getDatabase()
81		{
82	1	return $this->get('database');
83		}
84
85		/**
86		* @param string $db
87		* @return $this
88		*/
89	44	public function database($db)
90		{
91	44	$this->set('database', $db);
92	44	return $this;
93		}
94
95		/**
96		* @return mixed
97		*/
98	36	public function getTimeOut()
99		{
100	36	return $this->get('max_execution_time');
101		}
102
103		/**
104		* @return mixed\|null
105		*/
106	36	public function isEnableHttpCompression()
107		{
108	36	return $this->getSetting('enable_http_compression');
109		}
110
111		/**
112		* @param bool\|int $flag
113		* @return $this
114		*/
115	27	public function enableHttpCompression($flag)
116		{
117	27	$this->set('enable_http_compression', intval($flag));
118	27	return $this;
119		}
120
121
122		public function https($flag = true)
123		{
124		$this->set('https', $flag);
125		return $this;
126		}
127
128	36	public function isHttps()
129		{
130	36	return $this->get('https');
131		}
132
133
134		/**
135		* @param int\|bool $flag
136		* @return $this
137		*/
138		public function readonly($flag)
139		{
140		$this->set('readonly', $flag);
141		return $this;
142		}
143
144		/**
145		* @param string $session_id
146		* @return $this
147		*/
148	2	public function session_id($session_id)
149		{
150	2	$this->set('session_id', $session_id);
151	2	return $this;
152		}
153		/**
154		* @return mixed
155		*/
156	36	public function getSessionId()
157		{
158	36	if (empty($this->settings['session_id'])) {
159	36	return false;
160		}
161	2	return $this->get('session_id');
162		}
163
164		/**
165		* @return string
166		*/
167	2	public function makeSessionId()
168		{
169	2	$this->session_id(sha1(uniqid('', true)));
170	2	return $this->getSessionId();
		0 ignored issues – show Bug Best Practice introduced 2018-06-19 11:33 UTC by Report Bug Copy Issue Report The expression `return $this->getSessionId()` could also return `false` which is incompatible with the documented return type `string`. Did you maybe forget to handle an error condition? If the returned type also contains false, it is an indicator that maybe an error condition leading to the specific return statement remains unhandled. Loading history...
171		}
172
173		/**
174		* @param int $time
175		* @return $this
176		*/
177	2	public function max_execution_time($time)
178		{
179	2	$this->set('max_execution_time', $time);
180	2	return $this;
181		}
182
183		/**
184		* @return array
185		*/
186	36	public function getSettings()
187		{
188	36	return $this->settings;
189		}
190
191		/**
192		* @param array $settings_array
193		* @return $this
194		*/
195	2	public function apply($settings_array)
196		{
197	2	foreach ($settings_array as $key => $value) {
198	2	$this->set($key, $value);
199		}
200
201	2	return $this;
202		}
203
204		/**
205		* @param int\|bool $flag
206		*/
207		public function setReadOnlyUser($flag)
208		{
209		$this->_ReadOnlyUser = $flag;
210		}
211
212		/**
213		* @return bool
214		*/
215	36	public function isReadOnlyUser()
216		{
217	36	return $this->_ReadOnlyUser;
218		}
219
220		/**
221		* @param string $name
222		* @return mixed\|null
223		*/
224	36	public function getSetting($name)
225		{
226	36	if (!isset($this->settings[$name])) {
227		return null;
228		}
229
230	36	return $this->get($name);
231		}
232		}
233

smi2 / phpClickHouse

Push — master ( 5a27f9...28edde )

Settings::set() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like