ClickHouseDB\Transport\Http::streaming()

Complexity

Conditions	9
Paths	322

Size

Total Lines	62
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	10.7781

Importance

Changes

0

<?php
    private function streaming(Stream $streamRW,CurlerRequest $request)

Method \ClickHouseDB\Transport\Http::streaming() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Statement".

Expected 1 space between comma and type hint "CurlerRequest"; 0 found

    {
        $callable=$streamRW->getClosure();

Equals sign not aligned with surrounding assignments; expected 1 space but found 0 spaces

        $stream=$streamRW->getStream();

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 0 spaces

Functions must not contain multiple empty lines in a row; found 3 empty lines

        try {

Blank line found at start of control structure

Functions must not contain multiple empty lines in a row; found 2 empty lines

            if (!is_callable($callable)) {

There must be a single space after a NOT operator; 0 found

Function is_callable() should not be referenced via a fallback global name, but via a use statement.

                if ($streamRW->isWrite())
                {

Blank line found at start of control structure

                    $callable = function ($ch, $fd, $length) use ($stream) {
                        return ($line = fread($stream, $length)) ? $line : '';

Function fread() should not be referenced via a fallback global name, but via a use statement.

                    };
                } else {
                    $callable = function ($ch, $fd) use ($stream) {
                        return fwrite($stream, $fd);

Function fwrite() should not be referenced via a fallback global name, but via a use statement.

                    };
                }
            }

            if ($streamRW->isGzipHeader()) {

Blank line found at start of control structure

                if ($streamRW->isWrite())
                {
                    $request->header('Content-Encoding', 'gzip');
                    $request->header('Content-Type', 'application/x-www-form-urlencoded');
                } else {
                    $request->header('Accept-Encoding', 'gzip');
                }

Blank line found after control structure

Blank line found at end of control structure

            }

Functions must not contain multiple empty lines in a row; found 3 empty lines

            $request->header('Transfer-Encoding', 'chunked');

Functions must not contain multiple empty lines in a row; found 2 empty lines

            if ($streamRW->isWrite())
            {
                $request->setReadFunction($callable);
            } else {
                $request->setWriteFunction($callable);

Functions must not contain multiple empty lines in a row; found 3 empty lines

//                $request->setHeaderFunction($callableHead);
            }

Functions must not contain multiple empty lines in a row; found 2 empty lines

            $this->_curler->execOne($request,true);
            $response = new Statement($request);
            if ($response->isError()) {
                $response->error();
            }

No blank line found after control structure

            return $response;
        } finally {
            if ($streamRW->isWrite())

It is generally a best practice to always use braces with control structures.

            fclose($stream);

Function fclose() should not be referenced via a fallback global name, but via a use statement.

        }