CurlerRolling::__destructor() - Code Metrics - Inspection of "Add support PHP 8" - smi2/phpClickHouse - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4f9fcc...6c92c6 )

by Igor

created 2021-01-20 05:28 UTC

CurlerRolling::__destructor() A

↳ Parent: CurlerRolling

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10

<?php

introduced 2019-03-13 07:05 UTC by

Missing declare(strict_types=1).

namespace ClickHouseDB\Transport;

use ClickHouseDB\Exception\TransportException;

class CurlerRolling

    const SLEEP_DELAY = 1000; // 1ms

introduced 2020-01-17 15:54 UTC by

Constant \ClickHouseDB\Transport\CurlerRolling::SLEEP_DELAY visibility missing.

/**

     * @var int

     * Max number of simultaneous requests.

*/

    private $simultaneousLimit = 10;

/**

     * @var array

introduced 2020-12-21 16:16 UTC by

@var annotation of property \ClickHouseDB\Transport\CurlerRolling::$activeRequests does not specify type hint for its items.

     * Requests currently being processed by curl

*/

    private $activeRequests = [];

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRolling::$runningRequests with single line content, use one-line comment instead.

     * @var int

*/

    private $runningRequests = 0;

/**

     * @var CurlerRequest[]

     * Requests queued to be processed

*/

    private $pendingRequests = [];

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRolling::$completedRequestCount with single line content, use one-line comment instead.

     * @return int

*/

    private $completedRequestCount = 0;

introduced 2020-12-21 16:16 UTC by

Property \ClickHouseDB\Transport\CurlerRolling::$completedRequestCount does not have @var annotation for its value.

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRolling::$_pool_master with single line content, use one-line comment instead.

     * @var null|resource

introduced 2020-12-21 16:16 UTC by

Null type hint should be on last position in "null|resource".

*/

    private $_pool_master = null;

Coding Style introduced 2020-12-21 16:16 UTC by

Member variable "_pool_master" is not in valid camel caps format

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRolling::$waitRequests with single line content, use one-line comment instead.

     * @var int

*/

    private $waitRequests = 0;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRolling::$handleMapTasks with single line content, use one-line comment instead.

     * @var array

introduced 2020-12-21 16:16 UTC by

@var annotation of property \ClickHouseDB\Transport\CurlerRolling::$handleMapTasks does not specify type hint for its items.

*/

    private $handleMapTasks = [];

/**

introduced 2018-07-08 20:56 UTC by

Empty comment

*/

    public function __destructor()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::__destructor() does not have void return type hint.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::__destructor() does not need documentation comment.

        $this->close();

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

/**

     * @return resource

*/

    private function handlerMulti()

        if (!$this->_pool_master) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $_pool_master should be in camel caps format.

            $this->_pool_master = curl_multi_init();

introduced 2018-07-08 20:56 UTC by

Function curl_multi_init() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $_pool_master should be in camel caps format.

Documentation Bug introduced 2021-01-19 11:08 UTC by

It seems like curl_multi_init() of type CurlMultiHandle or true is incompatible with the declared type null|resource of property $_pool_master.

            if (function_exists('curl_multi_setopt')) {

introduced 2018-07-08 20:56 UTC by

Function function_exists() should not be referenced via a fallback global name, but via a use statement.

                curl_multi_setopt($this->_pool_master, CURLMOPT_MAXCONNECTS, $this->simultaneousLimit);

introduced 2018-07-08 20:56 UTC by

Function curl_multi_setopt() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Constant CURLMOPT_MAXCONNECTS should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $_pool_master should be in camel caps format.

Bug introduced 2021-01-19 11:08 UTC by

It seems like $this->_pool_master can also be of type true; however, parameter $multi_handle of curl_multi_setopt() does only seem to accept CurlMultiHandle|resource, maybe add an additional type check? ( Ignorable by Annotation )

        return $this->_pool_master;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $_pool_master should be in camel caps format.

Bug Best Practice introduced 2021-01-19 11:08 UTC by

The expression return $this->_pool_master also could return the type CurlMultiHandle|true which is incompatible with the documented return type resource.

/**

introduced 2018-07-08 20:56 UTC by

Empty comment

*/

    public function close()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::close() does not have void return type hint.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::close() does not need documentation comment.

        if ($this->_pool_master) {

introduced 2018-07-08 20:56 UTC by

Use early exit to reduce code nesting.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $_pool_master should be in camel caps format.

            curl_multi_close($this->handlerMulti());

introduced 2018-07-08 20:56 UTC by

Function curl_multi_close() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

/**

     * @param CurlerRequest $req

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::addQueLoop() has useless @param annotation for parameter $req.

     * @param bool $checkMultiAdd

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 10 spaces after parameter type; 1 found

     * @param bool $force

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 10 spaces after parameter type; 1 found

     * @return bool

     * @throws TransportException

*/

100

    public function addQueLoop(CurlerRequest $req, $checkMultiAdd = true, $force = false)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::addQueLoop() does not have native type hint for its parameter $checkMultiAdd but it should be possible to add it based on @param annotation "bool".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::addQueLoop() does not have native type hint for its parameter $force but it should be possible to add it based on @param annotation "bool".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::addQueLoop() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "bool".

101

102

        $id = $req->getId();

103

104

        if (!$id) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

105

            $id = $req->getUniqHash($this->completedRequestCount);

106

107

108

        if (!$force && isset($this->pendingRequests[$id])) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

109

            if (!$checkMultiAdd) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

110

                return false;

111

112

113

            throw new TransportException("Cant add exists que - cant overwrite : $id!\n");

Coding Style Best Practice introduced 2019-11-28 14:43 UTC by

Variable "$id" not allowed in double quoted string; use sprintf() or concatenation instead

114

115

116

        $this->pendingRequests[$id] = $req;

117

        return true;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

118

119

120

/**

121

     * @param resource $oneHandle

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

122

     * @return CurlerResponse

123

*/

124

    private function makeResponse($oneHandle)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::makeResponse() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "CurlerResponse".

125

126

        $response = curl_multi_getcontent($oneHandle);

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

introduced 2018-07-08 20:56 UTC by

Function curl_multi_getcontent() should not be referenced via a fallback global name, but via a use statement.

127

        $header_size = curl_getinfo($oneHandle, CURLINFO_HEADER_SIZE);

introduced 2018-07-08 20:56 UTC by

Function curl_getinfo() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Constant CURLINFO_HEADER_SIZE should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_size should be in camel caps format.

128

        $header = substr($response, 0, $header_size);

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

introduced 2018-07-08 20:56 UTC by

Function substr() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_size should be in camel caps format.

129

        $body = substr($response, $header_size);

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

introduced 2018-07-08 20:56 UTC by

Function substr() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_size should be in camel caps format.

130

131

        $n = new CurlerResponse();

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space

132

        $n->_headers = $this->parse_headers_from_curl_response($header);

133

        $n->_body = $body;

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

134

        $n->_info = curl_getinfo($oneHandle);

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

introduced 2018-07-08 20:56 UTC by

Function curl_getinfo() should not be referenced via a fallback global name, but via a use statement.

135

        $n->_error = curl_error($oneHandle);

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

introduced 2018-07-08 20:56 UTC by

Function curl_error() should not be referenced via a fallback global name, but via a use statement.

136

        $n->_errorNo = curl_errno($oneHandle);

introduced 2018-07-08 20:56 UTC by

Function curl_errno() should not be referenced via a fallback global name, but via a use statement.

137

        $n->_useTime = 0;

138

139

        return $n;

140

141

142

/**

143

     * @return bool

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

144

     * @throws TransportException

145

*/

146

    public function execLoopWait()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::execLoopWait() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "bool".

147

148

        do {

149

            $this->exec();

150

            usleep(self::SLEEP_DELAY);

introduced 2020-01-17 15:54 UTC by

Function usleep() should not be referenced via a fallback global name, but via a use statement.

151

        } while (($this->countActive() + $this->countPending()) > 0);

introduced 2020-12-21 16:16 UTC by

Useless parentheses.

152

153

        return true;

154

155

156

/**

157

     * @param string $response

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

158

     * @return array

introduced 2020-12-21 16:16 UTC by

@return annotation of method \ClickHouseDB\Transport\CurlerRolling::parse_headers_from_curl_response() does not specify type hint for items of its traversable return value.

159

*/

160

    private function parse_headers_from_curl_response($response)

Coding Style introduced 2018-07-08 20:56 UTC by

Method name "CurlerRolling::parse_headers_from_curl_response" is not in camel caps format

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::parse_headers_from_curl_response() does not have native type hint for its parameter $response but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::parse_headers_from_curl_response() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "array".

161

162

        $headers = [];

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

163

        $header_text = $response;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_text should be in camel caps format.

164

165

        foreach (explode("\r\n", $header_text) as $i => $line) {

introduced 2018-07-08 20:56 UTC by

Function explode() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $header_text should be in camel caps format.

166

            if ($i === 0) {

167

                $headers['http_code'] = $line;

168

            } else {

169

                $r = explode(': ', $line);

introduced 2018-07-08 20:56 UTC by

Function explode() should not be referenced via a fallback global name, but via a use statement.

170

                if (sizeof($r) == 2) {

introduced 2018-07-08 20:56 UTC by

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

The use of function sizeof() is forbidden; use count() instead

introduced 2020-12-21 16:16 UTC by

Operator == is disallowed, use === instead.

171

                    $headers[$r[0]] = $r[1];

172

173

174

175

176

        return $headers;

177

178

179

/**

180

     * @return int

181

*/

182

    public function countPending()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::countPending() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "int".

183

184

        return sizeof($this->pendingRequests);

introduced 2018-07-08 20:56 UTC by

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

The use of function sizeof() is forbidden; use count() instead

185

186

187

/**

188

     * @return int

189

*/

190

    public function countActive()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::countActive() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "int".

191

192

        return count($this->activeRequests);

introduced 2018-07-08 20:56 UTC by

Function count() should not be referenced via a fallback global name, but via a use statement.

193

194

195

/**

196

     * @return int

197

*/

198

    public function countCompleted()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::countCompleted() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "int".

199

200

        return $this->completedRequestCount;

201

202

203

/**

204

     * Set the limit for how many cURL requests will be execute simultaneously.

205

206

     * Please be mindful that if you set this too high, requests are likely to fail

207

     * more frequently or automated software may perceive you as a DOS attack and

208

     * automatically block further requests.

209

210

     * @param int $count

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

211

     * @throws \InvalidArgumentException

introduced 2018-09-26 10:27 UTC by

Class \InvalidArgumentException should not be referenced via a fully qualified name, but via a use statement.

212

     * @return $this

213

*/

214

    public function setSimultaneousLimit($count)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::setSimultaneousLimit() does not have native type hint for its parameter $count but it should be possible to add it based on @param annotation "int".

215

216

        if (!is_int($count) || $count < 2) {

introduced 2018-10-23 07:05 UTC by

The condition is_int($count) is always true.

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

introduced 2018-07-08 20:56 UTC by

Function is_int() should not be referenced via a fallback global name, but via a use statement.

217

            throw new \InvalidArgumentException("setSimultaneousLimit count must be an int >= 2");

introduced 2018-09-26 10:27 UTC by

Class \InvalidArgumentException should not be referenced via a fully qualified name, but via a use statement.

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal setSimultaneousLimit count must be an int >= 2 does not require double quotes, as per coding-style, please use single quotes.

218

219

220

        $this->simultaneousLimit = $count;

221

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

222

223

224

/**

225

     * @return int

226

*/

227

    public function getSimultaneousLimit()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::getSimultaneousLimit() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "int".

228

229

        return $this->simultaneousLimit;

230

231

232

/**

233

     * @return int

234

*/

235

    public function getRunningRequests()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::getRunningRequests() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "int".

236

237

        return $this->runningRequests;

238

239

240

/**

241

     * @param CurlerRequest $request

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::execOne() has useless @param annotation for parameter $request.

242

     * @param bool $auto_close

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 10 spaces after parameter type; 1 found

243

     * @return mixed

244

     * @throws TransportException

245

*/

246

    public function execOne(CurlerRequest $request, $auto_close = false)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::execOne() does not have native type hint for its parameter $auto_close but it should be possible to add it based on @param annotation "bool".

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $auto_close should be in camel caps format.

247

248

        $h = $request->handle();

249

        curl_exec($h);

introduced 2018-07-08 20:56 UTC by

Function curl_exec() should not be referenced via a fallback global name, but via a use statement.

250

251

        $request->setResponse($this->makeResponse($h));

Bug introduced 2021-01-19 11:08 UTC by

It seems like $h can also be of type CurlHandle; however, parameter $oneHandle of ClickHouseDB\Transport\C...Rolling::makeResponse() does only seem to accept resource, maybe add an additional type check? ( Ignorable by Annotation )

252

253

        if ($auto_close) {

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $auto_close should be in camel caps format.

254

            $request->close();

255

256

257

        return $request->response()->http_code();

258

259

260

/**

261

     * @return string

262

*/

263

    public function getInfo()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::getInfo() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "string".

264

265

        return "runningRequests = {$this->runningRequests} , pending=" . sizeof($this->pendingRequests) . " ";

Coding Style Best Practice introduced 2019-11-28 14:43 UTC by

Variable "$this" not allowed in double quoted string; use sprintf() or concatenation instead

introduced 2018-07-08 20:56 UTC by

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

The use of function sizeof() is forbidden; use count() instead

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal does not require double quotes, as per coding-style, please use single quotes.

266

267

268

/**

269

     * @throws TransportException

270

*/

271

    public function exec()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::exec() does not have return type hint nor @return annotation for its return value.

272

273

        $this->makePendingRequestsQue();

274

275

        // ensure we're running

276

        // a request was just completed -- find out which one

277

278

        while (($execrun = curl_multi_exec($this->handlerMulti(), $running)) == CURLM_CALL_MULTI_PERFORM);

introduced 2018-07-08 20:56 UTC by

Function curl_multi_exec() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Constant CURLM_CALL_MULTI_PERFORM should not be referenced via a fallback global name, but via a use statement.

introduced 2020-12-21 16:16 UTC by

Operator == is disallowed, use === instead.

279

280

        if ($execrun != CURLM_OK) {

introduced 2018-07-08 20:56 UTC by

Constant CURLM_OK should not be referenced via a fallback global name, but via a use statement.

introduced 2020-12-21 16:16 UTC by

Operator != is disallowed, use !== instead.

281

            throw new TransportException("[ NOT CURLM_OK ]");

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal [ NOT CURLM_OK ] does not require double quotes, as per coding-style, please use single quotes.

282

283

284

        $this->runningRequests = $running;

285

286

        while ($done = curl_multi_info_read($this->handlerMulti())) {

introduced 2018-07-08 20:56 UTC by

Function curl_multi_info_read() should not be referenced via a fallback global name, but via a use statement.

287

            $response = $this->makeResponse($done['handle']);

288

289

            // send the return values to the callback function.

290

Coding Style introduced 2021-01-20 05:35 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

291

292

            if (is_object($done['handle'])) {

introduced 2021-01-20 05:35 UTC by

Function is_object() should not be referenced via a fallback global name, but via a use statement.

293

                $key = spl_object_id( $done['handle'] );

introduced 2021-01-20 05:35 UTC by

Function spl_object_id() should not be referenced via a fallback global name, but via a use statement.

294

            } else {

295

                $key = (string) $done['handle'] ;

Coding Style introduced 2021-01-20 05:35 UTC by

Space found before semicolon; expected "];" but found "] ;"

296

297

298

            $task_id = $this->handleMapTasks[$key];

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

299

            $request = $this->pendingRequests[$this->handleMapTasks[$key]];

300

301

            unset($this->handleMapTasks[$key]);

302

            unset($this->activeRequests[$task_id]);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

303

304

            $this->pendingRequests[$task_id]->setResponse($response);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

305

            $this->pendingRequests[$task_id]->onCallback();

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

306

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

307

308

            if (!$request->isPersistent()) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

309

                unset($this->pendingRequests[$task_id]);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

310

311

312

            $this->completedRequestCount++;

313

314

            // remove the curl handle that just completed

315

            curl_multi_remove_handle($this->handlerMulti(), $done['handle']);

introduced 2018-07-08 20:56 UTC by

Function curl_multi_remove_handle() should not be referenced via a fallback global name, but via a use statement.

316

317

            // if something was requeued, this will get it running/update our loop check values

318

            $status = curl_multi_exec($this->handlerMulti(), $active);

Unused Code introduced 2018-05-14 13:41 UTC by

The assignment to $status is dead and can be removed.

introduced 2018-07-08 20:56 UTC by

Function curl_multi_exec() should not be referenced via a fallback global name, but via a use statement.

319

320

321

        // see if there is anything to read

322

        curl_multi_select($this->handlerMulti(), 0.01);

introduced 2018-07-08 20:56 UTC by

Function curl_multi_select() should not be referenced via a fallback global name, but via a use statement.

323

        return $this->countActive();

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

324

325

326

    public function makePendingRequestsQue()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::makePendingRequestsQue() does not have void return type hint.

327

328

        $max = $this->getSimultaneousLimit();

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

329

        $active = $this->countActive();

330

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

331

332

        if ($active < $max) {

333

            $canAdd = $max - $active;

334

//            $pending = sizeof($this->pendingRequests);

335

336

            $add = [];

337

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

338

339

            foreach ($this->pendingRequests as $task_id => $params) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "foreach", found 2.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

340

                if (empty($this->activeRequests[$task_id])) {

introduced 2018-07-08 20:56 UTC by

Use early exit to reduce code nesting.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

341

                    $add[$task_id] = $task_id;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

342

343

344

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

345

346

            if (sizeof($add)) {

introduced 2018-07-08 20:56 UTC by

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

The use of function sizeof() is forbidden; use count() instead

347

                if ($canAdd >= sizeof($add)) {

introduced 2018-07-08 20:56 UTC by

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

The use of function sizeof() is forbidden; use count() instead

348

                    $ll = $add;

349

                } else {

350

                    $ll = array_rand($add, $canAdd);

introduced 2018-07-08 20:56 UTC by

Function array_rand() should not be referenced via a fallback global name, but via a use statement.

351

                    if (!is_array($ll)) {

Coding Style introduced 2019-03-13 07:05 UTC by

Expected 1 space(s) after NOT operator; 0 found

introduced 2018-07-08 20:56 UTC by

Function is_array() should not be referenced via a fallback global name, but via a use statement.

352

                        $ll = array($ll => $ll);

Coding Style introduced 2018-07-08 20:56 UTC by

Short array syntax must be used to define arrays

353

354

355

356

                foreach ($ll as $task_id) {

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

357

                    $this->_prepareLoopQue($task_id);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

358

359

            }// if add

360

        }// if can add

361

362

363

/**

364

     * @param string $task_id

365

*/

366

    private function _prepareLoopQue($task_id)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::_prepareLoopQue() does not have native type hint for its parameter $task_id but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRolling::_prepareLoopQue() does not have void return type hint.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

367

368

        $this->activeRequests[$task_id] = 1;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

369

        $this->waitRequests++;

370

371

        $h = $this->pendingRequests[$task_id]->handle();

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

372

373

        // pool

374

        curl_multi_add_handle($this->handlerMulti(), $h);

introduced 2018-07-08 20:56 UTC by

Function curl_multi_add_handle() should not be referenced via a fallback global name, but via a use statement.

375

376

        if (is_object($h)) {

introduced 2021-01-20 05:35 UTC by

Function is_object() should not be referenced via a fallback global name, but via a use statement.

377

            $key = spl_object_id( $h );

introduced 2021-01-20 05:35 UTC by

Function spl_object_id() should not be referenced via a fallback global name, but via a use statement.

378

        } else {

379

            $key = (string) $h ;

Coding Style introduced 2021-01-20 05:35 UTC by

Space found before semicolon; expected "$h;" but found "$h ;"

380

381

382

        $this->handleMapTasks[$key] = $task_id;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $task_id should be in camel caps format.

383

384

385

smi2 / phpClickHouse

Push — master ( 4f9fcc...6c92c6 )

CurlerRolling::__destructor() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like