UInt64::fromString() - Code Metrics - Inspection of "Uint64 values" - smi2/phpClickHouse - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#94)

by Šimon

created 2018-09-25 13:55 UTC

UInt64::fromString() A

↳ Parent: UInt64

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace ClickHouseDB\Type;

final class UInt64 implements NumericType
{
    /** @var string */
    public $value;

    private function __construct(string $uint64Value)
    {
        $this->value = $uint64Value;
    }

    /**
     * @return self
     */
    public static function fromString(string $uint64Value)

    {
        return new self($uint64Value);
    }

    /**
     * @return string
     */
    public function getValue()

    {
        return $this->value;
    }

    /**
     * @return string
     */
    public function __toString()

    {
        return $this->value;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace ClickHouseDB\Type;
6
7		final class UInt64 implements NumericType
8		{
9		/** @var string */
10		public $value;
11
12	2	private function __construct(string $uint64Value)
13		{
14	2	$this->value = $uint64Value;
15	2	}
16
17		/**
18		* @return self
19		*/
20	2	public static function fromString(string $uint64Value)
		0 ignored issues – show introduced 2018-09-25 13:59 UTC by Report Bug Copy Issue Report Method \ClickHouseDB\Type\UInt64::fromString() does not have return type hint for its return value but it should be possible to add it based on @return annotation "self". Loading history...
21		{
22	2	return new self($uint64Value);
23		}
24
25		/**
26		* @return string
27		*/
28	1	public function getValue()
		0 ignored issues – show introduced 2018-09-25 13:59 UTC by Report Bug Copy Issue Report Method \ClickHouseDB\Type\UInt64::getValue() does not have return type hint for its return value but it should be possible to add it based on @return annotation "string". Loading history...
29		{
30	1	return $this->value;
31		}
32
33		/**
34		* @return string
35		*/
36	1	public function __toString()
		0 ignored issues – show introduced 2018-09-25 13:59 UTC by Report Bug Copy Issue Report Method \ClickHouseDB\Type\UInt64::__toString() does not have return type hint for its return value but it should be possible to add it based on @return annotation "string". Loading history...
37		{
38	1	return $this->value;
39		}
40		}
41

smi2 / phpClickHouse

Pull Request — master (#94)

UInt64::fromString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like