CurlerRequest::__destruct() - Code Metrics - Inspection of "Support KeepAlive to avoid duplicate connections" - smi2/phpClickHouse - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#220)

unknown

created 2024-07-19 08:41 UTC

CurlerRequest::__destruct() A

↳ Parent: CurlerRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
c	0
b	0
f	0
nc	1
nop	0
dl	0
loc	3
ccs	1
cts	1
cp	1
crap	1
rs	10

<?php

introduced 2019-03-13 07:05 UTC by

Missing declare(strict_types=1).

namespace ClickHouseDB\Transport;

use const CURLOPT_HTTPGET;

use const CURLOPT_POST;

class CurlerRequest

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$extendinfo with single line content, use one-line comment instead.

     * @var array

introduced 2020-12-21 16:16 UTC by

@var annotation of property \ClickHouseDB\Transport\CurlerRequest::$extendinfo does not specify type hint for its items.

*/

    public $extendinfo = [];

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$parameters with single line content, use one-line comment instead.

     * @var string|array

introduced 2020-12-21 16:16 UTC by

@var annotation of property \ClickHouseDB\Transport\CurlerRequest::$parameters does not specify type hint for its items.

*/

    private $parameters = '';

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$options with single line content, use one-line comment instead.

     * @var array

introduced 2020-12-21 16:16 UTC by

@var annotation of property \ClickHouseDB\Transport\CurlerRequest::$options does not specify type hint for its items.

*/

    private $options;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$headers with single line content, use one-line comment instead.

     * @var array

introduced 2020-12-21 16:16 UTC by

@var annotation of property \ClickHouseDB\Transport\CurlerRequest::$headers does not specify type hint for its items.

*/

    private $headers; // Parsed reponse header object.

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$url with single line content, use one-line comment instead.

     * @var string

*/

    private $url;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$method with single line content, use one-line comment instead.

     * @var string

*/

    private $method;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$id with single line content, use one-line comment instead.

     * @var bool

*/

    private $id;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$handle with single line content, use one-line comment instead.

     * @var resource|null

*/

    private $handle;

    /** @var CurlerResponse */

    private $response;

    /** @var bool */

    private $_persistent = false;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$_attachFiles with single line content, use one-line comment instead.

     * @var bool

*/

    private $_attachFiles = false;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$callback_class with single line content, use one-line comment instead.

     * @var string

*/

    private $callback_class = '';

Coding Style introduced 2020-12-21 16:16 UTC by

Member variable "callback_class" is not in valid camel caps format

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$callback_functionName with single line content, use one-line comment instead.

     * @var string

*/

    private $callback_functionName = '';

Coding Style introduced 2020-12-21 16:16 UTC by

Member variable "callback_functionName" is not in valid camel caps format

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$_httpCompression with single line content, use one-line comment instead.

     * @var bool

*/

    private $_httpCompression = false;

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$callback_function with single line content, use one-line comment instead.

     * @var callable

*/

    private $callback_function = null;

Coding Style introduced 2020-12-21 16:16 UTC by

Member variable "callback_function" is not in valid camel caps format

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$infile_handle with single line content, use one-line comment instead.

     * @var bool|resource

*/

    private $infile_handle = false;

Coding Style introduced 2020-12-21 16:16 UTC by

Member variable "infile_handle" is not in valid camel caps format

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$_dns_cache with single line content, use one-line comment instead.

     * @var int

*/

    private $_dns_cache = 120;

Coding Style introduced 2020-12-21 16:16 UTC by

Member variable "_dns_cache" is not in valid camel caps format

/**

introduced 2018-07-08 20:56 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$resultFileHandle with single line content, use one-line comment instead.

     * @var resource

*/

    private $resultFileHandle = null;

/**

introduced 2019-11-28 14:43 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$sslCa with single line content, use one-line comment instead.

     * @var string

*/

    private $sslCa = null;

introduced 2019-11-28 14:43 UTC by

The private property $sslCa is not used, and could be removed.

100

101

102

/**

introduced 2022-04-20 19:38 UTC by

Found multi-line comment for property \ClickHouseDB\Transport\CurlerRequest::$stdErrOut with single line content, use one-line comment instead.

103

     * @var null|resource

introduced 2022-04-20 19:38 UTC by

Null type hint should be on last position in "null|resource".

104

*/

105

    private $stdErrOut = null;

106

/**

107

     * @param bool $id

108

*/

109

    public function __construct($id = false, $handle = null)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::__construct() does not have native type hint for its parameter $id but it should be possible to add it based on @param annotation "bool".

Coding Style introduced 2022-04-20 19:38 UTC by

Expected 1 blank line before function; 0 found

introduced 2024-07-15 07:05 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::__construct() does not have parameter type hint nor @param annotation for its parameter $handle.

110

111

        $this->id = $id;

112

113

        $this->header('Cache-Control', 'no-cache, no-store, must-revalidate');

114

        $this->header('Expires', '0');

115

        $this->header('Pragma', 'no-cache');

116

117

        $this->options = array(

Coding Style introduced 2018-07-08 20:56 UTC by

Short array syntax must be used to define arrays

118

            CURLOPT_SSL_VERIFYHOST => 0,

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_SSL_VERIFYHOST should not be referenced via a fallback global name, but via a use statement.

119

            CURLOPT_SSL_VERIFYPEER => false,

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_SSL_VERIFYPEER should not be referenced via a fallback global name, but via a use statement.

120

            CURLOPT_TIMEOUT => 10,

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_TIMEOUT should not be referenced via a fallback global name, but via a use statement.

121

            CURLOPT_CONNECTTIMEOUT => 5, // Количество секунд ожидания при попытке соединения

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_CONNECTTIMEOUT should not be referenced via a fallback global name, but via a use statement.

122

            CURLOPT_HTTP_VERSION => CURL_HTTP_VERSION_1_1,

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_HTTP_VERSION should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Constant CURL_HTTP_VERSION_1_1 should not be referenced via a fallback global name, but via a use statement.

123

            CURLOPT_MAXREDIRS => 10,

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_MAXREDIRS should not be referenced via a fallback global name, but via a use statement.

124

            CURLOPT_HEADER => TRUE,

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_HEADER should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

TRUE, FALSE and NULL must be lowercase; expected true, but found TRUE.

125

            CURLOPT_FOLLOWLOCATION => TRUE,

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_FOLLOWLOCATION should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

TRUE, FALSE and NULL must be lowercase; expected true, but found TRUE.

126

            CURLOPT_AUTOREFERER => 1, // при редиректе подставлять в «Referer:» значение из «Location:»

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_AUTOREFERER should not be referenced via a fallback global name, but via a use statement.

127

            CURLOPT_BINARYTRANSFER => 1, // передавать в binary-safe

introduced 2021-01-19 11:08 UTC by

The constant CURLOPT_BINARYTRANSFER has been deprecated: 5.1.3 ( Ignorable by Annotation )

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_BINARYTRANSFER should not be referenced via a fallback global name, but via a use statement.

128

            CURLOPT_RETURNTRANSFER => TRUE,

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_RETURNTRANSFER should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

TRUE, FALSE and NULL must be lowercase; expected true, but found TRUE.

129

            CURLOPT_USERAGENT => 'smi2/PHPClickHouse/client',

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_USERAGENT should not be referenced via a fallback global name, but via a use statement.

130

);

131

        $this->handle = $handle;

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

132

133

134

/**

135

     * @param array $attachFiles

introduced 2020-12-21 16:16 UTC by

@param annotation of method \ClickHouseDB\Transport\CurlerRequest::attachFiles() does not specify type hint for items of its traversable parameter $attachFiles.

136

*/

137

    public function attachFiles($attachFiles)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::attachFiles() does not have native type hint for its parameter $attachFiles but it should be possible to add it based on @param annotation "array".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::attachFiles() does not have void return type hint.

138

139

        $this->header("Content-Type", "multipart/form-data");

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal Content-Type does not require double quotes, as per coding-style, please use single quotes.

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal multipart/form-data does not require double quotes, as per coding-style, please use single quotes.

140

141

        $out = [];

142

        foreach ($attachFiles as $post_name => $file_path) {

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $post_name should be in camel caps format.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $file_path should be in camel caps format.

143

            $out[$post_name] = new \CURLFile($file_path);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $post_name should be in camel caps format.

introduced 2018-09-26 10:27 UTC by

Class \CURLFile should not be referenced via a fully qualified name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $file_path should be in camel caps format.

144

145

146

        $this->_attachFiles = true;

147

        $this->parameters($out);

148

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

149

150

151

/**

152

     * @param bool $set

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

153

     * @return $this

154

*/

155

    public function id($set = false)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::id() does not have native type hint for its parameter $set but it should be possible to add it based on @param annotation "bool".

156

157

        if ($set) {

158

            $this->id = $set;

159

160

161

        return $this;

162

163

164

/**

165

     * @param array $params

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

@param annotation of method \ClickHouseDB\Transport\CurlerRequest::setRequestExtendedInfo() does not specify type hint for items of its traversable parameter $params.

166

     * @return $this

167

*/

168

    public function setRequestExtendedInfo($params)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setRequestExtendedInfo() does not have native type hint for its parameter $params but it should be possible to add it based on @param annotation "array".

169

170

        $this->extendinfo = $params;

171

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

172

173

174

/**

175

     * @param string|integer|null $key

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2018-07-08 20:56 UTC by

Expected "int" but found "integer" in @param annotation.

176

     * @return mixed

177

*/

178

    public function getRequestExtendedInfo($key = null)

179

180

        if ($key) {

181

            return isset($this->extendinfo[$key]) ? $this->extendinfo[$key] : false;

introduced 2018-07-08 20:56 UTC by

Use null coalesce operator instead of ternary operator.

182

183

184

        return $this->extendinfo;

185

186

187

/**

188

     * @return bool|resource

189

*/

190

    public function getInfileHandle()

191

192

        return $this->infile_handle;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "infile_handle" is not in valid camel caps format

193

194

195

/**

196

     * @param string $file_name

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

197

     * @return bool|resource

198

*/

199

    public function setInfile($file_name)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setInfile() does not have native type hint for its parameter $file_name but it should be possible to add it based on @param annotation "string".

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $file_name should be in camel caps format.

200

201

        $this->header('Expect', '');

202

        $this->infile_handle = fopen($file_name, 'r');

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "infile_handle" is not in valid camel caps format

introduced 2018-07-08 20:56 UTC by

Function fopen() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $file_name should be in camel caps format.

203

        if (is_resource($this->infile_handle)) {

introduced 2018-07-08 20:56 UTC by

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "infile_handle" is not in valid camel caps format

Coding Style introduced 2019-11-28 14:43 UTC by

Blank line found at start of control structure

204

205

            if ($this->_httpCompression) {

206

                $this->header('Content-Encoding', 'gzip');

207

                $this->header('Content-Type', 'application/x-www-form-urlencoded');

208

209

                stream_filter_append($this->infile_handle, 'zlib.deflate', STREAM_FILTER_READ, ["window" => 30]);

introduced 2018-07-08 20:56 UTC by

Function stream_filter_append() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "infile_handle" is not in valid camel caps format

introduced 2018-07-08 20:56 UTC by

Constant STREAM_FILTER_READ should not be referenced via a fallback global name, but via a use statement.

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal window does not require double quotes, as per coding-style, please use single quotes.

210

211

                $this->options[CURLOPT_SAFE_UPLOAD] = 1;

introduced 2021-01-19 11:08 UTC by

The constant CURLOPT_SAFE_UPLOAD has been deprecated: 7.0 Use <b>CURLFile</b> for uploads instead. ( Ignorable by Annotation )

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_SAFE_UPLOAD should not be referenced via a fallback global name, but via a use statement.

212

            } else {

213

                $this->options[CURLOPT_INFILESIZE] = filesize($file_name);

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_INFILESIZE should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function filesize() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $file_name should be in camel caps format.

214

215

216

            $this->options[CURLOPT_INFILE] = $this->infile_handle;

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_INFILE should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "infile_handle" is not in valid camel caps format

217

218

219

        return $this->infile_handle;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "infile_handle" is not in valid camel caps format

220

221

222

/**

223

     * @param callable $callback

224

*/

225

    public function setCallbackFunction($callback)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setCallbackFunction() does not have native type hint for its parameter $callback but it should be possible to add it based on @param annotation "callable".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setCallbackFunction() does not have void return type hint.

226

227

        $this->callback_function = $callback;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_function" is not in valid camel caps format

228

229

230

/**

231

     * @param callable $callback

232

*/

233

    public function setWriteFunction($callback)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setWriteFunction() does not have native type hint for its parameter $callback but it should be possible to add it based on @param annotation "callable".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setWriteFunction() does not have void return type hint.

234

235

        $this->options[CURLOPT_WRITEFUNCTION] = $callback;

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_WRITEFUNCTION should not be referenced via a fallback global name, but via a use statement.

236

237

238

/**

239

     * @param callable $callback

240

*/

241

    public function setReadFunction($callback)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setReadFunction() does not have native type hint for its parameter $callback but it should be possible to add it based on @param annotation "callable".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setReadFunction() does not have void return type hint.

242

243

        $this->options[CURLOPT_READFUNCTION] = $callback;

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_READFUNCTION should not be referenced via a fallback global name, but via a use statement.

244

245

246

    public function setHeaderFunction($callback)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setHeaderFunction() does not have parameter type hint nor @param annotation for its parameter $callback.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setHeaderFunction() does not have void return type hint.

247

248

        $this->options[CURLOPT_HEADERFUNCTION] = $callback;

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_HEADERFUNCTION should not be referenced via a fallback global name, but via a use statement.

249

250

251

/**

252

     * @param string $classCallBack

253

     * @param string $functionName

254

*/

255

    public function setCallback($classCallBack, $functionName)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setCallback() does not have native type hint for its parameter $classCallBack but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setCallback() does not have native type hint for its parameter $functionName but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setCallback() does not have void return type hint.

256

257

        $this->callback_class = $classCallBack;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_class" is not in valid camel caps format

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

258

        $this->callback_functionName = $functionName;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_functionName" is not in valid camel caps format

259

260

261

/**

introduced 2018-07-08 20:56 UTC by

Empty comment

262

263

*/

264

    public function onCallback()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::onCallback() does not have void return type hint.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::onCallback() does not need documentation comment.

265

266

        if ($this->callback_function) {

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_function" is not in valid camel caps format

267

            $x = $this->callback_function;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_function" is not in valid camel caps format

268

            $x($this);

269

270

271

        if ($this->callback_class && $this->callback_functionName) {

introduced 2018-07-08 20:56 UTC by

Use early exit to reduce code nesting.

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_class" is not in valid camel caps format

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_functionName" is not in valid camel caps format

272

            $c = $this->callback_functionName;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_functionName" is not in valid camel caps format

273

            $this->callback_class->$c($this);

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "callback_class" is not in valid camel caps format

274

275

276

277

    public function getDetails(): array

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::getDetails() does not have @return annotation for its traversable return value.

278

279

        return [

280

            'url'        => $this->url,

281

            'method'     => $this->method,

282

            'parameters' => $this->parameters,

283

            'headers'    => $this->headers,

284

];

285

286

287

/**

288

     * @param resource $stream

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

289

     * @return void

290

*/

291

    public function setStdErrOut($stream)

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setStdErrOut() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "void".

292

293

        if (is_resource($stream)) {

introduced 2022-04-20 19:38 UTC by

Expected 0 lines after "if", found 1.

introduced 2022-04-20 19:38 UTC by

Use early exit to reduce code nesting.

introduced 2022-04-20 19:38 UTC by

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

294

            $this->stdErrOut=$stream;

Coding Style introduced 2022-04-20 19:38 UTC by

Expected at least 1 space before "="; 0 found

Coding Style introduced 2022-04-20 19:38 UTC by

Expected at least 1 space after "="; 0 found

Coding Style introduced 2022-04-20 19:38 UTC by

Equals sign not aligned correctly; expected 1 space but found 0 spaces

295

296

297

Coding Style introduced 2022-04-20 19:38 UTC by

Function closing brace must go on the next line following the body; found 1 blank lines before brace

298

299

/**

300

     * @param bool $result

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

301

     * @return string

302

*/

303

    public function dump($result = false)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::dump() does not have native type hint for its parameter $result but it should be possible to add it based on @param annotation "bool".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::dump() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "string".

304

305

        $message = "\n------------  Request ------------\n";

Coding Style introduced 2019-08-24 09:12 UTC by

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

306

        $message .= 'URL:' . $this->url . "\n\n";

307

        $message .= 'METHOD:' . $this->method . "\n\n";

308

        $message .= 'PARAMS:' . print_r($this->parameters, true) . "\n";

Bug introduced 2021-01-19 11:08 UTC by

Are you sure print_r($this->parameters, true) of type string|true can be used in concatenation? ( Ignorable by Annotation )

introduced 2018-07-08 20:56 UTC by

Function print_r() should not be referenced via a fallback global name, but via a use statement.

309

        $message .= 'PARAMS:' . print_r($this->headers, true) . "\n";

Bug introduced 2021-01-19 11:08 UTC by

Are you sure print_r($this->headers, true) of type string|true can be used in concatenation? ( Ignorable by Annotation )

introduced 2018-07-08 20:56 UTC by

Function print_r() should not be referenced via a fallback global name, but via a use statement.

310

        $message .= "-----------------------------------\n";

311

312

        if ($result) {

313

            return $message;

314

315

316

        echo $message;

317

        return '';

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

318

319

320

/**

321

     * @return bool

322

*/

323

    public function getId()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::getId() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "bool".

324

325

        return $this->id;

326

327

328

/**

329

     * @param integer $key

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2018-07-08 20:56 UTC by

Expected "int" but found "integer" in @param annotation.

330

     * @param mixed $value

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 3 spaces after parameter type; 1 found

331

     * @return $this

332

*/

333

    private function option($key, $value)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::option() does not have native type hint for its parameter $key but it should be possible to add it based on @param annotation "integer".

334

335

        $this->options[$key] = $value;

336

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

337

338

339

/**

340

     * @return $this

341

*/

342

    public function persistent()

343

344

        $this->_persistent = true;

345

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

346

347

348

/**

349

     * @return bool

350

*/

351

    public function isPersistent()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::isPersistent() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "bool".

352

353

        return $this->_persistent;

354

355

356

/**

357

     * @param int $sec

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::keepAlive() has useless @param annotation for parameter $sec.

358

     * @return $this

359

*/

360

    public function keepAlive(int $sec = 60)

361

362

        $this->headers['Connection'] = 'keep-alive';

363

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

364

365

366

/**

367

     * @param bool $flag

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::verbose() has useless @param annotation for parameter $flag.

368

     * @return $this

369

*/

370

    public function verbose(bool $flag = true)

371

372

        $this->options[CURLOPT_VERBOSE] = $flag;

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_VERBOSE should not be referenced via a fallback global name, but via a use statement.

373

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

374

375

376

/**

377

     * @param string $key

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::header() has useless @param annotation for parameter $key.

378

     * @param string $value

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::header() has useless @param annotation for parameter $value.

379

     * @return $this

380

*/

381

    public function header(string $key, string $value)

382

383

        $this->headers[$key] = $value;

384

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

385

386

387

/**

388

     * @return array

introduced 2020-12-21 16:16 UTC by

@return annotation of method \ClickHouseDB\Transport\CurlerRequest::getHeaders() does not specify type hint for items of its traversable return value.

389

*/

390

    public function getHeaders():array

introduced 2022-04-20 19:38 UTC by

There must be exactly one space between return type hint colon and return type hint.

391

392

        $head = [];

393

        foreach ($this->headers as $key => $value) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "foreach", found 0.

394

            $head[] = sprintf("%s: %s", $key, $value);

introduced 2018-07-08 20:56 UTC by

Function sprintf() should not be referenced via a fallback global name, but via a use statement.

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal %s: %s does not require double quotes, as per coding-style, please use single quotes.

395

396

        return $head;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

397

398

399

/**

400

     * @param string $url

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::url() has useless @param annotation for parameter $url.

401

     * @return $this

402

*/

403

    public function url(string $url)

404

405

        $this->url = $url;

406

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

407

408

409

/**

410

     * @return string

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::getUrl() has useless @return annotation.

411

*/

412

    public function getUrl():string

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::getUrl() does not need documentation comment.

introduced 2022-04-20 19:38 UTC by

There must be exactly one space between return type hint colon and return type hint.

413

414

        return $this->url;

415

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

416

417

418

/**

419

     * @param string $id

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::getUniqHash() has useless @param annotation for parameter $id.

420

     * @return string

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::getUniqHash() has useless @return annotation.

421

*/

422

    public function getUniqHash(string $id):string

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::getUniqHash() does not need documentation comment.

introduced 2022-04-20 19:38 UTC by

There must be exactly one space between return type hint colon and return type hint.

423

424

        return $id . '.' . microtime() . mt_rand(0, 1000000);

introduced 2018-07-08 20:56 UTC by

Function microtime() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function mt_rand() should not be referenced via a fallback global name, but via a use statement.

425

426

427

/**

428

     * @param bool $flag

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::httpCompression() has useless @param annotation for parameter $flag.

429

*/

430

    public function httpCompression(bool $flag):void

introduced 2022-04-20 19:38 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::httpCompression() does not need documentation comment.

introduced 2022-04-20 19:38 UTC by

There must be exactly one space between return type hint colon and return type hint.

431

432

        if ($flag) {

433

            $this->_httpCompression = $flag;

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 10 spaces but found 1 space

434

            $this->options[CURLOPT_ENCODING] = 'gzip';

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_ENCODING should not be referenced via a fallback global name, but via a use statement.

435

        } else {

436

            $this->_httpCompression = false;

437

            unset($this->options[CURLOPT_ENCODING]);

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_ENCODING should not be referenced via a fallback global name, but via a use statement.

438

439

440

441

/**

442

     * @param string $username

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

443

     * @param string $password

444

     * @return $this

445

*/

446

    public function authByBasicAuth($username, $password)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::authByBasicAuth() does not have native type hint for its parameter $username but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::authByBasicAuth() does not have native type hint for its parameter $password but it should be possible to add it based on @param annotation "string".

447

448

        $this->options[CURLOPT_USERPWD] = sprintf("%s:%s", $username, $password);

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_USERPWD should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function sprintf() should not be referenced via a fallback global name, but via a use statement.

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal %s:%s does not require double quotes, as per coding-style, please use single quotes.

449

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

450

451

452

    public function authByHeaders($username, $password)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::authByHeaders() does not have parameter type hint nor @param annotation for its parameter $username.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::authByHeaders() does not have parameter type hint nor @param annotation for its parameter $password.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::authByHeaders() does not have return type hint nor @return annotation for its return value.

453

454

        $this->headers['X-ClickHouse-User'] = $username;

455

        $this->headers['X-ClickHouse-Key'] = $password;

Coding Style introduced 2024-07-15 07:05 UTC by

Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space

456

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

457

458

459

/**

460

     * @param array|string $data

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

@param annotation of method \ClickHouseDB\Transport\CurlerRequest::parameters() does not specify type hint for items of its traversable parameter $data.

461

     * @return $this

462

*/

463

    public function parameters($data)

464

465

        $this->parameters = $data;

466

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

467

468

469

/**

470

     * The number of seconds to wait when trying to connect. Use 0 for infinite waiting.

471

472

     * @param float $seconds

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2022-08-03 17:13 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::connectTimeOut() has useless @param annotation for parameter $seconds.

473

     * @return $this

474

*/

475

    public function connectTimeOut(float $seconds = 1.0)

476

477

        $this->options[CURLOPT_CONNECTTIMEOUT_MS] = (int) ($seconds*1000.0);

introduced 2022-08-03 17:13 UTC by

Constant CURLOPT_CONNECTTIMEOUT_MS should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2022-08-03 17:13 UTC by

Expected at least 1 space before "*"; 0 found

Coding Style introduced 2022-08-03 17:13 UTC by

Expected at least 1 space after "*"; 0 found

478

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

479

480

481

/**

482

     * The maximum number of seconds (float) allowed to execute cURL functions.

483

484

     * @param float $seconds

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2022-08-03 17:13 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::timeOut() has useless @param annotation for parameter $seconds.

485

     * @return $this

486

*/

487

    public function timeOut(float $seconds = 10)

488

489

        return $this->timeOutMs((int) ($seconds * 1000.0));

490

491

492

/**

493

     * The maximum allowed number of milliseconds to perform cURL functions.

494

495

     * @param int $ms millisecond

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

496

     * @return $this

497

*/

498

    protected function timeOutMs(int $ms = 10000)

499

500

        $this->options[CURLOPT_TIMEOUT_MS] = $ms;

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_TIMEOUT_MS should not be referenced via a fallback global name, but via a use statement.

501

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

502

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

503

504

505

/**

506

     * @param array|mixed $data

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

@param annotation of method \ClickHouseDB\Transport\CurlerRequest::parameters_json() does not specify type hint for items of its traversable parameter $data.

507

     * @return $this

508

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

509

*/

510

    public function parameters_json($data)

Coding Style introduced 2018-07-08 20:56 UTC by

Method name "CurlerRequest::parameters_json" is not in camel caps format

511

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 0 blank lines after opening function brace; 1 found

512

513

        $this->header("Content-Type", "application/json, text/javascript; charset=utf-8");

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal Content-Type does not require double quotes, as per coding-style, please use single quotes.

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal application/json, text/javascript; charset=utf-8 does not require double quotes, as per coding-style, please use single quotes.

514

        $this->header("Accept", "application/json, text/javascript, */*; q=0.01");

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal Accept does not require double quotes, as per coding-style, please use single quotes.

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal application/json, text/javascript, */*; q=0.01 does not require double quotes, as per coding-style, please use single quotes.

515

516

        if ($data === null) {

517

            $this->parameters = '{}';

518

            return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

519

520

521

        if (is_string($data)) {

introduced 2018-07-08 20:56 UTC by

Function is_string() should not be referenced via a fallback global name, but via a use statement.

522

            $this->parameters = $data;

523

            return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

524

525

526

        $this->parameters = json_encode($data);

introduced 2018-07-08 20:56 UTC by

Function json_encode() should not be referenced via a fallback global name, but via a use statement.

527

528

        if (!$this->parameters && $data) {

Coding Style introduced 2024-01-10 11:49 UTC by

Expected 1 space after NOT operator; 0 found

529

            throw new \ClickHouseDB\Exception\TransportException('Cant json_encode: ' . strval($data));

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function strval() should not be referenced via a fallback global name, but via a use statement.

530

531

532

        return $this;

533

534

535

/**

536

     * @return resource

537

*/

538

    public function getResultFileHandle()

539

540

        return $this->resultFileHandle;

541

542

543

/**

544

     * @return bool

545

*/

546

    public function isResultFile()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::isResultFile() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "bool".

547

548

        return ($this->resultFileHandle ? true : false);

introduced 2018-07-08 20:56 UTC by

Usage of language construct "return" with parentheses is disallowed.

introduced 2020-12-21 16:16 UTC by

Useless ternary operator.

549

550

551

/**

552

     * @param resource $h resource

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 4 spaces after parameter name; 1 found

553

     * @param bool $zlib

Coding Style introduced 2018-07-08 20:56 UTC by

Expected 5 spaces after parameter type; 1 found

554

     * @return $this

555

*/

556

    public function setResultFileHandle($h, $zlib = false)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setResultFileHandle() does not have native type hint for its parameter $zlib but it should be possible to add it based on @param annotation "bool".

557

558

        $this->resultFileHandle = $h;

559

        if ($zlib) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

560

            $params = array('level' => 6, 'window' => 15, 'memory' => 9);

Coding Style introduced 2018-07-08 20:56 UTC by

Short array syntax must be used to define arrays

561

            stream_filter_append($this->resultFileHandle, 'zlib.deflate', STREAM_FILTER_WRITE, $params);

introduced 2018-07-08 20:56 UTC by

Function stream_filter_append() should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Constant STREAM_FILTER_WRITE should not be referenced via a fallback global name, but via a use statement.

562

563

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

564

565

566

/**

567

     * @return CurlerRequest

568

*/

569

    public function PUT()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::PUT() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

570

571

        return $this->execute('PUT');

572

573

574

/**

575

     * @return CurlerRequest

576

*/

577

    public function POST()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::POST() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

578

579

        return $this->execute('POST');

580

581

582

/**

583

     * @return CurlerRequest

584

*/

585

    public function OPTIONS()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::OPTIONS() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

586

587

        return $this->execute('OPTIONS');

588

589

590

/**

591

     * @return CurlerRequest

592

*/

593

    public function GET()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::GET() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

594

595

        return $this->execute('GET');

596

597

598

/**

599

     * The number of seconds that DNS records are stored in memory. By default this parameter is 120 (2 minutes).

600

601

     * @param integer $set

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

introduced 2018-07-08 20:56 UTC by

Expected "int" but found "integer" in @param annotation.

602

     * @return $this

603

*/

604

    public function setDnsCache($set)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setDnsCache() does not have native type hint for its parameter $set but it should be possible to add it based on @param annotation "integer".

605

606

        $this->_dns_cache = $set;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "_dns_cache" is not in valid camel caps format

607

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

608

609

610

/**

611

     * The number of seconds that DNS records are stored in memory. By default this parameter is 120 (2 minutes).

612

613

     * @return int

614

*/

615

    public function getDnsCache()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::getDnsCache() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "int".

616

617

        return $this->_dns_cache;

Coding Style introduced 2021-10-08 16:39 UTC by

Member variable "_dns_cache" is not in valid camel caps format

618

619

620

/**

621

     * Sets client certificate

622

623

     * @param string $filePath

624

*/

625

    public function setSslCa($filePath)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setSslCa() does not have native type hint for its parameter $filePath but it should be possible to add it based on @param annotation "string".

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setSslCa() does not have void return type hint.

626

627

        $this->option(CURLOPT_SSL_VERIFYPEER, true);

introduced 2019-11-28 14:43 UTC by

Constant CURLOPT_SSL_VERIFYPEER should not be referenced via a fallback global name, but via a use statement.

628

        $this->option(CURLOPT_CAINFO, $filePath);

introduced 2019-11-28 14:43 UTC by

Constant CURLOPT_CAINFO should not be referenced via a fallback global name, but via a use statement.

629

630

631

/**

632

     * @param string $method

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

633

     * @return $this

634

*/

635

    private function execute($method)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::execute() does not have native type hint for its parameter $method but it should be possible to add it based on @param annotation "string".

636

637

        $this->method = $method;

638

        return $this;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

639

640

641

/**

642

     * @return CurlerResponse

introduced 2018-09-26 10:27 UTC by

Incorrect annotations group.

643

     * @throws \ClickHouseDB\Exception\TransportException

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

644

*/

645

    public function response()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::response() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "CurlerResponse".

646

647

        if (!$this->response) {

Coding Style introduced 2024-01-10 11:49 UTC by

Expected 1 space after NOT operator; 0 found

648

            throw new \ClickHouseDB\Exception\TransportException('Can`t fetch response - is empty');

introduced 2018-07-08 20:56 UTC by

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

649

650

651

        return $this->response;

652

653

654

    public function isResponseExists(): bool

655

656

        return $this->response !== null;

657

658

659

    public function setResponse(CurlerResponse $response): void

660

661

        $this->response = $response;

662

663

664

/**

665

     * @return mixed

666

*/

667

    public function handle()

668

669

        $this->prepareRequest();

670

        return $this->handle;

introduced 2020-12-21 16:16 UTC by

Expected 1 lines before "return", found 0.

671

672

673

/**

674

     * @param callable $callback

introduced 2022-04-20 19:38 UTC by

Incorrect annotations group.

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setFunctionProgress() has useless @param annotation for parameter $callback.

675

     * @throws \Exception

introduced 2018-09-26 10:27 UTC by

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

676

*/

677

    public function setFunctionProgress(callable $callback)

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::setFunctionProgress() does not have void return type hint.

678

679

        if (!is_callable($callback)) {

Coding Style introduced 2024-01-10 11:49 UTC by

Expected 1 space after NOT operator; 0 found

introduced 2018-07-08 20:56 UTC by

Function is_callable() should not be referenced via a fallback global name, but via a use statement.

680

            throw new \Exception('setFunctionProgress not is_callable');

introduced 2018-09-26 10:27 UTC by

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

681

682

683

        $this->option(CURLOPT_NOPROGRESS, false);

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_NOPROGRESS should not be referenced via a fallback global name, but via a use statement.

684

        $this->option(CURLOPT_PROGRESSFUNCTION, $callback); // version 5.5.0

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_PROGRESSFUNCTION should not be referenced via a fallback global name, but via a use statement.

685

Coding Style introduced 2020-12-21 16:16 UTC by

Expected 1 blank line after function; 2 found

686

687

688

/**

689

     * @return bool

690

*/

691

    private function prepareRequest()

introduced 2020-12-21 16:16 UTC by

Method \ClickHouseDB\Transport\CurlerRequest::prepareRequest() does not have native return type hint for its return value but it should be possible to add it based on @return annotation "bool".

692

693

        if (!$this->handle) {

Coding Style introduced 2024-01-10 11:49 UTC by

Expected 1 space after NOT operator; 0 found

694

            $this->handle = curl_init();

Documentation Bug introduced 2021-01-19 11:08 UTC by

It seems like curl_init() can also be of type CurlHandle. However, the property $handle is declared as type null|resource. Maybe add an additional type check?

introduced 2018-07-08 20:56 UTC by

Function curl_init() should not be referenced via a fallback global name, but via a use statement.

695

696

697

        $curl_opt = $this->options;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

698

        $method = $this->method;

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

699

700

        if ($this->_attachFiles) {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 2.

701

            $curl_opt[CURLOPT_SAFE_UPLOAD] = true;

introduced 2021-01-19 11:08 UTC by

The constant CURLOPT_SAFE_UPLOAD has been deprecated: 7.0 Use <b>CURLFile</b> for uploads instead. ( Ignorable by Annotation )

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_SAFE_UPLOAD should not be referenced via a fallback global name, but via a use statement.

702

703

Coding Style introduced 2018-07-08 20:56 UTC by

Functions must not contain multiple empty lines in a row; found 2 empty lines

704

705

        if (strtoupper($method) == 'GET') {

introduced 2020-12-21 16:16 UTC by

Expected 1 lines after "if", found 0.

introduced 2018-07-08 20:56 UTC by

Function strtoupper() should not be referenced via a fallback global name, but via a use statement.

introduced 2020-12-21 16:16 UTC by

Operator == is disallowed, use === instead.

706

            $curl_opt[CURLOPT_HTTPGET] = true;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

707

            $curl_opt[CURLOPT_CUSTOMREQUEST] = strtoupper($method);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_CUSTOMREQUEST should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function strtoupper() should not be referenced via a fallback global name, but via a use statement.

708

            $curl_opt[CURLOPT_POSTFIELDS] = false;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_POSTFIELDS should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

709

        } else {

710

            if (strtoupper($method) === 'POST') {

introduced 2018-07-08 20:56 UTC by

Function strtoupper() should not be referenced via a fallback global name, but via a use statement.

711

                $curl_opt[CURLOPT_POST] = true;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

712

713

714

            $curl_opt[CURLOPT_CUSTOMREQUEST] = strtoupper($method);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_CUSTOMREQUEST should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function strtoupper() should not be referenced via a fallback global name, but via a use statement.

715

716

            if ($this->parameters) {

717

                $curl_opt[CURLOPT_POSTFIELDS] = $this->parameters;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_POSTFIELDS should not be referenced via a fallback global name, but via a use statement.

718

719

                if (!is_array($this->parameters)) {

Coding Style introduced 2024-01-10 11:49 UTC by

Expected 1 space after NOT operator; 0 found

introduced 2018-07-08 20:56 UTC by

Function is_array() should not be referenced via a fallback global name, but via a use statement.

720

                    $this->header('Content-Length',  mb_strlen($this->parameters, '8bit'));

Coding Style introduced 2021-10-08 16:39 UTC by

Expected 1 space after comma in argument list; 2 found

introduced 2021-10-08 16:39 UTC by

Function mb_strlen() should not be referenced via a fallback global name, but via a use statement.

721

722

723

724

        // CURLOPT_DNS_CACHE_TIMEOUT - Количество секунд, в течение которых в памяти хранятся DNS-записи.

725

        $curl_opt[CURLOPT_DNS_CACHE_TIMEOUT] = $this->getDnsCache();

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_DNS_CACHE_TIMEOUT should not be referenced via a fallback global name, but via a use statement.

726

        $curl_opt[CURLOPT_URL] = $this->url;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_URL should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space

727

728

        if (!empty($this->headers) && sizeof($this->headers)) {

Coding Style introduced 2024-01-10 11:49 UTC by

Expected 1 space after NOT operator; 0 found

introduced 2018-07-08 20:56 UTC by

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

The use of function sizeof() is forbidden; use count() instead

729

            $curl_opt[CURLOPT_HTTPHEADER] = [];

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_HTTPHEADER should not be referenced via a fallback global name, but via a use statement.

730

731

            foreach ($this->headers as $key => $value) {

732

                $curl_opt[CURLOPT_HTTPHEADER][] = sprintf("%s: %s", $key, $value);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_HTTPHEADER should not be referenced via a fallback global name, but via a use statement.

introduced 2018-07-08 20:56 UTC by

Function sprintf() should not be referenced via a fallback global name, but via a use statement.

Coding Style Comprehensibility introduced 2018-07-08 20:56 UTC by

The string literal %s: %s does not require double quotes, as per coding-style, please use single quotes.

733

734

735

736

        if (!empty($curl_opt[CURLOPT_INFILE])) {

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

Coding Style introduced 2024-01-10 11:49 UTC by

Expected 1 space after NOT operator; 0 found

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_INFILE should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

Blank line found at start of control structure

737

738

            $curl_opt[CURLOPT_PUT] = true;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_PUT should not be referenced via a fallback global name, but via a use statement.

739

740

741

        if (!empty($curl_opt[CURLOPT_WRITEFUNCTION])) {

Coding Style introduced 2024-01-10 11:49 UTC by

Expected 1 space after NOT operator; 0 found

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_WRITEFUNCTION should not be referenced via a fallback global name, but via a use statement.

742

            $curl_opt[CURLOPT_HEADER] = false;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_HEADER should not be referenced via a fallback global name, but via a use statement.

743

744

745

        if ($this->resultFileHandle) {

746

            $curl_opt[CURLOPT_FILE] = $this->resultFileHandle;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_FILE should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2018-07-08 20:56 UTC by

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

747

            $curl_opt[CURLOPT_HEADER] = false;

Coding Style introduced 2022-04-20 19:38 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_HEADER should not be referenced via a fallback global name, but via a use statement.

748

749

750

        if ($this->options[CURLOPT_VERBOSE]) {

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_VERBOSE should not be referenced via a fallback global name, but via a use statement.

751

            $msg="\n-----------BODY REQUEST----------\n" . $curl_opt[CURLOPT_POSTFIELDS] . "\n------END--------\n";

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

Coding Style introduced 2022-04-20 19:38 UTC by

Expected at least 1 space before "="; 0 found

Coding Style introduced 2022-04-20 19:38 UTC by

Expected at least 1 space after "="; 0 found

Coding Style introduced 2022-04-20 19:38 UTC by

Equals sign not aligned correctly; expected 1 space but found 0 spaces

introduced 2018-07-08 20:56 UTC by

Constant CURLOPT_POSTFIELDS should not be referenced via a fallback global name, but via a use statement.

752

            if ($this->stdErrOut && is_resource($this->stdErrOut)) {

introduced 2022-04-20 19:38 UTC by

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

753

                fwrite($this->stdErrOut,$msg);

introduced 2022-04-20 19:38 UTC by

Function fwrite() should not be referenced via a fallback global name, but via a use statement.

754

            } else {

755

                echo $msg;

756

757

758

759

        if ($this->stdErrOut) {

760

            if (is_resource($this->stdErrOut)) {

introduced 2022-04-20 19:38 UTC by

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

761

                $curl_opt[CURLOPT_STDERR]=$this->stdErrOut;

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2022-04-20 19:38 UTC by

Constant CURLOPT_STDERR should not be referenced via a fallback global name, but via a use statement.

Coding Style introduced 2022-04-20 19:38 UTC by

Expected at least 1 space before "="; 0 found

Coding Style introduced 2022-04-20 19:38 UTC by

Expected at least 1 space after "="; 0 found

Coding Style introduced 2022-04-20 19:38 UTC by

Equals sign not aligned correctly; expected 1 space but found 0 spaces

762

763

764

765

        curl_setopt_array($this->handle, $curl_opt);

Coding Style introduced 2020-12-21 16:16 UTC by

The variable $curl_opt should be in camel caps format.

introduced 2018-07-08 20:56 UTC by

Function curl_setopt_array() should not be referenced via a fallback global name, but via a use statement.

766

        return true;

introduced 2024-07-15 07:05 UTC by

Expected 1 lines before "return", found 0.

767

768

769

smi2 / phpClickHouse

Pull Request — master (#220)

CurlerRequest::__destruct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like