ClickHouseDB\Quote\StrictQuoteLine::quoteValue()

Complexity

Conditions	13
Paths	1

Size

Total Lines	65
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	36
CRAP Score	13

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function quoteValue($row,bool $skipEncode=false)

Method \ClickHouseDB\Quote\StrictQuoteLine::quoteValue() does not have parameter type hint nor @param annotation for its parameter $row.

Method \ClickHouseDB\Quote\StrictQuoteLine::quoteValue() does not have return type hint for its return value but it should be possible to add it based on @return annotation "array".

Type hint "row" missing for

Expected 1 space between comma and type hint "bool"; 0 found

Incorrect spacing between argument "$skipEncode" and equals sign; expected 1 but found 0

Incorrect spacing between default value and equals sign for argument "$skipEncode"; expected 1 but found 0

    {
        $enclosure = $this->settings['Enclosure'];

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        $delimiter = $this->settings['Delimiter'];

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        $encodeEnclosure = $this->settings['EncodeEnclosure'];
        $encodeArray = $this->settings['EnclosureArray'];

Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space

        $null = $this->settings['Null'];

Equals sign not aligned with surrounding assignments; expected 12 spaces but found 1 space

        $tabEncode = $this->settings['TabEncode'];

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        $quote = function($value) use ($enclosure, $delimiter, $encodeEnclosure, $encodeArray, $null, $tabEncode, $skipEncode) {

Expected 1 space after FUNCTION keyword; 0 found

            $delimiter_esc = preg_quote($delimiter, '/');

The assignment to $delimiter_esc is dead and can be removed.

Function preg_quote() should not be referenced via a fallback global name, but via a use statement.

            $enclosure_esc = preg_quote($enclosure, '/');

Function preg_quote() should not be referenced via a fallback global name, but via a use statement.

            $encode_esc = preg_quote($encodeEnclosure, '/');

Function preg_quote() should not be referenced via a fallback global name, but via a use statement.

            $encode = true;
            if ($value instanceof NumericType) {
                $encode = false;
            }

No blank line found after control structure

            if ($value instanceof Expression) {
                $encode = $value->needsEncoding();
            }

            if (is_array($value)) {
                // Arrays are formatted as a list of values separated by commas in square brackets.
                // Elements of the array - the numbers are formatted as usual, and the dates, dates-with-time, and lines are in
                // single quotation marks with the same screening rules as above.
                // as in the TabSeparated format, and then the resulting string is output in InsertRow in double quotes.

                $value       = array_map(
                    function ($v) use ($enclosure_esc, $encode_esc) {
                        return is_string($v) ? $this->encodeString($v, $enclosure_esc, $encode_esc) : $v;
                    },
                    $value
                );
                $resultArray = FormatLine::Insert($value,($encodeEnclosure==='\\'?true:false));
                return $encodeArray . '[' . $resultArray . ']' . $encodeArray;
            }

            $value = ValueFormatter::formatValue($value, false);

            if (is_float($value) || is_int($value)) {
                return (string) $value;
            }

            if (is_string($value) && $encode) {
                if ($tabEncode) {
                    return str_replace(["\t", "\n"], ['\\t', '\\n'], $value);
                }

                if (!$skipEncode)

It is generally a best practice to always use braces with control structures.

                $value = $this->encodeString($value, $enclosure_esc, $encode_esc);

                return $enclosure . $value . $enclosure;
            }

            if ($value === null) {
                return $null;
            }

            return $value;
        };

        return array_map($quote, $row);
    }