ClickHouseDB\Transport\Http

Complexity

Total Complexity

85

Size/Duplication

Total Lines	766
Duplicated Lines	0 %

Test Coverage

Coverage

77.17%

Importance

Changes	44
Bugs	5	Features	8

34 Methods

Rating	Name	Duplication	Size	Complexity
A	makeRequest()	0	32	4
A	getRequestWrite()	0	4	1
A	getConnectTimeOut()	0	3	1
A	writeAsyncCSV()	0	34	2
A	verbose()	0	4	1
A	addQueryDegeneration()	0	4	1
A	executeAsync()	0	3	1
C	getRequestRead()	0	58	12
A	streamRead()	0	5	1
A	ping()	0	7	1
A	getUri()	0	14	5
A	getCurler()	0	3	1
A	selectAsync()	0	5	1
A	setConnectTimeOut()	0	3	1
B	__findXClickHouseProgress()	0	31	8
A	cleanQueryDegeneration()	0	4	1
A	setDirtyCurler()	0	4	2
A	setHost()	0	7	2
A	__construct()	0	13	2
A	setProgressFunction()	0	3	1
A	writeStreamData()	0	28	2
B	newRequest()	0	38	6
A	prepareWrite()	0	8	2
C	streaming()	0	56	9
A	getUrl()	0	21	4
A	settings()	0	3	1
A	getCountPendingQueue()	0	3	1
A	prepareQuery()	0	9	2
A	select()	0	5	1
A	setSslCa()	0	3	1
A	streamWrite()	0	5	1
A	prepareSelect()	0	8	2
A	setCurler()	0	3	1
A	write()	0	11	3

<?php

An error occurred during processing; checking has been aborted. The error message was: "if" without curly braces is not supported.

Missing declare(strict_types=1).

namespace ClickHouseDB\Transport;

use ClickHouseDB\Exception\TransportException;
use ClickHouseDB\Query\Degeneration;
use ClickHouseDB\Query\Query;
use ClickHouseDB\Query\WhereInFile;
use ClickHouseDB\Query\WriteToFile;
use ClickHouseDB\Settings;
use ClickHouseDB\Statement;
use const PHP_EOL;

class Http
{
    const AUTH_METHOD_HEADER       = 1;

Constant \ClickHouseDB\Transport\Http::AUTH_METHOD_HEADER visibility missing.

    const AUTH_METHOD_QUERY_STRING = 2;

Constant \ClickHouseDB\Transport\Http::AUTH_METHOD_QUERY_STRING visibility missing.

    const AUTH_METHOD_BASIC_AUTH   = 3;

Constant \ClickHouseDB\Transport\Http::AUTH_METHOD_BASIC_AUTH visibility missing.

    const AUTH_METHODS_LIST = [

Constant \ClickHouseDB\Transport\Http::AUTH_METHODS_LIST visibility missing.

        self::AUTH_METHOD_HEADER,

This array value does not seem to be aligned correcty; expected 31 spaces, but found 8.

        self::AUTH_METHOD_QUERY_STRING,

This array value does not seem to be aligned correcty; expected 31 spaces, but found 8.

        self::AUTH_METHOD_BASIC_AUTH,

This array value does not seem to be aligned correcty; expected 31 spaces, but found 8.

    ];

The closing parenthesis does not seem to be aligned correctly; expected 30 space(s), but found 4.

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_username with single line content, use one-line comment instead.

     * @var string
     */
    private $_username = null;

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_password with single line content, use one-line comment instead.

     * @var string
     */
    private $_password = null;

    /**
     * The username and password can be indicated in one of three ways:
     *  - Using HTTP Basic Authentication.
     *  - In the ‘user’ and ‘password’ URL parameters.
     *  - Using ‘X-ClickHouse-User’ and ‘X-ClickHouse-Key’ headers (by default)
     *
     * @see https://clickhouse.tech/docs/en/interfaces/http/

Incorrect annotations group.

     * @var int
     */
    private $_authMethod = self::AUTH_METHOD_HEADER;

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_host with single line content, use one-line comment instead.

     * @var string
     */
    private $_host = '';

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_port with single line content, use one-line comment instead.

     * @var int
     */
    private $_port = 0;

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_verbose with single line content, use one-line comment instead.

     * @var bool|int
     */
    private $_verbose = false;

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_curler with single line content, use one-line comment instead.

     * @var CurlerRolling
     */
    private $_curler = null;

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_settings with single line content, use one-line comment instead.

     * @var Settings
     */
    private $_settings = null;

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$_query_degenerations with single line content, use one-line comment instead.

     * @var array

@var annotation of property \ClickHouseDB\Transport\Http::$_query_degenerations does not specify type hint for its items.

     */
    private $_query_degenerations = [];

    /**
     * Count seconds (int)
     *
     * @var int
     */
    private $_connectTimeOut = 5;

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$xClickHouseProgress with single line content, use one-line comment instead.

     * @var callable
     */
    private $xClickHouseProgress = null;

    /**

Found multi-line comment for property \ClickHouseDB\Transport\Http::$sslCA with single line content, use one-line comment instead.

     * @var null|string

Null type hint should be on last position.

     */
    private $sslCA = null;

    /**
     * Http constructor.

Documentation comment contains forbidden comment "Http constructor.".

     * @param string $host

Expected 1 lines between description and annotations, found 0.

Missing parameter comment

     * @param int $port

Missing parameter comment

Expected "integer" but found "int" for parameter type

Expected 4 spaces after parameter type; 1 found

     * @param string $username

Missing parameter comment

     * @param string $password

Missing parameter comment

     * @param int $authMethod

Missing parameter comment

Expected "integer" but found "int" for parameter type

Expected 4 spaces after parameter type; 1 found

     */
    public function __construct($host, $port, $username, $password, $authMethod = null)

Method \ClickHouseDB\Transport\Http::__construct() does not have parameter type hint for its parameter $host but it should be possible to add it based on @param annotation "string".

Method \ClickHouseDB\Transport\Http::__construct() does not have parameter type hint for its parameter $port but it should be possible to add it based on @param annotation "int".

Method \ClickHouseDB\Transport\Http::__construct() does not have parameter type hint for its parameter $username but it should be possible to add it based on @param annotation "string".

Method \ClickHouseDB\Transport\Http::__construct() does not have parameter type hint for its parameter $password but it should be possible to add it based on @param annotation "string".

Type hint "string" missing for $host

Type hint "int" missing for $port

Type hint "string" missing for $username

Type hint "string" missing for $password

Method \ClickHouseDB\Transport\Http::__construct() does not have parameter type hint for its parameter $authMethod but it should be possible to add it based on @param annotation "int".

Type hint "int" missing for $authMethod

    {
        $this->setHost($host, $port);

        $this->_username = $username;
        $this->_password = $password;
        if ($authMethod) {

The expression $authMethod of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $this->_authMethod = $authMethod;
        }

        $this->_settings = new Settings($this);

        $this->setCurler();
    }


    public function setCurler()

Method \ClickHouseDB\Transport\Http::setCurler() does not have void return type hint.

Missing doc comment for function setCurler()

    {
        $this->_curler = new CurlerRolling();
    }

    /**
     * @param CurlerRolling $curler

Missing parameter comment

     */

Missing @return tag in function comment

    public function setDirtyCurler(CurlerRolling $curler)

Method \ClickHouseDB\Transport\Http::setDirtyCurler() does not have void return type hint.

Method \ClickHouseDB\Transport\Http::setDirtyCurler() does not need documentation comment.

    {
        if ($curler instanceof CurlerRolling) {

$curler is always a sub-type of ClickHouseDB\Transport\CurlerRolling.

Use early exit to reduce code nesting.

            $this->_curler = $curler;
        }
    }

    /**
     * @return CurlerRolling
     */
    public function getCurler()

Method \ClickHouseDB\Transport\Http::getCurler() does not have return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRolling".

    {
        return $this->_curler;
    }

    /**
     * @param string $host

Missing parameter comment

     * @param int $port

Missing parameter comment

Expected "integer" but found "int" for parameter type

Expected 4 spaces after parameter type; 1 found

     */

Missing @return tag in function comment

    public function setHost($host, $port = -1)

Method \ClickHouseDB\Transport\Http::setHost() does not have parameter type hint for its parameter $host but it should be possible to add it based on @param annotation "string".

Method \ClickHouseDB\Transport\Http::setHost() does not have parameter type hint for its parameter $port but it should be possible to add it based on @param annotation "int".

Method \ClickHouseDB\Transport\Http::setHost() does not have void return type hint.

Type hint "string" missing for $host

Type hint "int" missing for $port

    {
        if ($port > 0) {
            $this->_port = $port;
        }

        $this->_host = $host;
    }

    /**
     * Sets client SSL certificate for Yandex Cloud
     *
     * @param string $caPath

Missing parameter comment

     */

Missing @return tag in function comment

    public function setSslCa($caPath)

Method \ClickHouseDB\Transport\Http::setSslCa() does not have parameter type hint for its parameter $caPath but it should be possible to add it based on @param annotation "string".

Method \ClickHouseDB\Transport\Http::setSslCa() does not have void return type hint.

Type hint "string" missing for $caPath

    {
        $this->sslCA = $caPath;
    }

    /**
     * @return string
     */
    public function getUri()

Method \ClickHouseDB\Transport\Http::getUri() does not have return type hint for its return value but it should be possible to add it based on @return annotation "string".

    {
        $proto = 'http';
        if ($this->settings()->isHttps()) {
            $proto = 'https';
        }

No blank line found after control structure

        $uri = $proto . '://' . $this->_host;
        if (stripos($this->_host, '/') !== false || stripos($this->_host, ':') !== false) {

Function stripos() should not be referenced via a fallback global name, but via a use statement.

            return $uri;
        }

No blank line found after control structure

        if (intval($this->_port) > 0) {

Function intval() should not be referenced via a fallback global name, but via a use statement.

            return $uri . ':' . $this->_port;
        }

No blank line found after control structure

        return $uri;
    }

    /**
     * @return Settings
     */
    public function settings()

Method \ClickHouseDB\Transport\Http::settings() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Settings".

    {
        return $this->_settings;
    }

    /**
     * @param bool|int $flag

Incorrect annotations group.

Missing parameter comment

Expected "boolean|integer" but found "bool|int" for parameter type

     * @return mixed
     */
    public function verbose($flag)
    {
        $this->_verbose = $flag;
        return $flag;
    }

    /**
     * @param array $params

Incorrect annotations group.

@param annotation of method \ClickHouseDB\Transport\Http::getUrl() does not specify type hint for items of its traversable parameter $params.

Missing parameter comment

     * @return string
     */
    private function getUrl($params = [])

Method \ClickHouseDB\Transport\Http::getUrl() does not have parameter type hint for its parameter $params but it should be possible to add it based on @param annotation "array".

Method \ClickHouseDB\Transport\Http::getUrl() does not have return type hint for its return value but it should be possible to add it based on @return annotation "string".

Type hint "array" missing for $params

    {
        $settings = $this->settings()->getSettings();

        if (is_array($params) && sizeof($params)) {

Function is_array() should not be referenced via a fallback global name, but via a use statement.

Function sizeof() should not be referenced via a fallback global name, but via a use statement.

The use of function sizeof() is forbidden; use count() instead

            $settings = array_merge($settings, $params);

Function array_merge() should not be referenced via a fallback global name, but via a use statement.

        }

Functions must not contain multiple empty lines in a row; found 2 empty lines

        if ($this->settings()->isReadOnlyUser()) {
            unset($settings['extremes']);
            unset($settings['readonly']);
            unset($settings['enable_http_compression']);
            unset($settings['max_execution_time']);

Blank line found at end of control structure

        }

        unset($settings['https']);

Functions must not contain multiple empty lines in a row; found 2 empty lines

        return $this->getUri() . '?' . http_build_query($settings);

Function http_build_query() should not be referenced via a fallback global name, but via a use statement.

    }

    /**
     * @param array $extendinfo

Incorrect annotations group.

@param annotation of method \ClickHouseDB\Transport\Http::newRequest() does not specify type hint for items of its traversable parameter $extendinfo.

Missing parameter comment

     * @return CurlerRequest
     */
    private function newRequest($extendinfo)

Method \ClickHouseDB\Transport\Http::newRequest() does not have parameter type hint for its parameter $extendinfo but it should be possible to add it based on @param annotation "array".

Method \ClickHouseDB\Transport\Http::newRequest() does not have return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

Type hint "array" missing for $extendinfo

    {
        $new = new CurlerRequest();

        switch ($this->_authMethod) {
            case self::AUTH_METHOD_QUERY_STRING:
                /* @todo: Move this implementation to CurlerRequest class. Possible options: the authentication method
                 *        should be applied in method `CurlerRequest:prepareRequest()`.
                 */
                $this->settings()->set('user', $this->_username);
                $this->settings()->set('password', $this->_password);
                break;
            case self::AUTH_METHOD_BASIC_AUTH:
                $new->authByBasicAuth($this->_username, $this->_password);
                break;
            default:
                // Auth with headers by default
                $new->authByHeaders($this->_username, $this->_password);
                break;
        }

        $new->POST()->setRequestExtendedInfo($extendinfo);

        if ($this->settings()->isEnableHttpCompression()) {
            $new->httpCompression(true);
        }

No blank line found after control structure

        if ($this->settings()->getSessionId()) {
            $new->persistent();
        }

No blank line found after control structure

        if ($this->sslCA) {
            $new->setSslCa($this->sslCA);
        }

        $new->timeOut($this->settings()->getTimeOut());
        $new->connectTimeOut($this->_connectTimeOut);//->keepAlive(); // one sec
        $new->verbose(boolval($this->_verbose));

Function boolval() should not be referenced via a fallback global name, but via a use statement.

        return $new;
    }

    /**
     * @param Query $query

Incorrect annotations group.

Method \ClickHouseDB\Transport\Http::makeRequest() has useless @param annotation for parameter $query.

Missing parameter comment

     * @param array $urlParams

@param annotation of method \ClickHouseDB\Transport\Http::makeRequest() does not specify type hint for items of its traversable parameter $urlParams.

Missing parameter comment

     * @param bool $query_as_string

Missing parameter comment

Expected "boolean" but found "bool" for parameter type

Expected 2 spaces after parameter type; 1 found

     * @return CurlerRequest
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    private function makeRequest(Query $query, $urlParams = [], $query_as_string = false)

Method \ClickHouseDB\Transport\Http::makeRequest() does not have parameter type hint for its parameter $urlParams but it should be possible to add it based on @param annotation "array".

Method \ClickHouseDB\Transport\Http::makeRequest() does not have parameter type hint for its parameter $query_as_string but it should be possible to add it based on @param annotation "bool".

Method \ClickHouseDB\Transport\Http::makeRequest() does not have return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

Type hint "array" missing for $urlParams

Type hint "bool" missing for $query_as_string

    {
        $sql = $query->toSql();

        if ($query_as_string) {
            $urlParams['query'] = $sql;
        }

        $extendinfo = [
            'sql' => $sql,

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

Array double arrow not aligned correctly; expected 4 space(s) but found 1

            'query' => $query,

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

Array double arrow not aligned correctly; expected 2 space(s) but found 1

            'format' => $query->getFormat()

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

MultiLine arrays must have a trailing comma after the last element.

Each line in an array declaration must end in a comma

        ];

The closing parenthesis does not seem to be aligned correctly; expected 22 space(s), but found 8.

        $new = $this->newRequest($extendinfo);

        /*
         * Build URL after request making, since URL may contain auth data. This will not matter after the
         * implantation of the todo in the `HTTP:newRequest()` method.
         */
        $url = $this->getUrl($urlParams);
        $new->url($url);

Functions must not contain multiple empty lines in a row; found 2 empty lines

        if (!$query_as_string) {

Expected 1 space(s) after NOT operator; 0 found

            $new->parameters_json($sql);
        }

No blank line found after control structure

        if ($this->settings()->isEnableHttpCompression()) {
            $new->httpCompression(true);
        }

        return $new;
    }

    /**
     * @param string|Query $sql

Incorrect annotations group.

Missing parameter comment

     * @return CurlerRequest
     */
    public function writeStreamData($sql)

Method \ClickHouseDB\Transport\Http::writeStreamData() does not have return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

    {

Expected 0 blank lines after opening function brace; 1 found

        if ($sql instanceof Query) {
            $query = $sql;
        } else {
            $query = new Query($sql);
        }

        $extendinfo = [
            'sql' => $sql,

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

Array double arrow not aligned correctly; expected 4 space(s) but found 1

            'query' => $query,

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

Array double arrow not aligned correctly; expected 2 space(s) but found 1

            'format' => $query->getFormat()

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

Each line in an array declaration must end in a comma

MultiLine arrays must have a trailing comma after the last element.

        ];

The closing parenthesis does not seem to be aligned correctly; expected 22 space(s), but found 8.

        $request = $this->newRequest($extendinfo);

        /*
         * Build URL after request making, since URL may contain auth data. This will not matter after the
         * implantation of the todo in the `HTTP:newRequest()` method.
         */
        $url = $this->getUrl([
            'readonly' => 0,

This array key does not seem to be aligned correctly; expected 30 spaces, but found 12.

            'query' => $query->toSql()

This array key does not seem to be aligned correctly; expected 30 spaces, but found 12.

Array double arrow not aligned correctly; expected 4 space(s) but found 1

MultiLine arrays must have a trailing comma after the last element.

        ]);

The closing parenthesis does not seem to be aligned correctly; expected 29 space(s), but found 8.

        $request->url($url);
        return $request;
    }


    /**
     * @param string $sql

Incorrect annotations group.

Missing parameter comment

     * @param string $file_name

Missing parameter comment

     * @return Statement
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    public function writeAsyncCSV($sql, $file_name)

Method \ClickHouseDB\Transport\Http::writeAsyncCSV() does not have parameter type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

Method \ClickHouseDB\Transport\Http::writeAsyncCSV() does not have parameter type hint for its parameter $file_name but it should be possible to add it based on @param annotation "string".

Method \ClickHouseDB\Transport\Http::writeAsyncCSV() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Statement".

Type hint "string" missing for $sql

Type hint "string" missing for $file_name

    {
        $query = new Query($sql);

        $extendinfo = [
            'sql' => $sql,

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

Array double arrow not aligned correctly; expected 4 space(s) but found 1

            'query' => $query,

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

Array double arrow not aligned correctly; expected 2 space(s) but found 1

            'format' => $query->getFormat()

This array key does not seem to be aligned correctly; expected 23 spaces, but found 12.

Each line in an array declaration must end in a comma

MultiLine arrays must have a trailing comma after the last element.

        ];

The closing parenthesis does not seem to be aligned correctly; expected 22 space(s), but found 8.

        $request = $this->newRequest($extendinfo);

        /*
         * Build URL after request making, since URL may contain auth data. This will not matter after the
         * implantation of the todo in the `HTTP:newRequest()` method.
         */
        $url = $this->getUrl([
            'readonly' => 0,

This array key does not seem to be aligned correctly; expected 30 spaces, but found 12.

            'query' => $query->toSql()

This array key does not seem to be aligned correctly; expected 30 spaces, but found 12.

Array double arrow not aligned correctly; expected 4 space(s) but found 1

MultiLine arrays must have a trailing comma after the last element.

        ]);

The closing parenthesis does not seem to be aligned correctly; expected 29 space(s), but found 8.

        $request->url($url);

        $request->setCallbackFunction(function (CurlerRequest $request) {

Closure not using "$this" should be declared static.

Closure does not have void return type hint.

            $handle = $request->getInfileHandle();
            if (is_resource($handle)) {

Use early exit to reduce code nesting.

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

                fclose($handle);

Function fclose() should not be referenced via a fallback global name, but via a use statement.

            }
        });

        $request->setInfile($file_name);
        $this->_curler->addQueLoop($request);

        return new Statement($request);
    }

    /**
     * get Count Pending Query in Queue
     *
     * @return int

Expected "integer" but found "int" for function return type

     */
    public function getCountPendingQueue()

Method \ClickHouseDB\Transport\Http::getCountPendingQueue() does not have return type hint for its return value but it should be possible to add it based on @return annotation "int".

    {
        return $this->_curler->countPending();
    }

    /**
     * set Connect TimeOut in seconds [CURLOPT_CONNECTTIMEOUT] ( int )
     *
     * @param int $connectTimeOut

Missing parameter comment

Expected "integer" but found "int" for parameter type

     */

Missing @return tag in function comment

    public function setConnectTimeOut($connectTimeOut)

Method \ClickHouseDB\Transport\Http::setConnectTimeOut() does not have parameter type hint for its parameter $connectTimeOut but it should be possible to add it based on @param annotation "int".

Method \ClickHouseDB\Transport\Http::setConnectTimeOut() does not have void return type hint.

Type hint "int" missing for $connectTimeOut

    {
        $this->_connectTimeOut = $connectTimeOut;
    }

    /**
     * get ConnectTimeOut in seconds
     *
     * @return int

Expected "integer" but found "int" for function return type

     */
    public function getConnectTimeOut()

Method \ClickHouseDB\Transport\Http::getConnectTimeOut() does not have return type hint for its return value but it should be possible to add it based on @return annotation "int".

    {
        return $this->_connectTimeOut;
    }


    public function __findXClickHouseProgress($handle)

Method \ClickHouseDB\Transport\Http::__findXClickHouseProgress() does not have parameter type hint nor @param annotation for its parameter $handle.

Method \ClickHouseDB\Transport\Http::__findXClickHouseProgress() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function __findXClickHouseProgress()

    {
        $code = curl_getinfo($handle, CURLINFO_HTTP_CODE);

Function curl_getinfo() should not be referenced via a fallback global name, but via a use statement.

Constant CURLINFO_HTTP_CODE should not be referenced via a fallback global name, but via a use statement.

        // Search X-ClickHouse-Progress
        if ($code == 200) {

Use early exit to reduce code nesting.

Operator == is disallowed, use === instead.

            $response = curl_multi_getcontent($handle);

Equals sign not aligned with surrounding assignments; expected 4 spaces but found 1 space

Function curl_multi_getcontent() should not be referenced via a fallback global name, but via a use statement.

            $header_size = curl_getinfo($handle, CURLINFO_HEADER_SIZE);

Function curl_getinfo() should not be referenced via a fallback global name, but via a use statement.

Constant CURLINFO_HEADER_SIZE should not be referenced via a fallback global name, but via a use statement.

            if (!$header_size) {

Expected 1 space(s) after NOT operator; 0 found

                return false;
            }

            $header = substr($response, 0, $header_size);

Function substr() should not be referenced via a fallback global name, but via a use statement.

            if (!$header_size) {

Expected 1 space(s) after NOT operator; 0 found

                return false;
            }

No blank line found after control structure

            $pos = strrpos($header, 'X-ClickHouse-Progress');

Function strrpos() should not be referenced via a fallback global name, but via a use statement.

            if (!$pos) {

Expected 1 space(s) after NOT operator; 0 found

                return false;
            }

            $last = substr($header, $pos);

Function substr() should not be referenced via a fallback global name, but via a use statement.

            $data = @json_decode(str_ireplace('X-ClickHouse-Progress:', '', $last), true);

Function json_decode() should not be referenced via a fallback global name, but via a use statement.

Function str_ireplace() should not be referenced via a fallback global name, but via a use statement.

            if ($data && is_callable($this->xClickHouseProgress)) {

Function is_callable() should not be referenced via a fallback global name, but via a use statement.

Blank line found at start of control structure

                if (is_array($this->xClickHouseProgress)) {

Function is_array() should not be referenced via a fallback global name, but via a use statement.

                    call_user_func_array($this->xClickHouseProgress, [$data]);

Function call_user_func_array() should not be referenced via a fallback global name, but via a use statement.

                } else {
                    call_user_func($this->xClickHouseProgress, $data);

Function call_user_func() should not be referenced via a fallback global name, but via a use statement.

                }

Blank line found after control structure

Functions must not contain multiple empty lines in a row; found 2 empty lines

Blank line found at end of control structure

            }

Blank line found after control structure

Blank line found at end of control structure

        }

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace

    /**
     * @param Query $query

Incorrect annotations group.

Method \ClickHouseDB\Transport\Http::getRequestRead() has useless @param annotation for parameter $query.

Missing parameter comment

Expected 12 spaces after parameter type; 1 found

     * @param null|WhereInFile $whereInFile

Null type hint should be on last position.

Missing parameter comment

     * @param null|WriteToFile $writeToFile

Null type hint should be on last position.

Missing parameter comment

     * @return CurlerRequest
     * @throws \Exception

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    public function getRequestRead(Query $query, $whereInFile = null, $writeToFile = null)

Method \ClickHouseDB\Transport\Http::getRequestRead() does not have parameter type hint for its parameter $whereInFile but it should be possible to add it based on @param annotation "null|WhereInFile".

Method \ClickHouseDB\Transport\Http::getRequestRead() does not have parameter type hint for its parameter $writeToFile but it should be possible to add it based on @param annotation "null|WriteToFile".

Method \ClickHouseDB\Transport\Http::getRequestRead() does not have return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

    {
        $urlParams = ['readonly' => 2];

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

        $query_as_string = false;
        // ---------------------------------------------------------------------------------
        if ($whereInFile instanceof WhereInFile && $whereInFile->size()) {
            // $request = $this->prepareSelectWhereIn($request, $whereInFile);
            $structure = $whereInFile->fetchUrlParams();
            // $structure = [];
            $urlParams = array_merge($urlParams, $structure);

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space

Function array_merge() should not be referenced via a fallback global name, but via a use statement.

            $query_as_string = true;
        }

No blank line found after control structure

        // ---------------------------------------------------------------------------------
        // if result to file
        if ($writeToFile instanceof WriteToFile && $writeToFile->fetchFormat()) {
            $query->setFormat($writeToFile->fetchFormat());
            unset($urlParams['extremes']);
        }

No blank line found after control structure

        // ---------------------------------------------------------------------------------
        // makeRequest read
        $request = $this->makeRequest($query, $urlParams, $query_as_string);
        // ---------------------------------------------------------------------------------
        // attach files
        if ($whereInFile instanceof WhereInFile && $whereInFile->size()) {
            $request->attachFiles($whereInFile->fetchFiles());
        }

No blank line found after control structure

        // ---------------------------------------------------------------------------------
        // result to file
        if ($writeToFile instanceof WriteToFile && $writeToFile->fetchFormat()) {

Blank line found at start of control structure

            $fout = fopen($writeToFile->fetchFile(), 'w');

Function fopen() should not be referenced via a fallback global name, but via a use statement.

            if (is_resource($fout)) {

Function is_resource() should not be referenced via a fallback global name, but via a use statement.

Blank line found at start of control structure

                $isGz = $writeToFile->getGzip();

                if ($isGz) {
                    // write gzip header
                    // "\x1f\x8b\x08\x00\x00\x00\x00\x00"
                    // fwrite($fout, "\x1F\x8B\x08\x08".pack("V", time())."\0\xFF", 10);
                    // write the original file name
                    // $oname = str_replace("\0", "", basename($writeToFile->fetchFile()));
                    // fwrite($fout, $oname."\0", 1+strlen($oname));

                    fwrite($fout, "\x1f\x8b\x08\x00\x00\x00\x00\x00");

Function fwrite() should not be referenced via a fallback global name, but via a use statement.

Blank line found at end of control structure

                }

Functions must not contain multiple empty lines in a row; found 2 empty lines

                $request->setResultFileHandle($fout, $isGz)->setCallbackFunction(function (CurlerRequest $request) {

Closure not using "$this" should be declared static.

Closure does not have void return type hint.

                    fclose($request->getResultFileHandle());

Function fclose() should not be referenced via a fallback global name, but via a use statement.

                });
            }
        }

No blank line found after control structure

        if ($this->xClickHouseProgress) {
            $request->setFunctionProgress([$this, '__findXClickHouseProgress']);
        }

No blank line found after control structure

        // ---------------------------------------------------------------------------------
        return $request;

    }

Function closing brace must go on the next line following the body; found 1 blank lines before brace

    public function cleanQueryDegeneration()

Method \ClickHouseDB\Transport\Http::cleanQueryDegeneration() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function cleanQueryDegeneration()

    {
        $this->_query_degenerations = [];
        return true;
    }

    public function addQueryDegeneration(Degeneration $degeneration)

Method \ClickHouseDB\Transport\Http::addQueryDegeneration() does not have return type hint nor @return annotation for its return value.

Missing doc comment for function addQueryDegeneration()

    {
        $this->_query_degenerations[] = $degeneration;
        return true;
    }

    /**
     * @param Query $query

Incorrect annotations group.

Method \ClickHouseDB\Transport\Http::getRequestWrite() has useless @param annotation for parameter $query.

Missing parameter comment

     * @return CurlerRequest
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    public function getRequestWrite(Query $query)

Method \ClickHouseDB\Transport\Http::getRequestWrite() does not have return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

    {
        $urlParams = ['readonly' => 0];
        return $this->makeRequest($query, $urlParams);
    }

    /**
     * @throws TransportException

Comment missing for @throws tag in function comment

     */

Missing @return tag in function comment

    public function ping(): bool

There must be exactly 1 whitespace between closing parenthesis and return type colon.

    {
        $request = new CurlerRequest();
        $request->url($this->getUri())->verbose(false)->GET()->connectTimeOut($this->getConnectTimeOut());
        $this->_curler->execOne($request);

        return $request->response()->body() === 'Ok.' . PHP_EOL;
    }

    /**
     * @param string $sql

Incorrect annotations group.

Missing parameter comment

Expected 2 spaces after parameter type; 1 found

     * @param mixed[] $bindings

Missing parameter comment

     * @return Query
     */
    private function prepareQuery($sql, $bindings)

Method \ClickHouseDB\Transport\Http::prepareQuery() does not have parameter type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

Method \ClickHouseDB\Transport\Http::prepareQuery() does not have parameter type hint for its parameter $bindings but it should be possible to add it based on @param annotation "mixed[]".

Method \ClickHouseDB\Transport\Http::prepareQuery() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Query".

Type hint "string" missing for $sql

Type hint "array" missing for $bindings

    {

Expected 0 blank lines after opening function brace; 1 found

        // add Degeneration query
        foreach ($this->_query_degenerations as $degeneration) {
            $degeneration->bindParams($bindings);
        }

        return new Query($sql, $this->_query_degenerations);
    }


    /**
     * @param Query|string $sql

Incorrect annotations group.

Missing parameter comment

Expected 5 spaces after parameter type; 1 found

     * @param mixed[] $bindings

Missing parameter comment

Expected 10 spaces after parameter type; 1 found

     * @param null|WhereInFile $whereInFile

Null type hint should be on last position.

Missing parameter comment

     * @param null|WriteToFile $writeToFile

Null type hint should be on last position.

Missing parameter comment

     * @return CurlerRequest
     * @throws \Exception

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    private function prepareSelect($sql, $bindings, $whereInFile, $writeToFile = null)

Method \ClickHouseDB\Transport\Http::prepareSelect() does not have return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

Type hint "array" missing for $bindings

    {
        if ($sql instanceof Query) {
            return $this->getRequestWrite($sql);
        }

No blank line found after control structure

        $query = $this->prepareQuery($sql, $bindings);
        $query->setFormat('JSON');
        return $this->getRequestRead($query, $whereInFile, $writeToFile);
    }


    /**
     * @param Query|string $sql

Incorrect annotations group.

Missing parameter comment

     * @param mixed[] $bindings

Missing parameter comment

Expected 6 spaces after parameter type; 1 found

     * @return CurlerRequest
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    private function prepareWrite($sql, $bindings = [])

Method \ClickHouseDB\Transport\Http::prepareWrite() does not have return type hint for its return value but it should be possible to add it based on @return annotation "CurlerRequest".

Type hint "array" missing for $bindings

    {
        if ($sql instanceof Query) {
            return $this->getRequestWrite($sql);
        }

        $query = $this->prepareQuery($sql, $bindings);
        return $this->getRequestWrite($query);
    }

    /**
     * @return bool

Incorrect annotations group.

Expected "boolean" but found "bool" for function return type

     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    public function executeAsync()

Method \ClickHouseDB\Transport\Http::executeAsync() does not have return type hint for its return value but it should be possible to add it based on @return annotation "bool".

    {
        return $this->_curler->execLoopWait();
    }

    /**
     * @param Query|string $sql

Incorrect annotations group.

Missing parameter comment

Expected 5 spaces after parameter type; 1 found

     * @param mixed[] $bindings

Missing parameter comment

Expected 10 spaces after parameter type; 1 found

     * @param null|WhereInFile $whereInFile

Null type hint should be on last position.

Missing parameter comment

     * @param null|WriteToFile $writeToFile

Null type hint should be on last position.

Missing parameter comment

     * @return Statement
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     * @throws \Exception

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    public function select($sql, array $bindings = [], $whereInFile = null, $writeToFile = null)

Method \ClickHouseDB\Transport\Http::select() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Statement".

    {
        $request = $this->prepareSelect($sql, $bindings, $whereInFile, $writeToFile);
        $this->_curler->execOne($request);
        return new Statement($request);
    }

    /**
     * @param Query|string $sql

Incorrect annotations group.

Missing parameter comment

Expected 5 spaces after parameter type; 1 found

     * @param mixed[] $bindings

Missing parameter comment

Expected 10 spaces after parameter type; 1 found

     * @param null|WhereInFile $whereInFile

Null type hint should be on last position.

Missing parameter comment

     * @param null|WriteToFile $writeToFile

Null type hint should be on last position.

Missing parameter comment

     * @return Statement
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     * @throws \Exception

Class \Exception should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    public function selectAsync($sql, array $bindings = [], $whereInFile = null, $writeToFile = null)

Method \ClickHouseDB\Transport\Http::selectAsync() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Statement".

    {
        $request = $this->prepareSelect($sql, $bindings, $whereInFile, $writeToFile);
        $this->_curler->addQueLoop($request);
        return new Statement($request);
    }

    /**
     * @param callable $callback

Missing parameter comment

     */

Missing @return tag in function comment

    public function setProgressFunction(callable $callback)

Method \ClickHouseDB\Transport\Http::setProgressFunction() does not have void return type hint.

Method \ClickHouseDB\Transport\Http::setProgressFunction() does not need documentation comment.

    {
        $this->xClickHouseProgress = $callback;
    }

    /**
     * @param string $sql

Incorrect annotations group.

Missing parameter comment

Expected 2 spaces after parameter type; 1 found

     * @param mixed[] $bindings

Missing parameter comment

     * @param bool $exception

Missing parameter comment

Expected "boolean" but found "bool" for parameter type

Expected 4 spaces after parameter type; 1 found

     * @return Statement
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    public function write($sql, array $bindings = [], $exception = true)

Method \ClickHouseDB\Transport\Http::write() does not have parameter type hint for its parameter $sql but it should be possible to add it based on @param annotation "string".

Method \ClickHouseDB\Transport\Http::write() does not have parameter type hint for its parameter $exception but it should be possible to add it based on @param annotation "bool".

Method \ClickHouseDB\Transport\Http::write() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Statement".

Type hint "string" missing for $sql

Type hint "bool" missing for $exception

    {
        $request = $this->prepareWrite($sql, $bindings);
        $this->_curler->execOne($request);
        $response = new Statement($request);
        if ($exception) {
            if ($response->isError()) {
                $response->error();
            }
        }

No blank line found after control structure

        return $response;
    }

    /**
     * @param Stream $streamRW

Incorrect annotations group.

Method \ClickHouseDB\Transport\Http::streaming() has useless @param annotation for parameter $streamRW.

Missing parameter comment

Expected 8 spaces after parameter type; 1 found

     * @param CurlerRequest $request

Method \ClickHouseDB\Transport\Http::streaming() has useless @param annotation for parameter $request.

Missing parameter comment

     * @return Statement
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

Comment missing for @throws tag in function comment

     */
    private function streaming(Stream $streamRW, CurlerRequest $request)

Method \ClickHouseDB\Transport\Http::streaming() does not have return type hint for its return value but it should be possible to add it based on @return annotation "Statement".

    {
        $callable = $streamRW->getClosure();
        $stream = $streamRW->getStream();

Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space

Functions must not contain multiple empty lines in a row; found 2 empty lines

        try {

Blank line found at start of control structure

Functions must not contain multiple empty lines in a row; found 2 empty lines

            if (!is_callable($callable)) {

Expected 1 space(s) after NOT operator; 0 found

Function is_callable() should not be referenced via a fallback global name, but via a use statement.

                if ($streamRW->isWrite()) {

Blank line found at start of control structure

                    $callable = function ($ch, $fd, $length) use ($stream) {

Closure not using "$this" should be declared static.

                        return ($line = fread($stream, $length)) ? $line : '';

Useless parentheses.

Function fread() should not be referenced via a fallback global name, but via a use statement.

                    };
                } else {
                    $callable = function ($ch, $fd) use ($stream) {

Closure not using "$this" should be declared static.

                        return fwrite($stream, $fd);

Function fwrite() should not be referenced via a fallback global name, but via a use statement.

                    };
                }
            }

            if ($streamRW->isGzipHeader()) {

Blank line found at start of control structure

                if ($streamRW->isWrite()) {
                    $request->header('Content-Encoding', 'gzip');
                    $request->header('Content-Type', 'application/x-www-form-urlencoded');
                } else {
                    $request->header('Accept-Encoding', 'gzip');
                }

Blank line found after control structure

Blank line found at end of control structure

            }

Functions must not contain multiple empty lines in a row; found 2 empty lines

            $request->header('Transfer-Encoding', 'chunked');

Functions must not contain multiple empty lines in a row; found 2 empty lines

            if ($streamRW->isWrite()) {
                $request->setReadFunction($callable);
            } else {
                $request->setWriteFunction($callable);

Functions must not contain multiple empty lines in a row; found 2 empty lines

//                $request->setHeaderFunction($callableHead);
            }

Functions must not contain multiple empty lines in a row; found 2 empty lines

            $this->_curler->execOne($request, true);
            $response = new Statement($request);
            if ($response->isError()) {
                $response->error();
            }

No blank line found after control structure

            return $response;
        } finally {
            if ($streamRW->isWrite())

It is generally a best practice to always use braces with control structures.

                fclose($stream);

Function fclose() should not be referenced via a fallback global name, but via a use statement.

        }


    }

Function closing brace must go on the next line following the body; found 2 blank lines before brace

    /**
     * @param Stream $streamRead
     * @param string $sql
     * @param mixed[] $bindings
     * @return Statement
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

     */
    public function streamRead(Stream $streamRead, $sql, $bindings = [])
    {
        $sql = $this->prepareQuery($sql, $bindings);
        $request = $this->getRequestRead($sql);
        return $this->streaming($streamRead, $request);

    }

    /**
     * @param Stream $streamWrite
     * @param string $sql
     * @param mixed[] $bindings
     * @return Statement
     * @throws \ClickHouseDB\Exception\TransportException

Class \ClickHouseDB\Exception\TransportException should not be referenced via a fully qualified name, but via a use statement.

     */
    public function streamWrite(Stream $streamWrite, $sql, $bindings = [])
    {
        $sql = $this->prepareQuery($sql, $bindings);
        $request = $this->writeStreamData($sql);
        return $this->streaming($streamWrite, $request);
    }
}